Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-02-28
16:33:58 gibi mriedem: FYI ALLOCATIN for https://review.openstack.org/#/c/622421/32/nova/network/neutronv2/api.py@1734 need a rebase first.
16:34:52 melwitt o/
16:35:49 mriedem gibi: yup
16:35:57 mriedem gibi: i'll fast re-approve your bottom change
16:36:04 gibi mriedem: coolio
16:36:05 mriedem cfriesen: comments in https://review.openstack.org/#/c/635350/
16:36:50 cfriesen okay, will do
16:38:56 mriedem edleafe: i'm glad you picked up on the az name struggle in https://review.openstack.org/#/c/639874/ :)
16:40:03 openstackgerrit sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432
16:40:25 edleafe mriedem: As an east coast native, I felt slighted. :(
16:42:46 mriedem az=rochester-ne
16:42:47 mriedem there
16:42:51 mriedem locally sourced
16:43:19 edleafe no
16:43:20 mriedem az=building25-floor3-mens-br
16:43:33 edleafe az=teaneck-ne
16:45:31 openstackgerrit Chris Friesen proposed openstack/nova master: fix up numa-topology live migration hypervisor check https://review.openstack.org/635350
16:46:52 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653
16:46:53 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421
16:46:53 openstackgerrit Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310
16:47:17 gibi mriedem: fixed ^^
16:50:28 mriedem ok +2 on https://review.openstack.org/#/c/622421/ now
16:50:31 mriedem jaypipes: ^
16:52:30 openstackgerrit Merged openstack/nova master: docs: ComputeDriver.update_provider_tree in nova https://review.openstack.org/633375
16:54:47 cfriesen can mock.patch.object change an object data member (not a function)?
16:57:37 jaypipes mriedem: yeah, I'm in-progress on that review.
16:58:21 efried cfriesen: Yes?
16:58:56 cfriesen efried: can you point me to an example?
16:59:40 cfriesen efried: do I use ".return_value" or something else?
16:59:41 efried cfriesen: http://paste.openstack.org/show/746513/
16:59:47 mriedem gibi: just a question on https://review.openstack.org/#/c/625310/
16:59:53 gibi looking
17:00:08 cfriesen efried: sweet, thanks
17:00:12 efried yw
17:00:33 mriedem cfriesen: you can also create the attribute if it might not exist
17:00:38 mriedem https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch create=True
17:00:43 mriedem normally shouldn't have to use that though
17:00:46 gibi mriedem: you are correct
17:01:05 gibi mriedem: it would be better to move the requester_id = request_net.port_id down where it is used
17:01:15 gibi mriedem: let me fix it
17:01:25 mriedem gibi: you might want to wait for jaypipes review to finish
17:02:04 gibi mriedem: OK
17:07:33 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.70 - expose device tags https://review.openstack.org/636779
17:07:39 mriedem melwitt: can you look at ^ again
17:07:46 mriedem takashin's comments should be addressed
17:08:13 melwitt yep, looking
17:09:09 mriedem dansmith: you want to send cells v1 docs to their watery grave? https://review.openstack.org/#/c/636718/
17:10:02 openstackgerrit Matt Riedemann proposed openstack/nova stable/rocky: Avoid BadRequest error log on volume attachment https://review.openstack.org/640110
17:10:03 dansmith mriedem: only if I can go with them
17:10:35 mriedem i'm struggling to make an under-the-sea merman joke here
17:11:02 mriedem https://i.imgur.com/qiJRWMM.gif
17:14:16 melwitt lol
17:14:59 mriedem gibi: oh i guess jay is reviewing the port detach / deallocate change, so feel free to respin the pci request one
17:15:29 gibi I did the fix locally, and I will publish it before I leave. which is in ~15 minutes
17:16:07 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: Avoid BadRequest error log on volume attachment https://review.openstack.org/640116
17:16:31 mriedem gibi: ok then we have 3 more patches to get to what i think is the target goal for stein which is the microversion change
17:16:37 mriedem how are you feeling about the rest of the changes to that point?
17:17:21 gibi mriedem: correct. If we can merge the microversion patch then I'm happy. However heal port allocation is _after_ the microversion patch so that might make people sad
17:17:40 mriedem i think that is backportable
17:17:44 mriedem since it's an edge case
17:17:54 gibi mriedem: yeah, I hope so
17:18:14 gibi mriedem: the microversion patch itself is small and formal but needs some API doc
17:18:23 gibi mriedem: however I can add doc after FF
17:18:42 mriedem sure. i imagine we'll want some more involved docs about this somewhere, probably nova user docs
17:18:53 mriedem because the spec is going to be overwhelming for a user to try and figure out how this all works
17:18:54 stephenfin mriedem: Missed the ping earlier, but I'll take a shot at https://review.openstack.org/#/c/567860/ tomorrow
17:19:10 gibi mriedem: rubasov started creating a networking doc for the whole
17:19:10 stephenfin notifications on Cinnamon suuuuck
17:19:20 gibi mriedem: I will add to it
17:19:39 sean-k-mooney stephenfin: you dont like the way they pop up in the corner of the screen
17:20:02 stephenfin sean-k-mooney: Not at all. It's pretty but they're no in your face enough
17:20:14 stephenfin Nor are they duplicated across all screens
17:20:27 gibi mriedem: the other two patches handing an edge case (two PF on the same compute connected to the same physnet) and it needs an extra tag in the passthrough_whitelist config
17:20:35 sean-k-mooney stephenfin: well that is why i like them i hate os notification and i tolerater there because they are non intrusive
17:20:55 gibi mriedem: stephenfin has some issue with that which I trying to explain away right now
17:21:41 openstackgerrit Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363
17:22:46 cfriesen This ^ should be ready to review now
17:25:29 mriedem cfriesen: throw it in runways
17:25:34 mriedem https://etherpad.openstack.org/p/nova-runways-stein
17:25:56 mriedem kashyap: have you looked at this at all? https://review.openstack.org/#/c/637834/
17:26:04 mriedem i know you like to think about cpu models
17:28:17 gibi stephenfin: I've just replied to your concerns about the pf_interface_name tag in https://review.openstack.org/#/c/625311/25/doc/source/admin/networking.rst@266
17:29:33 openstackgerrit Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310
17:29:59 gibi mriedem: ^^ fixed
17:30:51 mriedem gibi: are you sure? https://review.openstack.org/#/c/625310/28..29
17:30:55 mriedem you only changed the commit message
17:31:01 gibi mriedem: looking
17:31:11 gibi forget to add the cahnge to the commit
17:31:12 gibi :/
17:31:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310
17:31:27 mriedem git review should not allow you to push if you have pending local changes
17:31:29 mriedem but ok :)
17:31:46 mriedem i get a rebase conflict if i try doing that
17:31:57 gibi mriedem: I never tried to use git review as that hides to much
17:32:08 mriedem so you're both ahead of your time,
17:32:10 mriedem and stuck in the past
17:32:32 gibi :D
17:32:33 gibi yeah
17:32:35 gibi sort of
17:33:15 gibi I hope it is good now as I have to run

Earlier   Later