| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-26 | |||
| 14:14:30 | jaypipes | I thought it was a pep thing. | |
| 14:14:43 | stephenfin | Nah, Sphinx magic taken from epydoc, I'd suspect | |
| 14:14:48 | stephenfin | Or Doxygen, maybe | |
| 14:14:50 | jaypipes | once again I am schooled by the illustrious stephenfin. | |
| 14:15:35 | jangutter | stephenfin, jaypipes: "#:" before or """ after.... drat, I hate choices. | |
| 14:15:38 | jaypipes | stephenfin: ty sir! | |
| 14:15:38 | sean-k-mooney | jaypipes: i stopped questioning him on docs stuff a while ago. after 2 or 3 times it just gets embarassing when he is always right about my questions | |
| 14:16:08 | jaypipes | sean-k-mooney: oh, I definitely don't question his answers :) I just ask away and trust. | |
| 14:16:48 | stephenfin | On a totally unrelated note, has anyone tried to read the argparse source? Oh boy | |
| 14:17:08 | jaypipes | stephenfin: better or worse than ConfigParser? :) | |
| 14:18:28 | zhubx | can someone give some suggestions for https://review.openstack.org/#/c/638080/ a bug fix. thanks | |
| 14:18:33 | stephenfin | Oh, that's bad, but this is worse :) | |
| 14:19:13 | stephenfin | (for reference, we can't do live-migration without a destination in openstackclient until that's fixed https://review.openstack.org/#/c/626949/) | |
| 14:19:32 | stephenfin | or we rewrite argparse | |
| 14:20:23 | sean-k-mooney | stephenfin: why because it does not allow the host to be optional? | |
| 14:20:29 | kashyap | zhubx: I agree with Matt Boot there. To avoid format detection, *always* explicitly specify the backing file format. | |
| 14:20:59 | sean-k-mooney | i assume you cant register an arge to optional take a paramater | |
| 14:21:21 | kashyap | zhubx: IOW, if you know the format, explicitly specify it | |
| 14:21:37 | bauzas | efried: nvm, working on the functest you asked | |
| 14:21:46 | bauzas | it will be a FUP | |
| 14:21:50 | bauzas | given you already +2d | |
| 14:23:06 | efried | bauzas: roger that. I'll be happy to +2 once I see that test. | |
| 14:23:41 | stephenfin | sean-k-mooney: Not quite | |
| 14:24:11 | yonglihe | alex_xu, jaypipes, i update topology API , so it's not depending on the server_group API: https://review.openstack.org/#/c/621476/ | |
| 14:24:52 | stephenfin | sean-k-mooney: You can say an optional parameter may or may not take an option, but if you also have a positional argument, it gets swallowed by the optional parameter regardless | |
| 14:25:44 | sean-k-mooney | ah and the instnace we are migratin is a postional arg and that gets eaten by --live | |
| 14:25:54 | stephenfin | 'zactly | |
| 14:26:08 | stephenfin | Only way to work around it is to add '--', but that breaks everyone | |
| 14:26:31 | stephenfin | So we need to fix argparse then vendor it til until if/when it's fixed upstream | |
| 14:26:42 | sean-k-mooney | that or add a --live-migrate as an alternitve to --live when you want to hit the schduler | |
| 14:27:21 | stephenfin | that would be more practical but not as pretty :) | |
| 14:27:27 | jaypipes | yonglihe: ack. I'll add that to my review queue. | |
| 14:30:50 | dansmith | tssurya: at first glance, stephenfin's grammar nits are things I would have complained about.. can you fix those real quick and I'll just +2+W (after I review) if everything else looks good? | |
| 14:31:33 | dansmith | or I could just do it I guess | |
| 14:31:36 | yonglihe | thanks, | |
| 14:32:53 | jaypipes | stephenfin: the Sarlacc pit beckons. I'll let you nudge https://review.openstack.org/#/c/482226/ off the skiff. | |
| 14:34:21 | efried | jaypipes clearly hasn't seen the movie | |
| 14:35:29 | jaypipes | efried: I have. I just choose to forge a very different plotline in my head. | |
| 14:35:54 | efried | jaypipes: you mean one where that whiny brat Luke gets his just desserts? | |
| 14:36:13 | jaypipes | efried: yes. and the Sarlacc itself gets a nice dessert in the desert. | |
| 14:36:24 | efried | well played sir. well played | |
| 14:39:13 | stephenfin | ralonsoh, sean-k-mooney: Quick one: you've marked this as done but I assume you're replying to me, and sean-k-mooney's comment is void because of his second comment? https://review.openstack.org/#/c/482226/54/vif_plug_ovs/ovs.py@60 | |
| 14:40:01 | sean-k-mooney | stephenfin: i fixed my nit in the help sting in v56 | |
| 14:40:14 | sean-k-mooney | so yes i assumed that ralonsoh was replying to you | |
| 14:40:20 | ralonsoh | stephenfin, yes, this "Done" was for you. ovsdb_connection must have a value | |
| 14:40:24 | stephenfin | Gotcha | |
| 14:40:43 | stephenfin | +W'd \o/ | |
| 14:42:07 | tssurya | dansmith: sure thing I'll correct those nits | |
| 14:42:20 | dansmith | tssurya: hang on I have a couple other things I'm adding | |
| 14:42:33 | tssurya | ah ok | |
| 14:43:15 | mriedem | heh i just addressed them | |
| 14:43:39 | tssurya | :) | |
| 14:46:30 | dansmith | tssurya: mriedem just published my comments | |
| 14:47:21 | tssurya | dansmith: thanks, on it | |
| 14:47:33 | dansmith | I'm standing by with my +2 finger | |
| 15:14:18 | spatel | sean-k-mooney: morning | |
| 15:14:50 | sean-k-mooney | spatel: o/ | |
| 15:14:50 | spatel | sean-k-mooney: do you have experience with cellv2 deployment? | |
| 15:15:17 | sean-k-mooney | spatel: dansmith is the expert but a little | |
| 15:15:35 | spatel | i have 150 new compute nodes waiting ready to go and i am just trying to think i of how to scale my cloud | |
| 15:15:43 | sean-k-mooney | spatel: mainly due to the fact all deployments are cellv2 deplpyment of one cell | |
| 15:16:16 | sean-k-mooney | spatel: you are considering if you should add another cell or not | |
| 15:16:22 | spatel | How difficult its going to be in running production cloud migrate over Cellv2? | |
| 15:16:57 | spatel | currently i have 200 compute nodes in production (in-used) 150 in racks waiting to join cloud | |
| 15:17:29 | sean-k-mooney | what release are you running again? | |
| 15:17:31 | spatel | soon my cloud will be 350 ( I think my current controller can handle that but at some point i have to think big ) | |
| 15:17:37 | spatel | queens | |
| 15:19:22 | sean-k-mooney | spatel: you can handel 500-1000 nodes in a singel cell without too much issue the rabbitmq message bus will be the first bottelneck in the system you will hit. cells of 200 nodes would be fine but you could easily run the 350 nodes you plan to have in the short term in one cell | |
| 15:20:04 | spatel | hmm! currently my rabbitmq rate is 250 mesg/s around :) | |
| 15:20:40 | dansmith | mriedem: stephenfin: wanna hit this again or should I just +W for you? https://review.openstack.org/#/c/638173 | |
| 15:21:21 | sean-k-mooney | spatel: you do not have a dynmaic cloud e.g. you dont spawn/kill/migrate instnaces requently for you voip usecases if i understand correctly | |
| 15:21:42 | sean-k-mooney | spatel: you are also not using celomiter so you have less pressure on the message bus | |
| 15:21:49 | spatel | Yes, you are right | |
| 15:22:04 | sean-k-mooney | spatel: in a public cloud env the message bus trafffic is higher | |
| 15:22:06 | spatel | This is my private cloud for my customer.. very few activity so far | |
| 15:22:32 | spatel | I am not using celomiter :) | |
| 15:22:49 | sean-k-mooney | spatel: i think we swapped over to cellsv2 by default in pike | |
| 15:22:54 | sean-k-mooney | dansmith: is ^ right | |
| 15:23:20 | sean-k-mooney | spatel: dan had a talk on this a while back https://www.youtube.com/watch?v=o7jkqzORij8 | |
| 15:23:21 | stephenfin | dansmith: Done, but I'd have been happy with you fast approving too | |
| 15:23:24 | dansmith | sean-k-mooney: I don't really remember, but he's on queens anyway | |
| 15:23:40 | dansmith | stephenfin: I figured, but I had non-grammar comments, so was just trying to be polite :) | |
| 15:23:41 | cfriesen | mdbooth: I made the changes you suggested for https://review.openstack.org/#/c/616692/ I like the idea of adding proper unit tests for convert_image(), but maybe we can do that in T? | |
| 15:24:16 | spatel | Yes i am on Queens | |
| 15:24:19 | mriedem | i'm going to mark https://blueprints.launchpad.net/nova/+spec/handling-down-cell as complete | |
| 15:24:25 | dansmith | mriedem: rock on | |
| 15:24:34 | sean-k-mooney | spatel: so on quees you are already running cellsv2 | |
| 15:24:43 | mriedem | also just figured out my volume attachment tracking issue with the cross-cell resize series and have it fixed, so that's nice | |
| 15:24:54 | sean-k-mooney | so your coices are to expand your current cell or add a new cell for the new nodes | |
| 15:25:32 | spatel | sean-k-mooney: when you say i am already running on cellsv2 ( what does that means, do i need to enable or made some change to create cellsv2? ) | |
| 15:26:03 | cfriesen | mriedem: is the neutron-grenade-multinode failure here expected? https://review.openstack.org/#/c/616692/ | |
| 15:26:16 | stephenfin | dansmith: Appreciated :) | |
| 15:26:53 | mriedem | http://logs.openstack.org/92/616692/20/check/neutron-grenade-multinode/ac5746b/logs/grenade.sh.txt.gz#_2019-02-26_00_36_45_216 | |
| 15:26:59 | spatel | Watching youtube... dansmith, looking good you was in Boston man!! :) I am in boston.. | |
| 15:27:40 | mriedem | cfriesen: known issue http://status.openstack.org/elastic-recheck/#1463631 | |
| 15:27:49 | sean-k-mooney | spatel: all openstack deplopyment form queens/pike timeframe default to using cellsv2 with cellsv1 cells were optional. for cells v2 that was changed so all recent opensatack deployment are deploy using cellsv2 | |
| 15:28:17 | sean-k-mooney | spatel: so what that means is in the db you have an api db and 2 cell dbs | |
| 15:28:19 | mriedem | *ocata | |
| 15:28:57 | sean-k-mooney | cell0 is special, cell1 is where all your compute nodes are | |
| 15:29:31 | mriedem | we do have docs for this... https://docs.openstack.org/nova/latest/user/cellsv2-layout.html | |