| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-21 | |||
| 13:18:19 | ygk_12345 | sean-k-mooney: i cant see any errors in the conductor logs | |
| 13:18:20 | cdent | noted | |
| 13:18:24 | gibi | jaypipes: ack | |
| 13:18:54 | sean-k-mooney | jaypipes: ack | |
| 13:20:22 | s10 | Please review https://review.openstack.org/#/c/636678/ . We've faced this bug in Queens week ago, had to apply the patch. | |
| 13:22:59 | sean-k-mooney | lyarwood: do you have time to look at ^ . it looks like a strait forward backport | |
| 13:23:27 | lyarwood | sean-k-mooney: looking | |
| 13:23:34 | openstackgerrit | Merged openstack/nova master: Update nova docs front page for placement removal https://review.openstack.org/628183 | |
| 13:23:42 | openstackgerrit | Merged openstack/nova master: Remove placement from nova install docs https://review.openstack.org/628184 | |
| 13:23:52 | openstackgerrit | Merged openstack/nova master: Remove link to placement configuration from nova config docs https://review.openstack.org/628185 | |
| 13:24:05 | openstackgerrit | Merged openstack/nova master: Remove placement from contributor doc https://review.openstack.org/628186 | |
| 13:27:38 | lyarwood | stephenfin: ^ isn't that slightly premature in S? | |
| 13:28:17 | lyarwood | if we aren't dropping the actual placement code from nova until T that is | |
| 13:29:06 | sean-k-mooney | well we cant add new patchs to that code so not really | |
| 13:29:20 | lyarwood | but users can still deploy it in S | |
| 13:29:37 | lyarwood | but now we've removed the docs | |
| 13:29:39 | sean-k-mooney | yes i broght that up a few weeks ago | |
| 13:30:09 | sean-k-mooney | but the feeling was we should not advocate deploying with in tree with stien | |
| 13:30:54 | lyarwood | sean-k-mooney: kk | |
| 13:31:22 | sean-k-mooney | lyarwood: i had the same question when i first saw it proposed | |
| 13:36:17 | cdent | yeah, the idea was that new installs should use the new code | |
| 13:36:22 | cdent | upgrades, different story | |
| 13:38:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add microversion to expose virtual device tags https://review.openstack.org/631948 | |
| 13:42:45 | mriedem | takashin: i've reported bug 1817064 for novaclient - looks like novaclient.tests.functional.v2.test_instance_action.TestInstanceActionCLIV266.test_list_instance_action_with_changes_before still has race issues | |
| 13:42:47 | openstack | bug 1817064 in python-novaclient "test_list_instance_action_with_changes_before intermittently fails with "MismatchError: ['create'] != ['create', 'stop']"" [Undecided,New] https://launchpad.net/bugs/1817064 | |
| 13:43:56 | takashin | mriedem: Thank you. | |
| 13:50:33 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add function "has_table_columns" to OVSDB implementation API https://review.openstack.org/634967 | |
| 13:56:07 | gibi | nova meeting starts in 5 minutes in #openstack-meeting | |
| 14:06:31 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | |
| 14:06:40 | kashyap | Huzzah, this merged: https://review.openstack.org/#/c/632507/ | |
| 14:07:03 | kashyap | Thanks for the reviews / time, folks. Now to clean up the rest of the cruft... | |
| 14:08:06 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | |
| 14:10:01 | sean-k-mooney | TIL print("...", file=some_file) is only suport in python3 ... | |
| 14:10:20 | sean-k-mooney | back to some_file.write() it is | |
| 14:11:25 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add function "has_table_columns" to OVSDB implementation API https://review.openstack.org/634967 | |
| 14:12:58 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | |
| 14:24:33 | jackding | takashin: mdbooth: Could you please revisit https://review.openstack.org/#/c/616692/? Thanks | |
| 14:25:14 | takashin | jackdin: Okay. I will check it later. | |
| 14:25:23 | takashin | jackding: Okay. I will check it later. | |
| 14:29:57 | jackding | mriedem: Could you please revisit https://review.openstack.org/#/c/620706/ and https://review.openstack.org/#/c/616692/? Thanks | |
| 14:30:14 | jackding | takashin: thanks | |
| 14:48:37 | openstackgerrit | Merged openstack/os-vif master: Clean up versioned object backlevelling code https://review.openstack.org/630976 | |
| 15:02:04 | mdbooth | jackding: Done. Change looks good. I think there's some missing unit test coverage, though. | |
| 15:02:27 | mdbooth | jackding: Hopefully trivial to add. | |
| 15:03:11 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: [Doc] Best practices for effectively tolerating down cells https://review.openstack.org/638173 | |
| 15:07:58 | mriedem | dansmith: you want to get this rocky backport for that live migration volumes thing https://review.openstack.org/#/c/636895/ | |
| 15:08:24 | openstackgerrit | ya.wang proposed openstack/nova master: Select cpu model from a list of cpu models https://review.openstack.org/637834 | |
| 15:16:55 | openstackgerrit | sean mooney proposed openstack/os-vif master: remove brctl from vif_plug_ovs https://review.openstack.org/636821 | |
| 15:16:56 | openstackgerrit | sean mooney proposed openstack/os-vif master: remove use of brctl from vif_plug_linux_bridge https://review.openstack.org/636822 | |
| 15:42:20 | mriedem | lyarwood: mgoddard: i know this backport has been hanging out awhile but i'm pretty uncomfortable with it https://review.openstack.org/#/c/608573/ | |
| 15:42:30 | mriedem | given the bug report and commit message says "since change in rocky" which was actually a change in stein | |
| 15:43:53 | mriedem | i guess this is an example of the warning http://logs.openstack.org/95/636895/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/c4e5305/controller/logs/screen-n-cpu.txt.gz#_Feb_15_14_25_05_143091 | |
| 15:44:57 | mgoddard | mriedem: the "since change in rocky" == https://review.openstack.org/#/c/565841/? It merged in August '18 | |
| 15:45:55 | mriedem | included in on that change says master | |
| 15:46:43 | mriedem | https://github.com/openstack/nova/commits/stable/rocky/nova/virt/ironic/driver.py | |
| 15:46:46 | mriedem | not in there | |
| 15:47:03 | mriedem | i remember us talking about merging that late in rocky but decided to defer to early stein | |
| 15:47:11 | mriedem | and it was merged right after the ptg as i recall | |
| 15:47:22 | mriedem | and proceeded to break tripleo | |
| 15:47:37 | mriedem | because they were still using the scheduler filters that needed those inventory values | |
| 15:48:12 | mgoddard | ok, I agree it's not in stable/rocky | |
| 15:48:35 | mriedem | https://wiki.openstack.org/wiki/Nova/Rocky_Release_Schedule so that was merged probably right after rc1 | |
| 15:48:39 | mriedem | when we cut stable/rocky | |
| 15:51:05 | openstackgerrit | Pierre Riteau proposed openstack/nova master: Fix a typo in configuration description https://review.openstack.org/638445 | |
| 15:51:06 | mgoddard | ok, let's abandon it then. the backport was based on the assumption that that change was in rocky | |
| 15:51:07 | mriedem | god this whole transition has been a mess | |
| 15:51:15 | mgoddard | yup | |
| 15:51:18 | mriedem | mgoddard: i left a comment, but if we do have the warnings, | |
| 15:51:24 | mriedem | i think they have to be conditional based on the https://docs.openstack.org/nova/rocky/configuration/config.html#workarounds.report_ironic_standard_resource_class_inventory option in rocky | |
| 15:51:34 | mriedem | because if that's true, the warnings are legit | |
| 15:51:41 | mgoddard | that's another option | |
| 15:51:42 | mriedem | if false, then we can avoid the warnings | |
| 15:52:02 | mriedem | if that option is false we're not reporting standard resoruce class inventory anyway so we don't need to warn about 0 values | |
| 15:52:53 | mgoddard | that seems reasonable. I'll update it to check that flag | |
| 15:53:30 | mriedem | the commit message is going to need some updating | |
| 15:53:33 | mriedem | to sort out the confusion | |
| 15:53:52 | mgoddard | sure | |
| 15:54:15 | mgoddard | thanks for following up | |
| 15:55:26 | mgoddard | actually, hold up | |
| 15:55:44 | mgoddard | "They were not required to be set since the Pike release, but still this | |
| 15:55:47 | mgoddard | warning is emitted. | |
| 15:56:15 | mgoddard | that's why I marked it as backport potential for pike - rocky | |
| 15:56:52 | mgoddard | so since pike, it's valid not to set them, but if you don't then you get a warning | |
| 15:58:11 | mgoddard | it doesn't matter what is reported to placement, this is about the ironic node config | |
| 15:58:38 | mriedem | ok i see https://review.openstack.org/#/c/608573/3/nova/virt/ironic/driver.py@815 | |
| 15:58:56 | mriedem | so if the values are 0 we won't report those resource classes for inventory | |
| 16:00:00 | mriedem | i guess https://docs.openstack.org/ironic/rocky/install/configure-nova-flavors.html doesn't mention anything about 0ing out the node property values, | |
| 16:00:04 | mriedem | is that in the ironic docs somewhere? | |
| 16:01:15 | bauzas | gibi: I'm just starting to sharpen my pen for reviewing network-bw-providers | |
| 16:01:26 | bauzas | gibi: did the implementation diverged from the spec https://specs.openstack.org/openstack/nova-specs/specs/stein/approved/bandwidth-resource-provider.html ? | |
| 16:01:38 | bauzas | gibi: that helps me catching up quickier | |
| 16:02:04 | gibi | bauzas: the name of the resource classes got shorter, and there are extra object model addition that was not covered by the spec | |
| 16:02:16 | mriedem | and the microversion... | |
| 16:02:20 | gibi | bauzas: but I think the basic logic and goal did not changef | |
| 16:02:25 | gibi | mriedem: ++ | |
| 16:02:57 | bauzas | gibi: okay, gtk | |
| 16:03:19 | bauzas | mriedem: a new API microversion ? | |
| 16:03:27 | bauzas | if so, I'll be able to get it | |
| 16:03:42 | gibi | bauzas: yes a new microversion to enable the feature for server create/delete | |
| 16:04:00 | bauzas | gotcha | |