| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-19 | |||
| 03:44:28 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | |
| 04:25:27 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix output of interface-attach command https://review.openstack.org/637677 | |
| 04:28:32 | alex_xu | melwitt: I probably didn't get what your mean about the unrelated between instance.project_id as target and removing project_only=True | |
| 04:29:29 | alex_xu | melwitt: I'm thinking make the instance.project_id as target should be the first step, then we can remove the project_only=True. so...that I'm thinking they are related | |
| 04:37:47 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix resetting non-persistent fields when saving obj https://review.openstack.org/636271 | |
| 06:37:54 | openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | |
| 06:40:01 | openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | |
| 06:49:16 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | |
| 06:49:59 | bauzas | good morning Nova | |
| 06:54:07 | openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | |
| 06:59:27 | openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | |
| 07:38:45 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.openstack.org/637716 | |
| 09:04:15 | openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476 | |
| 09:12:25 | kashyap | This needs a final +W, if anyone wants to put this through: https://review.openstack.org/#/c/632507/ (libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein") | |
| 09:14:21 | gibi | kashyap: I'm here but I cannot help :) | |
| 09:14:27 | kashyap | Heh, I know. | |
| 09:14:36 | kashyap | That's why I didn't ping anyone explicitly :-) | |
| 09:15:02 | gibi | :) | |
| 09:16:03 | kashyap | gibi: I _think_ this is related to my patch, isn't it: http://logs.openstack.org/78/637578/1/check/nova-tox-functional-py35/14da3dc/testr_results.html.gz | |
| 09:16:18 | kashyap | Coming from https://review.openstack.org/#/c/637578 ("libvirt: Omit needless check on 'CONF.serial_console'") | |
| 09:18:12 | gibi | kashyap: fells like there is a connection. Is it always fails for your patch? | |
| 09:18:34 | kashyap | Don't know yet | |
| 09:23:12 | kashyap | It is this test 'test_volume_swap_server_with_error' from nova/tests/functional/notification_sample_tests/test_instance.py | |
| 09:26:41 | kashyap | gibi: But the "IndexError: list index out of range | |
| 09:26:43 | kashyap | " | |
| 09:27:12 | kashyap | ... give me a déjà vu, as I fixed similar errors in unit tests in main patch. | |
| 09:27:31 | kashyap | Usually lowering the index of devices by one, because we removed one needless serial device. | |
| 09:28:39 | gibi | kashyap: that index out of range is a missing notification that is probably caused by the stack trace before it | |
| 09:28:42 | gibi | File "/home/zuul/src/git.openstack.org/openstack/nova/nova/compute/manager.py", line 5688, in _init_volume_connection | |
| 09:28:45 | gibi | new_cinfo['serial'] = new_volume_id | |
| 09:28:47 | gibi | TypeError: 'tuple' object does not support item assignment | |
| 09:31:20 | kashyap | gibi: What's your `tox` command-line? | |
| 09:31:37 | gibi | tox -e functional-py35 | |
| 09:32:35 | gibi | kashyap: I cannot reproduce the failure locally | |
| 09:33:11 | kashyap | Hmm | |
| 09:33:38 | gibi | but the stacktrace is there in the log even if the test does not fail | |
| 09:33:48 | kashyap | Ah, I see. | |
| 09:33:49 | gibi | no I will check for the stack trace without your patch | |
| 09:33:59 | kashyap | gibi: One more: did you apply the main bump patch as well? | |
| 09:34:59 | gibi | kashyap: I checked out your Omit patch so I have the whole series | |
| 09:35:05 | kashyap | Ah, good. | |
| 09:35:49 | gibi | kashyap: the stacktrace is there even on master without your series | |
| 09:35:56 | gibi | so it is something unrelated | |
| 09:36:11 | kashyap | Okay, noted. Thanks for the quick check. | |
| 09:36:26 | kashyap | Wonder then should I 'recheck', as this could be a spurious failure? | |
| 09:36:42 | gibi | bottom line, the test fail in your patch due to some timing issue in the notification test, unrelated to that there is a ugly stack trace in the log even if it passes, all unrelated to your patch | |
| 09:36:50 | gibi | kashyap: yep, recheck it is | |
| 09:37:58 | kashyap | Noted, thanks for the quick double-check, feel a bit saner now | |
| 09:38:55 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Reject resize requests when the source host is down https://review.openstack.org/623489 | |
| 09:39:34 | lyarwood | sean-k-mooney: ^ I think you looked at this a while ago, should be ready for another review if you have time today. | |
| 09:40:43 | gibi | kashyap: filed a bug not to forget to look at that stacktrace https://bugs.launchpad.net/nova/+bug/1816538 | |
| 09:40:44 | openstack | Launchpad bug 1816538 in OpenStack Compute (nova) "test_volume_swap_server_with_error produce a suspicious stack trace" [Undecided,New] | |
| 09:40:56 | kashyap | Ah, excellent, thanks | |
| 09:50:15 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Use the correct mdev allocated from the pGPU https://review.openstack.org/636591 | |
| 09:50:16 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: implement reshaper for vgpu https://review.openstack.org/599208 | |
| 09:50:16 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559 | |
| 09:58:13 | kashyap | stephenfin: When you can: https://review.openstack.org/#/c/632507/ | |
| 09:59:11 | kashyap | gibi: Remind me again, if I touch-up the commit message, will I lose all the +2s / +1s? | |
| 09:59:41 | kashyap | There is a small grammar mistake; it absolutely needs no touching up, but it's just the OCD... | |
| 10:04:14 | gibi | kashyap: hm, if you lose it I can give it back | |
| 10:04:25 | gibi | kashyap: I think rebase only remove +A | |
| 10:04:35 | gibi | but commit message change might remove +2 as well | |
| 10:04:56 | kashyap | Not worth it; the `diff` is this: | |
| 10:05:13 | kashyap | - create a duplicate 'pty' devices | |
| 10:05:14 | kashyap | + create duplicate 'pty' devices | |
| 10:05:15 | kashyap | :D | |
| 10:06:32 | gibi | kashyap: don't change it :D | |
| 10:08:53 | kashyap | Won't :-) | |
| 10:09:35 | kashyap | I'm not a native speaker either, but a stickler for (my own) language. | |
| 10:09:46 | kashyap | s/language/words/ | |
| 10:11:18 | stephenfin | kashyap: Yup, I left one comment there | |
| 10:11:55 | stephenfin | Still wondering if we should fix the s390x as a (backportable) precursor | |
| 10:12:59 | kashyap | stephenfin: Yeah, I'm wondering that too. I'll respond in the afternoon; need to be AFK soon for a bit | |
| 10:13:31 | stephenfin | kashyap: Cool. I'll hold off reviewing until then so | |
| 10:13:53 | stephenfin | It probably doesn't matter too much (no one has spotted this in ~2 years) but if it's an easy fix... | |
| 10:14:32 | kashyap | stephenfin: Yeah. And to backport it, it's easy to glean it off | |
| 10:14:48 | kashyap | stephenfin: Probably not worth the churn in this patch, IMHO. Not sure if you agree there | |
| 10:15:03 | kashyap | Let me comment on the review, and then head out | |
| 10:19:27 | kashyap | stephenfin: Responded; let me know what you think there. | |
| 10:30:42 | kashyap | stephenfin: Alright, will do. I _began_ with a separate patch, originally, you know - then squashed it :-) | |
| 10:47:20 | openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | |
| 11:40:18 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245 | |
| 11:50:59 | openstackgerrit | sean mooney proposed openstack/os-vif master: [WIP] remove brctl from vif_plug_ovs https://review.openstack.org/636821 | |
| 11:52:22 | openstackgerrit | sean mooney proposed openstack/os-vif master: remove brctl from vif_plug_ovs https://review.openstack.org/636821 | |
| 11:53:52 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/637827 | |
| 12:35:35 | openstackgerrit | ya.wang proposed openstack/nova master: Add configuration item cpu_models to libvirt https://review.openstack.org/637834 | |
| 13:12:21 | aspiers | cdent: you around? I'm a bit confused whether a compute driver should be able to provide a CUSTOM_ trait or not. | |
| 13:13:53 | aspiers | https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/resource-provider-traits.html suggests not but https://review.openstack.org/#/c/538498/7/nova/virt/driver.py@934 seems to contradict that | |
| 13:15:30 | openstackgerrit | sean mooney proposed openstack/os-vif master: remove use of brctl from vif_plug_linux_bridge https://review.openstack.org/636822 | |
| 13:15:57 | cdent | aspiers: I'm around now. What's up? | |
| 13:16:09 | aspiers | that spec suggests CUSTOM_* was just for admin/operator usage, but maybe it's for everything not in os-traits? | |
| 13:16:24 | aspiers | I see the placement API prevents a PUT of any trait without CUSTOM_ prefix | |
| 13:16:53 | aspiers | would a virt driver ever want to provide a trait not in os-traits? | |
| 13:17:02 | aspiers | 3rd-party drivers maybe? | |
| 13:23:59 | cdent | aspiers: sorry for the delay. It depends on who you ask. | |
| 13:24:40 | cdent | The hope is that anything that is the result of the virt driver "knowing things" about it's environment would be traits in os-traits | |
| 13:24:53 | cdent | and as things are needed by the virt drivers they get added to os-traits | |
| 13:25:25 | cdent | but it's pretty clear that's not always going to be realistic, but, as you say placement will only allow CUSTOM_* traits to be created over the api | |
| 13:25:38 | cdent | s/it's/its/ | |
| 13:26:11 | kashyap | stephenfin: Untangling the mess out of it turning out to be more painful than expected :-( | |