| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-15 | |||
| 17:04:19 | mriedem | well, skipping slow tests would help quite a bit | |
| 17:05:19 | mriedem | at the sacrifice of coverage | |
| 17:05:49 | melwitt | yeah, that's what I was about to say. a separate ceph slow tests job comes to mind but "yet another job" | |
| 17:05:51 | mriedem | compare to the timeout on the tempest-slow job which only runs slow tests | |
| 17:05:51 | mriedem | http://git.openstack.org/cgit/openstack/tempest/tree/.zuul.yaml#n276 | |
| 17:05:55 | mriedem | that timeout is 3 hours rather than 2 | |
| 17:06:11 | mriedem | the easy fix is bumping the timeout | |
| 17:06:33 | mriedem | but if that job is consistently taking over 2 hours, that means all nova changes are waiting at least that long in the check queue for results from a non-voting job | |
| 17:07:00 | melwitt | hm, yeah | |
| 17:07:01 | mriedem | so if we're going to wait that long for that job, i think it needs to be voting | |
| 17:07:19 | mriedem | and if it's going to take that long and be non-voting, i think it's place is in the experimental queue | |
| 17:07:31 | melwitt | yeah, that's fair | |
| 17:07:51 | mriedem | probably something to be brought up in the ML since it likely also affects other projects (cinder/glance at least) | |
| 17:08:52 | smcginnis | ++ | |
| 17:09:16 | melwitt | the job was as stable as the normal tempest-full (I need to get the graph again) for quite a while, but I never got around to trying to make it voting again | |
| 17:09:36 | melwitt | yeah, ok. I'll grab the data and post to the ML | |
| 17:10:55 | mriedem | speaking of jobs, it looks like while i fixed legacy-grenade-dsvm-neutron-multinode-live-migration the zuul.yaml change on irrelevant-files means it's not running on nova changes now... | |
| 17:11:18 | mriedem | https://review.openstack.org/#/c/634962/5/.zuul.yaml@242 | |
| 17:15:16 | melwitt | ? | |
| 17:15:44 | mriedem | e.g. that job isn't running on https://review.openstack.org/#/c/591657/ | |
| 17:16:01 | mriedem | it's now only running if there are changes to nova/tests/live_migration/ | |
| 17:16:16 | melwitt | oh.... oops | |
| 17:16:55 | mriedem | nova/tests/live_migration/ should probably move under nova/gate/ | |
| 17:18:40 | melwitt | that's weird, I thought we've used that regex before to run on nova/tests/live_migration in addition to non-test nova changes | |
| 17:20:34 | mriedem | i've got a fix | |
| 17:25:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix irrelevant-files for legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/637231 | |
| 17:29:25 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Trim fake_deserialize_context in test_conductor https://review.openstack.org/635859 | |
| 17:29:26 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Cleanup inflight rpc messages between test cases https://review.openstack.org/637233 | |
| 17:29:37 | gibi | mriedem: fyi, I think I got the fkr ^^ | |
| 17:30:53 | mriedem | dansmith: maybe we were too hasty https://review.openstack.org/#/c/635146/10/nova/api/openstack/compute/views/servers.py@114 | |
| 17:31:03 | mriedem | https://review.openstack.org/#/c/635147/13/api-guide/source/down_cells.rst@28 | |
| 17:33:06 | dansmith | mriedem: hmm, is that going to refer to links in other apis that we won't support? | |
| 17:33:15 | dansmith | like /servers/uuid/somethingelse ? | |
| 17:33:16 | mriedem | no it's a ref back to itself | |
| 17:33:21 | mriedem | so nova show | |
| 17:33:31 | dansmith | I thought there were a couple of links, like to self, flavor, etc | |
| 17:33:45 | mriedem | flavor links would be under the flavor dict in the response | |
| 17:33:59 | mriedem | self is just GET /servers/{server_id} | |
| 17:34:00 | mriedem | "href": "http://openstack.example.com/v2/6f70656e737461636b20342065766572/servers/22c91117-08de-4894-9aa9-6ef382400985" | |
| 17:34:30 | dansmith | okay | |
| 17:38:26 | dansmith | hmm, she's not around and it's friday.. perhaps someone else should just fix it up for her? | |
| 17:38:49 | mriedem | yeah first thing is pulling it from the gate | |
| 17:38:55 | mriedem | so i guess i'll jack the commit message | |
| 17:39:21 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146 | |
| 17:39:51 | openstackgerrit | Lajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.69 https://review.openstack.org/637234 | |
| 17:52:53 | mriedem | alright then, looks like i'm going to have lunch and then i'll add the links and such, and probably also fix up my comments in the docs patch at the end | |
| 17:53:18 | mriedem | so much for cross-cell resize fun today | |
| 19:34:47 | mriedem | dansmith: here it comes | |
| 19:35:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146 | |
| 19:35:03 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add context.target_cell() stub to DownCellFixture https://review.openstack.org/637182 | |
| 19:35:03 | openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.69: Handles Down Cells https://review.openstack.org/591657 | |
| 19:35:04 | openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | |
| 19:37:57 | dansmith | mriedem: omg -1 so hard | |
| 19:39:30 | mriedem | here it comes | |
| 19:39:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146 | |
| 19:39:41 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add context.target_cell() stub to DownCellFixture https://review.openstack.org/637182 | |
| 19:39:41 | openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.69: Handles Down Cells https://review.openstack.org/591657 | |
| 19:39:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | |
| 19:41:57 | dansmith | mriedem: and the ones above are unchanged so I can stamp them? | |
| 19:42:31 | mriedem | minor changes | |
| 19:42:38 | mriedem | the api samples had to change b/c of the links key in the response | |
| 19:44:58 | dansmith | sure, but I see other stuff too | |
| 19:45:00 | dansmith | anyway, looks okay | |
| 19:45:30 | mriedem | cdent: you want to propose for stable/rocky and friends? https://review.openstack.org/#/c/636701/ | |
| 19:45:36 | mriedem | or send out the gary signal? | |
| 19:46:15 | mriedem | dansmith: i'm +2 on the docs change at the end if you want to flush it all | |
| 19:46:23 | mriedem | i think you do | |
| 19:48:32 | dansmith | 420 lines.. | |
| 19:49:04 | mriedem | you live in portland, you can get down with that | |
| 19:49:49 | dansmith | heh | |
| 19:59:13 | openstackgerrit | Corey Bryant proposed openstack/nova master: add python 3.7 unit test job https://review.openstack.org/610694 | |
| 19:59:53 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: API microversion 2.69: Handles Down Cells https://review.openstack.org/579563 | |
| 20:01:00 | dansmith | mriedem: comments on the docs patch.. I could just +2 and we could discuss/fix later, but probably not as much of a rush on that one I'm thinking | |
| 20:04:38 | tssurya | mriedem, dansmith: you had to respin for the links part ? sorry about that and again my never-ending list of "thank you"'s | |
| 20:07:03 | openstackgerrit | Corey Bryant proposed openstack/python-novaclient master: add python 3.7 unit test job https://review.openstack.org/637290 | |
| 20:11:31 | mriedem | dansmith: tssurya: i also just thought about this https://review.openstack.org/#/c/591657/44/nova/api/openstack/compute/services.py@78 | |
| 20:13:38 | tssurya | mriedem: hmm so you want it to be false if those filters are passed ? | |
| 20:14:11 | mriedem | dansmith: yeah i'm ok with those docs changes | |
| 20:14:15 | mriedem | tssurya: idk, hence the question | |
| 20:14:34 | mriedem | tssurya: if we were being consistent, we'd set cell_down_support=False if there were any filters on the request | |
| 20:14:37 | dansmith | I don't really have an opinion on the servers stuff | |
| 20:14:40 | dansmith | er, services | |
| 20:14:54 | mriedem | but like i said, we're not filtering in the db query, we're doing it in python once we get results | |
| 20:14:58 | mriedem | so *shrug*? | |
| 20:16:18 | tssurya | yea | |
| 20:16:38 | tssurya | besides technically the edge cases are only for "listing servers" :D | |
| 20:17:10 | tssurya | at least in the docs and everywhere its only for the server details | |
| 20:19:46 | mriedem | oh well if the docs say so... | |
| 20:20:41 | mriedem | anyway i'm fine with the way it is, not really worth losing sleep over it | |
| 20:31:44 | mriedem | looks like a whole bunch of 3rd party CIs are failing on this | |
| 20:31:44 | mriedem | ConnectionError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Max retries exceeded with url: /packages/ed/39/15045ae46f2a123019aa968dfcba0396c161c20f855f11dea6796bcaae95/PyMySQL-0.9.3-py2.py3-none-any.whl (Caused by ReadTimeoutError("HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out. (read timeout=15)",)) | |
| 20:43:30 | fried_rice | okay, but cmon, do we actually *need* PyMySQL? | |
| 20:43:55 | melwitt | nah | |
| 20:44:07 | fried_rice | tssurya: Did you see the patch I proposed to improve the ironic ufpt thing? | |
| 20:44:34 | fried_rice | gibi: Is it too late to make the bw part of the binding profile look more like the resource request syntax in extra specs? | |
| 20:45:10 | tssurya | fried_rice: saw the WIP, but didn't review it yet | |
| 20:45:36 | fried_rice | tssurya: Less about review, more about trying it in your env and seeing if it takes the 6h processing ironic nodes down to something sane. | |
| 20:46:07 | tssurya | haha we kind of hacked the bit of code that tries to do the N^2 thing already got the node up | |
| 20:46:11 | tssurya | for now | |
| 20:46:32 | tssurya | I will be able to try your patch only on Monday :( | |