Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-02-13
22:17:17 aspiers mriedem: ignore the get_traits failure, I already fixed it but didn't push a new patchset yet
22:18:31 aspiers I guess I can push a new one and you'll see the exact failure
22:20:34 openstackgerrit Adam Spiers proposed openstack/nova master: WIP: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498
22:34:59 aspiers mriedem: https://gist.github.com/aspiers/d64eff8a1d5594ad9763ebbd192d36b1
22:42:29 mriedem yeah it's failing because you removed the get_traits mock which was returning ['CUSTOM_FOO', 'HW_CPU_X86_VMX']
22:42:35 aspiers DOH
22:42:35 mriedem from the drier
22:42:39 mriedem *driver
22:42:40 aspiers lol
22:42:47 aspiers missed that
22:43:45 mriedem you essentially need to stub the driver.update_provider_tree method with a fake so you can intercept the provider tree and shove your traits into it
22:43:46 mriedem i think
22:43:52 aspiers yeah sure, got it now
22:44:07 aspiers I was assuming it was hardcoded somewhere - was searching the fixtures high and low X-D
22:44:38 mriedem or just change FakeDriver.update_provider_tree to always return those traits but that could affect other tests
22:44:58 mriedem i'd do something like,
22:45:10 mriedem original_upt = self.compute.driver.update_provider_tree
22:45:17 mriedem def fake_upt(...):
22:45:25 mriedem original_upt(...)
22:45:34 mriedem # inject the traits i want in the tree object
22:45:37 mriedem return that thing
22:46:10 mriedem self.stub_out('nova.virt.fake.FakeDriver.update_provider_tree', fake_upt)
22:46:19 mriedem i think that should do it
22:47:26 mriedem if you need that to be temporary, you can use self.useFixture(fixtures.MonkeyPatch(old, new)) directly as a context manager
22:48:48 aspiers cool, thanks!
23:32:06 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.69 https://review.openstack.org/636779
23:36:52 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.69 - expose device tags https://review.openstack.org/636779
23:40:22 openstackgerrit Artom Lifshitz proposed openstack/nova master: Remove _legacy_dict methods https://review.openstack.org/636210
23:40:22 openstackgerrit Artom Lifshitz proposed openstack/nova master: Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605
23:40:23 openstackgerrit Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827
23:40:23 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP] Introduce live_migration_claim() https://review.openstack.org/635669
23:40:24 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP] Use live_migration_claim() to check dest resources https://review.openstack.org/634606
23:40:24 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828
23:40:25 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: update NUMA-related XML on the source https://review.openstack.org/635229
23:47:29 mriedem efried: question in https://review.openstack.org/#/c/636378/
23:48:12 mriedem oh gdi
23:48:15 mriedem now i see the follow up
23:48:19 openstackgerrit Merged openstack/nova master: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/551302
23:51:06 efried mriedem: Yeah, I considered actually referring to the fup in the commit message, but stephenfin's suggestion was intended to make it stand on its own, so...
23:52:15 mriedem which i guess is this https://review.openstack.org/#/c/582392/2/tox.ini@a26
23:53:00 mriedem now to see how many people complain about unit tests not working tomorrow
23:54:09 efried heh
23:54:29 efried I did happen to notice that bionic doesn't have tox 3.x, I had to install it by hand.
23:55:08 mriedem i'm still on xenial
23:55:14 mriedem i get tox from pypi anyway
#openstack-nova - 2019-02-14
00:17:22 openstackgerrit Matt Riedemann proposed openstack/nova master: docs: ComputeDriver.update_provider_tree in nova https://review.openstack.org/633375
00:24:31 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: Add descriptions for vol-backed snapshots https://review.openstack.org/615084
02:12:17 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix resetting non-persistent fields when saving obj https://review.openstack.org/636271
02:12:25 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix resetting non-persistent fields when saving obj https://review.openstack.org/636271
02:56:18 openstackgerrit Merged openstack/nova master: Document how to make tests log at DEBUG level https://review.openstack.org/636744
02:56:25 openstackgerrit Merged openstack/nova master: Drop specific versions of openSUSE-based distributions https://review.openstack.org/636745
02:56:34 openstackgerrit Merged openstack/nova master: tox: Don't write byte code (maybe) https://review.openstack.org/636378
02:56:42 openstackgerrit Merged openstack/nova master: Use tox 3.1.1 fixes https://review.openstack.org/582392
04:05:25 openstackgerrit Merged openstack/nova master: Update help messages for weight multipliers https://review.openstack.org/633446
04:05:32 openstackgerrit Merged openstack/nova master: Use :oslo-config: role in hypervisor-kvm doc https://review.openstack.org/634798
04:07:44 openstackgerrit sean mooney proposed openstack/os-vif master: [WIP] remove brctl from vif_plug_ovs https://review.openstack.org/636821
04:07:45 openstackgerrit sean mooney proposed openstack/os-vif master: [WIP] remove use of brctl from vif_plug_linux_bridge https://review.openstack.org/636822
08:00:35 openstackgerrit Merged openstack/nova master: Provide a useful error message when trying to update non-compute services https://review.openstack.org/620667
08:00:53 openstackgerrit Merged openstack/nova master: Ignore VolumeAttachmentNotFound exception in compute.manager https://review.openstack.org/632657
08:42:26 openstackgerrit Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476
08:43:08 openstackgerrit garyk proposed openstack/nova master: Lock detach_volume https://review.openstack.org/636701
09:46:32 bauzas gibi: around ?
09:48:41 bauzas gibi: I don't get why when entering the reshape here https://review.openstack.org/#/c/599208/13/nova/virt/libvirt/driver.py@7000 we don't have the VGPU inventory
09:48:53 gibi bauzas: just from a phone. I will be around properly during my afternoon (UTC+1)
09:49:13 bauzas gibi: ack, I probably need your help to understand the problem
09:49:50 bauzas gibi: just to explain the issue, we don't trigger the reshape since the root inventory we have at first time doesn't have yet the VGPU RC
09:49:57 bauzas it will be there later
09:50:54 gibi good hint, can be some race condition in the test
09:52:47 bauzas gibi: I feel we probably trigger the reshape *before* we add the inventory to the root RP
10:02:13 ioni hello
10:02:33 ioni did you guys noticed that novnc sometimes doesn't have the right keymap, i think. the problem is that i cannot type | in the console, whenever i try to use shift+\ for |, the character is > instead of |
10:02:58 openstackgerrit Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972
10:05:17 lyarwood mdbooth_: https://review.openstack.org/#/c/551349/ - Anything more you wanted to add to this btw?
10:05:32 stephenfin ioni: What version of noVNC are you using? You need 1.0 for proper keymap support
10:06:01 ioni stephenfin, it's the one that comes with openstack ansible queens version
10:06:32 ioni novncproxy_git_repo: https://github.com/novnc/noVNC
10:06:32 ioni novncproxy_git_install_branch: 37b4d13db81e0e80e117c07b86ff98714c7b6b1a # Frozen HEAD of "master" as of 10.02.2018
10:06:52 ioni stephenfin, i think on rocky is the same
10:07:31 ioni stephenfin, i tried latest master and had the same problem but it was giving me the wrong server console for some reason and i reverted
10:07:47 stephenfin ioni: Oh yeah, that's 1.0.0, which should be fine
10:07:58 ioni had the same problem with |
10:08:23 stephenfin Then I'm not sure. You should not have the '[vnc] keymap' nova.conf setting configured
10:08:32 stephenfin So if that's set, unset it
10:08:44 ioni ok so keymap = None ?
10:09:15 gibi bauzas: the test first boot an instance while the vgpu resource is still on the root RP
10:09:20 ioni default on queens is en-us
10:09:46 gibi bauzas: and check the allocation and usages
10:09:47 ioni 2019-02-14 12:09:31.814 2988 DEBUG oslo_service.service [req-b9b6b811-d6c2-49f7-9006-47e60b8d17a7 - - - - -] vnc.keymap = en-us log_opt_values /openstack/venvs/nova-17.1.7/lib/python2.7/site-packages/oslo_config/cfg.py:2898
10:09:47 ioni 2019-02-14 12:09:31.874 2988 DEBUG oslo_service.service [req-b9b6b811-d6c2-49f7-9006-47e60b8d17a7 - - - - -] spice.keymap = en-us log_opt_values /openstack/venvs/nova-17.1.7/lib/python2.7/site-packages/oslo_config/cfg.py:2898
10:09:58 mdbooth_ lyarwood: Not specifically.
10:10:00 ioni it's starts with this default if is not set
10:10:18 gibi bauzas: anyhow, i will know more in 2 hours when i finally download and run the test
10:10:39 bauzas gibi: so, I tried to look at where we were, and I think we have a race
10:10:57 stephenfin ioni: You might want to look at commits d983234288728427235ef2c1f355ec135119b865 and cab8139498c7ea6b05cfdc8b4997276051b943fc in nova
10:11:15 stephenfin The first of those probably should have been backported, if it wasn't
10:11:45 stephenfin Looks like it is in stable/queens, actually
10:11:53 bauzas gibi: when https://review.openstack.org/#/c/631559/5/nova/tests/functional/libvirt/test_reshape.py@123, we don't have yet VGPU inventory since we just changed the conf opt
10:12:38 bauzas gibi: so, when entering .start(), we eventually go into https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L942
10:12:44 stephenfin ioni: OK, so override the default and set it to '' (the empty string)
10:13:09 ioni stephenfin, ok, testing

Earlier   Later