| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-12 | |||
| 16:34:22 | dansmith | mriedem: well, then backport this and fix it after if you want | |
| 16:34:33 | lyarwood | ack, I can take that if mdbooth can't | |
| 16:34:44 | dansmith | I would also define the partial right before you make the call to the driver, | |
| 16:34:53 | mdbooth | dansmith: TBH, I actually like the partial better, and in this context I'd partial all the things. | |
| 16:35:00 | dansmith | mdbooth: I have no doubt that you do | |
| 16:35:12 | mriedem | rollback still has to be fixed as well | |
| 16:35:13 | mriedem | for the same issue | |
| 16:35:29 | mdbooth | dansmith: The reason is that is simplifies the interface between compute and the driver by removing arguments which are purely local the the calling method. | |
| 16:35:45 | mdbooth | So the callback method only passes relevant data, and everything else remains local. | |
| 16:36:00 | mdbooth | However, that isn't why I used one here. Here's it's just so I didn't have to change the interface. | |
| 16:36:11 | dansmith | mdbooth: yeah, I get the obvious argument for it, I just think it hurts readability and understandability if you're just focused on that one method | |
| 16:36:44 | dansmith | it'd be slightly better if you define the partial and all the extra things you're going to pass down right before you make the call to the driver, | |
| 16:36:54 | openstackgerrit | Merged openstack/nova stable/pike: Add functional regression test for bug 1794996 https://review.openstack.org/623358 | |
| 16:36:55 | openstack | bug 1794996 in OpenStack Compute (nova) pike "_destroy_evacuated_instances fails and kills n-cpu startup if lazy-loading flavor on a deleted instance" [High,In progress] https://launchpad.net/bugs/1794996 - Assigned to Matt Riedemann (mriedem) | |
| 16:37:03 | openstackgerrit | Merged openstack/nova stable/pike: Fix InstanceNotFound during _destroy_evacuated_instances https://review.openstack.org/623359 | |
| 16:37:13 | openstackgerrit | Merged openstack/nova master: Trivial: reorder hashes according to object_hashes.txt https://review.openstack.org/636261 | |
| 16:37:19 | dansmith | but if I were to add something else in a year, we could easily end up with a partial(partial(thing)) because someone didn't read 50 lines up | |
| 16:38:27 | dansmith | using it to make a backport cleaner is exactly the hacky situation where I think the benefit outweighs the cost, but going forward in master, it's just a confusing hack, IMHO | |
| 16:58:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't set bandwidth limits for vhostuser, hostdev interfaces https://review.openstack.org/635170 | |
| 16:58:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove get_config_vhostuser https://review.openstack.org/565471 | |
| 16:58:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Validate bandwidth configuration for other VIF types https://review.openstack.org/636383 | |
| 16:58:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Further de-dupe os-vif VIF tests https://review.openstack.org/636384 | |
| 16:58:34 | stephenfin | jangutter, sean-k-mooney: Per our discussion on IRC last week ^ | |
| 16:59:32 | lyarwood | dansmith: so just to confirm, you'd be okay with https://review.openstack.org/#/c/551302/ as a backportable hack if the partial was moved down and we followed up with something different in master? | |
| 16:59:52 | dansmith | lyarwood: yeah | |
| 17:00:10 | lyarwood | dansmith: kk, I'll move that down now then, thanks | |
| 17:03:10 | stephenfin | mriedem, alex_xu: Any chance you could take a look at this again as some point this week? https://review.openstack.org/#/c/631038/ | |
| 17:04:51 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/551302 | |
| 17:05:20 | lyarwood | dansmith: ^ there we go, thanks again | |
| 17:06:17 | prometheanfire | does nova require pci_passthough_whitelist to be in the [pci] section in rocky or can it remain in [DEFAULT]? | |
| 17:10:05 | stephenfin | prometheanfire: It will be read from DEFAULT but it should be moved as we'll eventually remove the aliases | |
| 17:10:47 | stephenfin | prometheanfire: You'll get a warning. Also, the option in the '[pci]' group is simply called 'passthrough_whitelist', in case you'd missed that | |
| 17:11:04 | prometheanfire | ya | |
| 17:11:24 | prometheanfire | I'm working on a os_nova backport to stable/rocky, stein is already updated | |
| 17:11:26 | sean-k-mooney | it was technically moved in queens i think | |
| 17:11:35 | prometheanfire | ya, docs show it in pike too | |
| 17:11:44 | prometheanfire | https://docs.openstack.org/nova/pike/admin/pci-passthrough.html | |
| 17:12:15 | sean-k-mooney | prometheanfire: oh it was move in ocata | |
| 17:12:36 | prometheanfire | no one uses that :P | |
| 17:13:11 | sean-k-mooney | you would be surprised how many people are on Newton still | |
| 17:13:41 | sean-k-mooney | there are still people on liberty but yes few people use ocata | |
| 17:13:53 | sean-k-mooney | its EOL upstream anyway | |
| 17:14:19 | prometheanfire | it was a joke :P | |
| 17:14:48 | sean-k-mooney | but anyway https://github.com/openstack/nova/blob/master/nova/conf/pci.py#L84 | |
| 17:15:14 | sean-k-mooney | we still support both but we really shoudl drop support for [DEFAULT] at this point | |
| 17:15:28 | prometheanfire | ya | |
| 17:16:26 | sean-k-mooney | prometheanfire: if you are moving it yyou shoudl also move the pci alias too | |
| 17:17:07 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/conf/pci.py#L23 | |
| 17:18:34 | prometheanfire | alias wasn't even defined/used until stein (I'm adding it in the backports) | |
| 17:19:03 | sean-k-mooney | they predate kolla by years | |
| 17:19:22 | sean-k-mooney | you could use them via the config override mechanisium | |
| 17:20:14 | sean-k-mooney | the main issue was you could only have 1 alsi tuse to how the config_merger ansible plugin worked | |
| 17:20:35 | sean-k-mooney | it does not support MultiStrOpt fields | |
| 17:21:17 | sean-k-mooney | unlike the whitelist the alais does not support a json list format | |
| 17:30:05 | prometheanfire | does nova support out of tree drivers? (xenxl) | |
| 17:33:01 | melwitt | o/ | |
| 17:33:18 | sean-k-mooney | prometheanfire: nova does nto support out of tree drivers in general no | |
| 17:36:22 | prometheanfire | sean-k-mooney: ok, just curious | |
| 17:44:06 | stephenfin | sean-k-mooney, adrianc: Finished SR-IOV series review and left some comments. Ping me if/when there's more to look at. | |
| 17:44:32 | sean-k-mooney | stephenfin: cool i will try to adress them later today | |
| 17:47:00 | sean-k-mooney | stephenfin: it can wait till tomorow but we need to review https://review.openstack.org/#/c/636061/ tool the ironic and neutron spec were approved after m2 so apparently this is intending to target stien. | |
| 17:48:45 | sean-k-mooney | stephenfin: so 1 we need to validate it makes sense and 2 merge it and releas a new os-vif version before teh 27th. i was hoping to do a new release on friday week anyway but i would have prefered to at least have a nova/os-vif blueprint for this earlier | |
| 17:48:46 | prometheanfire | sean-k-mooney: they don't think they'd be able to support the driver fully upstream is the reason I asked | |
| 17:49:40 | sean-k-mooney | prometheanfire: so technically you can use out of tree drivers but they are not offically supported by nova (since they are out of tree) and nova may break them at any time | |
| 17:50:04 | sean-k-mooney | historically i dont know how volitile that interface has been | |
| 17:50:22 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146 | |
| 17:50:23 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells https://review.openstack.org/591657 | |
| 17:50:23 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | |
| 17:50:34 | sean-k-mooney | prometheanfire: so there is noting preventign kolla from supproting deploying them but they may break | |
| 17:52:15 | sean-k-mooney | prometheanfire: being out of tree means that maintaining comptablity with nova fall entirly onto the xenxl team. but yes being intree requires ci and other testing requirement so its non trivial | |
| 17:54:04 | prometheanfire | sean-k-mooney: not asking for osa (or kolla), that comes as the cost of out of tree :D | |
| 17:54:37 | sean-k-mooney | well being out of tree has benifits too | |
| 17:55:07 | sean-k-mooney | if the hypervior you are intergrating with is evolving quickly you can add features and adapt your driver much faster out of tree | |
| 17:55:44 | sean-k-mooney | so it best to bring it in tree when it stable and you have hit the baseline of feature you want o support | |
| 17:56:45 | prometheanfire | yep | |
| 17:58:42 | odyssey4me | prometheanfire OSA has implementations of out of tree drivers for nova already - for powervm IIRC | |
| 17:59:14 | prometheanfire | odyssey4me: good point I'll point him there | |
| 17:59:19 | odyssey4me | nova supports the use of out of tree drivers, but obviously the core team for nova does not 'support' those drivers - that'd be for the out of tree driver team | |
| 17:59:42 | odyssey4me | OSA also has nova-lxd driver support | |
| 18:09:51 | openstackgerrit | Paul-Emile Element proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | |
| 18:17:29 | prometheanfire | the pci_whitelist can accept a value like passthrough_whitelist= "{ "vendor_id": "10de", "product_id": "15f7" }" ? | |
| 18:17:42 | prometheanfire | or does it need to look like { "vendor_id": "10de", "product_id": "15f7" } | |
| 18:24:45 | sean-k-mooney | the later i think | |
| 18:25:13 | sean-k-mooney | prometheanfire: there a a bunch of examples here https://github.com/openstack/nova/blob/master/nova/conf/pci.py#L128-L162 | |
| 18:28:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Move finish_resize.(start|end) notifications to helper method https://review.openstack.org/635079 | |
| 18:28:27 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012 | |
| 18:28:27 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.openstack.org/614035 | |
| 18:28:28 | mriedem_afk | dansmith: there will be some easy pickings at the bottom of this series ^ | |
| 18:28:28 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036 | |
| 18:28:28 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037 | |
| 18:28:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353 | |
| 18:28:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123 | |
| 18:28:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892 | |
| 18:28:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | |
| 18:28:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853 | |
| 18:28:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | |
| 18:28:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | |
| 18:28:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890 | |
| 18:28:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | |
| 18:28:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | |