| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-11 | |||
| 14:43:56 | bauzas | placement will choose one child RP and make an allocation to it | |
| 14:44:07 | bauzas | then it goes down to the driver | |
| 14:44:16 | bauzas | which picks randomly at the moment | |
| 14:44:34 | bauzas | the last sentence has to change | |
| 14:44:53 | bauzas | the driver has to pick one of the available mdevs from the pGPU related to the allocation | |
| 14:45:00 | mriedem | driver.spawn() gets the allocations, so we just have to reconcile the local inventory in the driver to what was allocated and pick that mdev yeah? | |
| 14:45:05 | bauzas | or allocations would diverge from actual usage | |
| 14:45:14 | bauzas | mriedem: yup that | |
| 14:45:43 | bauzas | mriedem: we need to lookup the child RP from the allocation and find an allocable mdev from it | |
| 14:45:52 | bauzas | not a big deal, but still has to be done | |
| 14:46:12 | openstackgerrit | garyk proposed openstack/nova master: Better handle live migration abort https://review.openstack.org/635440 | |
| 14:46:17 | mriedem | does that need to be done separately from the reshaper patch, like as a dependency - even though it won't do anything until the reshape is done? | |
| 14:46:23 | mriedem | because that reshaper patch is already big | |
| 14:46:31 | bauzas | yeah I was considering this | |
| 14:46:38 | mriedem | i'd split them if possible | |
| 14:46:41 | bauzas | we could drop a -2 | |
| 14:46:46 | mriedem | 1. handled nested in spawn, 2. do reshapes | |
| 14:46:48 | bauzas | and only +W once all are accepted | |
| 14:46:54 | bauzas | or yeah, that | |
| 14:46:57 | bauzas | whatever | |
| 14:47:45 | mriedem | to remind me, the child RP is a pGPU on the compute node right? | |
| 14:48:04 | mriedem | and len(mdevs) is total VGPU inventory per pGPU child provider | |
| 14:48:53 | openstackgerrit | sean mooney proposed openstack/nova master: [DNM] libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | |
| 14:48:58 | sean-k-mooney | ignore ^ im just testing something | |
| 14:52:12 | bauzas | mriedem: correct, with the slight detail that total = len(mdevs) + pGPU.'available_instances' (which changes over the time) | |
| 14:52:34 | bauzas | that's why we need to count mdevs for the inventory | |
| 14:52:55 | bauzas | as "available instances" is a value that has a very different meaning | |
| 14:54:29 | openstackgerrit | sean mooney proposed openstack/nova master: [DNM] libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | |
| 14:54:56 | sean-k-mooney | still ignore ^ needed to fix merge confict to get gate jobs to run. | |
| 14:56:44 | mriedem | gibi: do you want to re-approve https://review.openstack.org/#/c/634767/ since it was rebased? | |
| 14:57:07 | gibi | mriedem: done | |
| 14:57:34 | mriedem | thanks | |
| 15:13:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Ignore VolumeAttachmentNotFound exception in compute.manager https://review.openstack.org/632657 | |
| 15:24:54 | jackding | mdbooth_: Could you please revisit https://review.openstack.org/#/c/616692/ since your last -1? It | |
| 15:32:30 | gibi | hey cores, can somebody push in https://review.openstack.org/#/c/633776/ it is a follow up and mriedem already +2 on it | |
| 15:42:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix race in test_volume_swap_server_with_error https://review.openstack.org/634334 | |
| 15:43:46 | sean-k-mooney | gibi: ya that makes sense. it conflict with a tone of patches so it would be good to merge sooner rather then later | |
| 15:44:33 | gibi | sean-k-mooney: exactly | |
| 15:55:01 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize https://review.openstack.org/633227 | |
| 16:04:57 | sean-k-mooney | stephenfin: before you hit the sriov migration seires want to quickly look at gibi's patch https://review.openstack.org/634334. its a faily small change | |
| 16:05:05 | stephenfin | ack | |
| 16:05:15 | gibi | stephenfin: thanks | |
| 16:08:57 | stephenfin | sean-k-mooney: Right link? That's mriedem's change you linked | |
| 16:09:10 | stephenfin | wait - I see what you were referring to | |
| 16:16:50 | efried | Is there an etherpad for the PTG yet? | |
| 16:17:26 | efried | mriedem, melwitt, cdent, other people who might know. ^ | |
| 16:17:44 | sean-k-mooney | efried: not that im aware of | |
| 16:18:00 | mriedem | https://etherpad.openstack.org/p/nova-ptg-train | |
| 16:18:01 | mriedem | nope | |
| 16:18:15 | efried | ight, thx | |
| 16:18:34 | sean-k-mooney | efried: well i guess you might as well start one with ^ | |
| 16:19:34 | sean-k-mooney | we normally use the location in the name but give this is the third denver ptg swapping to the release name is likely better | |
| 16:21:39 | sean-k-mooney | efried: by the way you will be waiting a while for intel to appove. its always late. | |
| 16:22:01 | efried | :) | |
| 16:35:56 | openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: partition compute services by conductor group https://review.openstack.org/635006 | |
| 16:52:12 | mriedem | the location in etherpad name thing is a forum thing, not really the ptg, https://etherpad.openstack.org/p/nova-ptg-queens https://etherpad.openstack.org/p/nova-ptg-rocky https://etherpad.openstack.org/p/nova-ptg-stein | |
| 16:57:22 | dansmith | mriedem: thoughts on my comment here? https://review.openstack.org/#/c/635146/8/nova/api/openstack/compute/views/servers.py | |
| 17:03:43 | mriedem | dansmith: commented | |
| 17:06:15 | mriedem | i don't feel the need for the guard i guess | |
| 17:10:20 | sean-k-mooney | mriedem: ya you can get the original version from the timeline but it is annoying | |
| 17:11:09 | mriedem | ? | |
| 17:11:35 | sean-k-mooney | mriedem: the non translated queens etherpad | |
| 17:11:36 | mriedem | i personally don't need the location in the etherpad name since i don't care where it was, i care when it was | |
| 17:11:43 | mriedem | oh yeah - that was annoying | |
| 17:12:51 | sean-k-mooney | it confused the hell out of me in the nova room at the following ptg i spent 20 trying to figure out what was up with my brower just to realise i was looking at the wronge page | |
| 17:13:03 | sean-k-mooney | *20 mins | |
| 17:15:26 | mriedem | pebkac | |
| 17:17:22 | openstackgerrit | Merged openstack/nova stable/rocky: PCI: do not force remove allocated devices https://review.openstack.org/635071 | |
| 17:53:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668 | |
| 17:53:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.openstack.org/635684 | |
| 17:55:25 | mriedem | stephenfin: i have a couple of comments in your novaclient change, was on the fence about -1ing https://review.openstack.org/#/c/635131/ | |
| 17:55:43 | stephenfin | ack | |
| 17:59:25 | dansmith | mriedem: okay, it just seems like we're linking two sentinels somewhat via tribal knowledge and that we're setting this up for breakage later, but it's not a huge deal to me | |
| 18:03:19 | mriedem | sean-k-mooney: i've got some questions in https://review.openstack.org/#/c/624842/ which sound like they mirror things leakypipes was asking about before | |
| 18:03:50 | sean-k-mooney | looking | |
| 18:04:07 | mriedem | leakypipes must be stuck in friday limbo | |
| 18:07:18 | mriedem | dansmith: yeah it's definitely tight coupling but i'm not terribly worried about it right now. i wonder if setting an attribute on the instance (not persisted) would help, but idk | |
| 18:07:25 | dansmith | ack | |
| 18:07:37 | mriedem | instance.from_down_cell = True or something | |
| 18:07:53 | mriedem | but then you have to check if that attribute is set on the object as well | |
| 18:08:01 | mriedem | or we default to False i guess | |
| 18:10:06 | kukacz | hi, I'm getting "MigrationPreCheckError: ... CPU doesn't have compatibility." while trying to live-migrate between hosts with same model of CPU. Turned out that by mistake I got newer package with /usr/share/libvirt/cpu_map.xml differing between those 2 hosts. downgraded libvirt-bin, restarted libvirt-bin and nova-compute services but still seeing same precheck error. where does the precheck take the cpu model from? | |
| 18:11:10 | kukacz | (had newer package on one of the two hosts) | |
| 18:13:58 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.68: Remove 'forced' live migrations, evacuations https://review.openstack.org/635131 | |
| 18:14:07 | sean-k-mooney | mriedem_lunch: replied inline https://review.openstack.org/#/c/624842/8//COMMIT_MSG | |
| 18:14:15 | stephenfin | mriedem_lunch: When you're back ^ | |
| 18:31:32 | artom | Who's our PowerVM guy? cfriesen? | |
| 18:32:19 | artom | I guess efried used to "it" | |
| 18:36:40 | artom | There's a unit test issue with to_legacy_dict() in the PowerVMLiveMigrateData... but as far as I can tell nothing actually calls to_legacy_dict anywhere | |
| 18:36:47 | artom | So I'm wondering if I can just get rid of it | |
| 18:40:24 | artom | In fact, the only place I can find *any* _legacy_dict methods is in the migrate_data.py objects and a couple of times in the libvirt migration code where we check if we got an ovo | |
| 18:40:30 | cfriesen | artom: I'm x86. :) used to be we called to_legacy_dict() from check_can_live_migrate_source() | |
| 18:40:34 | artom | I feel like that's left over from a long time ago and I can remove all of that | |
| 18:41:01 | melwitt | edmondsw ^ | |
| 18:41:30 | artom | cfriesen, ah, sorry got confused about your arch allegiance ;) | |
| 18:41:47 | artom | You know what, I'll propose a thing that gets rid of it all, and we'll see what breaks :) | |
| 18:41:58 | edmondsw | artom in a mtg but will look in a few | |
| 18:43:39 | artom | edmondsw, cheers! I really need to relocate, but leave your reply here and I'll check eavesdrop | |
| 18:52:01 | mriedem_lunch | artom: i think that was dropped when we bumped the compute rpc api version to 5.0 | |
| 18:52:38 | mriedem | https://github.com/openstack/nova/blob/stable/queens/nova/compute/rpcapi.py#L535 | |