| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-06 | |||
| 16:31:24 | jangutter | sean-k-mooney: ya, there's no netdev to set nifty options like rxqueuelen, etc. | |
| 16:31:29 | sean-k-mooney | tc cant do ratelimiting on a unix socket escpially since that socket is part of the contol plane not the data plane | |
| 16:31:55 | sean-k-mooney | jangutter: well you can set the queue lenght in the qemu commandline | |
| 16:32:02 | sean-k-mooney | and we do i think | |
| 16:32:26 | sean-k-mooney | but qemu does not do the rate limiting tc did i think | |
| 16:33:51 | openstackgerrit | sean mooney proposed openstack/nova master: cleanup *.pyc files in docs tox envs https://review.openstack.org/635210 | |
| 16:33:59 | jangutter | sean-k-mooney: drat, already running out of caffeine, I'm thinking of txquelen for tc qdiscs (like ip link set txqueuelen 500 dev eth0) | |
| 16:34:47 | jangutter | sean-k-mooney: yah, setting things like number of descriptors in vhost-user is something entirely different and doesn't have to do with rate limiting. | |
| 16:34:51 | mriedem | sean-k-mooney: weren't you +1 on https://review.openstack.org/#/c/565471/ previously? this change for bw was split out from that | |
| 16:37:09 | sean-k-mooney | mriedem: no dont think i had ever left a +1 on that one specifrically but i did remove my -1 | |
| 16:37:46 | sean-k-mooney | i have not reviewed it recently | |
| 16:38:31 | sean-k-mooney | mriedem: stephenfin anyway i dont think it would break vhost-user but i think it would have no effect | |
| 16:38:58 | sean-k-mooney | in anycase we should not set it as it cannot work with vhost-user so its misleading | |
| 16:40:55 | mriedem | sean-k-mooney: ok i remember you asking me to look at it :) | |
| 16:40:59 | mriedem | so maybe i assumed you had | |
| 16:42:23 | sean-k-mooney | mriedem: yes i did sorry i had planned too re review but i didnt get to it yet sorry | |
| 16:44:11 | mriedem | you're forgiven sean | |
| 16:44:23 | melwitt | bauzas: you're not in #openstack-placement, but there's a extraction update meeting at the top of the hour, hangout url to be linked in #openstack-placement | |
| 16:45:45 | bauzas | melwitt: I'll be there | |
| 16:45:51 | melwitt | cool | |
| 16:46:01 | bauzas | melwitt: for some reason, ZNC dropped me from -placement, but I'll rejoin | |
| 16:46:40 | bauzas | melwitt: thanks for the notice :) | |
| 16:47:47 | jangutter | sean-k-mooney, stephenfin: https://github.com/libvirt/libvirt/blob/568a417224e7b4656b9959b03154d45566480d65/src/conf/netdev_bandwidth_conf.h#L38 | |
| 16:49:00 | sean-k-mooney | jangutter right so based on ^ libvirt will ignore it for vhos-user if it is set | |
| 16:49:45 | jangutter | sean-k-mooney, stephenfin: yah, in fact, if that's canonical, it's a nice checklist of "supported" interfaces. | |
| 16:49:51 | openstackgerrit | Michal Arbet proposed openstack/nova master: Fix python3 compatibilit https://review.openstack.org/635220 | |
| 16:50:25 | openstackgerrit | Michal Arbet proposed openstack/nova master: Fix python3 compatibility https://review.openstack.org/635220 | |
| 16:57:10 | jackding | mriedem: just let you know that https://review.openstack.org/#/c/620706/ and https://review.openstack.org/#/c/603844/ is ready to review, thanks | |
| 17:01:23 | cdent | for those not in #openstack-placement placement checkin hangout at https://hangouts.google.com/call/C5h9TyVk5BMfSO8vGxZ_AEEE | |
| 17:10:51 | stephenfin | jangutter, sean-k-mooney: Right, so we were setting the option for OVS vHost User interfaces but it wasn't doing anything | |
| 17:11:24 | stephenfin | jangutter, sean-k-mooney: In that case, is it fair to fold it back into the following patch and just ignore the fact that it's being set, given that it does nothing? | |
| 17:11:56 | stephenfin | Far as I can see, the only side effect will be this https://review.openstack.org/#/c/565471/7/nova/tests/unit/virt/libvirt/test_vif.py | |
| 17:16:14 | sean-k-mooney | stephenfin: we should not set it if its not supported | |
| 17:16:47 | stephenfin | OK,so I guess I should pivot that bug to say "this should *not* be set"? | |
| 17:17:04 | sean-k-mooney | yes i think so | |
| 17:35:01 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Create claims when live migrating https://review.openstack.org/634606 | |
| 17:35:02 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | |
| 17:35:02 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Send dest NUMA info inside LiveMigrateData https://review.openstack.org/634828 | |
| 17:35:03 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [Very WIP] Update NUMA XML during live migration https://review.openstack.org/635229 | |
| 17:36:01 | artom | cfriesen, ^^ I know you wanted to play with early code. So it's still very early, but once that top [Very WIP] patch is just WIP it'll be ready for testing - by which I mean, I'll have enough code written to start actually running it myself in my dev env | |
| 17:36:24 | artom | So it'll most likely still be broken, actually :) | |
| 17:36:55 | artom | My plan is to write some automated tests with a tempest plugin we have, and iterate running those/fixing bugs until the feature works. Then unit tests will get fixed/written. | |
| 17:38:36 | cfriesen | artom: cool. I'm just finishing up some other downstream stuff, but thanks for the heads-up. | |
| 17:47:31 | mriedem | speaking of gibi's bw provider series, i'm +2 on the bottom 2 patches https://review.openstack.org/#/c/567268/ | |
| 17:47:36 | mriedem | to help keep that moving | |
| 18:10:07 | artom | cfriesen, yeah, no huge rush, just an FYI | |
| 18:16:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/634962 | |
| 18:31:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Update the PCI passthrough guides https://review.openstack.org/635243 | |
| 18:31:57 | stephenfin | mriedem: You might have some interest in that little doc patch ^ | |
| 18:32:24 | stephenfin | Inspired by stephenfin's struggles getting a PCI environment set up locally again | |
| 18:40:15 | cdent | mriedem, melwitt, jaypipes: Assuming we all still have jobs and openstack is still a thing come the opening of train, I'd like to work on making shared disk a thing. Do we have anything other than effort that is blocking that? | |
| 19:08:19 | mordred | cdent: I think that also assumes that the rule of law still holds somewhat and the seas haven't risen and swallowed us right? | |
| 19:08:38 | mriedem | cdent: unknown unknowns | |
| 19:08:52 | mriedem | i have a devstack-plugin-ceph patch that sets up a shared DISK_GB provider | |
| 19:08:59 | mriedem | but that job needs to be made multi-node to be interesting | |
| 19:09:13 | mriedem | https://review.openstack.org/#/c/586363/ | |
| 19:09:22 | mriedem | plus that existing bug which enumerates some known issues and the ptg etherpad | |
| 19:09:41 | mriedem | the todo from the ptg was write up a spec with the known issues and how we deal with those so we have a clear picture | |
| 19:09:55 | mriedem | then the rest i guess we find out from integration testing | |
| 19:11:22 | mriedem | cdent: assuming the vmware case is something like multiple vcenters sharing the same datastore? | |
| 19:11:41 | mriedem | or maybe that's already supported albeit poorly in nova | |
| 19:12:01 | cdent | mriedem: that's one. the other is N>1 datastores in the same vcenter | |
| 19:12:06 | cdent | shared can work there too | |
| 19:12:18 | cdent | https://github.com/cdent/placement-disk-models | |
| 19:12:36 | cdent | or a mix of both | |
| 19:13:07 | cdent | the main problem facing vcenters right now is the N>1 situation where it appears like there is a larger free slice than there actually is | |
| 19:13:22 | cdent | right now max_unit is manipulated to cover that, but it is tetchy | |
| 19:15:18 | cdent | mordred: you make a good point. I should have forewarned that I'm unable to enumerate all risks, and past performance is not an indicator | |
| 19:15:57 | mordred | cdent: fair | |
| 19:26:14 | openstackgerrit | sean mooney proposed openstack/nova master: update flavor admin docs https://review.openstack.org/635198 | |
| 19:28:21 | mriedem | need another stable core for https://review.openstack.org/#/c/633807/ | |
| 19:39:22 | openstackgerrit | Matt Riedemann proposed openstack/nova master: update flavor admin docs https://review.openstack.org/635198 | |
| 19:43:03 | openstackgerrit | Andrey Volkov proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | |
| 19:45:42 | sean-k-mooney | mriedem: thanks for adressing the remaining nits. i dont mind respinning for things like that but docs are not really my strong suit. | |
| 19:46:14 | openstackgerrit | sean mooney proposed openstack/nova master: cleanup *.pyc files in docs tox envs https://review.openstack.org/635210 | |
| 19:48:01 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix link to flavor extra specs docs https://review.openstack.org/635252 | |
| 19:49:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix link to flavor extra specs docs https://review.openstack.org/635252 | |
| 19:59:41 | openstackgerrit | sean mooney proposed openstack/nova stable/ocata: PCI: do not force remove allocated devices https://review.openstack.org/635075 | |
| 20:14:44 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | |
| 20:14:45 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Send dest NUMA info inside LiveMigrateData https://review.openstack.org/634828 | |
| 20:14:45 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Update NUMA XML during live migration https://review.openstack.org/635229 | |
| 20:18:50 | artom | OK, that's "done". Now to automate some tests. | |
| 20:19:13 | sean-k-mooney | artom: done as in works? | |
| 20:19:40 | artom | sean-k-mooney, no idea :) But I'm at the point there the XML on the dest should be updated. So I can start writing tests that assert stuff about it | |
| 20:20:11 | sean-k-mooney | im planning to pull it down in tommorow anyway but i can try it out later if you think it will work | |
| 20:20:14 | artom | It's an MVP - claims aren't cleaned up where they should be, no rollback handling, etc etc | |
| 20:20:33 | artom | sean-k-mooney, unlikely, I haven't run it myself yet | |
| 20:20:50 | artom | (Unless you count the gate) | |
| 20:21:36 | sean-k-mooney | well it wont hurt to try. ill spin it up on my ci cloud in the backgound and take a look | |
| 20:21:48 | artom | I fully expect it to blow up immediately :D | |
| 20:22:15 | sean-k-mooney | well thats what devstack vms are for | |
| 20:29:12 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: mention description field in user flavors docs https://review.openstack.org/635263 | |
| 20:41:53 | cfriesen | stephenfin: you around? | |
| 20:43:36 | sean-k-mooney | stephenfin: he normally finishes about 2 hours before now | |
| 20:43:39 | cfriesen | sean-k-mooney: mriedem: you guys might know this too...we expect both KVM-based and tcg-based qemu to report a hypervisor type of "QEMU", right? | |
| 20:43:50 | sean-k-mooney | yes | |
| 20:45:00 | sean-k-mooney | kvm is just a software/kernel accleration for qemu so it does not change the hypervisor type if used | |
| 20:45:24 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/634962 | |
| 20:45:26 | cfriesen | I think there's a bug in stephenfin's "fail live migration if instance has numa topologies" commit then. https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L166 | |
| 20:45:33 | sean-k-mooney | similarly if you were to use the tcg multi thread backend "which we dont support yet" it would still be qemu | |