| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-06 | |||
| 14:49:05 | dansmith | ah and we have it in our tests | |
| 14:49:19 | dansmith | like, explicitly setting it =False | |
| 14:52:40 | tssurya | damsith: https://bugs.launchpad.net/nova/+bug/1814913 | |
| 14:52:41 | openstack | Launchpad bug 1814913 in OpenStack Compute (nova) "A new instance_mapping record will have queued_for_delete set to NULL" [Undecided,New] - Assigned to Dan Smith (dansmith) | |
| 14:53:00 | tssurya | dansmith * sorry | |
| 14:53:04 | dansmith | thanks, patch shortly | |
| 14:53:16 | mriedem | high fives for team work | |
| 14:54:00 | tssurya | I will change the patch then to no longer have to consider "None" values | |
| 14:54:38 | bauzas | mmm, we don't document the reasons why flavors are immutable, neither in https://docs.openstack.org/nova/latest/admin/flavors.html or https://docs.openstack.org/nova/latest/user/flavors.html | |
| 14:54:40 | dansmith | tssurya: your patch? you still need to handle none values | |
| 14:54:49 | dansmith | tssurya: meaning you can't fail if they're there | |
| 14:55:15 | tssurya | dansmith: I mean this one: https://review.openstack.org/#/c/635120/ | |
| 14:55:19 | bauzas | I have a downstream request about modifying the nested flavor by not resizing, so I'd like to explain to the customer why I don't like it | |
| 14:55:23 | sean-k-mooney | bauzas: they are immutable as if they were not existing instaces may exceed available resouces | |
| 14:55:33 | dansmith | tssurya: ah okay | |
| 14:55:39 | tssurya | to get non-deleted I only need to ask for "False()" right ? assuming people ran the migration | |
| 14:55:54 | bauzas | yeah, I know *why*, but I'd like to see the fact that you can't modify a nested flavor to be documented | |
| 14:55:58 | dansmith | tssurya: no | |
| 14:56:05 | openstackgerrit | Yury Kulazhenkov proposed openstack/nova master: rename ScaleIO driver to VxFlex Os https://review.openstack.org/634866 | |
| 14:56:09 | dansmith | tssurya: you can't assume the migration was run until it's forced really | |
| 14:56:17 | sean-k-mooney | bauzas: the downstream issue is related to the flavor extra specs not the flaovr | |
| 14:56:27 | bauzas | yeah | |
| 14:56:38 | sean-k-mooney | bauzas: but yes it would be nice to have that documented | |
| 14:57:09 | tssurya | dansmith: even then now that you are fixing it, it would be wrong for me to have a logic where I am also querying for the None ones thinking they are non-deleted | |
| 14:57:11 | bauzas | tbh, I don't like to be able to modify the extra specs but... | |
| 14:57:28 | tssurya | because it could just be that the user has not run the migration | |
| 14:57:57 | dansmith | tssurya: if it's null it means we don't know if it's queued for delete or not, so pick one.. should the user see their instance go away or come back from the dead? it has to be one or the other | |
| 14:59:00 | tssurya | dansmith: hah I don't have a strong opinion on that probably "come back from dead" is better | |
| 14:59:08 | tssurya | so I will just leave my change as it is then | |
| 14:59:28 | tssurya | and just edit the commit/comment | |
| 15:01:58 | sean-k-mooney | bauzas: we proably should update https://github.com/openstack/nova/blob/master/doc/source/admin/flavors.rst#modify-a-flavor | |
| 15:02:32 | bauzas | I'm out of steam for that but yeah | |
| 15:02:46 | mriedem | bauzas: so add something about that here https://docs.openstack.org/nova/latest/admin/flavors.html#modify-a-flavor | |
| 15:03:55 | sean-k-mooney | bauzas: i can add a note if you like | |
| 15:04:08 | mriedem | you can copy what's in https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/flavor-description.html if you want | |
| 15:04:15 | mriedem | " Note The only field that can be updated is the description field. Nova has historically intentionally not included an API to update a flavor because that would be confusing for instances already created with that flavor. Needing to change any other aspect of a flavor requires deleting and/or creating a new flavor. " | |
| 15:05:29 | sean-k-mooney | mriedem: ya that makes sense. bauzas want me to do it since your busy or will i leave it to you. | |
| 15:05:59 | mriedem | we can also update the osc command note in https://docs.openstack.org/nova/latest/admin/flavors.html#modify-a-flavor to mention that support was added in openstack CLI in 3.16.0: https://review.openstack.org/#/c/575390/ | |
| 15:06:17 | mriedem | or just change the example to use osc | |
| 15:06:20 | mriedem | and drop the nonte | |
| 15:06:22 | mriedem | *note | |
| 15:06:30 | sean-k-mooney | sure | |
| 15:06:37 | bauzas | actually, the spec is a good example | |
| 15:06:43 | sean-k-mooney | ill go do that now | |
| 15:06:54 | bauzas | thanks | |
| 15:07:12 | sean-k-mooney | bauzas: ya you can use the spec as a reference for the customer while i update this | |
| 15:07:25 | bauzas | yeah | |
| 15:07:35 | bauzas | but anyway, I need to provide a hack :( | |
| 15:07:40 | bauzas | and I hate this | |
| 15:07:46 | sean-k-mooney | well you dont | |
| 15:07:56 | sean-k-mooney | we shoud discuss that downstream | |
| 15:07:59 | bauzas | oh yeah, I have to do it | |
| 15:08:03 | bauzas | trust me | |
| 15:12:10 | stephenfin | adrianc: Quick question: how does one identify the "OPN" of a ConnectX-3 NIC? | |
| 15:12:25 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix InstanceMapping to always default queued_for_delete=False https://review.openstack.org/635185 | |
| 15:12:44 | stephenfin | I can find the PSID via 'mstflint query' but can't see the OPN http://www.mellanox.com/page/firmware_table_ConnectX3EN | |
| 15:12:45 | sean-k-mooney | stephenfin: OPN? | |
| 15:13:08 | sean-k-mooney | oh its a vendor id | |
| 15:13:12 | stephenfin | sean-k-mooney: The second column in that firmware download list. I assume it's the part ID | |
| 15:13:32 | sean-k-mooney | ya it like intels etag for there firmware | |
| 15:13:47 | sean-k-mooney | at least it looks like it is anyway | |
| 15:14:00 | stephenfin | sean-k-mooney: I think that's only good to distinguish between e.g. the ConnectX-3 and ConnectX-3 Pro, based on http://www.mellanox.com/page/firmware_HCA_FW_identification | |
| 15:14:28 | stephenfin | and the ID I'm getting, 15b3:1003, doesn't give me any deets on https://www.pcilookup.com/?ven=15b3&dev=1003&action=submit | |
| 15:15:44 | stephenfin | adrianc: I had the PSID and just clicked down through the list of OPNs to find what I was looking for. If there's a better way though, I'd be happy to hear about it | |
| 15:15:46 | stephenfin | sean-k-mooney: ^ | |
| 15:17:02 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268 | |
| 15:17:02 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend RequestGroup object for mapping https://review.openstack.org/619527 | |
| 15:17:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | |
| 15:17:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | |
| 15:17:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240 | |
| 15:17:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529 | |
| 15:17:05 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459 | |
| 15:17:05 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | |
| 15:17:06 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | |
| 15:17:06 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | |
| 15:17:07 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | |
| 15:17:07 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | |
| 15:17:40 | jaypipes | stephenfin: ok, will try. (sorry, been out of IRC contact for 6+ days) | |
| 15:19:24 | stephenfin | jaypipes: It's all good. Thanks for even trying | |
| 15:30:27 | mriedem | why oh why doesn't the set -x here https://review.openstack.org/#/c/634962/2/nova/tests/live_migration/hooks/run_tests.sh@12 enable tracing? | |
| 15:30:46 | mriedem | http://logs.openstack.org/62/634962/2/check/legacy-grenade-dsvm-neutron-multinode-live-migration/f8f245f/logs/devstack-gate-post_test_hook.txt.gz#_2019-02-05_22_35_09_439 | |
| 15:31:12 | mriedem | oh i bet something downstream unsets it | |
| 15:32:53 | mriedem | aha http://logs.openstack.org/62/634962/2/check/legacy-grenade-dsvm-neutron-multinode-live-migration/f8f245f/logs/devstack-gate-post_test_hook.txt.gz#_2019-02-05_22_35_09_525 | |
| 15:36:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/634962 | |
| 15:36:35 | bauzas | gibi_off: would you mind if I was rebasing https://review.openstack.org/#/c/631559/ on top of the new revision I'm working for https://review.openstack.org/#/c/599208/ | |
| 15:36:37 | bauzas | ? | |
| 15:37:33 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Allow [pci]alias to take a list https://review.openstack.org/635191 | |
| 15:37:51 | mriedem | bauzas: i'm sure he doesn't mind | |
| 15:37:57 | bauzas | ack | |
| 15:46:46 | openstackgerrit | Jack Ding proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692 | |
| 15:55:08 | stephenfin | sean-k-mooney: https://that.guru/blog/updating-mellanox-connectx-3/ | |
| 15:55:27 | stephenfin | adrianc: ^ if you figure that out, I'll update the above | |
| 15:59:58 | openstackgerrit | sean mooney proposed openstack/nova master: update flavor admin docs https://review.openstack.org/635198 | |
| 16:04:41 | sean-k-mooney | stephenfin: i assume this should not happen http://paste.openstack.org/show/744632/ | |
| 16:05:26 | stephenfin | sean-k-mooney: You've got left over pyc files | |
| 16:05:34 | openstackgerrit | Merged openstack/nova master: Ignore some PendingDeprecationWarnings for os-vif https://review.openstack.org/634928 | |
| 16:05:35 | stephenfin | and the interpreter is trying to read them | |
| 16:05:43 | sean-k-mooney | oh even after -r | |
| 16:05:46 | stephenfin | 'find . -type f -name "*.pyc" -delete' | |
| 16:05:58 | melwitt | o/ | |