| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-05 | |||
| 10:54:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | |
| 10:54:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | |
| 10:54:56 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | |
| 10:54:56 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | |
| 11:51:47 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657 | |
| 11:59:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: API: Remove evacuate/live-migrate 'force' parameter https://review.openstack.org/634600 | |
| 11:59:12 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't force evacuate/live migrate in notification sample tests https://review.openstack.org/634920 | |
| 13:01:41 | openstackgerrit | Merged openstack/nova master: Follow up for per-instance serial number change https://review.openstack.org/634743 | |
| 13:01:57 | openstackgerrit | Jan Gutter proposed openstack/nova master: Ignore some PendingDeprecationWarnings for os-vif https://review.openstack.org/634928 | |
| 13:10:00 | jangutter | mriedem: ^ apologies for contributing to g8h8 2019 | |
| 13:18:21 | mriedem | https://blueprints.launchpad.net/nova/+spec/libvirt-neutron-sriov-livemigration and https://blueprints.launchpad.net/nova/+spec/handling-down-cell are now in runway slots | |
| 13:23:09 | openstackgerrit | Merged openstack/nova master: Move setting mac addresses for network devices to privsep. https://review.openstack.org/621529 | |
| 13:23:16 | openstackgerrit | Merged openstack/nova master: Move interface disabling to privsep. https://review.openstack.org/622150 | |
| 13:45:52 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to spec obj. https://review.openstack.org/631243 | |
| 13:45:53 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.openstack.org/631244 | |
| 13:45:53 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.openstack.org/631245 | |
| 13:48:42 | openstackgerrit | Merged openstack/nova master: Reject unshelve with port having resource request https://review.openstack.org/630725 | |
| 14:14:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop nova-multiattach job https://review.openstack.org/606981 | |
| 14:15:08 | mriedem | jaypipes: next 2 in the bw provider series are awaiting your loving embrace https://review.openstack.org/#/c/567268/ | |
| 14:16:34 | gibi_off | mriedem, jaypipes: thank your for the reviews! | |
| 14:17:10 | cdent | gibi_off: I hope you're feeling well, or at least headed that way | |
| 14:19:57 | gibi_off | cdent: thanks, I'm pretty OK | |
| 14:21:19 | gibi_off | cdent: I still have some extra medical steps ahead but so far so good | |
| 14:21:32 | cdent | glad to hear it, good luck with it all | |
| 14:21:36 | gibi_off | cdent: thanks | |
| 14:22:01 | gibi_off | I think I will remove the _off postfix from next week | |
| 14:22:40 | cdent | whatever you do, don't let openstack rush things | |
| 14:23:31 | gibi_off | I use openstack (and software dev in general) as something agains boredom | |
| 14:32:37 | efried | tinwood: I left a +2. I'm hoping the second comes from someone like dansmith who knows how to spell OVO | |
| 14:33:05 | tinwood | efried, thanks very much. | |
| 14:34:55 | efried | You're welcome, fwiw :) | |
| 14:38:20 | dansmith | I commented | |
| 14:38:47 | dansmith | I'm not really in favor of tracking every possible out of tree driver in our objects | |
| 14:38:59 | dansmith | so I'll let someone else +2 that | |
| 14:41:29 | efried | dansmith: An alternative would be to make that a string field so drivers can put their name in there without having to exist in an enum. Is that enum used for anything else anywhere ever? | |
| 14:41:59 | dansmith | yeah I dunno why it's an enum, and don't know where it's used | |
| 14:42:14 | efried | I looked yesterday and couldn't find anywhere other than in the diagnostics object. | |
| 14:42:20 | efried | I think | |
| 14:42:38 | efried | yeah | |
| 14:47:02 | bauzas | afternoon, folks | |
| 14:47:23 | bauzas | here and now, I begin my upstream day | |
| 14:47:59 | efried | \o/ | |
| 14:48:04 | bauzas | any fancy reviews to make ? | |
| 14:49:41 | efried | dansmith, tinwood: I looked at the in-tree usages of get_instance_diagnostics, and they're all using a string to set that field; none of them are using the actual enum class. So changing that to a string field would require no changes *in tree*. Out of tree, I suppose it would be harmless if we kept the enum around (deprecated) and let folks know to transition to using a plain string. | |
| 14:50:13 | tinwood | efried, I tried that, but it errored out as the field checks the enum for the string. | |
| 14:50:30 | tinwood | That's how I found I needed to update the enum. | |
| 14:50:53 | efried | tinwood: You tried just using a string in your oot get_instance_diagnostics impl? | |
| 14:52:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop the integrated-gate (py27) template https://review.openstack.org/634949 | |
| 14:53:07 | tinwood | efried, yes, I wouldn't have changed nova except it wouldn't accept 'lxd'. The equivalent change in nova-lxd needing it is a string: https://review.openstack.org/#/c/633270/3/nova/virt/lxd/driver.py | |
| 14:53:38 | tinwood | efried, line 1175 | |
| 14:53:44 | efried | Yeah, so that's what I'm saying. Instead of augmenting the enum every time some OOT (or in-tree for that matter) driver needs to implement get_instance_diagnostics, let's just change the field in the Diagnostics object to a StringField. We can deprecate the HypervisorDriver enum (or not, I guess it doesn't really matter if drivers want to use it to get their string). That way, any impl - in tree or out - can use any string they l | |
| 14:53:44 | efried | without having to dork with this enum. | |
| 14:54:33 | tinwood | efried, ah, I see - well, it would help me ... :) | |
| 14:54:44 | efried | I mean, I get the value in having a discrete set of values allowed in that field, but I don't think it's probably worth the hassle in this case. | |
| 14:55:05 | efried | dansmith: would you be supportive of such a change? | |
| 14:55:47 | dansmith | efried: we should ask whoever added that | |
| 14:55:56 | dansmith | but this falls into the realm of my previous meh on the topic | |
| 14:56:09 | efried | sergei nitikin | |
| 14:56:18 | efried | nikitin | |
| 14:56:25 | efried | blueprint restore-vm-diagnostics | |
| 14:57:48 | cdent | mriedem: to avoid a pointless "woot, yeah" response to your recent email, I say "woot, yeah" here. | |
| 14:57:50 | cdent | woot, yeah | |
| 14:58:49 | efried | tinwood: ^ | |
| 14:59:06 | tinwood | efried, taking a look | |
| 14:59:14 | mriedem | cdent: woot acknowledged | |
| 14:59:46 | efried | The spec doesn't say it's an enum. It says it's a string. The enum-ness must have been decided during impl time. | |
| 15:00:44 | tinwood | efried, indeed. But I can't merge my nova-lxd change as nova either needs a change to the enum-ness or adding the lxd bit. I could take a look at removing the enumness if that would help? | |
| 15:00:56 | tinwood | efried, which would you prefer? | |
| 15:02:03 | efried | tinwood: Yes, clearly you need a change to nova, I get that. I also get dansmith's position of not wanting to enumerate OOT drivers in an in-tree object. I think changing to a string field is a good compromise. Can you dig it? | |
| 15:02:20 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove PLACEMENT_DB_ENABLED from nova-next job config https://review.openstack.org/634953 | |
| 15:02:22 | tinwood | efried, sure, happy to take a crack at that. | |
| 15:02:22 | efried | your code will work the same either way | |
| 15:02:31 | efried | okay. I'll leave a comment on your review. | |
| 15:02:46 | efried | tinwood: you can use the same change set, so we can keep track of this thread of discussion. | |
| 15:03:11 | tinwood | efried, okay, will do. | |
| 15:09:06 | efried | tinwood: wrt getting rid of HypervisorDriver[Field], my opinion is that we should just kill it, with a warning sent out to the ML in case downstream/oot code happens to be using it (which seems like a really low probability). Would you like to craft that patch and/or ML post as well? | |
| 15:10:36 | tinwood | Sure, I can do the patch. The ML patch; yes, I can probably draft something. | |
| 15:12:54 | efried | tinwood: Thanks! | |
| 15:13:00 | tinwood | np :) | |
| 15:26:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: API: Remove evacuate/live-migrate 'force' parameter https://review.openstack.org/634600 | |
| 15:31:31 | sean-k-mooney | efried: which hypervior driver filed | |
| 15:31:52 | efried | sean-k-mooney: See https://review.openstack.org/#/c/633279/ | |
| 15:33:00 | sean-k-mooney | efried: rather then kill it why not make it an string field | |
| 15:34:04 | efried | sean-k-mooney: That's the plan: make the .driver field a StringField. But that's the only place HypervisorDriver[Field] is used, so we can get rid of that object. | |
| 15:35:11 | sean-k-mooney | oh ok | |
| 15:35:38 | sean-k-mooney | efried: for compatiablity i think we woudl need to rename it too | |
| 15:36:09 | efried | sean-k-mooney: I don't think so. The data type per se isn't changing. | |
| 15:36:15 | sean-k-mooney | efried: as in i dont think we are allowed to chagne types of fields in OVO | |
| 15:36:30 | efried | sean-k-mooney: All existing in-tree consumers use a string to assign the field | |
| 15:37:27 | sean-k-mooney | that is not my concern im wonderign how this will work during an upgrade | |
| 15:38:12 | sean-k-mooney | e.g. if you had an old api node and a new compute | |
| 15:38:48 | sean-k-mooney | i guess that shoudl not be and issue as you should upgrade your api and condocutor before the computes | |
| 15:38:59 | sean-k-mooney | at least for majour upgrades | |
| 15:39:00 | efried | adding an enum value doesn't make that better though, right? | |
| 15:39:08 | efried | still have the same problem | |
| 15:39:42 | efried | if you receive an object and it has a value you don't recognize in that field, you're borked either way. | |
| 15:40:00 | efried | but at least making it a string field will avoid that problem in the future. | |
| 15:40:02 | sean-k-mooney | well you would need to handel it in the object make compatioble function | |
| 15:40:07 | sean-k-mooney | when you are downleveling it | |
| 15:40:55 | sean-k-mooney | ya im just wondering if we shoudl rename it to driver_name when we make it a sting | |