Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-01-31
07:17:59 openstackgerrit Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476
09:40:31 openstackgerrit Zhenyu Zheng proposed openstack/nova master: WIP Don't change volume status to `in-use` when attach to shelved vm. https://review.openstack.org/627096
10:02:37 kashyap sean-k-mooney: When you get a moment, here is the WIP machine types spec: https://review.openstack.org/631154
10:33:58 openstackgerrit Merged openstack/nova master: Add configuration of maximum disk devices to attach https://review.openstack.org/616777
10:38:30 openstackgerrit Merged openstack/nova master: Fix config docs for handle_virt_lifecycle_events https://review.openstack.org/634058
10:41:53 sean-k-mooney kashyap: ill take a look at it later :)
10:42:08 sean-k-mooney kashyap: just making tea
10:42:10 kashyap sean-k-mooney: Sure, I never count on instant responses. Take a week.
10:42:14 kashyap :-)
10:42:26 kashyap I've got a few irons in the fire. And I'm off tomm at a conference.
10:47:34 stephenfin bauzas: Fancy taking a look at some docs? https://review.openstack.org/#/c/626931/
10:47:45 stephenfin that came up again when deploying multi-node configuration
10:48:51 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: libvirt: Add workaround to cleanup instance dir when using rbd https://review.openstack.org/628726
10:50:34 openstackgerrit Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215
10:50:35 openstackgerrit Chris Dent proposed openstack/nova master: Update nova docs front page for placement removal https://review.openstack.org/628183
10:50:35 openstackgerrit Chris Dent proposed openstack/nova master: Remove placement from nova install docs https://review.openstack.org/628184
10:50:36 openstackgerrit Chris Dent proposed openstack/nova master: Remove link to placement configuration from nova config docs https://review.openstack.org/628185
10:50:36 openstackgerrit Chris Dent proposed openstack/nova master: Remove placement from contributor doc https://review.openstack.org/628186
10:50:55 openstackgerrit Chris Dent proposed openstack/nova master: Switch to using os-resource-classes https://review.openstack.org/628278
11:03:50 kashyap stephenfin: Ah, just noticed this: https://review.openstack.org/#/c/626932/1
11:04:08 kashyap Nice clean-up. I had a buried TODO item for it.
11:15:38 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Switch tempest-slow to be run on python 3 https://review.openstack.org/634204
12:36:04 openstackgerrit Jan Gutter proposed openstack/nova master: Add support for vrouter HW datapath offloads https://review.openstack.org/572082
12:36:04 openstackgerrit Jan Gutter proposed openstack/nova master: Duplicate os-vif datapath offload metadata https://review.openstack.org/634218
12:36:05 openstackgerrit Jan Gutter proposed openstack/nova master: Collect duplicate codepaths in os_vif_util https://review.openstack.org/634219
13:07:13 openstackgerrit Merged openstack/nova master: unused images are always deleted (add to in-tree hper-v code) https://review.openstack.org/628793
13:34:30 openstackgerrit Merged openstack/nova master: Fix using template cell urls with nova-manage https://review.openstack.org/631649
13:43:36 openstackgerrit Merged openstack/nova master: Add fill_virtual_interface_list online_data_migration script https://review.openstack.org/614167
13:43:42 openstackgerrit Merged openstack/nova stable/rocky: Don't call begin_detaching when detaching volume from shelved vm https://review.openstack.org/633960
13:43:50 openstackgerrit Merged openstack/nova stable/rocky: Fix port dns_name reset https://review.openstack.org/633806
13:43:58 openstackgerrit Merged openstack/nova stable/rocky: Restore nova-consoleauth to install docs https://review.openstack.org/630997
13:44:05 openstackgerrit Merged openstack/nova stable/rocky: Skip checking of target_dev for vhostuser https://review.openstack.org/633734
13:55:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Add support for vrouter HW datapath offloads https://review.openstack.org/572082
13:56:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Duplicate os-vif datapath offload metadata https://review.openstack.org/634218
13:56:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Collect duplicate codepaths in os_vif_util https://review.openstack.org/634219
13:57:29 jangutter mriedem: thanks, copypasta.
14:00:17 openstackgerrit Maria Luisa Arches proposed openstack/nova stable/queens: Skip checking of target_dev for vhostuser https://review.openstack.org/634236
14:00:44 mriedem the gate floweth once more
14:01:24 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: Skip checking of target_dev for vhostuser https://review.openstack.org/634236
14:01:56 openstackgerrit Merged openstack/nova master: Force refresh instance info_cache during heal https://review.openstack.org/591607
14:02:42 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: Fix port dns_name reset https://review.openstack.org/633807
14:04:13 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: Don't call begin_detaching when detaching volume from shelved vm https://review.openstack.org/633962
14:04:42 sean-k-mooney mriedem: you asked if stephenfin or i wanted to backport https://review.openstack.org/#/c/627540/ on monday but it looks like you have already done it for rocky and queens. do you think we should backport it futher or is queens enough?
14:05:38 mriedem shrug
14:05:52 mriedem if it's in pike and someone needs it it can be backported
14:06:38 sean-k-mooney ok we dont have a custom issue related to this that im aware of so for now i guess queens is fine. thanks for cherrypicking it :)
14:07:18 sean-k-mooney if someone shots ill propsoe a backport
14:09:11 mriedem jangutter: do you want to do follow up for these nits or respin? https://review.openstack.org/#/c/634218/
14:09:32 mriedem stephenfin: jaypipes: +2 on the vrouter offload change https://review.openstack.org/#/c/572082/
14:09:46 jangutter mriedem: respin is perfectly fine for me
14:10:03 mriedem jangutter: and when do we consider the bp complete? when ^ merges or https://review.openstack.org/#/c/634218/ ?
14:11:28 sean-k-mooney mriedem: since your looking at that code stephenfin has a related change that that you might want to take a look at
14:11:30 sean-k-mooney https://review.openstack.org/#/c/565471/7
14:11:46 jangutter mriedem: the last functional code is on https://review.openstack.org/#/c/572082/ and anything else is just cleanup, IMHO.
14:13:03 jangutter mriedem: https://review.openstack.org/#/c/634218/ is the last patch for nova (Stein) on bp/generic-os-vif-offloads, with one more coming for os-vif.
14:13:24 mriedem ah ok
14:21:18 mriedem tssurya: do you know if theodoros needs this change or should it be abandoned? https://review.openstack.org/#/c/566470/
14:25:25 bauzas mriedem: FWIW, I'm looking at comments on https://review.openstack.org/#/c/599208/12/
14:25:33 bauzas I finally have time now to work on it
14:26:07 mriedem bauzas: ok, because i'm really losing steam on caring about that
14:26:24 bauzas mriedem: okay, I'll then see the comments and try to provide a new revision
14:33:09 mriedem jroll: is https://blueprints.launchpad.net/nova/+spec/ironic-conductor-groups going to happen in stein or get deferred to train?
15:00:20 ShilpaSD mriedem: Hi
15:01:39 mriedem mnaser: you might have an opinion on http://lists.openstack.org/pipermail/openstack-discuss/2019-January/002267.html which i'm trying to unblock
15:01:41 mriedem ShilpaSD: hi
15:02:02 ShilpaSD mriedem: https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/fixture_data/hypervisors.py#L40
15:02:21 mnaser mriedem: click
15:02:25 ShilpaSD here when first time get will call i want data mentioned as 'get_os_hypervisors '
15:02:32 ShilpaSD but want to call same method again with different result
15:02:37 ShilpaSD like side_effects
15:02:52 ShilpaSD how i can fit this requirement in fixtures here?
15:03:17 ShilpaSD mriedem:means more precisely, get_hypervisors() calling two times, and at second time i want different result
15:08:37 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Move retry from _update to _update_to_placement https://review.openstack.org/634252
15:19:13 openstackgerrit Jan Gutter proposed openstack/nova master: Duplicate os-vif datapath offload metadata https://review.openstack.org/634218
15:19:14 openstackgerrit Jan Gutter proposed openstack/nova master: Collect duplicate codepaths in os_vif_util https://review.openstack.org/634219
15:21:51 sean-k-mooney ShilpaSD: you can do that by makeing the side effect a lamda that is a coroutie the yeild different results on ech execution
15:22:55 sean-k-mooney ShilpaSD: im pretty sure we do this in the test in other places ill see if i can get an example. there is a fairly simple way to do it
15:23:57 ShilpaSD sean-k-money: thanks will check that, example will be great help
15:24:05 mriedem or make it conditional like here https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/fixture_data/hypervisors.py#L129
15:24:14 mriedem or sublcass and overwrite that mock
15:24:17 mriedem *subclass
15:25:47 ShilpaSD mriedem: here based on API version url is different, so its conditional
15:26:00 ShilpaSD will check option of subclass
15:26:02 sean-k-mooney ShilpaSD: basically all you need to do is make the fuction that is set as the side effect stateful in some way so that it can yeild idfferent results
15:27:31 ShilpaSD sean-k-money: will check how i can do this
15:30:44 sean-k-mooney ShilpaSD: i think something like this will work
15:30:47 sean-k-mooney def side_effect_generator(items):
15:30:49 sean-k-mooney for x in items:
15:30:51 sean-k-mooney yeild x
15:30:53 sean-k-mooney
15:30:55 sean-k-mooney my_mock.side_effect = side_effect_generator
15:32:06 sean-k-mooney actully more like this
15:32:10 sean-k-mooney def side_effect_generator(items):
15:32:12 sean-k-mooney for x in items:
15:32:14 sean-k-mooney yeild x
15:32:16 sean-k-mooney results = [suff, more_stuff]
15:32:18 sean-k-mooney my_mock.side_effect = side_effect_generator(results)
15:32:33 sean-k-mooney ShilpaSD: does that makes sense ^
15:32:38 ShilpaSD sean-k-mooney: will try and get back to you
15:34:39 sean-k-mooney cool basically we are usign the fact that corouties/generator fuction will maintain there internal state so you can pass a set of results and everytime it gets invoke it will advance the genortor one step thoguh the list of results

Earlier   Later