Posted	Nick	Remark
#openstack-nova - 2019-01-29
20:53:18	mriedem	there are lots of TODOs and FIXMEs in the code with things like "this will need to change to support sharing providers"
20:53:24	mriedem	like in the cold migration flow
20:53:30	cdent	thanks, I had lost track of that bug
20:53:43	mriedem	also L220 https://etherpad.openstack.org/p/nova-ptg-stein
20:53:53	jaypipes	cdent: along with a giant-ass reshape-the-world-for-shared-storage function that would "correct" the allocation of resources.
20:57:02	cdent	It's looking like shared disk could make multiple datastores in one vsphere cluster way more sensible. nested could also work, but shared will work in both the "this cluster owns this store" and "this store is used by multiple clusters" set ups
21:05:21	mriedem	fyi, new pip release of something is destroying pep8 in the gate
21:06:41	mriedem	this https://pypi.org/project/pycodestyle/2.5.0/
21:11:06	cdent	joy!
21:11:20	cdent	this is the disk playing about I was talking about ^^ https://github.com/cdent/placement-disk-models
22:04:45	mriedem	good lord i really dislike the PciDevice* object interfaces
22:04:51	mriedem	so different from everything else we have for versioned objects
22:06:32	mriedem	burying too much business logic in the data model
22:06:42	mriedem	it's that some kind of anti-pattern...
22:06:45	mriedem	*isn't that
22:38:28	mriedem	dansmith: interesting fun fact of the day: you can't load 'fault' using expected_attrs with Instance.get_by_uuid
22:40:41	mriedem	http://paste.openstack.org/show/744212/
22:40:47	mriedem	something everyone cares about
23:24:12	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove deprecated 'os-server-groups' policy https://review.openstack.org/633672
#openstack-nova - 2019-01-30
00:51:20	openstackgerrit	Matt Riedemann proposed openstack/nova master: Isolate cell-targeting code in MigrationTask https://review.openstack.org/621310
00:51:21	openstackgerrit	Matt Riedemann proposed openstack/nova master: Move resize.prep.start/end notifications to helper method https://review.openstack.org/633298
00:51:22	openstackgerrit	Matt Riedemann proposed openstack/nova master: Extract compute API _create_image to compute.utils https://review.openstack.org/621311
00:51:22	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012
00:51:23	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.openstack.org/614035
00:51:23	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036
00:51:24	openstackgerrit	Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037
00:51:24	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353
00:51:25	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123
00:51:25	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892
00:51:26	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581
00:51:26	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313
00:51:27	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293
00:51:27	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890
00:51:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtSourceTask https://review.openstack.org/627891
00:51:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853
01:14:00	openstackgerrit	Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855
02:16:42	openstackgerrit	Merged openstack/nova master: Raise 403 instead of 500 error from attach volume API https://review.openstack.org/632904
02:16:51	openstackgerrit	Merged openstack/nova stable/pike: Default embedded instance.flavor.is_public attribute https://review.openstack.org/619352
02:16:58	openstackgerrit	Merged openstack/nova master: Fix port dns_name reset https://review.openstack.org/631684
08:20:07	openstackgerrit	Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476
10:08:15	openstackgerrit	Maciej Jozefczyk proposed openstack/nova master: Add fill_virtual_interface_list online_data_migration script https://review.openstack.org/614167
10:08:15	openstackgerrit	Maciej Jozefczyk proposed openstack/nova master: Force refresh instance info_cache during heal https://review.openstack.org/591607
10:29:55	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Fup for the bandwidth resource provider series https://review.openstack.org/633776
10:30:06	openstackgerrit	Merged openstack/nova master: Fix string interpolations in logging calls https://review.openstack.org/633657
10:40:03	openstackgerrit	Merged openstack/nova master: Convert vrouter legacy plugging to os-vif https://review.openstack.org/571325
10:42:44	openstackgerrit	melanie witt proposed openstack/nova stable/rocky: Allow ability for non admin users to use all filters on server list. https://review.openstack.org/633910
13:20:42	openstackgerrit	Merged openstack/nova master: Don't call begin_detaching when detaching volume from shelved vm https://review.openstack.org/624959
13:28:01	openstackgerrit	Merged openstack/nova master: Reject interface attach with QoS aware port https://review.openstack.org/570078
13:53:32	mriedem	Kevin_Zheng: should be able to cherry-pick https://review.openstack.org/#/c/624959/ to stable/rocky in the gerrit UI, I don't expect there to be conflicts
13:54:38	Kevin_Zheng	mriedem: yeah, I was planning to, my computer is updating...again
13:59:12	mnaser	not that i run or care much about ocata but, all previous serious patches have merged -- https://review.openstack.org/#/c/619366/
13:59:26	mnaser	(i just want to get it off my review list :)
13:59:52	mnaser	(cc melwitt smcginnis as they've merged the stable/pike)
14:05:50	smcginnis	Oh yeah, I had looked earlier but was waiting for later stable branches to merge.
14:12:15	openstackgerrit	Matt Riedemann proposed openstack/nova stable/rocky: Fix port dns_name reset https://review.openstack.org/633806
14:15:53	sean-k-mooney	stephenfin: jaypipes care to re +w https://review.openstack.org/#/c/591607/? it still can merge until https://review.openstack.org/#/c/614167/20 does but if ye are still happy with it it would be nice to have that lined up for wehn the bottom patch is merged
14:17:49	jaypipes	sean-k-mooney: done. I need to final review the bottom patch anyway, thx for the reminder
14:19:27	sean-k-mooney	jaypipes: this fixes a downstream customer issue which has be blocked on my trello board since last year so i am both lokking forward to it mergenign and not since i will have to backport it to newton...
14:20:31	maciejjozefczyk	\o/
14:25:48	openstackgerrit	Zhenyu Zheng proposed openstack/nova stable/rocky: Don't call begin_detaching when detaching volume from shelved vm https://review.openstack.org/633960
14:25:54	cdent	all the way to newton? ugh
14:27:06	openstackgerrit	Zhenyu Zheng proposed openstack/nova stable/queens: Don't call begin_detaching when detaching volume from shelved vm https://review.openstack.org/633962
14:29:24	mriedem	jangutter: a few questions in https://review.openstack.org/#/c/572082/
14:30:25	mriedem	sean-k-mooney: if it makes you feel better huawei will need to take it to mitaka
14:32:40	jangutter	mriedem: thanks, checking!
14:34:05	mdbooth	lyarwood: Just looking at your patch https://review.openstack.org/#/c/626952/1/nova/api/openstack/wsgi_app.py. IIUC that's basically what we do for all non-wsgi services here: https://github.com/openstack/nova/blob/master/nova/cmd/__init__.py
14:34:49	jaypipes	sean-k-mooney: yikes. (on newton). I just backported shit to Ocata and know how painful that is.
14:35:10	mdbooth	I'm pretty sure that means that we monkey patch while looking up the entry point, so before anything else.
14:35:57	sean-k-mooney	mriedem: well if it was not for the fact that osp 7 went endo f life on august 5 2018 we would have had to backport to kilo
14:36:18	mdbooth	'end of life'
14:38:24	mriedem	tssurya: regarding https://review.openstack.org/#/c/614167/ cern might want to investigate that up front before running it on all cells since it iterates all cells but is intended to migrate cell-specific data
14:38:40	mriedem	which is kind of different from how we do other online data migrations which only hit the cell db
14:38:41	sean-k-mooney	jaypipes: osp 10/netwon is an lts release which will be supported until decmber 15 2021 alther it will move to extend maintant at the end of the year but ya we have to backport to newton faily commonly at present
14:39:03	mriedem	tssurya: it uses a marker though so once it runs for all cells on the first run it should be a noop if run on each individual cell,
14:39:20	mriedem	which i'm assuming cern does as part of upgrades - run online_data_migrations per cell db config via config management
14:39:43	mdbooth	And, on occasion, to Kilo still, despite being 'end of life' :/
14:41:00	sean-k-mooney	mdbooth: well there is always the $$$ factor that makes "end of life" more flexible then we might like :)
14:41:04	mdbooth	lyarwood: Ah, your patch touches that code too. And.... I'll bet the reason is that nova.utils imports keystoneauth1, which means we've already imported it before running the monkey patching.
14:41:22	mdbooth	sean-k-mooney: Indeed.
14:42:54	mriedem	jaypipes: i +2ed https://review.openstack.org/#/c/614167/ since i was the one hammering on the limit processing and tests and such
14:42:55	mdbooth	lyarwood: I think I'll pull the monkey_patch util method into a separate module which doesn't import anything.
14:44:33	mdbooth	This is a fix to change Ie7bf5d012e2ccbcd63c262ddaf739782afcdaf56
14:45:37	jaypipes	mriedem, sean-k-mooney: done.
14:46:22	sean-k-mooney	maciejjozefczyk: ^
14:56:22	dpawlik	jaypipes, cdent, dansmith: Hi, could you check https://review.openstack.org/#/c/628956/ and https://review.openstack.org/#/c/628128/ ? Thanks
14:57:01	cdent	ayup, thanks
15:05:41	lyarwood	mdbooth: ack yeah feel free to rewrite it and also take over authorship of the actual commit
15:08:20	mdbooth	lyarwood: Don't think I can do that, in gerrit at least
15:10:19	lyarwood	mdbooth: right, that's why I said commit ;)
15:10:42	lyarwood	mdbooth: just git amend with --author
15:11:17	lyarwood	ah wait that's a local alias
15:11:45	lyarwood	git commit --amend --author=foo
15:11:59	mdbooth	lyarwood: Ok, I can take the git commit, but it'll still be yours in gerrit I think. Shouldn't matter, anyway.
15:12:09	mdbooth	lyarwood: What's the relevant test for this, btw?
15:13:11	lyarwood	mdbooth: ykarel in #tripleo should be able to help with that, iirc there's a fedora28 py3 undercloud job deploying with SSL somewhere.
15:14:09	mdbooth	I'm just running functional on my version, and I've run unit tests matching 'wsgi', but that seems little better than a smoke test
15:15:46	tssurya	mriedem: thanks for bringing it to our notice, looking into right now
15:23:23	mriedem	jangutter: replied in https://review.openstack.org/#/c/572082/
15:23:36	mriedem	jangutter: looks like just add a todo and tweak the release note and i'm +2
15:24:01	jangutter	mriedem: thanks for risking your sanity!

Earlier   Later