Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-01-14
14:43:13 asmita gibi: How do we use this mehod?[1]:https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/utils.py#L30
14:43:27 asmita method*
14:44:22 sean-k-mooney mriedem: are you ok with removing your procedual -2 in https://review.openstack.org/#/c/616120/ since the spec has been merged and blueprint approved?
14:44:24 mriedem you don't
14:44:26 mriedem asmita: ^
14:44:42 mriedem it's patching the mock library at import time to avoid adding tests which call invalid assert methods
14:44:54 mriedem which used to be a problem, but is fixed in latest mock i believe
14:45:20 gibi asmita: mriedem was faster. But I think the mock library already fixed to reject those wrong asserts
14:45:36 gibi asmita: so you don't even need that patch any more
14:45:49 mriedem sean-k-mooney: done
14:46:49 sean-k-mooney mriedem: thanks it need to be rebased and some nits addressed but i think the feature is effectivly complete. we just need to test it properly and clean it up at this point.
14:48:16 asmita Okay.There is a test scenario in test_hypervisors.py file of novaclient which I need to implement.I need to raise exception in that test case..But because of the fixtures,I get a error as "No mock address".So how do I overcome this situation?
14:49:26 gibi asmita: do you have a patch up on gerrit I can look at?
14:51:12 asmita gibi: Not yet.
14:51:27 gibi asmita: just push the not working code up so I can look at it
14:56:57 asmita gibi: Please have a look.https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/utils.py#L30
14:57:06 asmita gibi: https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/utils.py#L30
14:57:29 asmita gibi : Sorry wron link
14:57:34 asmita wrong link
14:58:35 asmita gibi: paste.openstack.org/show/742306..Thanks.
14:58:45 gibi asmita: looking...
14:59:49 tobias-urdin any good way to actually health check novncproxy? we've had some fallouts where it stops working with "handler exception: [Errno 32] Broken pipe" on console requests
15:00:17 tobias-urdin i guess i'll have to look into some doing some vnc client that does a handshake and tries to find some response that could be checked
15:04:32 gibi asmita: this patch you pasted works for me, both py27 and py35 test passes for me on it
15:05:21 gibi asmita: http://paste.openstack.org/show/742307/
15:07:06 asmita gibi :Thanks .
15:07:24 gibi asmita: so I don't know why it doesn't work for you
15:09:10 asmita gibi : My concern here is whether it is okay to mock.patch and raise exception,the way I have done?
15:13:38 asmita gibi : Thanks.I will look into it.
15:17:35 gibi amotoki: is the self.cs.hypervisors.search() you call and the novaclient.v2.hypervisors.HypervisorManager.search that you mocked the same thing? if they are the same then you are not testing anything (except the mock library)
15:17:40 gibi amotoki: sorry
15:17:45 gibi asmita: ^^
15:21:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Allow run metadata api per cell https://review.openstack.org/624612
15:22:26 mriedem dansmith: the channel topic is pretty out of date, maybe we should just link to https://etherpad.openstack.org/p/nova-runways-stein ?
15:22:36 mriedem "Current review runways: https://etherpad.openstack.org/p/nova-runways-stein" or something
15:22:40 dansmith aye
15:22:49 dansmith will update in a bit
15:22:59 mriedem thanks
15:27:04 mriedem easy runway bp change with a +2 https://review.openstack.org/#/c/624612/ - run meta-api per cell
15:27:10 openstackgerrit Jan Gutter proposed openstack/os-vif master: Extend port profiles with datapath offload type https://review.openstack.org/572081
15:27:48 belmoreira efried: hi
15:28:25 efried belmoreira: Greetings. Today in the nova-scheduler meeting we brought up a couple of patches that CERN had showed interest in.
15:28:53 efried We were looking to find out if y'all could (re)deploy them to make sure they do what's intended and don't break the world.
15:29:00 efried (jaypipes heads up)
15:29:48 efried The first one was the placement traffic improvement series starting at https://review.openstack.org/#/c/615677/
15:30:11 efried IIRC, you had deployed it and demonstrated the expected improvements, which is great.
15:30:11 efried but
15:30:22 efried there was some concern about how it would behave in large ironic deployments.
15:30:36 efried Late last week I made some updates to hopefully take care of that
15:31:25 efried Last I recall, you were about to start deploying to your ironic nodes - not sure how far you got on that or whether you stalled it because of the perceived problems with the patches.
15:31:43 belmoreira efried: that are great news
15:31:54 efried Anyway, we were hoping you could redeploy the series in its current form to see if it's copacetic
15:34:03 belmoreira before the end of the year I was trying it with the ironic compute nodes. It was in our small test cell, and it was OK. Scalability issues will only be noticed in our prod instance. Was planning to do it next week.
15:34:37 belmoreira will check the new code, thanks.
15:36:16 efried belmoreira: Great.
15:36:40 efried The other one was jaypipes: https://review.openstack.org/#/c/623558/
15:36:40 efried I don't know anything about this, will let him speak to it.
15:43:09 cfriesen artom: have you made any progress with the resource-aware live migration stuff? I don't see any reviews up since the spec review.
15:43:56 sean-k-mooney cfriesen: i haven't seen artom online downstream yet today so not sure if he is about yet
15:44:26 cfriesen sean-k-mooney: thanks
15:44:54 belmoreira efried: I didn't try jaypipes code because merge/dependencies issues. Ended up with a custom code that only gets the info from the nodes in the cell. Will revisit it next week.
15:45:06 efried ight
15:45:18 jaypipes belmoreira: https://review.openstack.org/#/c/623558/ commit message should be self-explanatory. It should dramatically increase performance of your scheduler due to not doing N queries and only doing 1 query per cell.
15:45:29 sean-k-mooney cfriesen: i know he plans to work on it this sprint and once i finsih off the last few bits for the sriov migraton ill likely try and spend my time helping him with that work
15:46:28 cfriesen sean-k-mooney: good to hear. I'm hoping to have some review cycles for this.
15:52:05 belmoreira jaypipes: let me revisit again your patch. I wasn't able to use your code directly because it was relying in few things that are new to rocky and I got scared to push them to prod. But we cooked a light similar thing. This is the result in the schedule time: https://docs.google.com/document/d/1atA0wbUNBCdojiq8WyBKA0k8Ulyj91bzXDMPOIN9gRI
15:52:24 belmoreira jaypipes: I think yours will improve it even more
15:55:07 belmoreira jaypipes: after this what we observed is that now most of the time is because the placement call... But needs more investigation in our side.
15:56:53 belmoreira jaypipes: will let you know when we start again our tests. Thanks for all this work
15:57:55 jaypipes belmoreira: rock on :)
16:11:30 adrianc sean-k-mooney: working on the nits, PS will be uploaded by tommorow
16:12:38 adrianc sean-k-mooney: left to deal with several on the indirect implementation commit and ill upload
16:13:05 sean-k-mooney ok ill wait untill you have uploaded it so to rebase
16:13:25 artom sean-k-mooney, I'm around
16:13:33 artom cfriesen, nothing posted yet, working on it
16:13:35 adrianc sean-k-mooney: thanks
16:13:55 artom sean-k-mooney, just because I don't say anything, doesn't mean I'm not here ;)
16:13:59 cfriesen artom: cool, thanks.
16:21:29 sean-k-mooney artom: ah lurking in the backgound. sneaky :)
16:23:21 artom sean-k-mooney, I mean, it's sort of what everyone does by default, no?
16:26:10 sean-k-mooney artom: ya true but i usually say hi in the morning
16:27:51 artom sean-k-mooney, maybe I'll start doing that :)
16:29:39 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reject interface attach with QoS aware port https://review.openstack.org/570078
16:29:40 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reject networks with QoS policy https://review.openstack.org/570079
16:29:40 openstackgerrit Balazs Gibizer proposed openstack/nova master: Create RequestGroup from neutron port https://review.openstack.org/625941
16:29:41 openstackgerrit Balazs Gibizer proposed openstack/nova master: Include requested_resources to allocation candidate query https://review.openstack.org/625942
16:29:43 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268
16:29:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: Extend RequestGroup object for mapping https://review.openstack.org/619527
16:29:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239
16:29:45 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528
16:29:45 openstackgerrit Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240
16:29:46 openstackgerrit Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529
16:29:49 openstackgerrit Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459
16:29:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317
16:29:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421
16:29:52 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor PortResourceRequestBasedSchedulingTestBase https://review.openstack.org/624080
16:29:52 openstackgerrit Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310
16:29:53 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311
16:29:54 openstackgerrit Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543
16:29:54 openstackgerrit Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to return port with resource request https://review.openstack.org/630719

Earlier   Later