Earlier  
Posted Nick Remark
#openstack-nova - 2019-01-08
12:09:15 kashyap cdent: Hi, there! Hehe, don't underestimate yourself :D
12:40:06 sean-k-mooney1 kashyap sure ill take a look. i think i added this to my list yesterday but did not get a chance to review it
12:44:06 openstackgerrit Yikun Jiang proposed openstack/nova master: Per aggregate scheduling weight https://review.openstack.org/628163
13:40:10 openstackgerrit Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215
13:40:11 openstackgerrit Chris Dent proposed openstack/nova master: Update nova docs front page for placement removal https://review.openstack.org/628183
13:40:11 openstackgerrit Chris Dent proposed openstack/nova master: Remove placement from nova install docs https://review.openstack.org/628184
13:40:12 openstackgerrit Chris Dent proposed openstack/nova master: Remove link to placement configuration from nova config docs https://review.openstack.org/628185
13:40:12 openstackgerrit Chris Dent proposed openstack/nova master: Remove placement from contributor doc https://review.openstack.org/628186
13:43:27 kashyap sean-k-mooney1: Thanks!
13:46:45 gibi kashyap: do I see correctly that the bluprint for https://review.openstack.org/#/c/625216 haven't been approved yet?
13:47:35 kashyap gibi: Before I left for PTO, melwitt and co said they'd approve it. And I recall even seeing it is approved
13:47:59 gibi kashyap: this is still in new phase https://blueprints.launchpad.net/nova/+spec/support-qemu-native-tls-for-live-migration
13:48:17 kashyap gibi: Ah, the "Definition"
13:48:35 kashyap Hmm
13:52:52 gibi kashyap: no worries, just ping melwitt when she is up and get the administration done
13:53:52 gibi kashyap: I've started reading the implementation patch...
13:53:57 kashyap Yep, will do. Thanks for noticing. I saw the BP, but the "Accepted for Stein" decieved me.
13:54:27 kashyap gibi: It is nothing complex; but the underlying setup is a buffalo
13:55:18 kashyap gibi: I wrote a detailed end-to-end test here (some parts of it are already scripted by installer tools): https://kashyapc.fedorapeople.org/Native-TLS/Setup-for-NBD-and-migration-streams-over-TLS.rst.txt
13:56:47 gibi kashyap: thanks for the pointers. I will dissapeare for a meeting but still have the intention to go through your patch
13:57:06 kashyap Sure. I don't count on instant responses :-) Thanks for the time!
13:57:52 gibi kashyap: thank you for your effort!
13:59:57 kashyap melwitt: When you're about, following up from our pre-break chat here: Mind ACKing this one, assuming I answered all questions: https://blueprints.launchpad.net/nova/+spec/support-qemu-native-tls-for-live-migration
14:09:17 maciejjozefczyk melwitt: jaypipes PTAL https://review.openstack.org/#/c/614167/ https://review.openstack.org/#/c/591607 :)
14:20:42 jaypipes maciejjozefczyk: on it.
14:28:50 maciejjozefczyk thanks Jay
14:36:26 yonglihe Jay, thank you giving constructive advice for spec "show-server-numa-topology," , https://review.openstack.org/#/c/612256/20
14:36:41 jaypipes yonglihe: no problem. I'll do a final review on that shortly.
14:36:50 jaypipes yonglihe: just finishing up maciejjozefczyk's second patch review.
14:37:16 yonglihe so efficiency -:)
14:37:32 jaypipes :)
14:38:22 maciejjozefczyk jaypipes: after coffee already?
14:39:32 yonglihe Hi Alex, Matt, this 'show-server-group' spec is quite small, please help on it. you guys already working on that hardly, thanks.
14:40:03 openstackgerrit Rui Zang proposed openstack/nova-specs master: support virtual persistent memory https://review.openstack.org/601596
14:40:40 yonglihe oh, s/hardly/hard
14:44:42 jaypipes maciejjozefczyk: of course! :) already on cup 3.
14:45:13 jaypipes yonglihe: Matt's on PTO this week I think. Alex's IRC nick is alex_xu
14:45:27 jaypipes yonglihe: and I will review the show-server-group spec too. it's small, like you said.
14:45:55 yonglihe thanks, i got to grab alex on Cube -:)
14:48:08 openstackgerrit Jie Li proposed openstack/nova master: Support volume-backed server rebuild in compute https://review.openstack.org/625893
14:49:03 stephenfin jaypipes: Random question: is hugepage tracking in placement a thing you've thought about (distant future, obv)
14:49:05 stephenfin *?
14:49:58 jaypipes stephenfin: https://review.openstack.org/#/c/442718/
14:50:05 jaypipes stephenfin: blast from the past ;)
14:50:16 stephenfin :D
14:50:47 jaypipes stephenfin: short answer is yes, I've wanted to track that stuff in placement but all the NUMA and CPU topology stuff has dragged on with nested and other things
14:51:15 stephenfin jaypipes: Fair. IMO, the CPU side of things gets us more and should be higher priority, for sure
14:51:31 stephenfin fwiw, the reason I ask is '[nova] Mempage fun' on openstack-discuss
14:52:12 cdent jaypipes: you could totally port that to os-resource-classes now, if you felt so inclined. I'm still as confused as I was on the review about how we count
14:52:50 sean-k-mooney1 stephenfin: jaypipes talking about the mempage fun?
14:53:11 stephenfin sean-k-mooney1: Not willingly - I dragged him into it slightly ;)
14:53:37 sean-k-mooney1 stephenfin: hugepages in placement is part of sylivans numa in placement spec i think
14:54:17 sean-k-mooney1 stephenfin: we have talked about it many times in the past and it was one of the main usecase we created nested resouce provirders for
14:55:03 sean-k-mooney1 stephenfin: infact it was higher on or prioity list for nested provider which is why i was surpised we were leading with vgpus in denver
14:55:12 stephenfin sean-k-mooney1: Possibly, I haven't checked
14:55:53 stephenfin sean-k-mooney1: Though I'd been thinking we'd report pagesizes on both the root provider and the numa cell providers, but that wouldn't work because they're the same thing viewed in different ways
14:56:14 stephenfin Doesn't matter though. Not anything we're going to be tackling in the immediate future
14:57:14 sean-k-mooney1 stephenfin: it was somthing i really want to fix last/this cycle but with the company move i didnt get to work on it
14:57:43 sean-k-mooney1 there were enough depencise however that it likely could nto have been done until this cycle anyway
14:58:09 openstackgerrit Jie Li proposed openstack/nova master: Support volume-backed server rebuild in compute https://review.openstack.org/625893
15:05:31 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Support native TLS for migration and disks over NBD https://review.openstack.org/625216
15:08:20 openstackgerrit Rui Zang proposed openstack/nova-specs master: Virtual persistent memory libvirt driver implementation https://review.openstack.org/622893
15:13:03 jaypipes maciejjozefczyk: ok, reviewed https://review.openstack.org/#/c/591607/. If you can make that small change I can re-review quickly.
15:13:24 jaypipes cdent: oh, totes. just not something that's been on my priority list :)
15:14:04 openstackgerrit Rui Zang proposed openstack/nova-specs master: support virtual persistent memory https://review.openstack.org/601596
15:14:18 maciejjozefczyk jaypipes: checking
15:14:39 cdent jaypipes: sure. i was just pointing it out mostly in a sort of "hey, we got a thing for that now!" way
15:27:32 jaypipes cdent: ack, totes.
15:27:50 jaypipes cdent: that patch I linked to stephenfin was >1 year old, after all :)
15:28:11 cdent too much water under the bridge. I feel the abyss of time.
15:29:21 jaypipes cdent: ha! :)
15:33:17 openstackgerrit Rui Zang proposed openstack/nova-specs master: Virtual persistent memory libvirt driver implementation https://review.openstack.org/622893
15:49:42 openstackgerrit Maciej Jozefczyk proposed openstack/nova master: Force refresh instance info_cache during heal https://review.openstack.org/591607
15:50:00 maciejjozefczyk jaypipes: update done, about sorting: it's kind of chicken or egg problem, which came first, row in VirtualInterface or device_id set in neutron port_data
16:01:41 jaypipes maciejjozefczyk: +2 :)
16:02:04 maciejjozefczyk jaypipes: thanks
16:02:13 jaypipes maciejjozefczyk: no problem.
16:02:16 adrianc sean-k-mooney: Hey, hope you had a good holiday. do you reckon we can converge on libvirt-sriov-live-migration spec by end of M2 ?
16:02:22 jaypipes maciejjozefczyk: thx for your patience!
16:04:41 maciejjozefczyk jaypipes: I put the helmet on because im testing it on 40k instances restored prod db
16:06:20 sean-k-mooney adrianc: i would hope so
16:06:31 sean-k-mooney adrianc: and hi o/
16:07:43 gibi kashyap: I left a question inline in ttps://review.openstack.org/#/c/625216
16:07:54 sean-k-mooney adrianc: there are currently no outstanding comments that im aware of for https://review.openstack.org/#/c/605116/ so if people have review bandwith between now and the spec freeze i hope it ill get merged
16:08:05 jaypipes maciejjozefczyk: :)
16:08:16 kashyap gibi: Thanks, will look in a few.
16:08:39 adrianc sean-k-mooney: :) Great, i believe we dont have any more open issues according to the discussions. will it help to patition for a review in the nova weekly meeting on thursday ?
16:09:02 sean-k-mooney maciejjozefczyk: im really looking forword to your chages hopefully merging soon
16:09:45 sean-k-mooney maciejjozefczyk: im less loging forward to haveing to figure out how to backport it to newton downstream but we have customer hitting issue that your patches fix
16:10:22 maciejjozefczyk sean-k-mooney: I have backport to Newton
16:10:48 sean-k-mooney maciejjozefczyk: isnt newton eol upstream
16:11:05 maciejjozefczyk but for: https://review.openstack.org/#/c/614167 without functional tests
16:11:22 maciejjozefczyk sean-k-mooney: newton is the newest release I support, I could say ;]
16:11:39 maciejjozefczyk sean-k-mooney: Let me test a bit and I can send you patches if you want
16:12:03 maciejjozefczyk but for Newton I needed to cherrry-pick about 4-5 other patches along with one more to neutron
16:12:59 sean-k-mooney maciejjozefczyk: that woudl be useful. our donwsteam backport policy still say i have to wait for it to merge on at least master upstream before i can submit it for downsteam with getting an exception for out of tree hotfix so no rush
16:13:31 maciejjozefczyk ok
16:13:54 maciejjozefczyk sean-k-mooney: i'm not that lucky, sometimes we have patches that are in review in upstream, but only when we're confident
16:15:06 sean-k-mooney if we have ci/release blocking bugs we will sometimes make an excpetion but while this is an annoying issue its not that pressing
16:15:49 maciejjozefczyk for this particular one we have about 20-30 occurrences/day

Earlier   Later