| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-01-03 | |||
| 15:59:49 | ade_lee | mriedem, is the error I posted above related to https://bugs.launchpad.net/nova/+bug/1808247 ? | |
| 15:59:49 | openstack | Launchpad bug 1808247 in OpenStack Compute (nova) "nova-lvm job failing with ArgsAlreadyParsedError (privsep)" [Medium,Confirmed] | |
| 16:00:31 | ade_lee | I'm seeing .. "ImportError: cannot import name api" | |
| 16:07:51 | openstackgerrit | Merged openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779 | |
| 16:11:20 | mriedem | ade_lee: yeah since you're using lvm | |
| 16:11:21 | mriedem | Jan 02 18:31:41.561505 ubuntu-xenial-inap-mtl01-0001459779 nova-compute[1225]: DEBUG oslo_service.service [None req-bd4be651-b5b9-4638-86a8-36108a0b464f None None] libvirt.images_type = lvm {{(pid=1225) log_opt_values /usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py:2575}} | |
| 16:15:27 | ade_lee | mriedem, any workaround/fix for that? Its blocking some gate tests | |
| 16:15:46 | mriedem | ade_lee: no idea, | |
| 16:15:56 | mriedem | it looks like something failing in privsep but i'm not expert on that code, | |
| 16:16:02 | mriedem | mikal is probably the best person to ask, | |
| 16:16:07 | mriedem | but he's in australia | |
| 16:16:26 | mriedem | i also don't know why it's only hitting the lvm configuration | |
| 16:17:36 | mriedem | should maybe try running with this set to DEBUG https://github.com/openstack/nova/blob/master/nova/config.py#L46 | |
| 16:17:41 | mriedem | and see if that helps show where privsep is blowing up | |
| 16:18:18 | ShilpaSD | hi All, doing restacking, but failing with error "neutronclient.Unauthorized", any suggestions? | |
| 16:18:46 | ade_lee | mriedem, ok -- will try doing that | |
| 16:18:50 | ade_lee | thanks | |
| 16:24:00 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: debugging lvm privsep failures https://review.openstack.org/628213 | |
| 16:24:01 | mriedem | ade_lee: ^ | |
| 16:24:46 | ade_lee | mriedem, cool - I'll piggyback off that | |
| 16:57:26 | openstackgerrit | Chris Dent proposed openstack/nova master: Update nova docs front page for placement removal https://review.openstack.org/628183 | |
| 16:57:26 | openstackgerrit | Chris Dent proposed openstack/nova master: Remove placement from nova install docs https://review.openstack.org/628184 | |
| 16:57:27 | openstackgerrit | Chris Dent proposed openstack/nova master: Remove link to placement configuration from nova config docs https://review.openstack.org/628185 | |
| 16:57:28 | openstackgerrit | Chris Dent proposed openstack/nova master: Remove placement from contributor doc https://review.openstack.org/628186 | |
| 17:01:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add microversion 2.68 to support for volume-backed server rebuild https://review.openstack.org/627518 | |
| 17:09:27 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.openstack.org/612256 | |
| 17:51:21 | dansmith | mriedem: while we're waiting for confirm, we still have the original instance root disk still on the source, right? | |
| 17:52:13 | mriedem | per v2 of the spec i said we destroy the guest | |
| 17:52:23 | mriedem | on revert we re-spawn it | |
| 17:52:53 | dansmith | destroy, but does that mean delete too? | |
| 17:52:56 | mriedem | i went the driver.destroy route because that unplugs vifs and disconnects volumes on the source host | |
| 17:53:02 | dansmith | right, saw that | |
| 17:53:18 | dansmith | was not sure that would delete the image though as I thought there's a flag for that and was thinking maybe you were planning to not | |
| 17:54:16 | mriedem | that driver.destroy method has a destroy_disks flag which defaults to True, | |
| 17:54:59 | mriedem | which deletes the instance path, | |
| 17:55:04 | mriedem | which is where the root disk image is right? | |
| 17:55:04 | dansmith | okay let me finish my comment on v2 and you can see what I'm asking | |
| 17:55:22 | dansmith | yes | |
| 17:55:46 | dansmith | mriedem: look at my last two comments just now | |
| 17:56:17 | mriedem | i think the main difference between destroy and migrate_disk_and_power_off is that migrate_disk_and_power_off powers off the instance rather than destroy it (and copies the disks obviously), it also disconnects volumes like destroy, but doesn't unplug vifs for some weird reason | |
| 18:04:06 | dansmith | mriedem: added a few more comments, but I think if you fix the image question I'll be ready to +2 | |
| 18:04:30 | mriedem | replying to the first set | |
| 18:06:48 | openstackgerrit | Ifat Afek proposed openstack/nova master: The field instance_name was added to InstanceCreatePayload https://review.openstack.org/627967 | |
| 18:09:08 | openstackgerrit | Adrian Chiris proposed openstack/nova master: Add free for claimed, allocated devices https://review.openstack.org/616120 | |
| 18:09:08 | openstackgerrit | Adrian Chiris proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365 | |
| 18:09:09 | openstackgerrit | Adrian Chiris proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929 | |
| 18:09:09 | openstackgerrit | Adrian Chiris proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | |
| 18:17:48 | ade_lee | mriedem, hey is the log with the privsep logging on (I think) -- http://logs.openstack.org/20/621920/2/check/barbican-simple-crypto-devstack-tempest/f013bd9/logs/screen-n-cpu.txt.gz | |
| 18:18:11 | ade_lee | mriedem, I do see this -- http://logs.openstack.org/20/621920/2/check/barbican-simple-crypto-devstack-tempest/f013bd9/logs/screen-n-cpu.txt.gz#_Jan_03_17_17_25_532237 | |
| 18:18:45 | ade_lee | mriedem, and also this -- http://logs.openstack.org/20/621920/2/check/barbican-simple-crypto-devstack-tempest/f013bd9/logs/screen-n-cpu.txt.gz#_Jan_03_17_17_27_635858 | |
| 18:21:07 | openstackgerrit | Adam Spiers proposed openstack/nova-specs master: AMD SEV: address final feedback received prior to merge https://review.openstack.org/628252 | |
| 18:22:59 | openstackgerrit | Adam Spiers proposed openstack/nova-specs master: AMD SEV: address final feedback received prior to merge https://review.openstack.org/628252 | |
| 18:37:53 | mriedem | ade_lee: yeah this http://logs.openstack.org/20/621920/2/check/barbican-simple-crypto-devstack-tempest/f013bd9/logs/screen-n-cpu.txt.gz#_Jan_03_17_17_25_525734 | |
| 18:38:16 | mriedem | looks like we have a classic circular import | |
| 18:40:20 | mriedem | ade_lee: yeah it's this change https://github.com/openstack/nova/commit/26521718bdba3bccbf6270e26b76754c26304658#diff-31323cc5d9a493e21871761c5051db7c | |
| 18:40:25 | mriedem | merged on dec 8 which is when the failures started | |
| 18:42:32 | mriedem | i need to wrap up replying to comments on a spec and then i can push a change to see if i can fix that | |
| 18:42:55 | dansmith | why is tripleo the only thing hitting that I wonder? | |
| 18:44:10 | mriedem | that lvm thing? it's not | |
| 18:44:14 | mriedem | the nova-lvm job is busted by it | |
| 18:50:40 | dansmith | oh okay | |
| 18:51:23 | dansmith | first saw it come up in #tripleo so I just assumed | |
| 19:03:46 | mriedem | dansmith: replies inline https://review.openstack.org/#/c/616037/ thanks - seems like non-drastic changes | |
| 19:04:26 | mriedem | maybe i'll change that 'open questions' section to 'known issues' to denote things we know about but don't really care about right now and could be dealt with later if necesary | |
| 19:08:18 | mriedem | jaypipes: so in yonglihe's show server topology spec, your alternative is the GET /servers/{server_id}/topology which would just be NUMA info (not pci devices) and admin-only by default? | |
| 19:08:57 | jaypipes | mriedem: right | |
| 19:09:18 | jaypipes | mriedem: with work on a /devices endpoint done in a separate spec (with efried's help) | |
| 19:10:02 | mriedem | i believe i said in the ML thread that i was ok with /diagnostics or a sub-resource, as long as it wasn't something shoe-horned into the normal response body (GET /servers/{server_id}) or list (GET /servers or GET /servers/detail) | |
| 19:10:13 | mriedem | so whatever | |
| 19:12:09 | mriedem | replied to the ML | |
| 19:12:17 | dansmith | mriedem: yep, just need to fix the fact that you're deleting all the original copies of the instance in case of rollback and then I'm good | |
| 19:12:42 | mriedem | i eagerly await the spec proposal in 12 months to include GET /servers/{server_id}/topology info in GET /servers/{server_id} and GET /servers/detail output | |
| 19:12:48 | mriedem | because 2 api calls is hard | |
| 19:13:57 | jaypipes | mriedem: well, by that point, we'll have changed everything to GraphQL so we're all good. | |
| 19:15:08 | ade_lee | mriedem, thanks! | |
| 19:21:41 | cdent | something something pabst blue ribbon | |
| 19:35:47 | openstackgerrit | sean mooney proposed openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116 | |
| 19:40:21 | openstackgerrit | Chris Dent proposed openstack/nova master: Switch to using os-resource-classes https://review.openstack.org/628278 | |
| 20:38:21 | cfriesen | when advertising new traits (specifically the COMPUTE_SECURITY_TPM_2_0 trait), does the trait need to be added to some standard list first? | |
| 20:40:59 | cdent | cfriesen: you mean placement related traits or other kinds of traits? | |
| 20:41:13 | cfriesen | placement | |
| 20:41:40 | cfriesen | does it need to get added to os_traits first or something? | |
| 20:41:43 | cdent | to create a new standard trait it gets added to the os-traits lib: http://git.openstack.org/cgit/openstack/os-traits | |
| 20:41:58 | cdent | and then the code which uses the added trait depends on the release of the lib that includes it | |
| 20:42:55 | cfriesen | okay, makes sense. for the one I mentioned above, would that go in os_traits/compute/security.py then? with TRAITS=['TPM_2_0"] as the content? | |
| 20:43:08 | cdent | lemme confirm, one sec | |
| 20:43:13 | sean-k-mooney1 | cfriesen: any trait not defiend in os-traitns must start with CUSTOM_ | |
| 20:43:19 | melwitt | o/ | |
| 20:43:38 | cfriesen | sean-k-mooney1: yeah...the intent is for this to be a standard trait, so I think we need to add it to os_traits | |
| 20:43:59 | cdent | cfriesen: simple answer to you where and content question is "yes" | |
| 20:44:06 | sean-k-mooney1 | yes you do i had a patch for that i abandons over a year ago | |
| 20:44:09 | cfriesen | cdent: sweet, thanks | |
| 20:44:36 | cdent | you're welcome | |
| 20:45:19 | sean-k-mooney1 | cfriesen: https://review.openstack.org/#/c/514712/3/os_traits/hw/platform/security.py | |
| 20:46:15 | sean-k-mooney1 | melwitt: o/ happy new year | |
| 20:46:48 | melwitt | sean-k-mooney1: happy new year | |
| 20:47:03 | cdent | sean-k-mooney1, cfriesen is it COMPUTE or HW? | |
| 20:47:22 | cfriesen | so in the spec we have it as COMPUTE_SECURITY_TPM_2_0 | |
| 20:47:45 | cfriesen | at the time of sean's change I don't think the "compute" subdirectory existed yet | |
| 20:48:30 | sean-k-mooney1 | cdent: my patch was from 2017 so the example is in the wong folder but as cfriesen said the spec says COMPUTE_SECURITY_TPM_2_0 | |