Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-12-19
21:15:08 mriedem melwitt: i'm going to fix that unnecessary for loop in https://review.openstack.org/#/c/624870/ that Kevin pointd out, then approve
21:15:46 melwitt ok, sounds good
21:30:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Exclude build request marker from server listing https://review.openstack.org/624870
21:41:17 melwitt mriedem: so the func test in this change doesn't fail without the change https://review.openstack.org/567701 is that expected based on the commit message? if so, is there no way to demonstrate the bug in the test?
21:42:11 melwitt I wasn't sure based on the wording "that is not a regression"
21:43:05 mriedem been awhile, but the commit message is saying I8d426f2635232ffc4b510548a905794ca88d7f99 didn't introduce a regression
21:43:51 melwitt ok, so unrelated to what I'm seeing I think. basically, without the change, somehow AZ is being updated on the instance. I don't yet know how
21:44:40 mriedem i'll have to poke at it, i wrote that in may
22:00:33 melwitt looking at it myself for curiosity, I'm not finding how AZ could be updated without the fix. weird
22:05:24 openstackgerrit Merged openstack/nova master: Move a generic bridge helper to a linux_net privsep file. https://review.openstack.org/620010
22:15:03 mriedem oh yay, for a looong time we passed potentially the wrong image to move claim during a resize https://github.com/openstack/nova/blob/1249617bdfaa8f4c586159374a4a0b244bbb298a/nova/conductor/tasks/migrate.py#L77
22:15:19 mriedem based on the original image used to create the server, but potentially not the last image used to rebuild the server
22:15:24 mriedem gd req spec
22:17:26 mriedem which wasn't fixed until https://github.com/openstack/nova/commit/984dd8ad6add4523d93c7ce5a666a32233e02e34 inadvertently
22:17:54 melwitt hoo boy
22:18:18 melwitt me too :(
22:19:30 mriedem oh this also likely means that if you shelve, unshelve, resize, we're passing the original image used to create the server, not the current image meta (in case that changed)
22:23:56 melwitt so the AZ is still the original all the way to the end of the live migration. so how is the servers.get API returning the new AZ... the search continues
22:25:57 mriedem i think i know
22:26:07 mriedem the api code looks up the az from the instance.host
22:26:12 mriedem i think
22:26:21 melwitt pulled from the DB, the AZ is still the original in instance.availability_zone
22:26:26 melwitt ahhhh
22:26:40 melwitt must be, it can't be looking at instance.availability_zone
22:26:42 mriedem there are other bugs for that behavior
22:26:50 melwitt THANKS API
22:26:55 mriedem https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/servers.py#L185
22:27:16 melwitt le sigh
22:27:18 mriedem https://github.com/openstack/nova/blob/master/nova/availability_zones.py#L165
22:27:33 mriedem yeah if instance.host is not None, that code gets the az from the host aggregate, not the instance.az
22:27:59 mriedem ala https://review.openstack.org/#/c/582342/
22:28:00 melwitt well, that explains it
22:28:08 mriedem i have a f'ing patch for everything
22:28:22 melwitt it's true
22:28:30 mriedem https://bugs.launchpad.net/nova/+bug/1782539
22:28:30 openstack Launchpad bug 1782539 in OpenStack Compute (nova) "Fail to filter the list of instances by the available zone" [Medium,In progress] - Assigned to huanhongda (hongda)
22:33:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Pass request_spec from compute to cell conductor on reschedule https://review.openstack.org/582417
22:33:11 mriedem speak-o-the-turd
22:34:19 mriedem melwitt: so i'll adjust that test to assert based on the db rather than the api
22:34:51 melwitt ok, makes sense
22:37:17 melwitt now, to finish reviewing cross-cell-resize
22:58:14 openstackgerrit Hongbin Lu proposed openstack/nova-specs master: [WIP] Support scheduling VM's NICs to different PFs https://review.openstack.org/626055
23:03:11 tonyb I'm seeing something 'strange' where placement is always selecting the same host out of the $n available I *suspect* there is cruft in the DB after a bunch of failed boots but I don't really know
23:03:28 tonyb asside form the scheduler and placement logs where should I look?
23:04:25 melwitt tonyb: in the past, default scheduler behavior was to pack instances, so as long as a host has capacity, it would be returned again. I'm not sure if that's still the case now though
23:04:35 melwitt is that what you're seeing or no?
23:05:05 mriedem tonyb: there was a thread in the ops list about this recently, there is an option you can set to randomize the results from placement
23:05:16 mriedem https://docs.openstack.org/nova/latest/configuration/config.html#placement.randomize_allocation_candidates
23:05:32 tonyb melwitt: Ahh perhaps that's it
23:05:58 mriedem ^ goes in the placement config btw, not nova-scheduler
23:06:59 tonyb mriedem: Okay. I should have said this is queens but I'll look for packing and/or randomising
23:07:02 tonyb Thanks
23:07:47 mriedem looky here
23:07:48 mriedem https://docs.openstack.org/nova/queens/configuration/config.html#placement.randomize_allocation_candidates
23:08:24 tonyb mriedem: Will do.
23:09:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Update instance.availability_zone during live migration https://review.openstack.org/567701
23:09:04 melwitt in the olden days, IIRC, lots of operators preferred to maximize cloud utilization and packing is the way to do that. but maybe nowadays people prefer to spread out servers and risk not being able to land larger flavors. that's the history on the default as I understand it
23:09:30 mriedem huawei public cloud wants to pack like you've never packed before
23:09:45 melwitt :)
23:09:47 mriedem they want nova to pack even more,
23:09:54 mriedem doing shit like the solver scheduler and what watcher does,
23:10:01 melwitt moar efficiency. not surprising
23:10:04 mriedem dynamically load balancing for ultimate packitude
23:20:28 openstackgerrit Matt Riedemann proposed openstack/nova stable/rocky: Update port device_owner when unshelving https://review.openstack.org/626407
23:22:51 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: Update port device_owner when unshelving https://review.openstack.org/626408
23:29:09 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Update port device_owner when unshelving https://review.openstack.org/626409
23:40:30 openstackgerrit Hongbin Lu proposed openstack/nova-specs master: [WIP] Support scheduling VM's NICs to different PFs https://review.openstack.org/626055
23:43:42 openstackgerrit Merged openstack/nova master: Handle unbound vif plug errors on compute restart https://review.openstack.org/626228
23:45:12 mriedem jackding: looked at https://review.openstack.org/#/c/603844/ again, i still don't like it
23:49:29 openstackgerrit Merged openstack/nova master: Update port device_owner when unshelving https://review.openstack.org/559828
23:49:53 openstackgerrit melanie witt proposed openstack/nova stable/rocky: Handle unbound vif plug errors on compute restart https://review.openstack.org/626410
23:52:01 mriedem tl;dr i don't want to randomly have to hit the neutron API every time we rebuild/reboot to list ports for a server just to check if something is broken
#openstack-nova - 2018-12-20
00:10:20 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: Update port device_owner when unshelving https://review.openstack.org/626413
00:11:13 alex_xu jackding: I guess you forget this comment https://review.openstack.org/#/c/620959/5/specs/stein/approved/cpu-model-selection.rst@32
01:04:40 openstackgerrit wingwj proposed openstack/nova master: Fix an inaccurate link in nova doc https://review.openstack.org/626416
01:33:45 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix broken links https://review.openstack.org/625481
01:39:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove "Resource Providers" upgrade check https://review.openstack.org/626421
01:41:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove "API Service Version" upgrade check https://review.openstack.org/615348
01:41:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Drop old service version check compat from _delete_while_booting https://review.openstack.org/623589
01:43:14 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix a broken link https://review.openstack.org/625481
01:58:46 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104
01:59:31 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106
02:08:53 openstackgerrit Dongcan Ye proposed openstack/nova master: Reword volume snapshot create https://review.openstack.org/623456
02:17:18 openstackgerrit Brin Zhang proposed openstack/nova master: Remove useless sample tests in v266 https://review.openstack.org/614671
02:31:51 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110
02:32:12 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113
02:32:39 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974
02:32:53 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311
02:33:04 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581
02:33:17 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017
03:03:39 openstackgerrit Jack Ding proposed openstack/nova-specs master: Select cpu model from a list of cpu models https://review.openstack.org/620959
03:10:38 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Update instance.availability_zone during live migration https://review.openstack.org/567701
04:08:13 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018
04:08:24 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019
04:08:34 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020
04:08:47 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027
04:09:02 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031
04:12:36 openstackgerrit Merged openstack/nova master: Exclude build request marker from server listing https://review.openstack.org/624870
04:19:48 openstackgerrit Merged openstack/nova stable/rocky: Update port device_owner when unshelving https://review.openstack.org/626407
04:19:55 openstackgerrit Merged openstack/nova master: Fix an inaccurate link in nova doc https://review.openstack.org/626416

Earlier   Later