Posted	Nick	Remark
#openstack-nova - 2018-12-12
22:48:15	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add py36/py37 functional jobs to the experimental queue https://review.openstack.org/624826
22:48:23	melwitt	found that the error message gets squashed here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2341-L2343 and that's what ends up in the instance fault
22:49:39	melwitt	feels like a separate patch for improving the information there, I can try it and see how it looks, going to be a much longer string
23:15:53	openstackgerrit	Matt Riedemann proposed openstack/os-resource-classes master: Sync STANDARDS with placement/nova rc_fields https://review.openstack.org/624370
23:15:54	openstackgerrit	Matt Riedemann proposed openstack/os-resource-classes master: Tune up documentation to be more useful https://review.openstack.org/624384
23:21:44	mriedem	melwitt: oh ok, we should just do similar in https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2341 then and probably include the underlying reason
23:21:54	mriedem	also, duh duh duh nova-lvm job is busted (privsep) http://logs.openstack.org/43/619143/12/check/nova-lvm/786180c/logs/screen-n-cpu.txt.gz?level=TRACE#_Dec_12_12_35_39_607002
23:22:24	melwitt	mriedem: yeah, doing it now. figured I should write up a bug too
23:23:57	mriedem	https://bugs.launchpad.net/nova/+bug/1808247
23:23:57	openstack	Launchpad bug 1808247 in OpenStack Compute (nova) "nova-lvm job failing with ArgsAlreadyParsedError (privsep)" [Medium,Confirmed]
23:24:02	mriedem	if only mikal were on irc
23:28:49	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/os-vif master: Create iproute.IPRoute() inside a context https://review.openstack.org/624831
23:29:05	openstackgerrit	Merged openstack/nova master: Make compute rpcapi version calculation check all cells https://review.openstack.org/623284
23:29:16	openstackgerrit	Merged openstack/nova master: Remove allocations before setting vm_status to SHELVED_OFFLOADED https://review.openstack.org/623596
23:31:11	openstackgerrit	melanie witt proposed openstack/nova master: Propagate exception message from _prep_block_device https://review.openstack.org/624832
23:33:57	melwitt	ah, I guess I need a test to show it going to the fault message. or maybe just that the message from _prep_block_device gets included
23:41:00	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/os-vif master: Create iproute.IPRoute() inside a context https://review.openstack.org/624831
#openstack-nova - 2018-12-13
00:01:19	openstackgerrit	melanie witt proposed openstack/nova master: Propagate exception message from _prep_block_device https://review.openstack.org/624832
00:16:50	openstackgerrit	melanie witt proposed openstack/nova master: Add method to generate device names universally https://review.openstack.org/573066
00:16:50	openstackgerrit	melanie witt proposed openstack/nova master: WIP Add configuration of maximum disk devices to attach https://review.openstack.org/616777
00:20:23	openstackgerrit	Merged openstack/nova master: refactor get_console_output() for console logfiles https://review.openstack.org/575735
01:18:38	openstackgerrit	sean mooney proposed openstack/nova master: Libvirt: do not set mac when unplugging macvtap vf https://review.openstack.org/624842
02:06:39	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Support admin to specify project to create snapshot https://review.openstack.org/616843
03:27:36	openstackgerrit	zhangyujun proposed openstack/nova master: ESFIX: Should not raise while restore power on failed https://review.openstack.org/624854
03:30:36	openstackgerrit	zhangyujun proposed openstack/nova master: Should not raise while restore power on failed https://review.openstack.org/624854
07:35:55	openstackgerrit	Andrey Volkov proposed openstack/nova master: Exclude build request instance with marker from listing https://review.openstack.org/624870
07:50:37	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Fix flavor keyerror when nova boot vm https://review.openstack.org/582147
08:11:28	openstackgerrit	Takashi NATSUME proposed openstack/os-resource-classes master: Update author-email in setup.cfg https://review.openstack.org/624885
10:45:25	openstackgerrit	Merged openstack/nova stable/rocky: Only warn about not having computes nodes once in rpcapi https://review.openstack.org/624677
11:07:53	frickler	lyarwood: could I ask you to place https://review.openstack.org/619254 onto your review list? that's the last one in my stable backport series, all the others got merged
11:11:31	lyarwood	frickler: ack
11:12:15	openstackgerrit	Merged openstack/os-resource-classes master: Initial automated testing for os-resource-classes https://review.openstack.org/624366
11:12:16	openstackgerrit	Merged openstack/os-resource-classes master: Rename ORDERED_CLASSES to STANDARDS https://review.openstack.org/624369
11:12:17	openstackgerrit	Merged openstack/os-resource-classes master: Sync STANDARDS with placement/nova rc_fields https://review.openstack.org/624370
11:18:50	openstackgerrit	Tom Barron proposed openstack/nova stable/rocky: Do Not Merge, testing libvirt-python requirements https://review.openstack.org/624958
11:33:55	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: WIP don't call begin_detaching when detaching volume from sheved vm https://review.openstack.org/624959
11:49:30	openstackgerrit	Chris Dent proposed openstack/os-resource-classes master: Tune up documentation to be more useful https://review.openstack.org/624384
12:14:01	cdent	stephenfin: see my comment on https://review.openstack.org/624826 for something that might be of interest to you. Also I fixed the problems you identified in ^
12:14:58	stephenfin	cdent: Hmm, the cookiecutter? Weird. Maybe something's changed that I wasn't aware of
12:15:39	cdent	no, the functional tests stuff in 624826 not producing tox files because of shared envs
12:26:52	openstackgerrit	Chris Dent proposed openstack/os-resource-classes master: Tune up documentation to be more useful https://review.openstack.org/624384
12:33:58	openstackgerrit	Adrian Chiris proposed openstack/nova master: Allow libvirt to properly set-up and clean-up MACs https://review.openstack.org/624973
12:34:40	openstackgerrit	Georg Hoesch proposed openstack/nova master: allow tcp-based consoles in get_console_output https://review.openstack.org/624974
12:41:53	sean-k-mooney	stephenfin: can you review https://review.openstack.org/#/c/624831/ ill need to do a 1.13.1 release when that lands. os-vif is currently breaking the iptable hybrid job in nueutron
12:42:08	stephenfin	can do
12:42:35	adrianc	sean-k-mooney: https://review.openstack.org/#/c/624973/ this should take care of the macs issue
12:43:23	adrianc	sean-k-mooney: also you will need to re-deploy https://review.openstack.org/#/c/620123/ (macvtap multiple port binding POC)
12:43:40	sean-k-mooney	adrianc: i also submitted https://review.openstack.org/#/c/624842/
12:44:52	adrianc	sean-k-mooney: ahh :) should have looked more carefully on the incoming reviews
12:45:30	adrianc	sean-k-mooney: well i believe another WA code should be removed that is related, under nova/network/linux_utils.py
12:45:52	sean-k-mooney	adrianc: yes i wanted to do it in two parts.
12:46:00	adrianc	sean-k-mooney: if you have time look at my commit, ill abandon mine then
12:46:22	sean-k-mooney	setting the mac to 0 so we can backport and thenremove teh fuction call
12:46:55	sean-k-mooney	adrianc: yes i saw you removed the code here https://review.openstack.org/#/c/624973/1/nova/network/linux_utils.py
12:48:45	openstackgerrit	Stephen Finucane proposed openstack/nova master: Fail to live migration if instance has a NUMA topology https://review.openstack.org/611088
12:48:49	adrianc	sean-k-mooney: its a must as the removed code sets the 0 mac on the VF netdev, this will fail
12:49:12	openstackgerrit	Tom Barron proposed openstack/nova stable/rocky: Do Not Merge, testing libvirt-python requirements https://review.openstack.org/624958
12:49:22	sean-k-mooney	the vf netdev perhaps the vf itself no
12:49:29	adrianc	sean-k-mooney: i.e not removing the code will attempt to set mac address on the VF netdev, in the case of zero mac it will fail
12:49:42	sean-k-mooney	i was about to use my patchset to live migrate back and foth with out issues
12:52:08	adrianc	sean-k-mooney: ive also uploaded a new PS for the macVtap multiple port binding, i removed all the set/clear macs on bind/unbind as it was just covering the problems introduces in the plug/unplug hw veb
12:53:31	sean-k-mooney	adrianc: a good to know. we have our christmas event this evening so i may or may not get a chance to test it before i leave in 2 hours but ill use it going forward
12:53:42	sean-k-mooney	and you are right we get sean@pop-os:~$ sudo ip link set enp0s31f6 address 00:00:00:00:00:00
12:53:45	sean-k-mooney	RTNETLINK answers: Cannot assign requested address
12:54:17	adrianc	sean-k-mooney: libvirt in the case of macVtap will just set the mac on the vf netdev not the vf index (e.g 'administrative mac') and restores it to the previous value on teardown
12:54:55	adrianc	sean-k-mooney: enjoy the christmas event !
12:54:58	sean-k-mooney	ya, ill combine our two patches and also fix the unit test which strangly passed form me before but whatever
12:55:57	adrianc	ack thanks, on my setup i managed to live migrate with ping running within the migrating VM so it seems to be working
12:59:47	openstackgerrit	Merged openstack/nova stable/pike: Make supports_direct_io work on 4096b sector size https://review.openstack.org/619254
12:59:50	openstackgerrit	Matt Riedemann proposed openstack/nova stable/rocky: Make compute rpcapi version calculation check all cells https://review.openstack.org/624982
13:27:04	stephenfin	sean-k-mooney: Before I submit the next version of this, thoughts on https://review.openstack.org/#/c/624444/1/nova/objects/instance_pci_requests.py ?
13:28:48	cdent	mriedem, stephenfin: jaypipes was +W on this before I found (and fixed) a race, so if you're inclined to give it a gander: https://review.openstack.org/#/c/617941/
13:29:42	stephenfin	cdent: mriedem has already taken a look at that, so if he has time I'll leave it to him
13:30:02	cdent	✔
13:30:43	sean-k-mooney	thanks i stephenfin so the default numa afinity policy was ment to keep backward compatiblyt with existing behavior whic was the legacy policy im not sure if https://github.com/openstack/nova/blob/f572527d2b7f93b0c2108118c2f240f2dd1cf968/nova/pci/stats.py#L155 does that
13:31:32	mriedem	i looked at one file in there :)
13:31:41	sean-k-mooney	i assuem it does but i hate the fact we assuem things in the code. e.g. that if cpu_policy is not dedicated it is shared.
13:31:41	stephenfin	sean-k-mooney: nope, but the function called on the next line after that does https://github.com/openstack/nova/blob/f572527d2b7f93b0c2108118c2f240f2dd1cf968/nova/pci/stats.py#L240
13:31:50	stephenfin	mriedem: Oh :) I can take a look so
13:32:35	mriedem	cdent: just this yeah? https://review.openstack.org/#/c/617941/30..31/nova/tests/functional/test_nova_status.py
13:32:47	cdent	mriedem: that was the latest change, yes
13:33:06	sean-k-mooney	stephenfin: so yes it will do the right thing eventrully i just prefer to set the vaules as early as possibel rather then doing late tests
13:33:26	cdent	the race there didn't show up for test after test after test, and then it was at the good slot in the gate and failed
13:34:07	mriedem	cdent: done
13:35:17	sean-k-mooney	stephenfin: its up to you ill remove my -1 but its just a style thing i guess i prefer to explitly state thing up front rather then defenively check later
13:36:12	stephenfin	sean-k-mooney: I can add it. No harm
13:36:45	cdent	mriedem: I and my lines removed stats thank you
13:37:31	openstackgerrit	Stephen Finucane proposed openstack/nova master: objects: Store InstancePCIRequest.numa_policy in DB https://review.openstack.org/624444
13:37:31	openstackgerrit	Stephen Finucane proposed openstack/nova master: conf: Call out where pci.alias should be set https://review.openstack.org/624445
13:37:38	sean-k-mooney	stephenfin: ok other then that i was happy with the change over all however looks like the unit tests were less so
13:37:49	stephenfin	sean-k-mooney: Yeah, one test that I missed. Fixed now
13:39:19	stephenfin	gibi, mriedem: Could you take a look at this follow up docs patch today? https://review.openstack.org/#/c/614322/
13:39:39	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add irrelevant-files for grenade-py3 jobs https://review.openstack.org/624997
13:46:05	gibi	stephenfin: +2 from my side
13:46:18	frickler	mriedem: now that my stable patches have merged, can we talk about a new round of releases? would save me from having to run on custom-built pkgs. I'd mostly be interested in pike and queens currently
13:46:19	stephenfin	gibi: Thank you
13:54:45	mriedem	frickler: we normally do the releases in order starting from the most recent, so rocky->queens->pike,
13:54:55	mriedem	idk if melwitt was planning a stable release soon or not
13:58:50	frickler	melwitt: mriedem: at least I'd say it looks like a nice bunch of things has piled up at https://docs.openstack.org/releasenotes/nova/rocky.html#relnotes-18-0-3-38-stable-rocky
14:00:34	gibi	nova team meeting is starting on #openstack-meeting

Earlier   Later