| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-12-05 | |||
| 15:33:22 | yan0s | also, does any service neds to be restarted for updates in policy.json to take effect? | |
| 15:33:31 | mriedem | dansmith: replied | |
| 15:33:57 | mriedem | just tell me what you want me to do and i'll make the change | |
| 15:35:09 | mriedem | yikun: fyi, https://blueprints.launchpad.net/nova/+spec/live-migration-force-after-timeout is now in a runway slot until dec 19 | |
| 15:35:38 | dansmith | mriedem: well, I was going to volunteer to fix it since it's my complaint, but I think I'd rather it not tweak updated_at unless it's going to do a full refresh so it's consistent | |
| 15:36:04 | mriedem | i'll do it, i've got the series local already - i've been tweaking it along the way for my minor stuff | |
| 15:36:13 | mriedem | can you take a look at the next in line before i do? | |
| 15:36:18 | mriedem | the one that adds the cli hook | |
| 15:36:28 | dansmith | okay, other than that I'm good with it | |
| 15:36:29 | dansmith | okay | |
| 15:37:21 | dansmith | mriedem: that migration is going to do deleted records too, is that the intent? | |
| 15:39:29 | dansmith | mriedem: two comments on there | |
| 15:40:27 | mriedem | ew, no i dont think we want that | |
| 15:40:30 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Body verification for the lock action https://review.openstack.org/622835 | |
| 15:41:31 | mriedem | i'll address those as well | |
| 15:41:39 | mriedem | stephenfin: done | |
| 15:41:47 | stephenfin | Thank you | |
| 15:41:51 | mriedem | stephenfin: note that the pike backport hasn't been released yet | |
| 15:42:06 | mriedem | even though it was done on august | |
| 15:42:10 | mriedem | *merged | |
| 15:42:31 | mriedem | so....probably time to think about doing an os-vif pike release | |
| 15:42:40 | mriedem | stephenfin: do you want to queue that up? | |
| 15:43:14 | stephenfin | mriedem: Sure thing | |
| 15:47:35 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use tempest [compute]/build_timeout in evacuate tests https://review.openstack.org/623011 | |
| 15:54:50 | stephenfin | mriedem: https://review.openstack.org/623016 | |
| 15:54:57 | openstackgerrit | Merged openstack/os-vif stable/ocata: Check if interface belongs to a Linux Bridge before removing https://review.openstack.org/554523 | |
| 15:55:12 | mriedem | woohoo, summit and ptg are separate, $700 summit only with no lunch, ptg is $400 w/ lunch (oh thank you), and $1200 for both | |
| 15:55:28 | mriedem | so longer week, more expensive, no lunch, what's not to love?! | |
| 15:55:48 | tbachman | do they have gift-bags? | |
| 15:56:01 | mriedem | byogb | |
| 15:56:06 | dansmith | come on, even for atcs? | |
| 15:56:06 | tbachman | darn | |
| 15:56:13 | mriedem | no idea about atcs | |
| 15:56:41 | stephenfin | mriedem: Oh, I wonder if we should include this too, if we're doing a release? https://review.openstack.org/#/c/505731/ | |
| 15:56:54 | stephenfin | I'll prepare an ocata release too. Nothing else on the backlog | |
| 15:58:01 | cdent | efried: is https://review.openstack.org/#/c/613613/ still alive (kill safe connect) | |
| 15:58:50 | efried | cdent: I think so. Just needs core reviews. | |
| 16:00:40 | cdent | roger, just doing a to do list review, and it came round | |
| 16:04:05 | mriedem | stephenfin: question in https://review.openstack.org/#/c/505731/4 | |
| 16:04:28 | stephenfin | looking | |
| 16:06:02 | melwitt | o/ | |
| 16:08:55 | mriedem | stephenfin: i guess it's always been there? https://kernel.googlesource.com/pub/scm/linux/kernel/git/shemminger/bridge-utils/+/38837a8e19540690c80f5a3b0971e0e1495a4a3e/brctl/brctl_cmd.c#124 | |
| 16:09:29 | stephenfin | mriedem: :D I was looking at the exact same thing | |
| 16:09:55 | lbragstad | yan0s i think it depends on how the service init's the oslo.policy enforcer object | |
| 16:10:01 | openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | |
| 16:10:09 | lbragstad | yan0s there is a configuration option to reload policy rules when they change on disk, i believe | |
| 16:10:29 | lbragstad | s/configuration option/option parameter to the enforcer/ | |
| 16:10:36 | mriedem | lbragstad: that would be here https://github.com/openstack/nova/blob/master/nova/policy.py#L68 | |
| 16:11:15 | stephenfin | mriedem: It's in Ubuntu 16.04 http://manpages.ubuntu.com/manpages/xenial/man8/brctl.8.html and there's no changelog section, so I assume it's always been there too | |
| 16:11:56 | lbragstad | mriedem yeah - some documentation on it here https://docs.openstack.org/oslo.policy/latest/reference/api/oslo_policy.policy.html#oslo_policy.policy.Enforcer | |
| 16:13:09 | mriedem | hmm, so nova-api isn't dynamically reloading rules? | |
| 16:13:30 | mriedem | i only see ENFORCER.load_rules() called when we initialize it | |
| 16:14:24 | mriedem | yan0s: did you restart nova-api when you changed nova.conf to set the policy_file option? | |
| 16:14:40 | sean-k-mooney | o/ | |
| 16:15:52 | gibi | mdbooth: I run ~30 consecutive full nova functional tests with random test case order to reproduce the test failure but I failed | |
| 16:16:47 | gibi | mdbooth: so I think it is more likely a timing issue as the gate runs the test slower than I | |
| 16:16:51 | sean-k-mooney | stephenfin: brctl? | |
| 16:16:56 | stephenfin | yes | |
| 16:17:54 | sean-k-mooney | i was wondering whtat the context was | |
| 16:19:35 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add workaround to remove instance dir during cleanup with rbd https://review.openstack.org/618478 | |
| 16:20:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | |
| 16:27:03 | openstackgerrit | Merged openstack/os-vif stable/pike: ovs-hybrid: should permanently keep MAC entries https://review.openstack.org/505731 | |
| 16:28:12 | stephenfin | gibi: I know no one wants to see that patch, but the notification samples would be so much easier to grok if they were a consistently sorted 😅 (especially the common payloads) | |
| 16:29:15 | yan0s | yes I did restart it | |
| 16:29:22 | yan0s | nova-api-os-compute | |
| 16:29:28 | yan0s | nova-api-os-compute.service | |
| 16:31:04 | mriedem | yan0s: ok so it might have just been that you restarted the service that reloaded the policy file rather than needing to configure nova.conf | |
| 16:31:18 | mriedem | i thought we always dynamically read the policy file on each auth check | |
| 16:31:20 | mriedem | but i guess not | |
| 16:31:29 | mdbooth | gibi: Yeah, I *suspect* that it's just a canary. I think that create is taking close to the 5 second timeout, and when the gate is clogged its the first thing to get pushed over. | |
| 16:32:25 | cfriesen | sean-k-mooney: regarding https://review.openstack.org/#/c/620959/, I believe the traits are already defined as part of https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/report-cpu-features-as-traits.html | |
| 16:32:47 | mdbooth | gibi: Problem is I can't prove it. I spent time this morning looking at a profiler and I can see a couple of opportunities for making that test slightly faster, but if I guessed wrong it's just going to be merge ping-pong. | |
| 16:33:50 | mdbooth | gibi: The other thing, of course, would be to increase the timeout. | |
| 16:36:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ratio online data migration when load compute node https://review.openstack.org/613499 | |
| 16:36:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add compute_node ratio online data migration script https://review.openstack.org/609995 | |
| 16:36:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Note the aggregate allocation ratio restriction in scheduler docs https://review.openstack.org/620713 | |
| 16:36:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add docs for (initial) allocation ratio configuration https://review.openstack.org/622588 | |
| 16:36:48 | mriedem | dansmith: done ^ | |
| 16:39:06 | dansmith | mriedem: got 'em | |
| 16:39:15 | mriedem | thanks | |
| 16:39:25 | mriedem | approving the non-docs changes | |
| 16:40:02 | mdbooth | mriedem: What do you think would be acceptable criteria for re-proposing that patch, btw? | |
| 16:40:17 | mriedem | the racy test? | |
| 16:40:29 | dansmith | mriedem: I'll look at the following ones in a bit | |
| 16:40:37 | mriedem | dansmith: thanks | |
| 16:40:42 | mdbooth | mriedem: Yeah. | |
| 16:40:47 | mriedem | mdbooth: idk, maybe not using mocks/stubs on the libvirt driver in functional tests? | |
| 16:41:00 | mriedem | like i said, might be better to subclass the libvirt driver and override what you need | |
| 16:41:04 | mdbooth | mriedem: I suspect the *race* is against a slow test worker. | |
| 16:41:19 | mdbooth | I can't see any evidence of an ordering thing. | |
| 16:41:24 | mriedem | could also add the REQUIRES_LOCKING = True variable, but i don't know if that will help anything | |
| 16:41:42 | mdbooth | Which isn't to say that it's not an ordering thing, but without being able to reproduce it we're really just trying stuff. | |
| 16:41:52 | mdbooth | So... when have we tried enough stuff? | |
| 16:41:58 | mriedem | just, doing file i/o and mocks and such in a functional test like that with a real driver - i'm not really surprised there were side effects | |
| 16:42:07 | mriedem | mdbooth: i can't answer that | |
| 16:42:16 | mdbooth | mriedem: Me neither :/ | |
| 16:42:57 | mdbooth | However, like I say I don't see any evidence of side effects, or globals, or anything like that. | |
| 16:43:23 | mdbooth | The failures look like it was just too slow to me. | |
| 16:43:30 | mdbooth | I can post performance improvements. | |
| 16:45:26 | efried | My boss just made me look at my remaining vacation time for the year. Turns out... I'm gone until January, starting this afternoon. melwitt mriedem Sundar edmondsw FYI. | |