| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-12-03 | |||
| 16:17:53 | cdent | so it would definitely need to be a prioer to this one, if you're feeling inclined | |
| 16:18:24 | mriedem | but the placement fixture (rest api) continues to work, right? but it gets the fixture from placement. | |
| 16:19:27 | cdent | yes, but that fixture is only available to functional tests, not unit | |
| 16:19:43 | cdent | (because only the functional tox jobs import placement master) | |
| 16:20:01 | cdent | this seemed a good safeguard to insure that unit tests are unit tests | |
| 16:20:11 | cdent | and is part of why this test ran into issues | |
| 16:21:03 | mriedem | ok in that case i guess (a) is best for now, unless we just drop the check altogether as i think we sort of flirted with last week | |
| 16:21:59 | cdent | roger that, I'll carry on, thanks | |
| 16:26:41 | mriedem | ok, i'm going to dump some words into the ML | |
| 16:42:04 | edleafe | Must have been a big dump | |
| 16:43:38 | dansmith | I call BS on the 5lb number | |
| 16:43:38 | dansmith | https://www.healthline.com/health/do-you-lose-weight-when-you-poop | |
| 16:45:21 | artom | I think BS (from bulls!) is definitely more than 5 lbs. | |
| 16:45:48 | dansmith | probably, but mriedem is decidedly smaller than a bull | |
| 16:46:47 | bauzas | are we discussing how our body filters and weights stuff ? | |
| 16:47:30 | mriedem | i'm going to take the high road here | |
| 16:47:35 | mriedem | just this once | |
| 16:48:59 | artom | My son blocked the toilet with his poop. Twice. He's not even 3 yet. | |
| 17:00:43 | mriedem | i've seen that from a kid once, at my gf's house in high school, her nephew birthed a loaf of bread i swear, it was amazing | |
| 17:00:57 | cdent | so much for the high road | |
| 17:01:04 | mriedem | you can thank artom | |
| 17:01:07 | mriedem | he brings out the worst in me | |
| 17:01:20 | cdent | yeah, he just gently laid that in there, and the house came down | |
| 17:04:32 | dansmith | artom: that's quite an, um, honor | |
| 17:08:06 | artom | I did to this channel what my son did to the toilet | |
| 17:08:20 | artom | I am... this channel's poop? Dammit >_< | |
| 17:08:39 | dansmith | we can't even see the high road from here | |
| 17:10:30 | artom | Yeah, but pot's legal in Canada now, so if I ever need to get to the high road, I'm all set | |
| 17:10:53 | artom | Which is why I can afford these shenanigans | |
| 17:22:03 | openstackgerrit | Jack Ding proposed openstack/nova master: [WIP] Preserve UEFI NVRAM variable store https://review.openstack.org/621646 | |
| 17:22:16 | dansmith | artom: when are you thinking you'll have numa-aware-live-migration patches up/refreshed for looking? | |
| 17:32:30 | openstackgerrit | Merged openstack/nova master: Fix sloppy initialization of the new disk ops semaphore. https://review.openstack.org/621346 | |
| 17:32:47 | jaypipes | sean-k-mooney: I think we need mdulko's response on your ML thread. | |
| 17:34:44 | artom | dansmith, it's in my tasks for this downstream sprint | |
| 17:34:53 | artom | So I'm not sure how much I'll get done, but at least 1 | |
| 17:36:06 | artom | dansmith, I'm not really expecting it to land by our downstream deadlines. But if I can get it in upstream in Stein, and make it tech preview for OSP15, I'd consider that a win | |
| 17:36:54 | dansmith | artom: okay, in the upstream channel I'm really only asking about things that matter to upstream :) | |
| 17:37:09 | sean-k-mooney | jaypipes: is there a responce to the os-vif one or is it another one? | |
| 17:37:14 | dansmith | just wondering if there will be meat to review this year or not, as it doesn't seem like there's much up right now | |
| 17:37:29 | artom | dansmith, I know, but was giving you context | |
| 17:37:55 | dansmith | alright | |
| 17:38:03 | artom | dansmith, maybe not a full 15 oz steak, but like, a chicken cutlet? | |
| 17:39:42 | jaypipes | sean-k-mooney: no, I mean you are asking for kuryr-kubernetes folks to respond to your questions in your ML thread and I'm saying I'll wait to hear from them until I weigh in. | |
| 17:39:57 | sean-k-mooney | jaypipes: ah ok | |
| 17:40:54 | sean-k-mooney | ya ill proably jump into there irc tommorw and flag it to them | |
| 17:54:08 | mriedem | so we're not trying hard to get numa-aware live migration done in stein upstream, got it | |
| 17:58:12 | efried | jaypipes: I redid the three patches starting at https://review.openstack.org/#/c/620711/ per your comments. Gate failures are spurious, rechecking. tssurya confirmed they've been running with this code in their env and it's performing as expected. | |
| 17:58:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for bug 1806064 https://review.openstack.org/621664 | |
| 17:58:19 | openstack | bug 1806064 in OpenStack Compute (nova) rocky "Volume remains in attaching/reserved status, if the instance is deleted after TooManyInstances exception in nova-conductor" [Medium,Triaged] https://launchpad.net/bugs/1806064 | |
| 17:58:19 | sean-k-mooney | mriedem: it will likely be hard to get it runway ready and reviewd before jan 10, it likely can be dont before upstream feature freeze but it likely will be non trival to review | |
| 17:58:20 | mriedem | s10: melwitt: ^ | |
| 17:58:45 | cfriesen | artom: we'll happily try to break any patches you come up with. :) | |
| 17:58:54 | mriedem | sean-k-mooney: feature freeze is not jan 10 | |
| 17:59:29 | mriedem | FF is march 7 | |
| 18:00:29 | sean-k-mooney | oh i taught it was mid febuary but i guess im mixing that up with non-client libs | |
| 18:01:09 | tssurya | efried: we will try to put up a blog post soon with the plots and perf-improvement | |
| 18:01:35 | efried | tssurya: That would be awesome, my boss was just asking me if such a thing was available. | |
| 18:01:41 | mriedem | tssurya: are there plans to test that out with the ironic computes? | |
| 18:01:45 | mriedem | so those can be upgraded? | |
| 18:02:08 | mriedem | you had to downgrade ironic computes to queens right? | |
| 18:02:14 | tssurya | mriedem: yea we are working on the ironic driver and for sure will have it upgraded asap | |
| 18:02:27 | tssurya | mriedem: yea the prod is still in queens for ironic compute | |
| 18:02:59 | mriedem | efried: do i smell pbc results? | |
| 18:03:06 | mriedem | er, | |
| 18:03:06 | artom | cfriesen, please do | |
| 18:03:08 | mriedem | checkpoint results | |
| 18:03:16 | tssurya | efried: will let you know as soon as we post one :) we have a huge reduction in requests per min from 120K to 10K | |
| 18:03:26 | efried | mriedem: Yeah, we call it checkpoint these days. | |
| 18:03:33 | artom | mriedem, I *do* bring out the worst in you ;) | |
| 18:07:02 | openstackgerrit | Chris Dent proposed openstack/nova master: Use external placement in functional tests https://review.openstack.org/617941 | |
| 18:07:02 | openstackgerrit | Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215 | |
| 18:40:57 | jaypipes | efried: tssurya also confirmed they're not using it for Ironic. :) | |
| 18:41:37 | jaypipes | efried: or are you just referring to *some* of those patches and not the one that could be trouble for Ironic installs? | |
| 18:42:21 | efried | jaypipes: I fixed the one we were concerned about for ironic as well. But yeah, it would be nice if we could get results from CERN playing with it live. | |
| 19:12:16 | dansmith | mriedem: questions in https://review.openstack.org/#/c/393930/4 | |
| 19:14:19 | dansmith | well, a question and a suggestive comment I guess | |
| 19:20:42 | jaypipes | jangutter: I support sean-k-mooney's suggestions about renaming VIFBase to VIF. | |
| 19:21:03 | jaypipes | jangutter: in the context of our planned changes to the 2.0 os-vif modeling. | |
| 19:22:36 | sean-k-mooney | jaypipes: at the end of the day it will have very little differnece from a code point of view but as a new person looking at it nameing is important and "base" implys meaning that we dont enforce which might confuse people | |
| 19:22:52 | jaypipes | ++ | |
| 19:23:25 | sean-k-mooney | it was never something that annoyed me enough to "fix" but if we are cleaning up things we might as well clean that up too | |
| 19:23:38 | jaypipes | right, my thoughts exactly. | |
| 19:25:06 | sean-k-mooney | that is a change that will break kuryr but again they should not have been inheriting form VIFBase anyway. we can use debtcollector to not break them untill i port over there vifs. | |
| 19:25:32 | sean-k-mooney | i wont get to it for a few weeks but i should get to it i january | |
| 19:28:32 | mriedem | dansmith: replied | |
| 19:29:33 | jaypipes | sean-k-mooney: well, again, kuryr should be pinning to a *specific* os-vif library release, so we should be safe to make these changes, along as they don't up their pinned release. same for nova, frankly. | |
| 19:32:39 | sean-k-mooney | ture but we have a kuryr ci job that will bitch since it runs against os-vif master | |
| 19:33:04 | sean-k-mooney | same as or nova job that test stuff before we merge it | |
| 19:33:39 | jaypipes | sean-k-mooney: that's fine (and works as expected, yeah?) | |
| 19:35:03 | sean-k-mooney | they are there to catch non backwards compatible changes so yes it works as expected but i just ment unless we make the change in a backward compatible way the zuul job will fail | |
| 19:36:41 | dansmith | mriedem: yeah I forgot about the distinction of the before-virt and after-virt nature of the two places we stash that stuff | |
| 19:36:48 | sean-k-mooney | e.g. if we renamed VIFBase to vif without the compaiblity code or removing the use of VIFbase in kuryer the kuryr-kubernetes-tempest-daemon-octavia would fail and stop use merging it in os-vif | |
| 19:37:30 | dansmith | mriedem: note that pulling it from an api node via instance_extra is the same number of hits to the db as just doing an query for all the virtual_interfaces for the instance presumptively, since the api is hitting the db directly | |
| 19:42:11 | openstackgerrit | David Hill proposed openstack/nova master: Add secret=true to fixed_key configuration parameter https://review.openstack.org/621684 | |
| 19:47:28 | mriedem | since john hopkins isn't around anymore, | |
| 19:47:38 | mriedem | i wonder who would care enough to unwind all of this deprecated code we have to remove it https://review.openstack.org/#/c/621684/1/nova/conf/key_manager.py | |
| 19:48:01 | mriedem | now that barbican is a required service or whatever the TC calls it | |
| 19:48:16 | mriedem | cdent: what is the latest opinion on barbican being required and co-gating? | |
| 19:48:24 | mriedem | base devstack still doesn't install barbican as far as i know | |
| 19:48:55 | mriedem | although not sure we'd need barbican anyway since i think in the gate we'd just use a fake key manager from castellan | |