| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-11-29 | |||
| 09:53:26 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix misuse of assertTrue https://review.openstack.org/620861 | |
| 10:08:39 | openstackgerrit | Merged openstack/nova master: Remove get_node_uuid https://review.openstack.org/620715 | |
| 10:10:08 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Refactor handling of PCIe root ports https://review.openstack.org/620327 | |
| 10:14:45 | openstackgerrit | Alex Xu proposed openstack/nova master: Parse the numa topology from the new flavor when resize instance https://review.openstack.org/620874 | |
| 10:42:47 | mdbooth | bauzas: I need placement to think my compute has more than 2 vcpus in my functional test. Any idea what the best thing to mock would be? | |
| 10:57:44 | mdbooth | bauzas: When you're back, I think I'll be best mocking LibvirtDriver.get_available_resource() | |
| 11:07:28 | bauzas | mdbooth: well, no | |
| 11:07:38 | bauzas | mdbooth: we now have a new method | |
| 11:08:56 | bauzas | mdbooth: but do you need libvirt ? because we have a FakeDriver | |
| 11:10:50 | bauzas | mdbooth: https://github.com/openstack/nova/blob/master/nova/virt/fake.py | |
| 11:11:07 | bauzas | eg. https://github.com/openstack/nova/blob/master/nova/virt/fake.py#L138 | |
| 11:32:59 | openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/queens: Make the nova-next job voting and gating https://review.openstack.org/620888 | |
| 12:10:31 | mdbooth | bauzas: No, I'm specifically testing the LibvirtDriver | |
| 12:10:38 | mdbooth | I *think* I've nearly got it | |
| 12:10:42 | mdbooth | Although.... | |
| 12:11:13 | mdbooth | AAAAAAAAAAAAAAAAAAARGH! methods which secretly modify shared data! | |
| 12:12:23 | sean-k-mooney | mdbooth: dose the method also retrun something? | |
| 12:13:01 | sean-k-mooney | if it just has sideffect its not terrible but if it both retruns things and has sideffect that is a pain | |
| 12:17:58 | mdbooth | bauzas: Sorted now. mocked libvirt methods for fetching disk space, vcpu, and memory, which are used in both places. | |
| 12:24:05 | cdent | mdbooth: tshirt | |
| 12:25:44 | mdbooth | cdent: Hehe | |
| 12:28:06 | mdbooth | cdent: This case wasn't egregious, tbh. LibvirtDriver._get_local_gb_info modified the return from libvirt_utils.get_fs_info() in place, which isn't unreasonable. However, I was mocking get_fs_info(), so it was always returning the same dict. It took me over an hour to work out why my disk space got 1000 times smaller every time it was called. | |
| 12:28:44 | cdent | <- doesn't know haskell | |
| 12:28:47 | mdbooth | FTW! | |
| 12:28:54 | mdbooth | <- neither | |
| 12:29:14 | cdent | of course the number of times I've heard people say that the original authors of nova didn't know python is unfortunately high | |
| 12:29:30 | mdbooth | HAHA | |
| 12:29:31 | cdent | so, you know, maybe it is a goer | |
| 12:30:15 | sean-k-mooney | i didnt know python when i started working on openstck not sure i still dont | |
| 12:31:07 | sean-k-mooney | python is a language that you can pick up as you go along and with the gated trunk/review model we use you learn what you need quickly | |
| 12:31:08 | cdent | yeah, that's the other side of the coin: if you can code, you can usally code anywhere, if you pay attention | |
| 12:31:52 | sean-k-mooney | yep once you lear to corralate different concpets in different languages and how to reason about problems that applies across many languages | |
| 12:32:22 | sean-k-mooney | functional programing people however i have found think differnetly then i do | |
| 12:33:37 | mdbooth | sean-k-mooney: It's a mental switch. It's not as hard to make as you'd think. | |
| 12:34:41 | sean-k-mooney | mdbooth: ya i have tried learning some functional libs in the past and i can use them but its still a style that i reserve for specific uses | |
| 12:34:56 | cdent | there are degrees as well. you can sort of pick and choose what you think matters most. for example: don't be side-effecty | |
| 12:35:21 | mdbooth | That's a general lesson | |
| 12:35:22 | cdent | for collaborative code maintenance I think that one is the most important | |
| 12:35:32 | cdent | a lesson people apparently don't learn often enough :) | |
| 12:36:07 | kashyap | cdent: What makes you think all the current contributors (/looks at self) "know" Python? :D | |
| 12:36:09 | cdent | If you're steeped in a certainly style of OO, it's too normal, even though it doesn't have to be | |
| 12:36:25 | cdent | kashyap: I was trying to be polite, please don't out me :) | |
| 12:36:46 | kashyap | Hehe, before I "out" anyone, /me goes to work on his own limitations | |
| 12:36:57 | sean-k-mooney | cdent: speaking of side effects this will reintoduce the placemetn wsgi isssue the run_once decorator was trying to avoid | |
| 12:36:58 | sean-k-mooney | https://review.openstack.org/#/c/620617/3/placement/db_api.py | |
| 12:37:19 | cdent | that's been abandoned | |
| 12:37:25 | sean-k-mooney | ya i just noticed | |
| 12:37:37 | cdent | in part because of exactly that | |
| 12:38:08 | sean-k-mooney | so is the issue fixed by the way? | |
| 12:40:16 | cdent | it's either fixed, or so out of the timing as to appear to be fixed. I got 77 successful runs last night | |
| 12:41:27 | sean-k-mooney | cool so just diffing the change ye stoped using a global config fixture | |
| 12:42:20 | cdent | sean-k-mooney: that helped, but the crux of the biscuit was probably moving something from init in the Database fixture to setUp | |
| 12:42:37 | cdent | which was probably wrong from the start, but didn't rear its head until mixing with nova | |
| 12:42:45 | cdent | jaypipes++ on the container shinkerage | |
| 12:43:23 | cdent | I think you've nailed it with "lightweight vms in disguise" | |
| 12:43:27 | sean-k-mooney | cdent: ah ok. ya this is proably raising it head due to the use of eventlets in nova | |
| 12:43:56 | kashyap | cdent: Where was that comment from Jay? | |
| 12:44:10 | sean-k-mooney | i just recived it in my email | |
| 12:44:14 | cdent | the removal of global config is still a huge win, sean-k-mooney, so I'm hoping we can keep and merge that soon | |
| 12:44:25 | sean-k-mooney | cdent is a few minuts ahead of us it seams | |
| 12:44:33 | cdent | http://lists.openstack.org/pipermail/openstack-discuss/2018-November/000338.html | |
| 12:44:49 | cdent | I subscribed to openstack-discuss very early so probably my messages a few seconds before others :) | |
| 12:46:28 | kashyap | Also all the mailing lists are being merged, aren't they? | |
| 12:46:59 | cdent | yeah, openstack-discuss is the one true mailing list now | |
| 12:47:27 | cdent | until early next week the others are still around and include the new one in what they send to | |
| 12:47:37 | cdent | but next week the old ones will stop accepting submissions | |
| 12:47:45 | cdent | but the archives will remain | |
| 12:48:37 | kashyap | (Thx) | |
| 12:48:52 | kashyap | cdent: What's the rationale for merging all of them, and making it into a one Jupiter-sized firehose? | |
| 12:49:23 | cdent | yeah probably better to read the related discussion. there are many reasons | |
| 12:49:35 | cdent | some better than others | |
| 12:50:48 | kashyap | Thanks | |
| 12:51:33 | cdent | the overriding reason is to break down some of the artificial boundaries between devs, users, ops, I touch upon that in https://anticdent.org/mailing-list-review.html | |
| 12:52:41 | kashyap | Yeah, but it also requires people to massively "up their game" of managing emails. | |
| 12:53:16 | cdent | Yes, that was one of the arguments that people made, but the conclusions appeared to be: you need to do that anyway for any of the lists | |
| 12:53:25 | cdent | which seemed a bit weak to me, but meh | |
| 12:53:55 | kashyap | cdent: If only more people realized (not just in our community; but inside company lists, too) this: | |
| 12:53:58 | kashyap | [quote] | |
| 12:53:59 | kashyap | [/quote] | |
| 12:54:01 | kashyap | Your main goal as a member of a mailing list is to keep the archive as useful as possible for other members of the community. Do that, and the dynamic activity on the list itself also manages to be useful. | |
| 12:55:08 | cdent | we've found several time, kashyap, that you and I have very similar attitudes towards community collaboration... | |
| 12:55:12 | sean-k-mooney | kashyap: none does that to the openstack list right | |
| 12:55:44 | kashyap | sean-k-mooney: Yeah, true. But it is also due to not doing enough due diligence about how to work in an open source community. | |
| 12:56:22 | kashyap | cdent: Probably it's just that I got exposed to old-school mailing list approach, being at RHT for 10 years I guess :-) | |
| 12:56:50 | sean-k-mooney | i kind of whish they had just made the mailing list openstack instead of openstack-discuss. i always coralate discuss mailing list with purly enduser support | |
| 12:56:55 | kashyap | sean-k-mooney: Err, what I meant was -- no one does that on the list, but there's a _crap_ load of "meeting invites" and related junk | |
| 12:57:12 | kashyap | Post the minutes, but not frequent reminders about invites and what-not. | |
| 12:57:33 | kashyap | sean-k-mooney: That is true, on the naming; 'qemu-discuss' is a user-focused list. | |
| 12:57:33 | sean-k-mooney | kashyap: i had an auto delete filter for meting invites | |
| 12:57:34 | cdent | sean-k-mooney: that was discussed too, but that list already exists, and the hope was by creating a new one to remove a lot of dead addresses | |
| 12:57:42 | kashyap | sean-k-mooney: Heh, thanks for the idea | |
| 12:58:45 | sean-k-mooney | cdent: ya i assumed that was the reason still i would be intally much less incliend to join it as a dev | |
| 12:59:24 | cdent | which gets to one of the other reasons: stop people thinking that way | |
| 12:59:26 | sean-k-mooney | its not an issue because i know its going to be the only opstack mailing list but otherwise i would ignore it | |
| 13:00:55 | sean-k-mooney | cdent: i dont think discuss is something we should have been trying to reclaim for all discussions about a project but that ship has sailed so ill hold my piece on that topic | |
| 13:01:55 | cdent | I've always wanted lots of small lists (and irc channels, and projects and everything else) but I lost that battle nearly 4 years ago, so I gave up on that front | |
| 13:02:40 | kashyap | Lots of small lists work for people with effective email workflows. And are disciplined enough to manage them properly. Which is quite a high bar. | |
| 13:03:09 | cdent | yes. | |
| 13:03:25 | sean-k-mooney | cdent: i dont mind the merger of the list as i will just use email filter to break it up but i would prefer if all email had [*] subjust tags in them | |
| 13:05:19 | sean-k-mooney | e.g. if its ment for all add [all] | |