Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-11-28
16:32:59 artom (Which reminds me, it means we need to do claims on the dest)
16:33:02 artom (And cleanup)
16:33:14 mriedem reminds you? the spec already says the claims happen on the dest
16:33:17 mriedem they have to happen on the dest
16:33:26 dansmith the spec should probably have the old/new src/dst truth table in it if it doesn't already
16:33:32 artom I mean, in the code
16:33:32 mriedem ++ on that
16:33:44 artom Any of the new stuff we do needs to be in code that runs on the dest
16:33:44 mriedem artom: i'm not sure what you're saying
16:33:50 mriedem yes the claim needs to happen on the dest
16:33:52 mriedem like the spec says :)
16:34:03 artom Does it? I thought I left it at "implementation detail"
16:34:07 mriedem oy
16:34:15 mriedem "Any of the new stuff we do needs to be in code that runs on the dest" is also not accurate
16:34:26 jaypipes Sundar: ty sir!
16:34:29 artom Well, yeah
16:34:30 mriedem obviously there will be new code on the source to generate the xml, using data from the dest, to send the xml to the dest
16:34:42 artom Creating claims and cleaning them
16:34:45 artom Has to be done on the dest
16:34:48 bauzas I'm fine with leaving details for the implementation
16:35:02 bauzas I just want to make sure we all agree on the behaviour for upgrades
16:35:03 mriedem create yes, i'm not entirely sure about clean (drop_move_claim), but sure
16:35:36 bauzas which is, whatever we write, in case a live migration happens from a Rocky node to a Stein node, we will just blindly accept the migration and not do the claim
16:35:40 mriedem as noted in my review comments, rollback doesn't always cleanup on the dest
16:35:43 mriedem today anyway
16:35:44 bauzas artom: ^
16:35:55 dansmith bauzas: I thought you dropped poop and left?
16:36:07 dansmith I must have misunderstood :)
16:36:09 artom OK, I think I need to go back to the spec after a bit of thinking
16:36:19 artom dansmith, he's relishing his poop
16:36:22 bauzas dansmith: hah, I just feel I need to discuss a bit more
16:36:38 mriedem artom: probably easiest to just start with a mixed compute upgrade table or something,
16:37:00 mriedem with (1) old source, old dest - what happens? (2) old source, new dest, what happens, (3) new source, old dest, (4) new source, new dest
16:37:09 dansmith a truth table, like I said
16:37:10 bauzas +1
16:37:19 artom Yeah, sounds like a good idea
16:37:20 bauzas the rest can be left for implementation
16:37:46 bauzas anyway, I'm just flushing my stuff now
16:37:53 bauzas see ya
16:38:19 mriedem if we do that, i'm not entirely sure how much we need https://review.openstack.org/#/c/611088/ now
16:39:24 artom mriedem, you're assuming the NUMA live migration code lands in Stein :)
16:39:35 artom I know I'm an all-star, but common
16:41:32 artom Pheeding first though, I'm phamished
16:41:52 cdent does first come before or after phirst?
16:42:10 artom Aww man, I missed the "phirst" opportunity :(
16:42:35 artom Phirst the thirts, than the phamine
16:42:39 artom *thirst
17:13:00 openstackgerrit Eric Fried proposed openstack/nova master: Rip the report client out of SchedulerClient https://review.openstack.org/617042
17:13:01 openstackgerrit Eric Fried proposed openstack/nova master: Rip out the SchedulerClient https://review.openstack.org/617049
17:14:20 mriedem cdent: i think https://bugs.launchpad.net/nova/+bug/1805408 might be a duplicate, see inline
17:14:20 openstack Launchpad bug 1805408 in OpenStack Compute (nova) "ServerGroupTestV21.test_boot_servers_with_anti_affinity and related tests can race" [Undecided,New]
17:22:49 cdent mriedem: yeah, I think you're right. It just shows up somewhat differently in the context of the placement extraction, but i think that's just noise
17:22:50 cdent i've marked it
17:29:01 mriedem so i'm pretty sure we've said we can't change 404s to be 400s just because it's a better fit without a microversion, right?
17:29:42 cdent mriedem: generally true, but fudging is often exercised
17:30:15 cdent the fear is someone branching on the status code, which you can easily imagine in that particular case
17:30:37 mriedem yeah, this seems pretty obvious what i'm looking at,
17:30:49 mriedem trying to disable a non-nova-compute service results in HostMappingNotFound which results in a 404
17:30:59 mriedem you can't disable non-nova-compute services, so really it's a bad request
17:31:19 mriedem i want to provide a better error message than 'host mapping not found' since that's not the problem really
17:31:29 mriedem but also wondering if i should change the response code at the same time to be a 400
17:31:59 cdent it should only ever be a 404 if the actual URL is a 404, not something within
17:32:06 cdent so yeah, this sounds kind of 400 ish
17:36:13 dansmith wait, what?
17:36:25 mriedem https://bugs.launchpad.net/nova/+bug/1805164
17:36:25 openstack Launchpad bug 1805164 in OpenStack Compute (nova) rocky "Confusing error message when trying to disable non-nova-compute service" [Low,Triaged]
17:36:36 dansmith disabling a non-compute service is still a 404 right? since the url to a non-compute service wouldn't exist?
17:37:04 mriedem the service id isn't in the URL for older microversoins
17:37:18 mriedem e.g. PUT /os-services/disable
17:37:23 mriedem the host/binary is in the body
17:37:41 dansmith ah yeah, was just pulling up the ref
17:37:45 dansmith yeah, okay
17:37:48 mriedem and anyway, we return 400 if you try doing PUT /os-services/{service_id} with a non-compute service with microversion >= 2.53
17:37:54 mriedem so this would be consistent with that
17:38:40 dansmith yn
17:38:44 dansmith um
17:38:50 dansmith can you GET the service by id?
17:38:55 dansmith for non-computes?
17:39:21 dansmith api-ref doesn't show that you can, but I wonder if it's a missing doc
17:39:22 mriedem you can GET /os-services
17:39:28 mriedem not a specific service
17:39:35 dansmith but you can PUT it?
17:39:35 dansmith weird
17:40:06 mriedem there was lots of weird to be dealt with in https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/service-hyper-uuid-in-api.html
17:40:07 dansmith point being PUT /os-services/id where id is not a compute is kinda 404ish right? if you can't update non-compute services?
17:40:36 dansmith if you can't GET them it's hard to say either way
17:40:42 mriedem shrug
17:40:53 mriedem you can definitely GET them via list, but not directly via show right
17:41:00 dansmith yeah I mean get by id
17:54:30 mriedem here it comes
17:54:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Provide a useful error message when trying to update non-compute services https://review.openstack.org/620667
17:54:34 mriedem for all your ridicule
17:57:08 dansmith mriedem: I commented on the rebuild spec.. I can fix my own nits but had a legit question
17:57:18 dansmith if you can answer I'll fix my nits and approve
17:59:52 mriedem melwitt: i've triaged at least 2 more bugs about the rocky install guide missing the mention of installing nova-consoleauth b/c it's still needed, i've duplicated them against https://bugs.launchpad.net/nova/+bug/1793255 but not sure what your plans were for putting some kind of note in the install guides about, "hey, you might still need to install nova-consoleauth, see the workaround option for details"
17:59:52 openstack Launchpad bug 1793255 in OpenStack Compute (nova) rocky "nova-consoleauth missing from Rocky install guide; unable to use VNC" [High,In progress] - Assigned to melanie witt (melwitt)
18:00:07 mriedem dansmith: before i look, let me guess: what do we do about running it through the scheduler?
18:00:15 dansmith no
18:05:36 mriedem dansmith: replies inline
18:10:15 dansmith mriedem: thanks, replied

Earlier   Later