| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-11-26 | |||
| 23:00:46 | mriedem | ok i think either would be ok | |
| 23:00:53 | openstackgerrit | Michael Still proposed openstack/nova master: Move bridge creation to privsep. https://review.openstack.org/620180 | |
| 23:01:00 | efried | but in all cases if CONF.cpu_allocation_ratio is set you want *that* value - i.e. ignore initial_* | |
| 23:01:05 | mriedem | well well well, look who it is | |
| 23:01:12 | efried | brb | |
| 23:01:14 | mriedem | efried: true yeah | |
| 23:01:17 | mriedem | ok i got your point now | |
| 23:04:02 | openstackgerrit | Merged openstack/nova stable/queens: Fix NoneType error in _notify_volume_usage_detach https://review.openstack.org/614868 | |
| 23:06:28 | efried | mriedem: I think we might strive to embed that logic in a base class helper somehow. | |
| 23:07:09 | efried | mriedem: to replace (and subsume) https://review.openstack.org/#/c/613126/4/nova/virt/driver.py@860 | |
| 23:08:19 | mriedem | yeah it would be nice to not duplicate it all over the place | |
| 23:12:09 | mriedem | alright with that i'm done | |
| 23:12:13 | mriedem | efried: thanks for the sound board | |
| 23:12:22 | efried | fo sho | |
| 23:12:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop cruft code for all_tenants behaviour https://review.openstack.org/620165 | |
| 23:42:19 | openstackgerrit | Eric Fried proposed openstack/nova master: Add missing ws seperator between words https://review.openstack.org/618491 | |
| #openstack-nova - 2018-11-27 | |||
| 00:35:14 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Give drop_move_claim() correct docstring https://review.openstack.org/620170 | |
| 01:01:05 | openstackgerrit | Vladyslav Drok proposed openstack/nova stable/pike: [pike-only] Fix resize_instance rpcapi call https://review.openstack.org/603439 | |
| 01:06:36 | openstackgerrit | Vladyslav Drok proposed openstack/nova stable/pike: [pike-only] Fix resize_instance rpcapi call https://review.openstack.org/603439 | |
| 05:48:41 | openstackgerrit | Merged openstack/nova master: Add missing ws seperator between words https://review.openstack.org/618491 | |
| 06:21:17 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove Placement API reference https://review.openstack.org/614437 | |
| 08:12:02 | openstackgerrit | Yikun Jiang proposed openstack/nova master: Change the default values of XXX_allocation_ratio https://review.openstack.org/602803 | |
| 09:41:31 | openstackgerrit | Chris Dent proposed openstack/nova master: Use external placement in functional tests https://review.openstack.org/617941 | |
| 09:41:31 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Delete the placement code https://review.openstack.org/618215 | |
| 10:25:30 | openstackgerrit | Chris Dent proposed openstack/nova master: Use external placement in functional tests https://review.openstack.org/617941 | |
| 10:25:30 | openstackgerrit | Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215 | |
| 10:29:36 | openstackgerrit | Brin Zhang proposed openstack/nova master: Remove useless sample and add the lack of tests in v266 https://review.openstack.org/614671 | |
| 11:52:03 | openstackgerrit | Merged openstack/nova stable/rocky: Make supports_direct_io work on 4096b sector size https://review.openstack.org/619251 | |
| 12:29:47 | openstackgerrit | Yikun Jiang proposed openstack/nova master: Change the default values of XXX_allocation_ratio https://review.openstack.org/602803 | |
| 12:29:48 | openstackgerrit | Yikun Jiang proposed openstack/nova master: Use new ``initial_xxx_allocation_ratio`` CONF https://review.openstack.org/602804 | |
| 13:12:53 | amab | I've changed the default console from vnc to spice, but I get the error is this link: https://paste.ubuntu.com/p/MF6mFQBJ88/ | |
| 13:53:32 | mnaser | https://review.openstack.org/#/c/619351/ stable/rocky fix merged, stable/queens up (sorry for my daily bugging alert :]) | |
| 14:24:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Default zero disk flavor to RULE_ADMIN_API in Stein https://review.openstack.org/603910 | |
| 14:28:00 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Refactor handling of PCIe root ports https://review.openstack.org/620327 | |
| 14:33:55 | dansmith | mriedem: http://logs.openstack.org/04/620104/1/check/neutron-grenade/832c98f/logs/grenade.sh.txt.gz#_2018-11-26_19_52_27_042 | |
| 14:33:59 | dansmith | mriedem: looks reasonable I think | |
| 14:35:35 | mriedem | so the placement api check failed as expected | |
| 14:36:08 | dansmith | yep, didn't explode and "unable to discover endpoint" is reasonably clear I think | |
| 14:49:04 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Refactor handling of PCIe root ports https://review.openstack.org/620327 | |
| 15:21:43 | mriedem | is mdbooth out? | |
| 15:22:06 | kashyap | mriedem: He's actually in; I was wondering why isn't he here too | |
| 15:22:26 | kashyap | mriedem: BTW, while I have your attention, are things like these useful? -- https://review.openstack.org/#/c/620327/ | |
| 15:22:59 | kashyap | The original code was hurting my head, so I _had_ to spin that code out into a separate function, and simplify the crap | |
| 15:23:11 | mdbooth | Weird, didn't get reconnected | |
| 15:23:18 | artom | kashyap, for what it's worth, I approve | |
| 15:23:33 | artom | That original 'if' is... evil | |
| 15:23:34 | kashyap | artom: Thanks, at least one other person finds it useful, then. | |
| 15:23:55 | kashyap | artom: Yeah, fucking awful. I was feeling stupid having to re-read it multiple times. | |
| 15:24:11 | artom | No, I'm staring at it now and my brain is complaining already | |
| 15:24:16 | kashyap | I held my nose, and cleaned up the excrements | |
| 15:24:17 | mdbooth | kashyap: What code's this? | |
| 15:24:35 | kashyap | mdbooth: Okay, now you're Cced :D it is this: https://review.openstack.org/#/c/620327/ | |
| 15:24:50 | kashyap | mdbooth: BTW, mriedem was pinging you for something else, perhaps. | |
| 15:24:50 | mriedem | mdbooth: fyi, some nits in https://review.openstack.org/#/c/591733/ which might be worth a follow up | |
| 15:25:11 | mdbooth | mriedem: Looking | |
| 15:25:21 | kashyap | artom: Since you did click, please go the next step and review. And if need be, complain if you need a test, etc | |
| 15:25:32 | artom | kashyap, yep, doing that now | |
| 15:25:37 | artom | (reviewing, not complainig) | |
| 15:25:48 | kashyap | Thanks! | |
| 15:26:00 | mdbooth | mriedem: Awesome, thanks! | |
| 15:26:52 | kashyap | artom: That TODO item | |
| 15:27:04 | kashyap | (Err hit send too soon) | |
| 15:27:10 | artom | I call that PCRS | |
| 15:27:17 | artom | Premature Carriage Return Syndrome | |
| 15:27:40 | kashyap | artom: ... is part of a larger work item that needs cleaning up of assumptions about machine types in Nova. And coordinating w/ relevant libvirt work | |
| 15:28:04 | kashyap | artom: Heh | |
| 15:38:03 | mriedem | mdbooth: what's the difference between the 'disk' and 'disk.local' entries in the block_device_info disk 'mapping' entry? | |
| 15:38:17 | mdbooth | mriedem: 'disk' is the root disk | |
| 15:38:33 | mdbooth | 'disk.local' is legacy, and no longer generated | |
| 15:38:53 | mdbooth | But it used to be the single ephemeral disk | |
| 15:38:54 | mriedem | unless... | |
| 15:39:06 | mdbooth | Now we have disk.eph0, disk.eph1, etc | |
| 15:39:11 | mriedem | if we have code for it, we must support it somehow... | |
| 15:39:18 | mriedem | is it for bdmv1? | |
| 15:39:27 | mriedem | or just really old bdm records in the db? | |
| 15:39:46 | mdbooth | It's a long time since I've checked the details on this, but I recall convincing myself in the past the current code can't generate this | |
| 15:39:49 | mdbooth | Yeah, it's old BDM records | |
| 16:10:02 | mriedem | mdbooth: comments inline https://review.openstack.org/#/c/578846/ | |
| 16:14:34 | mriedem | dansmith: efried: mdbooth: i'd like to move forward with getting this evacuate-related bug fixed https://review.openstack.org/#/c/606122/ - i think the open question was do we use dansmith's more generic solution https://review.openstack.org/#/c/575190/ or keep my "tactical" fix for backports and then rebase dan's on top to replace my specific fix with the generic one | |
| 16:15:11 | mriedem | because that's holding up getting us to do evacuate testing with both rbd and lvm backends https://review.openstack.org/#/c/604400/ | |
| 16:18:36 | dansmith | mriedem: if you'll do the rebase of mine and cleanup of this spot after we merge yours that's fine | |
| 16:18:49 | dansmith | I would backport my generic solution too, but if you don't want to that's fine | |
| 16:20:32 | mdbooth | mriedem: ^^^ wfm. | |
| 16:23:04 | mriedem | dansmith: ack will do | |
| 16:29:17 | efried | I'll need to reread everything to refresh my memory of what's going on here. | |
| 16:33:38 | efried | so wait, which are we doing? just dan's thing, master & backports; or matt's thing for backports and dan's thing for master? | |
| 16:35:06 | dansmith | we're doing whichever of those mriedem wants | |
| 16:35:14 | dansmith | which I think is the latter | |
| 16:35:21 | mriedem | the latter | |
| 16:36:15 | efried | okay, so my job is to +2 mriedem's patch (done) and then wait for mdbooth to be satisfied with dansmith's patch before reviewing it. | |
| 16:37:18 | dansmith | efried: I think the -1 on mine isn't actually a thing | |
| 16:39:04 | efried | yeah, but I'm drowning, so looking for any excuse to defer | |
| 16:41:31 | mdbooth | dansmith: It's not a thing? | |
| 16:41:39 | dansmith | mdbooth: the security groups thing? | |
| 16:42:27 | mdbooth | dansmith: Yeah. IIRC I would have been happy with a command saying: # We broke this, but we don't care because it's not a thing any more. | |
| 16:42:38 | mdbooth | s/comment | |
| 16:43:10 | dansmith | I don't understand why it's a thing at all anyway.. if the instance is deleted, we're not going to do anything with the security groups we do fetch out of the db (if there are any anyway), | |
| 16:43:21 | dansmith | and, in any case where we did load the instance with a deleted=yes context, | |
| 16:43:24 | dansmith | we'd have gotten the same | |
| 16:44:55 | dansmith | so the only case where we'd do something different is where we had an instance, which wasn't deleted when we started, but was deleted underneath us and we go to lazy-load security groups.. if we were to go on and save that instance later, it'd fail and I can't think of anything else we'd do with it that would trigger some different behavior than we have now | |