| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-11-19 | |||
| 17:26:35 | jaypipes | sean-k-mooney: I just finished up with jangutter's spec on os-vif object model changes. adding some comments to the cyborg spec now... | |
| 17:26:47 | sean-k-mooney | my understanding is that the instance will not be the consumer of the devices in placement and since they are not attach to the nova instance nova should not care | |
| 17:27:05 | cdent | efried: we (you?) need to come up with a plan for replacing the tests that use rp_object as added in https://review.openstack.org/#/c/560444/ | |
| 17:27:16 | sean-k-mooney | jaypipes: oh ya i need to go back to that one | |
| 17:28:23 | sean-k-mooney | jaypipes: am one point i made on the code which is not in the spec is we should not use the term datapath offlod since the representor netdev is actull part of the control plane. | |
| 17:30:47 | jaypipes | sean-k-mooney: I said on the spec that I think "OffloadBase" is fine and removing "Datapath" would be good. | |
| 17:31:55 | sean-k-mooney | i realise when i clicked the link i have only looked at the code for this so im currently readign the spec for the first tiem | |
| 17:35:01 | sean-k-mooney | jaypipes: if you have not seen it can you reivew this comment on the code to see if you agree https://review.openstack.org/#/c/572081/9/os_vif/objects/vif.py@376 i will see how that relates to the spec | |
| 17:41:20 | efried | cdent: That should be easy peasy. Did you want me to do that in nova, placement, or both? | |
| 17:41:34 | cdent | efried: it only exists in nova | |
| 17:41:40 | efried | stand by. | |
| 17:44:29 | openstackgerrit | Merged openstack/nova stable/rocky: Handle unicode characters in migration params https://review.openstack.org/618734 | |
| 17:51:34 | openstackgerrit | Eric Fried proposed openstack/nova master: Nix refs to ResourceProvider obj from libvirt UT https://review.openstack.org/618786 | |
| 17:51:35 | efried | cdent: There ya go ^ | |
| 17:51:41 | cdent | rad | |
| 17:52:16 | cdent | thanks | |
| 17:52:21 | efried | There's more refactoring that could be done there, but this is roughly the easiest. | |
| 17:52:25 | efried | without being too hacky | |
| 17:54:02 | efried | cdent: BTW, pretty sure the origin of the test code was bhagyashris. This doesn't look like my style at all. | |
| 17:54:34 | cdent | efried: noted. I just went by git blame when raising the "alarm`' | |
| 17:54:47 | efried | yup, and she's not around atm anyway. Easy enough fix. | |
| 18:01:04 | efried | jaypipes, mriedem, bauzas: ----^ easy one | |
| 18:07:35 | openstackgerrit | Chris Dent proposed openstack/nova master: Use external placement in functional tests https://review.openstack.org/617941 | |
| 18:07:36 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Delete the placement code https://review.openstack.org/618215 | |
| 18:08:51 | cdent | feh, that's not going to work after a merge | |
| 18:48:54 | larsks | Hey folks. Should disk-related instance resource quotas (such as quota:disk_write_bytes_sec) be applied when booting from a volume? | |
| 19:21:53 | cfriesen | larsks: I think it's supposed to be applied, at least for libvirt/qemu. | |
| 19:26:59 | sean-k-mooney | cfriesen: yes it is but i just tested with devstack and it does not work on master | |
| 19:27:43 | sean-k-mooney | cfriesen: larsks moved to public pastbin http://paste.openstack.org/show/735692/ | |
| 19:28:33 | sean-k-mooney | im link 95% sure this used to work | |
| 19:28:36 | cfriesen | sean-k-mooney: I think it's "quota:write_bytes_sec" | |
| 19:29:05 | cfriesen | no, that webpage was wrong | |
| 19:29:12 | sean-k-mooney | quota:disk_write_bytes_sec is what horizon set | |
| 19:30:16 | sean-k-mooney | ill set all the limits and see what hapes perhaps its just that one. i think this works with the ceph backend but maybe for boot form volume you have to use cinder qos | |
| 19:34:20 | sean-k-mooney | cfriesen: larsks nope still ignored http://paste.openstack.org/show/735693/ | |
| 19:40:09 | openstackgerrit | Jack Ding proposed openstack/nova master: Add HPET timer support for x86 guests https://review.openstack.org/605902 | |
| 19:46:08 | larsks | cfriesen: thanks, and sean-k-mooney thanks for checking. What I'm curious about is whether or not that is expected behavior... | |
| 19:46:17 | larsks | I.e., should I open a bug for this? | |
| 19:46:25 | sean-k-mooney | larsks: it is expect to work and yes | |
| 19:46:38 | larsks | Ack, I'll do that right now, then. | |
| 19:47:02 | sean-k-mooney | but we also advise peole not to use falvor qouta any more even though we have not deprecated them offically | |
| 19:47:24 | larsks | Oh, that's news. Why is that? | |
| 19:47:49 | sean-k-mooney | because cinder and neutron both have there own qos apis which are richer and better tested | |
| 19:48:38 | larsks | Okay. Being able to associate a collection disk/network/etc quotas with a flavor is very convenient. | |
| 19:49:04 | larsks | But I can see that having these resource quotas managed in different places could lead to confusion and duplication of effort. | |
| 19:49:09 | sean-k-mooney | it is but its legacy functionality that was supperseed by qos apis in the services | |
| 19:49:36 | sean-k-mooney | that daid if you are not using cinder or neutron an want that fuctionality the falvor were the only way to do it | |
| 19:49:45 | larsks | Fair enough. Do you know if there is documentation that would suggest avoiding flavor quotas? I may need to convince someone to do so. | |
| 19:50:26 | sean-k-mooney | larsks: not that im aware of but most people dont know they exist and we just dont activly publicise that fact to new users | |
| 19:50:36 | larsks | Got it. Okay, thanks! | |
| 19:56:32 | cdent | Is anyone else seeing HackingTestCase.test_check_doubled_words fail on py36 on ubuntu 18.04? It's not failing on macos | |
| 19:58:11 | efried | cdent: I just ran it locally on trusty and it ran okay. | |
| 19:59:00 | efried | I noticed it breaking here: https://review.openstack.org/#/c/618786/ <== is that where you were seeing it, or somewhere else? | |
| 19:59:43 | cdent | first on my placement removal patches, and then on master | |
| 20:12:04 | cdent | weird, it's a problem in 3.6 but not 3.7 | |
| 20:18:53 | cdent | oh rich, it passes in stestr in 3.7, but not with testtools.run or unittest | |
| 20:33:05 | larsks | sean-k-mooney: Looks like there is already a bug, from 2016 :). https://bugs.launchpad.net/nova/+bug/1445637 | |
| 20:33:05 | openstack | Launchpad bug 1445637 in OpenStack Compute (nova) "Instance resource quota not observed for non-ephemeral storage" [Wishlist,Opinion] | |
| 20:35:31 | sean-k-mooney | larsks: ah ok let me repriorise it for you | |
| 20:36:14 | larsks | I don't know, maybe at this point it's just a doc bug and the docs should say "use cinder and neutron resource controls". | |
| 20:37:53 | sean-k-mooney | i have set it to confirmed and low. we can propse a docs update as a resolution to the but if we like | |
| 21:01:34 | larsks | sean-k-mooney: ...but flavor quotas *are* still the correct mechanism for controlling cpu and memory limits? | |
| 21:03:40 | sean-k-mooney | larsks: cpu and memory limits? | |
| 21:03:53 | cdent | efried: it's because of this https://bugs.python.org/issue33899 which gets python 3.6.7 and newer versions of python 3.7. I'll make a bug and a patch | |
| 21:04:18 | larsks | sean-k-mooney: right, like quota:cpu_quota. | |
| 21:04:22 | larsks | sean-k-mooney: so really just cpu. | |
| 21:04:35 | sean-k-mooney | larsks: that is also something that in general is not used | |
| 21:05:13 | larsks | Okay. Is there an alternative for that, or is that just something that was considered less useful? | |
| 21:05:18 | sean-k-mooney | larsks: most of those values are from lxc | |
| 21:05:24 | sean-k-mooney | or vm ware | |
| 21:06:08 | sean-k-mooney | many of them never work with libvirt/kvm cpu_shares did but not the rest | |
| 21:06:35 | sean-k-mooney | the same is true fo the memory limits | |
| 21:06:40 | sean-k-mooney | https://docs.openstack.org/nova/latest/user/flavors.html | |
| 21:07:15 | sean-k-mooney | all of the flavor quota atibute came form the vmware driver originally | |
| 21:09:30 | larsks | Okay. So effectively the best practice is not to use instance resource limits for anything, and rely on the per-service limits (e.g., cinder, neutron) where available. Is that accurate? | |
| 21:10:02 | sean-k-mooney | if you want to have interop between different public cloud then you could not rely on that feature existing | |
| 21:10:39 | sean-k-mooney | as an operator you can set them but it may cause issues for your users if you also expose the service qos apis | |
| 21:10:44 | cdent | efried: https://bugs.launchpad.net/nova/+bug/1804062 the thing that I thought would fix it does not | |
| 21:10:45 | openstack | Launchpad bug 1804062 in OpenStack Compute (nova) "test_hacking fails for python 3.6.7 and newer" [Undecided,New] | |
| 21:10:47 | cdent | so still thinking | |
| 21:10:59 | larsks | sean-k-mooney: fair enough. Are there any plans to deprecate the feature in the near future? | |
| 21:11:18 | cdent | mriedem: to distract you, that bug ^ is real fun | |
| 21:11:36 | sean-k-mooney | larsks: again it kind of a if its not broken dont fix it or delete it situation | |
| 21:11:55 | sean-k-mooney | larsks: i dont think so but it has been mentioned in the past | |
| 21:12:36 | sean-k-mooney | larsks: a better way to look at it is it unlikely that we would add more quota: extraspec in the future | |
| 21:13:05 | larsks | Okay, that makes sense. Thanks for spending some time on this! | |
| 21:14:29 | cfriesen | is it just me or is it not intuitive that the way to get a vnc session to a server using the "openstack" command is "openstack console url show" rather than an "openstack server console show" or similar? | |
| 21:15:00 | sean-k-mooney | cfriesen: i did fine it weird too | |
| 21:15:19 | sean-k-mooney | its there to differenceate between the url or the log | |
| 21:15:45 | sean-k-mooney | but i would have gon with opesntack server console show and openstack server log show | |
| 21:16:48 | sean-k-mooney | cfriesen: sorry tehy are console log show and console url show | |
| 21:17:19 | sean-k-mooney | but yes openstack server console show and openstack server log show would have made more sense to me | |
| 21:19:21 | mriedem | cfriesen: likely a question for dtroyer in #openstack-sdks | |
| 21:20:27 | mriedem | cdent: so we're intermittently hitting that in py36 jobs? | |
| 21:20:34 | cdent | yes | |
| 21:21:02 | cdent | seems to depend on whether the node has a recently updated python. 3.6.7 was released to ubuntu not long ago | |
| 21:21:13 | sean-k-mooney | cdent: is that happening in nova or in the hacking repo? | |
| 21:21:18 | cdent | nova | |
| 21:21:44 | cdent | it's just the one test | |
| 21:22:02 | cdent | the root is that having a newline token being added on the end is causing pep8 to think it needs to do a "logical check" | |