Posted	Nick	Remark
#openstack-nova - 2018-11-05
20:41:01	melwitt	but, I think with oslo.limit the idea was to try and abstract away as much as possible and let it handle the hierarchical enforcement, and all you do is provide it a callback
20:46:37	lbragstad	oh - sure...
20:46:45	lbragstad	i can see where that can get muddy
20:47:18	lbragstad	i guess the only reason we have usage in the oslo.limits stuff is because we need to calculate enforcement, which checks what users are asking for against what they already have
20:50:49	lbragstad	and to melwitt's point, the callback is what oslo.limit is relying on for the usage of X in a given project
20:54:35	melwitt	I think what jaypipes is saying is that it's not technically required for oslo.limit to take care of enforcement, since enforcement could be done in projects in whatever way they want. but I thought oslo.limit was also trying to provide a common and simple interface for every project to use and let the callbacks be the only pieces each project would have to write separately. and otherwise use the common oslo.limit interface
20:54:53	mriedem	i think i found what cleans up the migration-based allocation during server delete of a VERIFY_RESIZE server
20:55:21	mriedem	https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2096
20:56:10	melwitt	mriedem: a-ha! nice find. what a sneaky code
20:56:34	melwitt	never knew resizes were confirmed right before deleting
20:56:53	melwitt	makes sense though
20:58:18	jaypipes	lbragstad: I still don't see why oslo.limits needs to "calculate enforcement".
20:58:56	melwitt	I don't think it "needs to" but if it does, it makes it so projects don't have to implement the same thing separately. they just have to write callbacks
20:59:39	melwitt	maybe that commonized code is minimal though, which I guess is your point
20:59:55	lbragstad	yeah - i think we were operating under the assumption that service would give oslo.limit a project_id + resource type and oslo.limit would return a yes or no based on the hierarchy and usage
21:00:35	lbragstad	because we didn't want to make service re-implement logic to understand this complex project hierarchy
21:00:41	lbragstad	services*
21:01:16	lbragstad	but - putting that aside... how do you see nova's interaction with oslo.limit jaypipes?
21:01:25	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add functional test to delete a server while in VERIFY_RESIZE https://review.openstack.org/615644
21:03:32	jaypipes	lbragstad: I see oslo.limit as basically the client for Keystone's GET /limits API.
21:03:58	jaypipes	lbragstad: and maybe the definition of some common objects. that's about it.
21:04:06	lbragstad	ok
21:04:31	lbragstad	so - to be clear, you except oslo.limit to still handle the tree of projects from keystone and their respective limits?
21:04:42	lbragstad	expect*
21:21:09	jaypipes	lbragstad: I don't necessarily think so, no...
21:21:38	jaypipes	lbragstad: all I need is a flattened dict of project limit amounts for a set of resource types
21:22:14	jaypipes	lbragstad: I figured Keystone would do the needful when it came to flattening the returned dict of resource type to limit amount.
21:22:44	jaypipes	lbragstad: still trying to finish up this code. I hope things will be clearer with the last patch in this series.
21:22:55	lbragstad	ack
21:23:05	lbragstad	we kinda do that already - http://specs.openstack.org/openstack/keystone-specs/specs/keystone/rocky/strict-two-level-enforcement-model.html#fetching-project-hierarchy
21:23:11	lbragstad	which was required for the limit work
21:43:16	openstackgerrit	Matt Riedemann proposed openstack/nova-specs master: Add support for emulated virtual TPM https://review.openstack.org/571111
21:56:54	cfriesen	mriedem: thanks for that tweak ^
22:10:12	openstackgerrit	Eric Fried proposed openstack/nova master: WIP: update_from_provider_tree: fast fail, clear cache https://review.openstack.org/615677
22:11:49	mriedem	efried: cdent: jaypipes: have we found a compromise on https://review.openstack.org/#/c/570847/10/nova/rc_fields.py@45 ?
22:12:01	mriedem	NET_BW_EGR_KILOBIT_PER_SEC and NET_BW_IGR_KILOBIT_PER_SEC ?
22:14:00	cdent	mriedem: ooph, I had managed to forget about that
22:14:17	mriedem	i'm rebasing his series so if we are cool with that naming then i'll make the change
22:17:44	cdent	did we consider NET_BW_EGRESS_KBPS or is that too ambiguous for bits and bytes? (although historicall *bps has always been bits?)
22:18:09	cdent	mriedem: I don't have a huge opinion on that actual name, just that the symbol and the string in the canonical location be the same thing
22:18:31	cdent	given the canonical location is going to change soonish *shrug*
22:19:47	mriedem	gibi mentioned the bits vs bytes thing
22:20:10	mriedem	"I needed to include the unit of the resource as it is not trivial and as the name needs to be all upper case the bit and byte difference (the capital B in KB means byte officially) in the unit cannot be expressed if abbreviated."
22:21:58	mriedem	i'll just change to NET_BW_EGR_KILOBIT_PER_SEC and NET_BW_IGR_KILOBIT_PER_SEC so we can shit and get off the pot
22:22:34	cdent	wfm
22:30:13	efried	since I think the discussion is all my fault, I might as well weigh back in.
22:30:13	efried	I don't see why the const has to be the same as the string.
22:30:13	efried	But jaypipes has a point that you can always alias it if you need to.
22:30:13	efried	So effit, we can just go back to the original names and suck up literally half the line width Python allows us.
22:32:24	mriedem	no backsies now
22:32:26	mriedem	i've already changed it
22:39:37	efried	idgas
22:47:47	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add request_spec.RequestGroup versioned object https://review.openstack.org/568840
22:47:48	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add requested_resources field to RequestSpec https://review.openstack.org/567267
22:47:48	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add bandwidth related standard resource classes https://review.openstack.org/570847
22:47:49	openstackgerrit	Matt Riedemann proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268
22:47:49	openstackgerrit	Matt Riedemann proposed openstack/nova master: Reject interface attach with QoS aware port https://review.openstack.org/570078
22:47:50	openstackgerrit	Matt Riedemann proposed openstack/nova master: Reject networks with QoS policy https://review.openstack.org/570079
23:01:53	mriedem	UH OH http://logs.openstack.org/47/615347/5/check/tempest-full/bf73d04/controller/logs/screen-n-sch.txt.gz#_Nov_05_20_39_53_554408
23:02:49	mriedem	http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22AllocationUpdateFailed%3A%20Failed%20to%20update%20allocations%20for%20consumer%5C%22%20AND%20message%3A%5C%22Error%3A%20another%20process%20changed%20the%20consumer%5C%22%20AND%20message%3A%5C%22after%20the%20report%20client%20read%20the%20consumer%20state%20during%20the%20claim%5C%22%20AND%20tags%3A%5C%22screen-n-sch.txt%5C%22&from=10d
23:08:25	efried	mriedem: Tell me we have a retry in place for that
23:13:47	efried	mriedem: Is the code path for is_new_compute_node guaranteed to run only on startup?
23:56:51	openstackgerrit	Eric Fried proposed openstack/nova master: Remove LazyLoad of Scheduler Clients https://review.openstack.org/615641
23:56:52	openstackgerrit	Eric Fried proposed openstack/nova master: SIGHUP n-cpu to refresh provider tree cache https://review.openstack.org/615646
23:56:52	openstackgerrit	Eric Fried proposed openstack/nova master: WIP: Reduce calls to placement from _ensure https://review.openstack.org/615677
#openstack-nova - 2018-11-06
00:04:47	openstackgerrit	Eric Fried proposed openstack/nova master: WIP: Remove redundant inventory refresh https://review.openstack.org/615695
00:12:28	efried	Oh, jaypipes, you're gonna like this one...
00:33:10	openstackgerrit	gaobin proposed openstack/nova master: Complete the parameters in the API documentation https://review.openstack.org/615697
01:03:52	openstackgerrit	Joshua Cornutt proposed openstack/nova master: Moving get_hash_str() from md5 to sha-256 https://review.openstack.org/615704
01:27:37	openstackgerrit	Eric Fried proposed openstack/nova master: WIP: Commonize _update code path https://review.openstack.org/615705
01:27:47	efried	jaypipes: Still working out the kinks, but ^^
01:28:00	efried	-1KLOC so far :)
01:34:45	openstackgerrit	Merged openstack/nova-specs master: High Precision Event Timer (HPET) on x86 guests https://review.openstack.org/607989
01:54:51	prometheanfire	not sure if oslo or nova, but the other services are fine
01:54:55	prometheanfire	new oslo.service breaks nova
01:54:57	prometheanfire	http://logs.openstack.org/76/615676/1/check/cross-nova-py27/67e6a5d/testr_results.html.gz
01:56:34	melwitt	prometheanfire: ouch. will take a look later
02:04:53	openstackgerrit	Joshua Cornutt proposed openstack/nova master: Moving get_hash_str() from md5 to sha-256 https://review.openstack.org/615704
05:05:53	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove Placement API reference https://review.openstack.org/614437
05:12:53	prometheanfire	melwitt: :D
05:44:19	openstackgerrit	melanie witt proposed openstack/nova master: Patch LoopingCallBase._sleep instead of _ThreadingEvent.wait https://review.openstack.org/615724
07:27:23	openstackgerrit	Yikun Jiang proposed openstack/nova master: Add compute_node ratio online data migration script https://review.openstack.org/609995
07:38:31	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750
08:14:40	openstackgerrit	Merged openstack/nova master: Add request_spec.RequestGroup versioned object https://review.openstack.org/568840
08:51:59	openstackgerrit	Merged openstack/nova master: Add requested_resources field to RequestSpec https://review.openstack.org/567267
09:31:29	openstackgerrit	Maciej Jozefczyk proposed openstack/nova master: Force refresh instance info_cache during heal https://review.openstack.org/591607
09:31:30	openstackgerrit	Maciej Jozefczyk proposed openstack/nova master: Add fill_virtual_interface_list online_data_migration script https://review.openstack.org/614167
10:14:24	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Improve formats of the Compute API guide https://review.openstack.org/615809
10:57:48	s10	Please approve backports for https://review.openstack.org/#/q/If1c901b974bc7295927b3f033a04eaa6ac36f603
11:49:52	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Support deleting data volume when destroy instance https://review.openstack.org/580336
12:37:30	fanzhang	hi melwitt, sorry to bother, but if you got some free time, would you please take a look at this patch ? https://review.openstack.org/#/c/612272/
13:33:24	openstackgerrit	Radoslav Gerganov proposed openstack/nova master: Fix support matrix for VMware UEFI support https://review.openstack.org/615870
13:56:45	openstackgerrit	sean mooney proposed openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116
14:11:21	mriedem	efried: "Tell me we have a retry in place for that" yes we should
14:11:49	mriedem	efried: "Is the code path for is_new_compute_node guaranteed to run only on startup?" no it runs during the periodic so you could delete the compute service, forget to stop the nova-compute service on the host, and it will recreate the compute node record
14:16:22	openstackgerrit	John Garbutt proposed openstack/nova-specs master: Enable rebuild for instances in cell0 https://review.openstack.org/554218
14:18:09	openstackgerrit	John Garbutt proposed openstack/nova-specs master: Add PENDING vm state https://review.openstack.org/554212
14:19:10	openstackgerrit	John Garbutt proposed openstack/nova-specs master: Add PENDING vm state https://review.openstack.org/554212
14:25:30	jangutter	to all the US people, good luck with voting... The most important vote in our lifetime is the one that names the T release.
14:26:57	bauzas	T

Earlier   Later