| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-10-30 | |||
| 16:06:10 | openstackgerrit | Florian Haas proposed openstack/nova stable/rocky: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609789 | |
| 16:07:47 | openstackgerrit | Florian Haas proposed openstack/nova stable/queens: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609790 | |
| 16:09:44 | efried | melwitt, johnthetubaguy: Thanks! | |
| 16:10:03 | openstackgerrit | sean mooney proposed openstack/nova master: harden placement init under wsgi https://review.openstack.org/610034 | |
| 16:34:36 | melwitt | johnthetubaguy: hey, thanks for the review! this is the corresponding reno update if you wouldn't mind https://review.openstack.org/613174 | |
| 16:34:57 | johnthetubaguy | melwitt: ah, missed that, looking | |
| 16:35:17 | melwitt | that one has to go direct to stable, in order to update a already release reno | |
| 16:35:25 | melwitt | thanks | |
| 16:36:55 | melwitt | oh, dangit I need to rebase | |
| 16:37:09 | melwitt | [the master change] | |
| 16:38:11 | melwitt | I used to have a master branch reno update on top, then learned it has to go direct to stable, so I abandoned the one on master, but that's preventing the approved bottom change from going to the gate | |
| 16:39:34 | gaudenz | Cloud someone have a look at https://review.openstack.org/#/c/523006/ ? This fixes a bug that has been around for a few releases and I made an effort to rebase it just a few days ago. Now all tests pass again. The bug is about resource usage calculations flapping between what nova calcualtes and what libvirt reports. | |
| 16:40:19 | gaudenz | It would be really nice if this could finally be approved and merged. If you have any comments I'm willing to do further work on the patch until it's acceptable. | |
| 16:45:51 | melwitt | hm, looks like I already orphaned the master branch reno, so not sure what's going on | |
| 16:47:50 | melwitt | a-ha, it's in the gate queue, just hasn't printed "starting gate jobs" on the review yet | |
| 16:51:06 | johnthetubaguy | melwitt: I just assumed I read the related changes the wrong way around again, phew | |
| 16:51:33 | melwitt | johnthetubaguy: nope, you're good! thanks for reviewing those | |
| 16:52:21 | johnthetubaguy | no worries, happened to just review the new console docs sfinucan wrote up, which was handy (but also need fixing due that console-auth changes) | |
| 16:52:42 | melwitt | yeah, I saw you're in console mode today | |
| 16:54:47 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347 | |
| 16:54:47 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add local_root to block_device_info https://review.openstack.org/529029 | |
| 16:56:02 | openstackgerrit | sean mooney proposed openstack/nova master: harden placement init under wsgi https://review.openstack.org/610034 | |
| 16:56:45 | sean-k-mooney | sorry for the noise ^ should now be ready for review | |
| 16:56:56 | openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Add nova-status upgrade check for consoles https://review.openstack.org/614302 | |
| 16:58:45 | melwitt | mriedem: I'm not sure if I did that right. if you find other problems in it, let me know and I'll fix at the same time ^ | |
| 17:00:29 | kashyap | melwitt: Just added a bunch of comments in that review after doing some tests with TCP consoles. | |
| 17:00:48 | kashyap | In short, we need to ensure the log file for the TCP char device is created at domain (Nova instance) define time. | |
| 17:01:10 | melwitt | kashyap: ok, I will take a look. thanks for looking into it | |
| 17:01:31 | kashyap | melwitt: FWIW, I also double-checked it w/ a libvirt upstream dev who knows this area | |
| 17:01:44 | kashyap | Will see if I can punch any other holes in this tomm / later this week | |
| 17:04:28 | mriedem | melwitt: looks ok | |
| 17:05:11 | sean-k-mooney | stephenfin: jaypipes can ye take a look at https://review.openstack.org/#/q/topic:bug/1734320+(status:open) when you have time. i would like to try and include these in the next release of os-vif on thusday | |
| 17:05:52 | sean-k-mooney | other core that feel comfortable reivewint os-vif are also welcome | |
| 17:06:00 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347 | |
| 17:06:00 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add local_root to block_device_info https://review.openstack.org/529029 | |
| 17:06:00 | openstackgerrit | Matthew Booth proposed openstack/nova master: Pass DriverBlockDevice to driver.attach_volume https://review.openstack.org/528363 | |
| 17:06:01 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix libvirt volume tests passing invalid disk_info https://review.openstack.org/529328 | |
| 17:06:02 | openstackgerrit | Matthew Booth proposed openstack/nova master: Pass disk_info dict to libvirt_info https://review.openstack.org/529329 | |
| 17:06:02 | openstackgerrit | Matthew Booth proposed openstack/nova master: Expose volume host type and path independent of libvirt config https://review.openstack.org/530786 | |
| 17:06:03 | openstackgerrit | Matthew Booth proposed openstack/nova master: Don't generate fake disk_info in swap_volume https://review.openstack.org/530787 | |
| 17:06:03 | openstackgerrit | Matthew Booth proposed openstack/nova master: Local disk serial numbers for the libvirt driver https://review.openstack.org/529380 | |
| 17:06:21 | melwitt | mriedem: thanks. I wasn't sure if there were any things I missed about backporting a thing that says "Added in Stein" | |
| 17:06:38 | jaypipes | sean-k-mooney: will try. | |
| 17:06:43 | jaypipes | sean-k-mooney: meeting hell day. | |
| 17:07:09 | sean-k-mooney | jaypipes: understood. if it does not make it we can do another release when its ready | |
| 17:07:44 | mriedem | melwitt: you're handling it the same as i did for this https://github.com/openstack/nova/commit/daac9a69500c318b5e9d94be0031a1c9506d0340#diff-019a63548bbf8607e233ccbc6a85b0fc | |
| 17:08:06 | jaypipes | sean-k-mooney: why is the next release of os-vif on thursday? | |
| 17:09:13 | melwitt | mriedem: a-ha, sweet. I managed to not notice it in the upgrade checks list in the file that there was another that said "also useful going back". thanks | |
| 17:09:57 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Pass request_spec from compute to cell conductor on reschedule https://review.openstack.org/582417 | |
| 17:09:57 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove legacy request spec compat code from API https://review.openstack.org/614309 | |
| 17:10:09 | sean-k-mooney | jaypipes: thursday is m1 i think so we have to do a release | |
| 17:10:24 | mriedem | that was last week | |
| 17:10:26 | mriedem | derp | |
| 17:10:38 | sean-k-mooney | jaypipes: atleast that is what i got form https://review.openstack.org/#/c/612844/ | |
| 17:10:45 | sean-k-mooney | mriedem: m1? | |
| 17:11:17 | mriedem | https://wiki.openstack.org/wiki/Nova/Stein_Release_Schedule | |
| 17:11:23 | mriedem | Oct 25: s-1 milestone | |
| 17:11:42 | sean-k-mooney | oh your right then why the november first deadline in https://review.openstack.org/#/c/612844/ | |
| 17:11:54 | mriedem | bauzas made it up i guess | |
| 17:12:39 | mriedem | or is nov 1 related to some cve deadline? | |
| 17:13:32 | sean-k-mooney | mriedem: not that im aware of the cve fix was not meged yet it was the patch sets that i was asking for review on | |
| 17:15:19 | sean-k-mooney | in anycase i cant review my own patches and i would like to get as much of a mitigation into the next release as we can. if it does not make 1.12.0 however we can do a 1.12.1 easilly enough before the end of the year | |
| 17:16:17 | sean-k-mooney | im just going to grab some food but if people do review and want any change ill priotise them when i get back/when the comments are left | |
| 17:16:19 | sean-k-mooney | brb | |
| 17:19:28 | bauzas | mriedem: I made what ? :) | |
| 17:19:53 | bauzas | holidays, internal stuff, french situation ? :p | |
| 17:24:55 | stephenfin | johnthetubaguy: Would you be averse to me addressing your comments in a follow-up? That patch is already quite huge and I'm going to lose my hard-earned +2s on the follow-ups https://review.openstack.org/#/c/606148 | |
| 17:27:35 | stephenfin | Also, does anyone have Visio? We're going to need someone to modify this diagram for us https://docs.openstack.org/nova/queens/_images/SCH_5009_V00_NUAC-VNC_OpenStack.png | |
| 17:32:49 | melwitt | Visio, what a blast from the past | |
| 17:33:45 | openstackgerrit | Jack Ding proposed openstack/nova master: Add I/O Semaphore to limit concurrent disk ops https://review.openstack.org/609180 | |
| 17:36:17 | stephenfin | In fairness, it's an damn fine tool (as with most of Office). I've yet to find anything as good | |
| 17:36:59 | openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Add nova-status upgrade check for consoles https://review.openstack.org/614302 | |
| 17:37:25 | melwitt | yeah, not criticizing it. just haven't heard or read the word Visio in several years | |
| 17:37:40 | melwitt | "it sounds familiar..." | |
| 17:53:06 | sean-k-mooney | stephenfin: png files are not normally editably in visio | |
| 17:53:28 | sean-k-mooney | do we have teh soruce file | |
| 17:53:32 | stephenfin | We do | |
| 17:53:35 | stephenfin | In the same folder | |
| 17:53:52 | sean-k-mooney | oh ok cool. | |
| 17:54:36 | sean-k-mooney | i dont see any visio files here https://docs.openstack.org/nova/queens/_images/ | |
| 17:54:47 | stephenfin | I don't imagine they're published | |
| 17:55:03 | sean-k-mooney | oh you mean its in the git repo that makes sense | |
| 17:55:15 | stephenfin | https://github.com/openstack/nova/tree/master/doc/source/admin/figures | |
| 17:56:09 | sean-k-mooney | ah vsd files i rememebr those | |
| 18:02:59 | mriedem | bauzas: we were trying to figure out where you came up with the nov 1 deadline in https://review.openstack.org/#/c/612844/ | |
| 18:05:52 | bauzas | ah ok | |
| 18:06:50 | sean-k-mooney | reading the mailing list post http://lists.openstack.org/pipermail/openstack-dev/2018-October/135689.html in the commit message we should have don it last week instead | |
| 18:06:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Address nits on I08991796aaced2abc824f608108c0c786181eb65 https://review.openstack.org/614322 | |
| 18:06:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Address nits on I1f1fa1d0f79bec5a4101e03bc2d43ba581dd35a0 https://review.openstack.org/614323 | |
| 18:07:23 | stephenfin | johnthetubaguy: Done those as follow ups https://review.openstack.org/614322 https://review.openstack.org/614323 | |
| 18:08:07 | sean-k-mooney | anyway os-vif does use cycle-with-intermediary so we can have more releases then milestones. the porposed change is just saying we should have at least 1 per milestone | |
| 18:08:37 | mriedem | yes i just commented again, i don't see a reason to wait | |
| 18:08:55 | stephenfin | mriedem, melwitt: If either of you fancy reviewing some console'y docs, I'd sure like to get these in https://review.openstack.org/#/q/topic:console-doc+(status:open+OR+status:merged) | |
| 18:11:11 | sean-k-mooney | mriedem: cool sounds fine to me. i would still prefer to merge sooner rather then later but ill just propose a 1.12.1 when they are ready rather then rushing for review feedback | |
| 20:11:22 | openstackgerrit | Merged openstack/nova master: Fix test bug when host doesn't have /etc/machine-id https://review.openstack.org/612717 | |
| 20:11:32 | openstackgerrit | Merged openstack/nova master: Cleanups for the scheduler code https://review.openstack.org/529343 | |
| 20:11:39 | openstackgerrit | Merged openstack/nova master: PowerVM: update_provider_tree() (compatible) https://review.openstack.org/468560 | |
| 20:11:49 | openstackgerrit | Merged openstack/nova master: tox: Stop build *all* docs in 'docs' https://review.openstack.org/613645 | |
| 20:51:41 | openstackgerrit | Jay Pipes proposed openstack/nova master: prevent common kwargs from glance client failure https://review.openstack.org/614351 | |
| 20:52:17 | jaypipes | lyarwood: you were interested in a previous commit that addressed ^^ | |