Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-10-19
20:12:09 melwitt gotcha
20:12:59 cfriesen okay. that simplifies my life, though not the end user's. :)
20:32:16 sean-k-mooney cfriesen: so as far as i can tell this is what determins what disks are migrated https://github.com/openstack/nova/blob/e2a39bb30f716c78af30d61efb3fb7526f9bdf6d/nova/virt/libvirt/driver.py#L7208-L7247
20:33:48 cfriesen sean-k-mooney: for live migration specifically
20:33:57 sean-k-mooney cfriesen: so for libvirt i think, that will include the ephermeral disk on live migration
20:34:01 sean-k-mooney yes
20:34:31 sean-k-mooney for rebuild/resize/cold migration i think we dont copy them
20:34:40 cfriesen the case I was looking into was a resize, followed by a resize-revert.
20:35:37 sean-k-mooney i can take a look. it makes sense that we copyt them on live migrate as that does not effect the life time of the instance as long as it succeeds
20:38:54 sean-k-mooney cfriesen: so for resize we copy the image here https://github.com/openstack/nova/blob/e2a39bb30f716c78af30d61efb3fb7526f9bdf6d/nova/virt/libvirt/driver.py#L8309-L8343 but i need to chec if the ephermeral disks are in elf._get_instance_disk_info(
20:40:34 cfriesen sean-k-mooney: don't waste time on my account, if the compute API says it can change, that's good enough for me.
20:40:41 sean-k-mooney cfriesen: it looks like its looping over all the disks too https://github.com/openstack/nova/blob/e2a39bb30f716c78af30d61efb3fb7526f9bdf6d/nova/virt/libvirt/driver.py#L7986
20:42:22 sean-k-mooney the code is very similar to the live migration code, they shoudl proably be refactored to gether but is also differnt enough that im not sure it does the same thing exactly
20:46:02 sean-k-mooney cfriesen: ya from an api persective it can. libvirt appears to keep them for cold and live migrate. i would assume they are not kept for rebuild,shelve and evacuate. i also think libvirt may be expanding the existing ephmeral disk in resize
20:47:34 sean-k-mooney cfriesen: the libvirt direver is specifclaly checking that we are not resizeing the ephermerl disk down https://github.com/openstack/nova/blob/e2a39bb30f716c78af30d61efb3fb7526f9bdf6d/nova/virt/libvirt/driver.py#L8268-L8275 implying that its not recreateing them but may be expanding them on resize
20:58:41 boden anyone heard about a "oslo_db.exception.DBNonExistentTable" cropping up across projects? Appears to have cropped up around 10/10 http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22oslo_db.exception.DBNonExistentTable%5C%22 and includes neutron, nova and others
21:15:39 mriedem boden: those are unit/functional tests,
21:15:47 mriedem and 10 days is as far back as logstash goes
21:15:54 mriedem so 10/10 is probably not really when it started
21:16:00 mriedem that's just how far back we have logs
21:16:13 mriedem it's showing patches in pike
21:16:39 mriedem and also shows up in successful job runs, so most likely unrelated to anything that's failing
21:17:52 boden mriedem perhaps that's the case for nova (I haven't dug there), but it doesnt appear to be the case for all others; there are valid failures
21:21:41 sean-k-mooney mriedem: boden is this realated why we have to loop for nova-manage out of interest
21:21:51 sean-k-mooney e.g. why wer did https://review.openstack.org/#/c/608091/
21:24:57 sean-k-mooney actully looking at the logs no this is unrealted
21:35:46 boden yeah my bad... I assumed nova was failing without digging... we have been getting this error on some other projects randomly; appears to be memory/resource related
21:50:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Drop legacy cold migrate allocation compat code https://review.openstack.org/611970
21:52:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Drop legacy cold migrate allocation compat code https://review.openstack.org/611970
22:18:30 openstackgerrit melanie witt proposed openstack/nova master: libvirt: set device address tag only if setting disk unit https://review.openstack.org/611974
22:22:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Drop legacy live migrate allocation compat code https://review.openstack.org/611975
22:23:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Drop legacy live migrate allocation compat code https://review.openstack.org/611975
#openstack-nova - 2018-10-20
00:13:23 openstackgerrit Merged openstack/nova master: Document each libvirt.sysinfo_serial choice https://review.openstack.org/611426
02:40:18 openstackgerrit Merged openstack/nova master: Remove the caching the resource on Request object https://review.openstack.org/609403
07:24:03 openstackgerrit Daniel Abad proposed openstack/nova master: Fix ironic client ironic_url deprecation warning https://review.openstack.org/611872
#openstack-nova - 2018-10-21
22:40:18 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113
22:40:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974
22:40:50 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311
#openstack-nova - 2018-10-22
00:07:21 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581
00:07:36 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017
00:07:52 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018
00:08:09 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019
02:03:52 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020
02:04:06 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027
02:04:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031
02:05:03 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add API ref guideline for body text https://review.openstack.org/605628
02:05:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153
02:06:11 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add API ref guideline for examples https://review.openstack.org/604060
02:41:33 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7) https://review.openstack.org/571992
02:41:51 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8) https://review.openstack.org/571993
02:46:46 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299
02:47:11 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344
02:47:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673
04:06:42 openstackgerrit Andreas Jaeger proposed openstack/nova master: Convert legacy-tempest-dsvm-neutron-src-oslo.versionedobjects job https://review.openstack.org/610271
04:08:32 openstackgerrit Andreas Jaeger proposed openstack/nova master: Rename tempest-nova job to follow conventions https://review.openstack.org/612230
04:17:15 openstackgerrit Sam Morrison proposed openstack/nova master: Fix up compute rpcapi version for pike release https://review.openstack.org/612231
05:37:23 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix best_match() deprecation warning https://review.openstack.org/611204
06:37:12 openstackgerrit Yongli He proposed openstack/nova-specs master: add 'show-server-group' spec https://review.openstack.org/612255
06:37:13 openstackgerrit Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.openstack.org/612256
07:07:15 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676
07:07:31 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689
07:07:51 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709
07:08:27 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712
07:09:09 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Replace MB with MiB https://review.openstack.org/608807
07:11:50 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Replace MB with MiB https://review.openstack.org/608807
07:42:24 jaosorior Hey folks! Could I get a review for this https://review.openstack.org/#/c/609591/ ? removing dead code :D
07:51:46 openstackgerrit Fan Zhang proposed openstack/nova master: Retry after hitting libvirt error VIR_ERR_OPERATION_INVALID in live migration. https://review.openstack.org/612272
09:43:16 openstackgerrit Radoslav Gerganov proposed openstack/nova stable/rocky: Update resources once in update_available_resource https://review.openstack.org/612293
09:44:01 openstackgerrit Radoslav Gerganov proposed openstack/nova stable/queens: Update resources once in update_available_resource https://review.openstack.org/612294
09:45:00 openstackgerrit Radoslav Gerganov proposed openstack/nova stable/pike: Update resources once in update_available_resource https://review.openstack.org/612295
10:37:30 adrianc sean-k-mooney: Hi, id like to collaborate on https://blueprints.launchpad.net/nova/+spec/libvirt-neutron-sriov-livemigration can we have a blue-jeans meeting to discuss ?
10:38:49 sean-k-mooney adrianc: sure we could that said it is best to keep as much of these discussion on irc/ml/gerrit when it comes to the design side
10:41:08 openstackgerrit Adam Spiers proposed openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779
10:41:20 sean-k-mooney adrianc: have you reviewed the spec i have published yet?
10:41:53 sean-k-mooney ah i see you have
10:41:56 Dinesh_Bhor Hi All, Is there a recommended/official API rate limiter for Nova?
10:42:14 adrianc sean-k-mooney: agree(also commented on your spec), I have also a WIP POC, myself and moshele would like to have a short sync on the topic
10:44:06 sean-k-mooney adrianc: did you have a time in mind. i would like th discuss the spec/blueprint at the next nova team meeting to see if we can at least get the blueprint approved
10:44:22 sean-k-mooney regarding the poc how far have you gotten
10:44:40 sean-k-mooney i had started on the same but i have been pulled into too other activities also
10:45:26 sean-k-mooney i had hoped to work on adding pci address claiming this week/next
10:45:54 adrianc sean-k-mooney: for indirect SRIOV with macvtap its working apart of the fact that no multiple port binding implementation in this mech driver
10:46:49 adrianc sean-k-mooney: including the pci resource claim for the migrated instance
10:47:16 sean-k-mooney adrianc: well wiht what i have published where im not doing the claim macvtap works
10:48:00 sean-k-mooney https://review.openstack.org/#/c/607365/ crrects the multiple port binding issue
10:48:21 sean-k-mooney then when i comment out this exception https://review.openstack.org/#/c/608788/1/nova/network/neutronv2/api.py
10:48:43 sean-k-mooney the migration succeeds. i was planning on trying to get the claim to work.
10:48:50 sean-k-mooney later this week
10:49:06 adrianc sean-k-mooney: was the neutron port in ACTIVE state ?
10:49:11 adrianc after migration that is
10:49:36 sean-k-mooney i did not check but i could ssh to the vm.
10:50:15 sean-k-mooney i belive it should be but we may need to modify the ml2 driver on the neutron side.
10:50:44 sean-k-mooney it has been almost 2 weeks since i worked on this since i was on training most of last week
10:52:40 sean-k-mooney adrianc: do you have any review pushed to gerrit
10:54:06 adrianc sean-k-mooney: not yet, its on local branch.
11:04:20 sean-k-mooney adrianc: did you have a time in mind to chat about this futher.
11:06:08 adrianc sean-k-mooney: im on PTO tomorrow but Wednesday would be great
11:08:47 sean-k-mooney sure that should work i have one or two meetsing around 4pm IST(UTC+1)
11:13:32 adrianc sean-k-mooney: great, can you set something at around 11AM (UTC+1)
11:14:36 sean-k-mooney that works for me. im not sure if there are any US based folks that should join but assumeing not then yes

Earlier   Later