Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-10-11
18:42:44 mriedem dansmith: on that cache thing, can we do that in a follow up?
18:47:14 dansmith mriedem: I was even going to volunteer to do it as a follow-up, but then you hurt my feelings by calling it excessive
18:47:41 mriedem "all nova devs are giant dicks"
18:47:58 mriedem just trying to stay true to form...
18:48:14 dansmith I would like to appeal to our guidance counselor
18:49:40 mriedem is it still mnaser?
18:50:16 mnaser mriedem: you're on timeout
18:50:19 mnaser 4 hours of typo fixing
18:50:21 dansmith they're drawing new names out of a hat to ensure fairness I think
18:50:23 mnaser be nice >:(
18:51:07 mnaser also now that i've been highlighted
18:51:09 openstackgerrit Adam Spiers proposed openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779
18:51:21 mnaser eyes on https://review.openstack.org/#/c/602384/ would be important/nice considering you can kinda snoop and listen to other vms traffic
18:51:31 mnaser which is kind of a big deal™
18:51:50 mriedem sean-k-mooney was supposed to be working on backports
18:52:09 mriedem to see if older versions of libvirt had issues with that
18:53:03 mnaser "someone" i know has done extensive testing
18:53:13 mnaser and would be likely happy to do local testing
18:53:20 mnaser so i'll try to ask/get them here to help sean-k-mooney
18:53:50 mriedem mnaser: on https://review.openstack.org/#/c/609330/1/specs/stein/approved/remove-force-flag-from-live-migrate-and-evacuate.rst@93 you don't know of any operators that disable computes and then force live migrations to those hosts to rebalance or during rolling upgrades?
18:55:45 mnaser mriedem: we do a bit of the opposite. we disable the host being evacuated and then evacuate that one
18:55:57 mnaser that way the scheduler just distributes things the way they're suppoesd to be
18:56:20 mnaser i'll reply to the comment
18:59:28 mnaser mriedem: added my comment
18:59:28 mriedem mnaser: btw, you don't get "on" timeout, you get "in" timeout
18:59:36 mriedem unless on timeout is a canadian thing
18:59:45 mriedem it's like kid jail
18:59:53 mnaser sorry i haven't done the whole raising a kid/pet/thing
19:00:54 mnaser whats wrong with kids napping
19:02:41 dansmith mriedem: hmm, does the context we're passing to get_all_volume_types potentially limit the result to what you have available based on who you are?
19:02:51 mriedem dansmith: yes
19:02:57 mriedem so no caching
19:03:10 mriedem unless you use cinder admin config and list all volume types
19:03:19 mriedem which we have, but it's optional
19:04:18 dansmith I'll just stop trying to be smart
19:05:03 mriedem that's ok, i apparently don't understand json schema https://review.openstack.org/#/c/606398/10/nova/tests/unit/api/openstack/compute/test_serversV21.py
19:06:34 melwitt mriedem: doesn't "null" mean not present at all? I don't think it means None
19:07:09 openstackgerrit Florian Haas proposed openstack/nova master: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609788
19:07:16 mriedem the "required" entry in the schema should say if the field can be missing
19:07:24 melwitt although, what would None map to then? not string, apparently
19:07:32 mriedem so i'm confused as to what 'null' means here, because it's the same for the trusted cert id and description fields
19:07:43 openstackgerrit Florian Haas proposed openstack/nova stable/rocky: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609789
19:07:51 melwitt hm, ok. I guess I don't understand it either then. I had thought "null" meant that it could be omitted
19:08:19 openstackgerrit Adam Spiers proposed openstack/nova-specs master: Add spec for libvirt driver launching AMD SEV-encrypted instances https://review.openstack.org/609779
19:08:35 openstackgerrit Florian Haas proposed openstack/nova stable/queens: Explain nested guest support https://review.openstack.org/609790
19:10:28 mriedem i'm able to create a server with a null description: {"server": {"name": "test-null-desc", "description": null, "imageRef": "b9cdd407-14fc-42fb-beb9-d53988d866e3", "flavorRef": "1", "max_count": 1, "min_count": 1, "networks": "none"}}
19:14:47 mriedem hmm wtf
19:14:48 mriedem curl -g -i -X POST http://199.204.45.149/compute/v2.1/servers -H "Accept: application/json" -H "Content-Type: application/json" -H "OpenStack-API-Version: compute 2.67" -H "X-Auth-Token: $token" -H "X-OpenStack-Nova-API-Version: 2.67" -d '{"server": {"name": "bfv-server-null-vol-type", "imageRef": "", "block_device_mapping_v2": [{"boot_index": "0", "uuid": "b9cdd407-14fc-42fb-beb9-d53988d866e3", "volume_size": "1", "volume_ty
19:14:48 mriedem null, "source_type": "image", "destination_type": "volume", "delete_on_termination": true}], "flavorRef": "1", "max_count": 1, "min_count": 1, "networks": "none"}}'
19:14:48 mriedem HTTP/1.1 202 Accepted
19:14:55 mriedem that's a null volume type
19:16:41 melwitt \:|
19:24:28 mriedem dansmith: you were right about that unset bdm.volume_type thing, wrote a test, will fix
19:24:46 dansmith finally.
19:33:22 mriedem i don't know how those functional api samples tests are passing without the cinder fixture either...
19:33:24 mriedem something smells in the tests
19:39:49 artom mriedem, a while ago I tried making the samples tests run with 2.latest, and realized I needed the CinderFixture (I think - might have been Neutron)
19:43:40 artom Hrmm, my old abandoned patches aren't telling me much. Anyways, it might be microversions, is what I'm saying.
20:11:39 mriedem well i think i know why the api samples are busted
20:12:23 mriedem https://github.com/openstack/nova/blob/7a5d7db7fc6ccfbd97508a1e8cd353ec25cf8ca2/nova/tests/functional/api_sample_tests/test_servers.py#L38
20:12:32 mriedem it's not using the 2.67 request sample
20:15:23 artom Hey, I was right! Time to revive https://review.openstack.org/#/c/430352/ ?
20:17:34 mriedem i'm not sure i understand all that black magic
20:18:45 mriedem common_req_names is definitely f'ed though
20:19:22 artom It's basically a way to automagically load whatever the latest samples in the tree are, and adds a test case that runs with 2.latest
20:20:30 openstackgerrit Merged openstack/os-vif master: Reflow docs to 79 columns https://review.openstack.org/609726
20:22:45 artom I still kinda want it to happen, but ideally there'd be a really awesome generous intelligent core who would commit to it, because it's loads of tedious work fixing all the samples that break with 2.latest
20:23:53 mriedem i don't see any cores like that around here
20:24:05 openstackgerrit melanie witt proposed openstack/nova-specs master: Document Stein review priorities https://review.openstack.org/609807
20:24:23 artom Giant dicks indeed ;)
20:35:45 mriedem ima need this to fix these tests https://www.youtube.com/watch?v=3sClFZ21oSo
20:40:52 melwitt I could use the same music to triage a bunch of bugs
20:41:37 mriedem this was on the radio on the way home from lunch with laura today, https://www.youtube.com/watch?v=zNgcYGgtf8M - i threatened to roll the windows down and blast it
20:42:03 mriedem who me?! yes you!
20:42:23 melwitt that's a good one
20:48:00 openstackgerrit melanie witt proposed openstack/nova-specs master: Document Stein review priorities https://review.openstack.org/609807
20:50:14 melwitt nova meeting in 10 minutes
20:58:33 mriedem well i figured out the 2.67 unit test failures
20:58:36 mriedem or lack thereof
21:12:59 cfriesen bauzas: you might find this interesting: https://bugs.launchpad.net/nova/+bug/1797269
21:12:59 openstack Launchpad bug 1797269 in OpenStack Compute (nova) "Nova fails creating multiple NVIDIA VGPU instances at the same time" [Undecided,New]
21:17:34 openstackgerrit sean mooney proposed openstack/os-vif master: add support for generic tap device plug https://review.openstack.org/602384
21:19:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add compute version 36 to support ``volume_type`` https://review.openstack.org/579360
21:19:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add compute API validation for when a volume_type is requested https://review.openstack.org/605573
21:19:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add microversion 2.67 to support volume_type https://review.openstack.org/606398
21:21:37 openstackgerrit Jack Ding proposed openstack/nova-specs master: WIP: High Precision Event Timer (HPET) on x86 guests https://review.openstack.org/607989
21:23:11 mriedem dansmith: there ^
21:23:16 mriedem not sure i can +2 those now
21:24:08 openstackgerrit Jack Ding proposed openstack/nova-specs master: WIP: High Precision Event Timer (HPET) on x86 guests https://review.openstack.org/607989
21:26:50 mriedem +1 on a couple, and +2 on the others that i didn't touch in non-trivial ways
21:35:07 sean-k-mooney melwitt: i have address your momments on https://review.openstack.org/#/c/602384 by the way. ill be starting on the backport tomorrow.
21:35:25 sean-k-mooney /momments/comments/
21:35:56 melwitt k, will look
21:36:21 sean-k-mooney mriedem: mnaser a different edgecase that will likely need a more invovled fix was flagged to me for that bug earlier today
21:37:45 sean-k-mooney mriedem: mnaser i dont think the current patch or os-vif on its own can address it if i confirm it tommrow and i think will require nova and or neutron change to fix the second vector.
21:38:14 mnaser sounds like a boatload of fun
21:39:41 sean-k-mooney mnaser: yes its one metric "boatload of fun".
21:42:18 cfriesen mriedem: any chance you could take a look at this? It's been sitting around for a while without any real reviews and it's in code you know about. https://review.openstack.org/#/c/603844/
21:42:41 sean-k-mooney mnaser: what version of openstack are you running by the way.
21:43:16 mnaser sean-k-mooney: queens in process of upgrading to rocky in montreal and rocky in sjc

Earlier   Later