Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-10-05
12:58:19 sean-k-mooney crap, when i said 3.x replace that with 4.x ... but same difference. install iso ships with much older kernel then cloud image that the gate uses
12:58:32 leakypipes sean-k-mooney: 3.17.x kernel!? well, at least it's 4 years old.
12:58:42 leakypipes alright, phew...
13:16:20 jroll leakypipes: of course :)
13:18:57 openstackgerrit Jay Pipes proposed openstack/os-traits master: Add COMPUTE_TIME_HPET trait https://review.openstack.org/608258
13:19:23 leakypipes sean-k-mooney: ^
13:26:59 fried_rice leakypipes, sean-k-mooney: I'm late to the naming party, but I want it noted that NO significance should be attached to the name I chucked into the spec draft. I was just a placeholder.
13:27:08 fried_rice I dig the name (and reasoning) leakypipes put into ---^
13:27:27 fried_rice just a teeny paperwork issue with that patch and I'm +2
13:27:46 sean-k-mooney fried_rice: cool
13:28:20 leakypipes fried_rice: coo, thx
13:30:04 finucannot lyarwood: Fancy hitting https://review.openstack.org/#/c/588570/2 today before you head off on your holliers
13:30:36 lyarwood *clicks*
13:32:23 lyarwood finucannot: cool thanks for doing that, it LGTM now.
13:33:39 finucannot lyarwood: ta
13:34:07 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Improve documentation for defer_iptables_apply https://review.openstack.org/445436
13:34:59 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Undeprecate the 'dhcp_domain' option https://review.openstack.org/480616
13:35:37 sean-k-mooney leakypipes: actuly just reading your comment regarding a harware htpe and resouce class i dont think that is how it works
13:36:01 sean-k-mooney leakypipes: you dont actully pass the hardware hpet to the guest
13:36:36 sean-k-mooney leakypipes: qemu just can use it as its time source for the guest hpet or it can use another timesoucre
13:37:03 leakypipes sean-k-mooney: oh? I thought you said that only a single guest could use the hardware HPET on a host at a time?
13:37:15 sean-k-mooney leakypipes: no that was for the TPM
13:37:20 leakypipes ahhhhhhhhh
13:37:38 leakypipes sorry, yeah, I was confused. I'll fix the HPET patch ASAP.
13:38:09 openstackgerrit Stephen Finucane proposed openstack/nova master: Modify PciDevice.uuid generation code https://review.openstack.org/530487
13:38:10 openstackgerrit Stephen Finucane proposed openstack/nova master: Add an online migration for PciDevice.uuid https://review.openstack.org/530905
13:38:40 finucannot fried_rice: Could you take a look at https://review.openstack.org/#/c/530924/ before it ends up in merge conflict again? :)
13:39:43 mdbooth mriedem: So this one is looking good: https://review.openstack.org/#/c/578846/. I got a clean (of relevant failures) run against your evacuate ci test.
13:40:12 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.openstack.org/537414
13:41:00 fried_rice finucannot: Cool feature. Reviewing...
13:41:21 finucannot ta
13:43:57 fried_rice finucannot: Not having looked too deep yet: The ones you skipped, you skipped on purpose?
13:44:09 finucannot fried_rice: For example?
13:44:36 fried_rice finucannot: https://review.openstack.org/#/c/530924/7/nova/conf/libvirt.py@107
13:44:56 fried_rice I guess because there was no description in the docstring
13:45:21 finucannot Less that and more it being near-zero value
13:45:43 finucannot It is possible that I missed a few others though so do keep your eyes peeled. It's been through a few rounds
13:46:13 fried_rice finucannot: Okay, I'll mark all the missed ones just for reference. But looking at them, I think I agree there's no value for now.
13:46:23 finucannot ack. Sounds good
13:47:05 fried_rice finucannot: I need to see how they show up in the docs. Wondering if it would be good future-proofing to turn choices=['foo', 'bar'] into choices=[('foo', ''), ('bar', '')] for those...
13:47:33 finucannot Oh, that's a good point, actually. Here's the rendering code
13:48:08 finucannot https://github.com/openstack/oslo.config/blob/master/oslo_config/sphinxext.py#L161-L171
13:48:08 fried_rice finucannot: Ahem
13:48:10 fried_rice http://logs.openstack.org/24/530924/7/check/openstack-tox-docs/a4e127f/html/configuration/config.html#api.auth_strategy
13:48:23 fried_rice it appears to be broken, at least for that first un
13:48:34 fried_rice shit, ignore
13:48:46 finucannot I was going to say...
13:48:59 fried_rice I thought I was going to skip coffee this morning. Clearly that is not going to be possible.
13:49:28 fried_rice finucannot: So yeah, quick experiment to make sure ('foo', '') shows up like I think it will. That could be done separately, of course.
13:57:54 melwitt .
14:14:33 fried_rice finucannot: tox -e docs is giving me
14:14:33 fried_rice ImportError: bad magic number in 'nova.notifications.objects.libvirt': b'\x03\xf3\r\n'
14:14:33 fried_rice which looks familiar but I can't remember wtf
14:15:02 finucannot Let me build locally. This is unrelated, right?
14:15:20 fried_rice totally
14:15:50 fried_rice well, I was trying to build locally to experiment with the above
14:15:56 fried_rice finucannot: removing *.pyc fixed it.
14:16:00 fried_rice call off the doggs
14:16:05 finucannot ack
14:16:25 fried_rice finucannot: We did something recently to stop doing that find -delete
14:16:32 fried_rice I guess it was there for a reason :(
14:19:07 fried_rice finucannot: Interesting data point: http://paste.openstack.org/show/731591/ results in no change to the output. I was actually expecting it to turn it into a bolded one-item-per-line list with no descriptions, but it doesn't - it still looks just like https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.virt_type
14:20:32 finucannot fried_rice: That's because I defensively coded against that. Oops https://github.com/openstack/oslo.config/blob/master/oslo_config/sphinxext.py#L163-L164
14:21:10 finucannot iirc, that was in place to prevent us emitting the 'Possible values' section twice for something like nova
14:21:18 fried_rice finucannot: Does '' convert to None somewhere along the line?
14:21:41 finucannot Hmm, it shouldn't but lemme check
14:22:25 fried_rice (I promise I will eventually get back to reviewing your actual patch - hopefully before another rebase is required :)
14:23:33 finucannot So it shouldn't, based on this https://github.com/openstack/oslo.config/blob/bc9b7f5d2fb4c552254263bb0843fb766a9978a0/oslo_config/types.py#L118-L121
14:24:39 finucannot Though, personally, given that we have the 'Valid values' line already, I think emitting the 'Possible values' section too probably isn't necessary https://github.com/openstack/oslo.config/blob/master/oslo_config/sphinxext.py#L117
14:24:41 fried_rice finucannot: Sorry, I still haven't gotten that coffee. It didn't dtrt, it printed the normal
14:24:41 fried_rice Valid Values:kvm, lxc, qemu, uml, xen, parallels
14:24:41 fried_rice but then also did the paragraph thing with <No description provided> for each, which is ugly.
14:25:06 finucannot Yeah, so drop back to choices=['foo', 'bar']
14:25:16 fried_rice yeah.
14:25:28 finucannot You'll keep the 'Valid Values' line but won't get those ugly lines
14:25:29 finucannot Cool
14:25:54 fried_rice finucannot: So yeah, the ones you changed are now showing up double, once in Valid Values on the third line, and then the new "Possible values" section.
14:26:10 fried_rice But that's going to be a change in oslo, if you want to dedup, not in consuming code.
14:26:30 finucannot Yup. That was on purpose. We we previously doing that in nova
14:26:34 finucannot Only by hand
14:27:28 finucannot I should probably just change the 'Possible values' title to something more meaningful, like 'Valid values description' or the likes
14:32:35 openstackgerrit Martin Midolesov proposed openstack/nova master: vmware:PropertyCollector for caching instance properties https://review.openstack.org/608278
14:33:12 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove get_config_vhostuser https://review.openstack.org/565471
14:33:13 openstackgerrit Stephen Finucane proposed openstack/nova master: Make 'plugin' a required argument for '_get_vif_instance' https://review.openstack.org/608279
14:37:16 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove get_config_vhostuser https://review.openstack.org/565471
14:37:17 openstackgerrit Stephen Finucane proposed openstack/nova master: Make 'plugin' a required argument for '_get_vif_instance' https://review.openstack.org/608279
14:38:30 finucannot fried_rice: Also, we still have the line to remove 'pyc' files
14:38:47 finucannot If that's not getting called, it's because the target isn't calling {[testenv]commands}
14:38:49 fried_rice hm, why didn't it hit when I did tox -e or tox -re?
14:38:58 fried_rice ...with the docs target. /me looks...
14:39:12 finucannot Yeah, we don't call it there
14:39:27 fried_rice okay. Should we?
14:40:10 finucannot If we do anything we code (which we do) then yeah, we should
14:41:03 finucannot Once we depend on tox 3.0.0, we can remove that line in favour of PYTHONDONTWRITEBYTECODE
14:41:46 finucannot https://github.com/tox-dev/tox/commit/336f4f6bd8b53223f940fc5cfc43b1bbd78d4699
14:45:42 fried_rice I'm gonna go review your actual patch now, mkay?
14:48:39 openstackgerrit Jay Pipes proposed openstack/os-traits master: Add COMPUTE_TIME_HPET trait https://review.openstack.org/608258
14:48:52 leakypipes fried_rice: ^
14:48:56 leakypipes sean-k-mooney: ^^
14:49:36 fried_rice leakypipes: +2

Earlier   Later