| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-10-03 | |||
| 06:08:41 | gmann | hanging around for some time if anyone has query related to API | |
| 06:14:22 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova stable/rocky: Imported Translations from Zanata https://review.openstack.org/604260 | |
| 06:32:36 | gmann | let's close office hour. | |
| 06:32:39 | gmann | #endmeeting | |
| 06:32:41 | openstack | Meeting ended Wed Oct 3 06:32:39 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 06:32:42 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-10-03-06.01.html | |
| 06:32:43 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-10-03-06.01.txt | |
| 06:32:44 | openstack | Log: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-10-03-06.01.log.html | |
| 06:37:40 | openstackgerrit | Merged openstack/nova stable/ocata: Update RequestSpec.flavor on resize_revert https://review.openstack.org/605880 | |
| 06:47:09 | openstackgerrit | Merged openstack/python-novaclient master: Fix up userdata argument to rebuild. https://review.openstack.org/605341 | |
| 07:10:03 | bauzas | good morning nova | |
| 07:28:53 | gibi | morning | |
| 07:41:48 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use provider tree in virt FakeDriver https://review.openstack.org/604083 | |
| 07:41:48 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor allocation checking in functional tests https://review.openstack.org/607287 | |
| 07:41:49 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run ServerMovingTests with nested resources https://review.openstack.org/604084 | |
| 07:41:49 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ignore forcing of live migration for nested instance https://review.openstack.org/605785 | |
| 07:41:50 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consider nested allocations during allocation cleanup https://review.openstack.org/606050 | |
| 07:41:50 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ignore forcing of evacuation for nested instance https://review.openstack.org/606111 | |
| 07:41:51 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs https://review.openstack.org/604125 | |
| 07:52:35 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: support claim_resources https://review.openstack.org/583667 | |
| 07:52:36 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable nested allocation candidates in scheduler https://review.openstack.org/585672 | |
| 07:52:36 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use provider tree in virt FakeDriver https://review.openstack.org/604083 | |
| 07:52:37 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor allocation checking in functional tests https://review.openstack.org/607287 | |
| 07:52:37 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run ServerMovingTests with nested resources https://review.openstack.org/604084 | |
| 07:52:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ignore forcing of live migration for nested instance https://review.openstack.org/605785 | |
| 07:52:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consider nested allocations during allocation cleanup https://review.openstack.org/606050 | |
| 07:52:39 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ignore forcing of evacuation for nested instance https://review.openstack.org/606111 | |
| 07:52:39 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs https://review.openstack.org/604125 | |
| 08:47:13 | ralonsoh | stephenfin: https://review.openstack.org/#/c/476612/36/vif_plug_ovs/ovsdb/ovsdb_lib.py@83. I don't understand this | |
| 08:47:56 | ralonsoh | stephenfin: do you mean I need to move this function... where? | |
| 08:54:02 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API https://review.openstack.org/476612 | |
| 09:02:41 | stephenfin | ralonsoh: Sorry, yeah, I mean move that above 'create_ovs_vif_port' or below 'delete_ovs_vif_port', so that 'create_', 'update_' and 'delete_' are grouped together | |
| 09:02:49 | stephenfin | ralonsoh: It's a nit though. Don't worry about it | |
| 09:02:56 | ralonsoh | stephenfin: done! | |
| 09:03:01 | stephenfin | Oh, perfect :) | |
| 09:03:07 | stephenfin | I'll review that now | |
| 09:38:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Rewrite the console doc https://review.openstack.org/606148 | |
| 09:38:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add minimal documentation for RDP consoles https://review.openstack.org/606992 | |
| 09:38:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add minimal documentation for MKS consoles https://review.openstack.org/606993 | |
| 09:38:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Allow 'nova-xvpvncproxy' to be called with CLI args https://review.openstack.org/606929 | |
| 09:47:20 | bauzas | does anyone know how to unstack/stack devstack with OFFLINE=True for a single project ? | |
| 09:47:37 | bauzas | I mean, I have all my stack but I just want to reinstall nova from master | |
| 09:49:22 | sean-k-mooney | bauzas: unstack, then manually git pull/checkout master on the nova repo set OFFLINE=True and stack | |
| 09:50:13 | sean-k-mooney | devstack wont update any of the projects and just used what is availabel | |
| 09:50:44 | sean-k-mooney | if you are unlucky you might need to pip install requirements form master if they have changed but that rarely is required | |
| 09:51:01 | bauzas | sean-k-mooney: that was my plan but I had the assumption that it would redeploy *all* projects from ENABLED_SERVICES | |
| 09:51:20 | sean-k-mooney | bauzas: it will | |
| 09:51:24 | bauzas | sean-k-mooney: my point is that I just want to init_nova() honestly | |
| 09:51:24 | sean-k-mooney | is that an issue | |
| 09:51:40 | sean-k-mooney | oh well dont unstack then | |
| 09:51:47 | bauzas | sean-k-mooney: my need is just that now that I reshaped some inventories, I just want to reshape back | |
| 09:52:22 | sean-k-mooney | just checkout the branch you want and run sudo systemctl restart devstack@n-* | |
| 09:53:16 | sean-k-mooney | if reshape is done by nova manage change restart to stop, then run nova manage and then start | |
| 09:55:29 | sean-k-mooney | as long as there are no schema migrations in between your current branch and the one your going to and no requiremetns changes you dont need to restack to change commit. just git checkout and restart service X | |
| 09:58:13 | cdent | yeah, that's what I was going to suggest | |
| 10:08:28 | stephenfin | bauzas: Could you look at pushing https://review.openstack.org/#/c/456572/ through? | |
| 10:17:37 | bauzas | sean-k-mooney: the problem is that the inventories are reshaped | |
| 10:17:50 | bauzas | sean-k-mooney: so a DB sync won't work, right? | |
| 10:17:59 | bauzas | because all the tables are there | |
| 10:18:14 | sean-k-mooney | bauzas: you can always drop the tables and then sync i guess | |
| 10:19:03 | bauzas | if I'm dropping the tables, I miss eg. https://github.com/openstack-dev/devstack/blob/master/lib/nova#L722-L723 | |
| 10:19:17 | bauzas | sean-k-mooney: ^ | |
| 10:20:36 | sean-k-mooney | i dont think there is any magical way to reshape witout deleting the reshaped RPs and restarting nova compute | |
| 10:20:45 | sean-k-mooney | that is what i ment by droping the tables | |
| 10:21:33 | bauzas | I think I'll just unstack/unstack for this time, and snapshot the DB | |
| 10:22:15 | bauzas | so, when I want to go backwards, I'll just use the dumpfile | |
| 10:22:17 | sean-k-mooney | ya that would work but other then for local testing is there a reason you are trying to downgrade? | |
| 10:22:35 | bauzas | sean-k-mooney: no, just testing indeed | |
| 10:23:31 | sean-k-mooney | if you have never used it https://www.heidisql.com/ is a great little tool for working with dbs | |
| 10:23:51 | bauzas | well | |
| 10:23:55 | sean-k-mooney | you need to run it under wine however | |
| 10:24:02 | bauzas | just for what I want, a mysqldump is enough | |
| 10:36:33 | sean-k-mooney | the one thing that annoys me more then the fact that we use a 80 charter line lenght is that we configure pep8 on spec for 79 charters | |
| 10:43:06 | openstackgerrit | sean mooney proposed openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116 | |
| 10:57:24 | stephenfin | That moment of panic where you submit a review and spot a group of comments on older patchsets from the corner of your eye | |
| 10:57:48 | stephenfin | What *did* Stephen of June 2018 have to say about this... | |
| 11:08:59 | mdbooth | stephenfin: Fancy a bash at this one: https://review.openstack.org/#/c/605436/ I bitch about python3 in it ;) | |
| 11:09:24 | openstackgerrit | sean mooney proposed openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116 | |
| 11:39:48 | sean-k-mooney | mdbooth: one basic question regarding https://review.openstack.org/#/c/605436/5. the compaute manger runs on the compute agent which is singel treaded but uses eventlets. so there is no paralleism but there is concurancy. so the lock you are aquiring is the mockey patched greenthread lock. is the reason we need the lock in the first place the fact we are doing db io and eventlets is cause us to yeild | |
| 11:39:51 | sean-k-mooney | allow another invocation of the fuction to start concurrently which races | |
| 11:40:43 | mdbooth | sean-k-mooney: Without going into details of locking, I find it's safest to ignore eventlets entirely when considering locking. | |
| 11:41:01 | mdbooth | When you tie yourself in knots trying to second guess a scheduler, you make lots of mistakes. | |
| 11:41:11 | sean-k-mooney | mdbooth: if we did not have eventlets in this case we would not need to lock | |
| 11:41:41 | mdbooth | It has multiple threads of execution. | |
| 11:41:49 | mdbooth | I don't care how we achieve that. | |
| 11:42:08 | sean-k-mooney | the compute manager is exectued from the compute agent right which does not have workers so only one thread | |
| 11:42:22 | mdbooth | Eventlets or python's 'threading' all have the same issues. | |
| 11:43:06 | sean-k-mooney | mdbooth: yes but my point is eventlets intoduced the concurency so that therefor we need a lock to be correct | |
| 11:43:33 | mdbooth | sean-k-mooney: We have concurrency. | |
| 11:43:55 | sean-k-mooney | if we did not have eventlets the previous code would have been correct because it would have been singel threaded | |
| 11:44:02 | sean-k-mooney | mdbooth: yep i know | |
| 11:44:28 | mdbooth | sean-k-mooney: Sure. We do have concurrency, though. It uses eventlets. | |
| 11:44:30 | sean-k-mooney | just makeing sure i understand the subtelties of the patch. this is an example of why i hate eventlets it hides concurancy | |
| 11:44:50 | mdbooth | sean-k-mooney: It doesn't really by the time you get into the compute manager. | |
| 11:45:16 | mdbooth | You just ignore eventlets entirely and assume you have multiple concurrent threads. How they're implemented isn't all that important in that code. | |
| 11:45:32 | mdbooth | If we later switched to a multi-threaded model, it would still be fine. | |
| 11:46:07 | sean-k-mooney | mdbooth: well if you were new to nova or did not think about it at the time then you can write races because of eventlets easier then if it was expcitly threaded | |
| 11:46:47 | mdbooth | Honestly, I never consider eventlets. I assume it's explicitly threaded. | |
| 11:47:11 | mdbooth | It's not, but that doesn't have any bearing on writing safe code, except when there's bugs in eventlet. | |
| 11:47:39 | sean-k-mooney | mdbooth: most new people i have talked to that work on openstack dont think about threads at all because the say oh its python and that has a gil so i dont need to care | |