| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-09-28 | |||
| 14:23:42 | jungleboyj | mriedem: Ok. | |
| 14:23:57 | mriedem | jungleboyj: kingbird is supposed to be related to this i think https://wiki.openstack.org/wiki/Kingbird in some way | |
| 14:24:05 | jungleboyj | melwitt: Ah, so there are ways to make it happen but nothing that is community developed? | |
| 14:24:12 | jungleboyj | Or supported by Nova? | |
| 14:24:35 | mriedem | and freezer? https://docs.openstack.org/freezer/latest/ | |
| 14:24:49 | mriedem | nova does not natively orchestrate DR | |
| 14:24:59 | mriedem | masakari deals with instance HA | |
| 14:25:10 | mriedem | freezer and kingbird are about backups/DR/replication i think | |
| 14:25:52 | jungleboyj | So that is what all those other projects are about. :-) | |
| 14:27:48 | jungleboyj | So, it looks like the answer is that there are projects out there working on this kind of problem. | |
| 14:28:53 | melwitt | jungleboyj: yeah, I mean, we've talked about this before and DR/HA would be best orchestrated outside of nova by another service/entity. and I wasn't familiar with the projects mriedem has mentioned ^ | |
| 14:29:13 | jungleboyj | melwitt: We both learned something. :-) | |
| 14:30:43 | melwitt | yep :) | |
| 14:35:09 | jungleboyj | mriedem: Thank you very much. Very helpful. | |
| 14:36:07 | mdbooth | mriedem: That bug iss an immediate practical win for your new test :) | |
| 14:41:31 | mdbooth | mriedem: Side note, I'm not a fan of using temporary_mutation on a context object, because context objects are shared between threads in various places. That could produce some incredibly weird behaviour would would be almost impossible to debug. | |
| 14:42:42 | mdbooth | Better to use a copy | |
| 14:43:48 | mdbooth | Outside of tests it's only ever used to set read_deleted on a context object, so probably best to add a method to context which returns a copy with read deleted set | |
| 14:44:10 | mdbooth | -> no possibility of weird threading issues | |
| 14:46:08 | mriedem | mdbooth: i've got a recreate regression functional test and it's an easy fix on top, | |
| 14:46:13 | mriedem | just need to clean up these patches | |
| 14:46:50 | mriedem | and yes it's amazing what you find when you actually have integration testing for features... :) | |
| 15:00:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for bug 1794996 https://review.openstack.org/606106 | |
| 15:00:45 | openstack | bug 1794996 in OpenStack Compute (nova) rocky "_destroy_evacuated_instances fails and kills n-cpu startup if lazy-loading flavor on a deleted instance" [High,Triaged] https://launchpad.net/bugs/1794996 | |
| 15:12:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ignore forcing of evacuation for nested instance https://review.openstack.org/606111 | |
| 15:12:38 | giblet | mriedem: FYI I applied the same ignore-the-force-flag tactic for the force evacuation with nested allocation case ^^ | |
| 15:22:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs https://review.openstack.org/604125 | |
| 15:36:41 | openstackgerrit | Elod Illes proposed openstack/nova master: Reject networks with QoS policy https://review.openstack.org/570079 | |
| 15:48:00 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for bug 1794996 https://review.openstack.org/606106 | |
| 15:48:00 | openstack | bug 1794996 in OpenStack Compute (nova) rocky "_destroy_evacuated_instances fails and kills n-cpu startup if lazy-loading flavor on a deleted instance" [High,Triaged] https://launchpad.net/bugs/1794996 | |
| 15:48:00 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix InstanceNotFound during _destroy_evacuated_instances https://review.openstack.org/606122 | |
| 15:53:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for bug 1794996 https://review.openstack.org/606106 | |
| 15:53:56 | openstack | bug 1794996 in OpenStack Compute (nova) "_destroy_evacuated_instances fails and kills n-cpu startup if lazy-loading flavor on a deleted instance" [High,In progress] https://launchpad.net/bugs/1794996 - Assigned to Matt Riedemann (mriedem) | |
| 15:53:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix InstanceNotFound during _destroy_evacuated_instances https://review.openstack.org/606122 | |
| 15:53:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Run evacuate tests with local/lvm and shared/rbd storage https://review.openstack.org/604400 | |
| 15:53:57 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: Test against mdbooth's evacuate patch https://review.openstack.org/604423 | |
| 15:55:58 | mriedem | melwitt: please to be approving backport to queens https://review.openstack.org/#/c/602409/ | |
| 15:56:08 | mriedem | oh and the change below it for testing | |
| 16:06:52 | mriedem | ocata backport https://review.openstack.org/#/c/570653/ is ready to go | |
| 16:08:33 | mriedem | and https://review.openstack.org/#/c/599885/1 | |
| 16:08:56 | cfriesen | when adding a new flavor extra-spec, what's the appropriate place to document it? embedded docs, reno, both? | |
| 16:09:02 | mriedem | and https://review.openstack.org/#/c/583422/ | |
| 16:09:19 | mriedem | cfriesen: https://docs.openstack.org/nova/latest/user/flavors.html#extra-specs | |
| 16:09:25 | mriedem | and reno | |
| 16:09:35 | cfriesen | thanks | |
| 16:10:46 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Fix host validity check for live-migration https://review.openstack.org/590611 | |
| 16:12:31 | mriedem | stable core should just fast approve this https://review.openstack.org/#/q/I9435fe84c8dc8a6f35ffb195ddbf71ca34edb242+status:open | |
| 16:12:42 | mriedem | it avoids us running the ironic job on docs-only changes in stable | |
| 16:17:45 | mdbooth | cfriesen: Are you in the US, btw? | |
| 16:18:44 | mdbooth | cfriesen: The evacuate anti-affinity bug again: https://review.openstack.org/#/c/605436/ now with support for max_server_per_host | |
| 16:18:56 | mdbooth | That actually made it a bit simpler :) | |
| 16:19:17 | mdbooth | I feel like we're squashing quite a lot of evacuate bugs | |
| 16:20:25 | mdbooth | cfriesen: Apologies, Canada. Of course I knew that... | |
| 16:20:45 | mdbooth | I had it in my head you were in the UK for some bizarre reason. | |
| 16:21:43 | mriedem | ocata-em call to arms email sent | |
| 16:22:40 | cfriesen | mdbooth: no worries, we have the same queen. :) | |
| 16:22:48 | mdbooth | Incidentally, as a bonus the above patch will also correctly handle multiple builds from the same anti-affinity group sent to a single compute. Previously they could all be rejected, now it will always allow max_server_per_host to succeed | |
| 16:23:40 | mdbooth | That's builds in addition to rebuilds | |
| 16:31:26 | mdbooth | Is there some documentation somewhere of the query language used by logstash? | |
| 16:31:44 | mdbooth | This was what got me last time I tried to use this. | |
| 16:31:48 | cfriesen | mdbooth: do we still need the nested contexts given we're basically doing refcounting? I mean, it's an elegant way to ensure we call builders.remove(instance.uuid) but we could presumably also do that other ways. Just wondering if it'd end up being less code churn. | |
| 16:32:32 | mdbooth | cfriesen: I'd strongly prefer to keep the nested contexts | |
| 16:32:49 | mdbooth | Otherwise you'll end up having disjoint code, which is a maintenance nightmare | |
| 16:33:07 | mdbooth | and we have enough of it already | |
| 16:34:10 | mdbooth | cfriesen: Consider all the error cleanup edge cases you'd have to consider | |
| 16:34:17 | cfriesen | fair enough...just thought I'd mention it | |
| 16:35:46 | mdbooth | Incidentally, it also makes sense to do this test *before* taking a claim, as it's really scheduler take 2 | |
| 16:37:54 | cfriesen | arguably both the claim and the affinity validation are both scheduler take 2. | |
| 16:38:37 | cfriesen | but sure, it'd be less wasted work to check affinity first | |
| 16:41:56 | mdbooth | afaict the syntax documented here is wrong: https://docs.openstack.org/infra/system-config/logstash.html#query-logstash | |
| 16:42:18 | mdbooth | I can't make any @message query return anything | |
| 16:43:10 | mdbooth | @fields.loglevel:"ERROR" returns nothing | |
| 16:43:23 | mdbooth | ...which is nice. We have no errors :) | |
| 16:45:22 | mdbooth | Similarly striking out here: https://www.elastic.co/guide/en/kibana/3.0/queries.html | |
| 16:48:40 | mdbooth | Ah, ha! Drop the @ seems to work | |
| 17:11:46 | melwitt | mriedem_lunch: roger copy | |
| 17:19:55 | openstackgerrit | Jack Ding proposed openstack/nova master: Handle missing marker during online data migration https://review.openstack.org/605164 | |
| 17:37:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Rewrite the console doc https://review.openstack.org/606148 | |
| 17:38:12 | finucannot | melwitt, mriedem_lunch: You two might be interested in that ^ | |
| 17:38:55 | melwitt | ack | |
| 17:55:11 | mriedem | easy fix needs a +W https://review.openstack.org/#/c/605748/ | |
| 18:12:05 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Null out instance.availability_zone on shelve offload https://review.openstack.org/606155 | |
| 18:15:13 | imacdonn | mriedem: Fix merged in os-brick that will hopefully address https://bugs.launchpad.net/nova/+bug/1732199 - thing is, I'm not sure where zuul gets os-brick from - it appears to be using /usr/local/lib/python2.7/dist-packages/os_brick, so not sure if it needs a release | |
| 18:15:13 | openstack | Launchpad bug 1732199 in OpenStack Compute (nova) "test_extend_attached_volume fails with Unexpected compute_extend_volume result 'Error'" [Medium,Confirmed] | |
| 18:20:49 | mriedem | imacdonn: yes nova can't use it until it's released and upper-constraints has that new version | |
| 18:21:22 | mriedem | imacdonn: so probably work with jungleboyj to see when he's ready to do a new os-brick release | |
| 18:21:45 | jungleboyj | :-) | |
| 18:22:03 | jungleboyj | imacdonn: I can look at doing that. | |
| 18:22:16 | jungleboyj | It will cost you a beer though. ;-) | |
| 18:22:17 | imacdonn | mriedem jungleboyj: OK. We might want to let this soak a little bit ... I think Gorka was a bit apprehensive about the fix | |
| 18:22:58 | mriedem | wfm, | |
| 18:22:59 | jungleboyj | imacdonn: Ok, want to put it on next week's meeting agenda and we can see how things look then? | |
| 18:23:05 | mriedem | it's been a latent issue since queens | |
| 18:23:28 | mriedem | note that nothing will be using this in CI until it's released and in upper-constraints | |
| 18:23:33 | mriedem | so i'm not sure how you're going to soak it in | |
| 18:23:43 | mriedem | well, except os-brick CI itself | |
| 18:23:48 | jungleboyj | mriedem: Oh, good point. | |
| 18:24:00 | imacdonn | yeah, I was just pondering that too | |
| 18:24:38 | imacdonn | I just I'd at least want to give Gorka a chance to object before a release is made | |
| 18:24:44 | imacdonn | I guess* | |