| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-09-26 | |||
| 12:35:44 | sean-k-mooney | mdbooth: ya we already have this https://github.com/openstack/nova/blob/957f4818b0d89cd71552effb8b5a5b231a68de7b/nova/test.py#L79-L85 so i think its fine to add the same for null | |
| 12:35:45 | jroll | you could also blame it on py2 not being dead yet :P | |
| 12:36:28 | mdbooth | jroll: py2 was a vibrant language with bazillions of lines written. Why kill it and create a new language at all? | |
| 12:37:42 | mdbooth | Fortunately that community has more sense | |
| 12:40:05 | mdbooth | Argh, contextlib.nested() went away in py3 | |
| 12:40:23 | mdbooth | And the new with syntax doesn't support composition | |
| 12:41:13 | sean-k-mooney | mdbooth: i mean if i had the choice then i would depercate C in favor of c++ but that ship has sailed | |
| 12:41:55 | mdbooth | sean-k-mooney: Indeed. The python answer to that was to fire a missile at the departed ship over the horizon anyway. | |
| 12:45:06 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable nested allocation candidates in scheduler https://review.openstack.org/585672 | |
| 12:46:59 | openstackgerrit | Chen proposed openstack/nova master: doc: update availability zone doc https://review.openstack.org/605306 | |
| 12:48:44 | mdbooth | Oh, ffs. contextlib.ExitStack looks like what I want, but it's py3 only | |
| 12:54:32 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use provider tree in virt FakeDriver https://review.openstack.org/604083 | |
| 12:58:44 | efried | mdbooth: No. I've just hit it a bazillion times. | |
| 12:59:45 | mdbooth | efried: I can see a relatively simple solution, but I'm currently trying to formulate a syntax which would work in both py2 and py3 | |
| 13:00:20 | mdbooth | efried: Not related to the other thing I'm working on, btw | |
| 13:00:58 | mdbooth | Amusingly, the bug is called out explicitly in a comment to the other caller of _validate_instance_group_policy: | |
| 13:01:03 | efried | mdbooth: what are you trying to do? | |
| 13:01:05 | mdbooth | # NOTE(russellb) It's important that this validation be done | |
| 13:01:05 | mdbooth | # *after* the resource tracker instance claim, as that is where | |
| 13:01:05 | mdbooth | # the host is set on the instance. | |
| 13:01:19 | mdbooth | efried: Have an optional context manager | |
| 13:01:37 | efried | optional based on what? | |
| 13:01:47 | mdbooth | Whether or not a lock is required | |
| 13:02:21 | efried | can't you have the context manager itself contain the condition? | |
| 13:02:56 | efried | @contextmanager | |
| 13:02:56 | efried | def cm(...): | |
| 13:02:56 | efried | yield | |
| 13:02:56 | efried | if lock_required: | |
| 13:02:56 | efried | do things | |
| 13:02:57 | efried | ? | |
| 13:03:09 | mdbooth | Then I'd have to refactor that whole method to be a context manager | |
| 13:03:44 | efried | or the callers? | |
| 13:03:44 | efried | if lock_required: | |
| 13:03:44 | efried | with cm: | |
| 13:03:44 | efried | do things | |
| 13:03:45 | efried | else: | |
| 13:03:45 | efried | do things | |
| 13:03:45 | efried | ? | |
| 13:04:50 | mdbooth | efried: Anyway, there are a bunch of obvious ways to do this. It's frustrating that they're all ugly though as they're deprecated/removed in py2 and not available in py3, or available only in py2 | |
| 13:04:53 | mdbooth | py3 even | |
| 13:05:03 | efried | okay | |
| 13:05:15 | efried | I'm sure I'll understand better when I see it | |
| 13:05:30 | mdbooth | Some language/library designers failed to consider their users | |
| 13:05:39 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Block automatic transport_url update for cell0 https://review.openstack.org/605414 | |
| 13:08:26 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Skip more rebuild tests for cells v1 job https://review.openstack.org/605416 | |
| 13:08:38 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Block automatic transport_url update for cell0 https://review.openstack.org/605414 | |
| 13:08:48 | edleafe | mdbooth: more likely is that someone proposed the ExitStack addition after py2 was put into maintenance mode. The mistake was OpenStack starting with py2 just because some vendors didn't distribute py3 yet | |
| 13:08:59 | sean-k-mooney | mdbooth: well to be fair they have said they will continue to support it byond 2020 if enough people have not migrated to py3 earlier this year and python3 is 10 years old in december so we have had time to stop using it | |
| 13:09:36 | mdbooth | edleafe: py3 wasn't a safe choice in 2010 :/ | |
| 13:09:48 | edleafe | Sure it was | |
| 13:10:01 | sean-k-mooney | mdbooth: it was not in 2010 but it was in 2014 when 3.4 shipped | |
| 13:10:01 | mdbooth | Ok | |
| 13:10:10 | edleafe | It's just that Ubuntu didn't include it by default, and Xen required py2.4 | |
| 13:10:26 | mdbooth | edleafe: That's 2 reasons right there | |
| 13:10:40 | mdbooth | There were many, many more | |
| 13:10:52 | edleafe | Right, so it isn't python that's the issue; it's the vendors dragging their butts | |
| 13:11:07 | mdbooth | And libraries | |
| 13:11:18 | sean-k-mooney | mdbooth: yes but at this point its well past the time that libary mantains can claim they did not have time to migrate. | |
| 13:11:47 | edleafe | It's chicken-and-egg: if big projects like OpenStack adopt py3, vendors would have motivation to update. If they stay with py2, well, why bother | |
| 13:11:54 | stephenfin | sean-k-mooney: http://py3readiness.org/ | |
| 13:12:00 | mdbooth | edleafe: It was a brand new language which had been around a little over a year whose future was not assured, not least because it marked an epoch in the language. | |
| 13:12:17 | mdbooth | I'd go so far as to say it would have been an insane choice in 2010 | |
| 13:12:22 | sean-k-mooney | almost there what are teh last 11 | |
| 13:13:09 | sean-k-mooney | stephenfin: nothing too critical bar may uwsgi | |
| 13:13:22 | stephenfin | sean-k-mooney: Aye, and I'd imagine that's wrong | |
| 13:13:30 | stephenfin | assuming uWSGI isn't dead | |
| 13:13:44 | stephenfin | https://uwsgi-docs.readthedocs.io/en/latest/Python.html#python-3 | |
| 13:13:46 | sean-k-mooney | stephenfin: was just going to say i assume its outdated | |
| 13:14:29 | stephenfin | Yup https://github.com/unbit/uwsgi/blob/master/setup.py | |
| 13:14:48 | sean-k-mooney | stephenfin: im surprised entrypoints is not updated. | |
| 13:15:15 | sean-k-mooney | stephenfin: has that been pulled into setuptools | |
| 13:15:28 | stephenfin | I don't know that is. We use pkg_resources (or whatever it's called) from setuptools | |
| 13:15:39 | stephenfin | sean-k-mooney: Yeah, I think so. Not sure what that is, tbh | |
| 13:16:35 | stephenfin | Looks like pykube also supports it so that's also wrong https://github.com/kelproject/pykube/blob/master/setup.py#L16-L19 | |
| 13:16:57 | sean-k-mooney | aprarently 200 ish lines of code that has not been update in a while https://github.com/takluyver/entrypoints/blob/master/entrypoints.py#L1 | |
| 13:18:20 | stephenfin | Which also supports Python 3 https://github.com/takluyver/entrypoints/blob/master/flit.ini | |
| 13:18:59 | stephenfin | (they use https://github.com/takluyver/flit) | |
| 13:21:46 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run ServerMovingTests with nested resources https://review.openstack.org/604084 | |
| 13:36:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs https://review.openstack.org/604125 | |
| 13:42:12 | openstackgerrit | Brin Zhang proposed openstack/nova master: Specifies the storage backend to boot instance https://review.openstack.org/579360 | |
| 13:45:46 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands https://review.openstack.org/487405 | |
| 13:45:47 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Remove IPTools deprecated implementation https://review.openstack.org/605422 | |
| 13:46:00 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Block automatic transport_url update for cell0 https://review.openstack.org/605414 | |
| 13:51:51 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_spec.RequestGroup versioned object https://review.openstack.org/568840 | |
| 14:02:26 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec https://review.openstack.org/567267 | |
| 14:10:07 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth related standard resource classes https://review.openstack.org/570847 | |
| 14:22:33 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add hide server address tests in test_serversV21.py https://review.openstack.org/605435 | |
| 14:24:17 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix a race evacuating instances in an anti-affinity group https://review.openstack.org/605436 | |
| 14:24:43 | openstackgerrit | Merged openstack/nova master: Consumer gen: remove_provider_from_instance_allocation https://review.openstack.org/591784 | |
| 14:25:05 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Remove IPTools deprecated implementation https://review.openstack.org/605422 | |
| 14:25:09 | mdbooth | efried: Lets see if ^^^ passes tests. | |
| 14:25:32 | stephenfin | bauzas, mriedem, tonyb: Could one of you do me a solid and abandon these unnecessary stable requirements patches? They're around since forever https://review.openstack.org/#/c/493146/ https://review.openstack.org/#/c/490256/ | |
| 14:25:40 | mdbooth | efried: NB: it's not central to what I'm working on, and I don't really care what colour the bike shed is. If it doesn't merge, I'll still sleep like a baby. | |
| 14:25:49 | bauzas | stephenfin: sure, lemme look | |
| 14:26:04 | bauzas | stephenfin: thanks for helping me to do something else but writing UTs :p | |
| 14:26:13 | stephenfin | You're...welcome? :) | |
| 14:26:26 | stephenfin | bauzas: Oh, and this one https://review.openstack.org/#/c/543705/ | |
| 14:26:56 | bauzas | stephenfin: wait | |
| 14:27:17 | bauzas | stephenfin: if I'm abandoning a bot change, will the bot be able to give us another change? | |
| 14:27:33 | stephenfin | bauzas: I think that bot is dead now? | |