| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-09-06 | |||
| 14:03:15 | mriedem | need a re-+2 on https://review.openstack.org/#/c/599744/ | |
| 14:03:41 | mriedem | alex_xu: or you can proxy gibi's +2 and approve ^ since he was +2 before i removed the try/except stuff | |
| 14:04:37 | openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | |
| 14:05:39 | dansmith | mriedem: so that online migration has to be removed when the split happens yeah? | |
| 14:07:20 | mriedem | dansmith: yup | |
| 14:07:30 | mriedem | i don't know how we're going to do those | |
| 14:07:31 | dansmith | ah, I guess this is all within placement tables anyway? | |
| 14:07:39 | mriedem | yeah | |
| 14:07:41 | dansmith | I was thinking this had to cross-reference nova and placement things | |
| 14:07:58 | dansmith | okay, so placement'll need a way to trigger this beyond that I suppose | |
| 14:08:35 | cdent | i've started some _very_ hand-wavey motions in the direction of a placement-manage | |
| 14:09:01 | mriedem | cdent: efried: the reshaper item ~L269 in https://etherpad.openstack.org/p/nova-ptg-stein should probably move to the retrospective etherpad? | |
| 14:09:06 | mriedem | it's more of a retrospective item right? | |
| 14:09:55 | efried | mriedem: okay | |
| 14:10:07 | sahid | efried: i shared my idea | |
| 14:10:10 | efried | which, if we do that, will let cdent keep the reins | |
| 14:10:10 | cdent | yeah, I think that existed before the retro etherpad did. and the retro etherpad needs friends | |
| 14:12:12 | mriedem | so i guess i'll move it | |
| 14:12:30 | mriedem | done | |
| 14:12:57 | efried | thanks matt | |
| 14:22:38 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: Fix resource tracker updates during instance evacuation https://review.openstack.org/600425 | |
| 14:29:07 | stephenfin | efried: We shouldn't be dropping 'default' on that patch https://review.openstack.org/#/c/592243/ | |
| 14:38:32 | openstackgerrit | sean mooney proposed openstack/nova master: add caching to _build_regex_range https://review.openstack.org/599071 | |
| 14:42:11 | sean-k-mooney | efried: alex_xu ^ i have made this use just a dictonry as a cache. im still getting a reasonable speedup, we may want to consider going to the global cache at a later point but this is simpler solution for now | |
| 14:52:40 | mriedem | oh boy the age old "should every commit be deployable" question is being debated in the tc channel | |
| 14:53:50 | melwitt | recently penick was talking about having a new cluster that deploys trunk | |
| 15:00:19 | efried | stephenfin: The problem with the default being [] is that it makes you think you can use square brackets to define a list, which you can't. And back in PS2 where they were trying to fix the code so that it *would* accept square brackets, I told them to quit because we don't want to be spending more resources working on this code. Which of course we now are :( | |
| 15:01:00 | stephenfin | efried: Ah, this is the bug in the oslo.config sphinxext module, right? | |
| 15:01:10 | bauzas | efried: dansmith: mriedem: others, sorry had to leave urgently because I missed my kids at schoold | |
| 15:01:25 | bauzas | I'm fine with punting the question about PCI future at the pth | |
| 15:01:27 | bauzas | pth | |
| 15:01:29 | bauzas | shit | |
| 15:01:30 | bauzas | ptg | |
| 15:02:06 | bauzas | but my take on it is "we can do some generic device refactoring in nova, while cyborg raises up" | |
| 15:02:15 | bauzas | I don't think it's a problem to us | |
| 15:02:20 | bauzas | and the community | |
| 15:02:49 | efried | bauzas: Okay, please take a look at https://review.openstack.org/#/c/591037/ when you get a chance then. | |
| 15:03:18 | efried | stephenfin: I don't think it has to do with sphinxext | |
| 15:03:53 | efried | stephenfin: If the default is [] I would think the sphinx doc should display it as []. But that's the confusing part (to the user). | |
| 15:04:42 | mriedem | efried: btw, i don't mean to minimize your gpu/pci/cyborg thing, i was just airing out my anxiety over the amount of stuff we have loaded up | |
| 15:04:58 | mriedem | which mostly makes me want to crawl in a hole | |
| 15:07:19 | efried | mriedem: Duly noted. But I should point out that I am expected to be making certain things happen to the benefit of those who sign my paycheck. I.e. I'm not totally free to work on a thing just because it's deemed a priority for nova-at-large, if that is to the exclusion of working on a thing that's a slightly-lesser-priority-for-nova-but-#1-priority-for-employer. | |
| 15:07:56 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Configure placement DB context manager for nova-manage/status https://review.openstack.org/600464 | |
| 15:07:57 | mriedem | efried: yup i know, same here | |
| 15:08:53 | bauzas | heh, we're all on the same boat | |
| 15:09:05 | dansmith | heh | |
| 15:09:32 | bauzas | or you would see me more often | |
| 15:16:42 | mriedem | well, | |
| 15:16:48 | mriedem | we don't all get august off... | |
| 15:26:23 | bauzas | mriedem: touché, my point being on the 45 other weeks :p | |
| 15:30:29 | efried | stephenfin: Hm, actually it looks like there *is* a sphinx bug https://docs.openstack.org/nova/latest/configuration/config.html#pci <== the default is showing up as u'' here | |
| 15:31:08 | efried | I mean, it's still confusing if you're looking at the source; not sure how many admins do that vs looking at the html. | |
| 15:31:13 | efried | and if that bug gets fixed... | |
| 15:33:34 | dansmith | mriedem: looks like the latest rev of the configurable instance list behavior is failing unit tests | |
| 15:33:54 | dansmith | she's out until next week, but maybe we can get that landed then, if I don't get a chance to fix some trivial test failure before then | |
| 15:34:17 | mriedem | landed in denver you mean? | |
| 15:34:20 | mriedem | i saw the tests failing | |
| 15:35:22 | dansmith | landed in denver yeah | |
| 15:36:34 | dansmith | hmm, it's in the middle of her stack now, | |
| 15:36:38 | dansmith | which is probably why it's breaking | |
| 15:36:47 | dansmith | I dunno why | |
| 15:36:58 | dansmith | why it's in the middle I mean | |
| 15:50:18 | cdent | sigh, how we supposed to think about forum when the ptg hasn't even happened yet? | |
| 15:50:35 | mriedem | guh so https://review.openstack.org/#/c/585475/ is still failing | |
| 15:51:06 | mriedem | gmann: do you have any ideas on the tempest test failing your change https://review.openstack.org/#/c/585475/ ? | |
| 15:51:39 | mriedem | cdent: oh that's easy | |
| 15:52:09 | mriedem | nova at the edge, LTS releases, API v3, <insert generic thing that will never amount to anything> | |
| 15:52:22 | mriedem | oh FFU | |
| 15:52:27 | mriedem | can't forget FFU | |
| 15:52:33 | mriedem | FFU & U! | |
| 15:53:02 | mriedem | well, i can't say they won't amount to anything, they will amount to SIG formation where those SIGs don't do anything | |
| 16:04:51 | mriedem | melwitt: looks like we need a rocky series for novaclient bug tracking https://launchpad.net/python-novaclient | |
| 16:05:19 | melwitt | mriedem: oh, I missed that | |
| 16:05:44 | melwitt | poor ol novaclient | |
| 16:06:40 | melwitt | need to do all our libs actually | |
| 16:12:55 | melwitt | mriedem: added rocky and stein to novaclient | |
| 16:13:35 | mriedem | thanks | |
| 16:16:06 | openstackgerrit | Eric Fried proposed openstack/nova master: fup: Fix import order and test nit https://review.openstack.org/600474 | |
| 16:18:11 | melwitt | looks like the other libs (os-traits, os-vif, placement-osc-plugin) just follow "trunk" and no series needed? it's not consistent | |
| 16:26:55 | nicolasbock | Hi, say I was hit by https://bugs.launchpad.net/nova/+bug/1709902 and have a few VMs now that are running somewhere where they are not supposed to | |
| 16:26:55 | openstack | Launchpad bug 1709902 in OpenStack Compute (nova) "source host allocation not cleaned up in placement after evacuation" [Medium,Fix released] - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 16:27:25 | nicolasbock | How would I get them to be correctly registered again? | |
| 16:36:48 | stephenfin | efried: Sorry, was on a call (and follow-ups). Yeah, I think you mentioned that issue before to me, hence why I brought it up again | |
| 16:37:18 | efried | stephenfin: It didn't sound familiar, so if I brought it up, I purged the memory. | |
| 16:37:52 | efried | stephenfin: See latest comment, not sure where to go from here. Back to PS2, or put really awkward words in, or <something else>...? | |
| 16:38:18 | stephenfin | efried: But, as you've summarized on the review, using that default is the correct thing to do. Confusingly, the default reflects the _processed_ result, i.e. once oslo.config has gone and merged all those disparate 'alias' values into one list | |
| 16:38:59 | stephenfin | efried: I'm also not 100% sure that the bug upstream is a bug as it's hiding the above fact from the user | |
| 16:39:29 | efried | Well, the bug just complains that you break if you use square brackets. Which is true. | |
| 16:39:31 | stephenfin | efried: The changes they've made to the help text are valid and should be retained. It's just the changes to default that need to be removed | |
| 16:39:43 | stephenfin | efried: In nova.conf? | |
| 16:39:49 | efried | yeah | |
| 16:40:06 | efried | it breaks when we try to process it. | |
| 16:40:12 | efried | not an oslo problem, a nova problem. | |
| 16:40:14 | stephenfin | efried: Yeah, then our docs are wrong. We never supported use of list values for that option | |
| 16:40:22 | stephenfin | Yup, a nova docs problem | |
| 16:41:08 | stephenfin | Fixing this by adding processing of lists would be a feature, not a bug fix, as you've pointed out. Fixing it by correcting the docs, on the other hand, is a must do | |
| 16:43:09 | stephenfin | efried: That make sense? | |
| 16:43:59 | efried | stephenfin: Yeah, I get it. And their add definitely helps. But don't you feel like we should mention that you *can't* use a square-bracket list, despite the fact that the default makes it look like you can? | |
| 16:44:31 | stephenfin | efried: The default in the code but not the docs. I think a comment would be a-ok | |
| 16:45:36 | stephenfin | I wouldn't put it into the docstring since that's going to show up in the HTML docs and nova.conf templates, neither of which will actually have that default | |