Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-08-26
19:48:23 openstackgerrit Surya Seetharaman proposed openstack/nova master: Return a minimal construct for nova list when a cell is down https://review.openstack.org/567785
19:48:24 openstackgerrit Surya Seetharaman proposed openstack/nova master: Return a minimal construct for nova show when a cell is down https://review.openstack.org/591658
19:48:25 openstackgerrit Surya Seetharaman proposed openstack/nova master: Return a minimal construct for nova service-list when a cell is down https://review.openstack.org/584829
21:18:42 openstackgerrit Surya Seetharaman proposed openstack/nova master: API microversion bump for handling-down-cell https://review.openstack.org/591657
22:05:30 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153
22:05:50 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (6) https://review.openstack.org/571330
22:06:04 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7) https://review.openstack.org/571992
22:06:29 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8) https://review.openstack.org/571993
22:06:55 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in test_compute_api.py (4) https://review.openstack.org/568462
#openstack-nova - 2018-08-27
01:55:31 openstackgerrit Takashi NATSUME proposed openstack/nova master: Transform volume.usage notification https://review.openstack.org/580345
01:55:55 openstackgerrit Takashi NATSUME proposed openstack/nova master: Transform libvirt.error notification https://review.openstack.org/484851
02:35:31 openstackgerrit Tsuyoshi Nagata proposed openstack/nova master: Fix nova can handle device name length more widely for universally. https://review.openstack.org/573066
05:34:21 openstackgerrit Merged openstack/python-novaclient stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/586364
05:34:21 openstackgerrit Merged openstack/python-novaclient stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky https://review.openstack.org/586365
06:02:13 openstackgerrit Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289
07:22:10 openstackgerrit Tsuyoshi Nagata proposed openstack/nova master: [nova] increasing the number of allowed volumes attached per instance > 26 https://review.openstack.org/567472
08:04:08 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104
08:44:45 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: PoC: Support exclusive traits https://review.openstack.org/596669
08:55:15 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter https://review.openstack.org/591976
09:07:51 openstackgerrit Surya Seetharaman proposed openstack/nova master: Add scatter-gather-single-cell utility https://review.openstack.org/594947
09:45:39 lennyb_ #openstack-horizon,#openstack-dib,#openstack-infra,#openstack-ironic,#openstack-meeting,#openstack-meeting-alt,#openstack-neutron,#openstack-nova,#openstack-qa,#openstack-release,#openstack-third-party-ci,#rdo,#zuul,#openstack-cinder,#opendaylight,#opendaylight-integration ,#tripleo
10:30:08 openstackgerrit Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211
10:46:11 openstackgerrit Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299
10:55:28 openstackgerrit Merged openstack/nova master: api: Remove unnecessary default parameter https://review.openstack.org/564451
11:29:00 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: PoC: Support exclusive traits https://review.openstack.org/596669
12:01:18 openstackgerrit Stephen Finucane proposed openstack/nova master: [nova] increasing the number of allowed volumes attached per instance > 26 https://review.openstack.org/567472
12:56:10 openstackgerrit Surya Seetharaman proposed openstack/nova master: Making instance listing skipping down cells configurable https://review.openstack.org/592428
13:14:38 moshele shaid: hi
13:14:49 moshele sahid: hi
13:15:03 moshele sahid: I reply to you comment on https://review.openstack.org/#/c/595592/
13:15:15 moshele sahid: let me know what you think
13:23:54 tssurya dansmith: if the change in instance_list here (https://review.openstack.org/#/c/567785/10/nova/compute/instance_list.py) is what you had in mind and if you are kind of okay, I can proceed to amending the tests..
13:24:12 tssurya mriedem: updated https://review.openstack.org/#/c/592428/
13:27:34 openstackgerrit Chris Dent proposed openstack/nova master: DNM: Make nova tests pass with externalized placement https://review.openstack.org/596291
13:33:27 dansmith tssurya: yep, makes sense
13:39:46 openstackgerrit Chen proposed openstack/nova master: Update volume-attachment API url in policies https://review.openstack.org/596726
13:42:59 openstackgerrit Konstantinos Samaras-Tsakiris proposed openstack/nova-specs master: Placement model for passthrough devices https://review.openstack.org/591037
13:44:39 openstackgerrit Dan Smith proposed openstack/nova master: Make instance_list perform per-cell batching https://review.openstack.org/593131
13:44:40 openstackgerrit Dan Smith proposed openstack/nova master: Record cell success/failure/timeout in CrossCellLister https://review.openstack.org/594265
13:44:41 openstackgerrit Dan Smith proposed openstack/nova master: Optimize global marker re-lookup in multi_cell_list https://review.openstack.org/594577
13:49:02 mnaser yaaaay
13:49:13 mnaser did you know the cinder section in nova still uses os_region_name and not region_name
13:49:22 mnaser that was a fun exercise.
13:50:01 mnaser and then even when fixing it, i had no idea why it didn't work, turns out service catalog and stuff was being cached
13:50:26 openstackgerrit Eric Fried proposed openstack/nova master: [placement] split gigantor SQL query, add logging https://review.openstack.org/590041
13:50:47 efried nova-scheduler meeting in 10 minutes in #openstack-meeting-alt
13:50:54 sean-k-mooney mnaser: seams ligit. we cache alot of things
13:51:52 mnaser sean-k-mooney: yeah it was a fun exercise in debugging
13:51:59 mnaser attaching a volume where it 404s on the attachemnt :p
14:18:20 openstackgerrit Konstantinos Samaras-Tsakiris proposed openstack/nova-specs master: Placement model for passthrough devices https://review.openstack.org/591037
14:33:47 mriedem stephenfin: have you seen this? http://status.openstack.org/elastic-recheck/#1788922
14:34:03 mriedem we have a new gate failure which started friday after the func test refactor changes landed for the libvirt func test base
14:34:14 mriedem looks like some directories are not getting mocked now and fail in certain node providers
14:34:24 stephenfin mriedem: I had not but I'll look into it now
14:35:46 openstackgerrit Merged openstack/nova master: List instances from all cells explicitly https://review.openstack.org/593717
15:02:41 sahid moshele: i replied
15:34:25 openstackgerrit sahid proposed openstack/nova master: hardware: fix memory check usage for small/large pages https://review.openstack.org/532168
15:34:58 openstackgerrit Stephen Finucane proposed openstack/nova master: privsep: Handle ENOENT when checking for direct IO support https://review.openstack.org/596815
15:35:24 stephenfin mriedem: ^^ I suspect you're going to dislike that, but I can't find any reason that those refactor patches would have caused the CI failures
15:40:28 mriedem stephenfin: ok question inline
15:40:34 mriedem maybe something switched over to py3 on friday?
15:41:23 dansmith shouldn't we be mocking that out for functional tests anyway?
15:42:14 dansmith we wouldn't want a functional test to behave differently if I run it on a weird filesystem...
15:44:01 sean-k-mooney dansmith: well if nova would behave qually weridly maybe we would
15:44:11 sean-k-mooney *equally
15:44:53 dansmith we can test for both/all cases and make sure we handle it
15:45:03 dansmith but anything dependent on the system we're running on belongs in integration tests, IMHO
15:45:24 dansmith otherwise we're saying we expect you can't run functional tests on weird platforms, which I think goes against the intent there
15:46:07 sean-k-mooney dansmith: i really thing mocking in functional test should ideally be as minimal as possible but that said it really depend on what the functional test is testing
15:47:06 dansmith sean-k-mooney: per-test mocking for sure, but I think that if functional tests run differently on the gate depending on which cloud provider, and different on dev boxes because we're using different distros, platforms, filesystems, etc that's not super helpful
15:47:17 sean-k-mooney dansmith: the main delta from me between a integration test and fuctional test is that for functual tests we mock other services
15:47:43 sean-k-mooney dansmith: ya i agree with that point
15:47:43 dansmith sean-k-mooney: it's why we don't use real libvirt in functional, right? because then you couldn't run the functional tests on other platforms
15:48:02 stephenfin dansmith: I thought it was because libvirt was another service, so to speak
15:48:39 mriedem stephenfin: no, it's because i shouldn't have to install libvirt to run unit tests
15:48:50 mriedem like, i don't need a vcenter installed locally to run vmware tests
15:48:51 sean-k-mooney mriedem: unit test yes
15:49:01 sean-k-mooney mriedem: fucntional test i would argue you should
15:49:21 sean-k-mooney mriedem: that is if the fucntional test is testing the libvirt driver
15:49:30 dansmith to me, our functional tests have minimal mocking so that we test large strings of nova together instead of mocking out everything above/below,
15:49:36 dansmith but they're still highly synthetic
15:49:40 sean-k-mooney mriedem: if its testing the compute manager then no. you should not need libvirt installed
15:50:36 stephenfin dansmith: Yeah, fair. Still think this is a valid fix though. Unless that particular platform couldn't even run libvirt, it's conceivable that someone using it in production would see this issue
15:51:14 dansmith stephenfin: not arguing that it's not valid
15:52:33 stephenfin "we wouldn't want a functional test to behave differently if I run it on a weird filesystem.." I figured we _would_ want it to behave differently
15:52:57 dansmith what happens if you run functional on windows?
15:53:10 sean-k-mooney stephenfin: is the filesystem logic germain to the functunality you are testing
15:53:16 stephenfin again, assuming that weird filesystem could conceivably be used in production
15:53:28 stephenfin Hmm, does libvirt work on Windows?
15:53:38 sean-k-mooney stephenfin: it can manage hyperv
15:53:44 stephenfin If not, these whole things should be marked with skipIf
15:53:55 sean-k-mooney stephenfin: not sure if it runs on windows in that case
15:53:59 dansmith stephenfin: is this using real libvirt? if not, then I'm not sure why that matters
15:54:14 stephenfin sean-k-mooney: Correction. Does nova+libvirt work on Windows?
15:55:17 sean-k-mooney stephenfin: its not support but it would proably run
15:55:43 dansmith stephenfin: are you saying that people shouldn't be able to run nova unit and functional tests of the libvirt driver on windows?
15:55:56 dansmith or any other platform where libvirt doesn't exist or is hard to get a dev environment for?
15:56:03 mriedem so i'm mostly just interested in finding out what regressed on friday
15:56:07 stephenfin dansmith: I think I am
15:56:10 stephenfin :)

Earlier   Later