| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-23 | |||
| 14:57:10 | sahid | a even less impacting solution is to reproduce what is done https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L153 | |
| 14:57:22 | sahid | for rx/tx queue block | |
| 15:00:14 | kosamara | Continuing from the meeting on https://review.openstack.org/#/c/579897 | |
| 15:01:12 | jaypipes | stephenfin: you fixing up https://review.openstack.org/#/c/595802/? | |
| 15:01:27 | stephenfin | jaypipes: as we speak | |
| 15:01:54 | kosamara | dansmith: I don't propose a new knob actually. The same condition that triggers "hide_hypervisor_id" will additionally hide the hyperv signature, if it's a windows guest. | |
| 15:02:20 | melwitt | sahid: ack | |
| 15:02:42 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove noisy DEBUG log https://review.openstack.org/595810 | |
| 15:02:54 | gibi | edmondsw, mriedem: ^^ | |
| 15:02:54 | dansmith | kosamara: okay I see, my mistaked | |
| 15:02:58 | kosamara | this is functionality that the "hide_hypervisor_id" feature already promises, but currently doesn't work for Windows guests. | |
| 15:03:28 | dansmith | kosamara: I think that we probably shouldn't have that feature, but that's just MHO and I'm wrong a lot. Also, I'm a terrible person. | |
| 15:03:58 | jaypipes | stephenfin: ack. cuz me likey that series. | |
| 15:04:04 | kosamara | dansmith: Self-sarcasm is usually a sign to the opposite :P | |
| 15:04:15 | mriedem | edmondsw: https://bugs.launchpad.net/nova/+bug/1788634/comments/3 | |
| 15:04:15 | openstack | Launchpad bug 1788634 in OpenStack Compute (nova) "Noisy DEBUG log: Defaulting the value of the field 'numa_membw_values' to None in MetricPayload" [Low,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 15:04:17 | jaypipes | kosamara: like dansmith I am also a terrible person. | |
| 15:04:30 | jaypipes | kosamara: and no, we're not being sarcastic, :P | |
| 15:06:20 | mriedem | edmondsw: tl;dr the object changes were added for the numa bw metric but the implementation wasn't | |
| 15:06:39 | mriedem | b/c we decided around the time of the newton midcycle meeting that nova as a stats gatherer was dumb | |
| 15:06:50 | edmondsw | mriedem got it | |
| 15:06:55 | edmondsw | tx for the history | |
| 15:07:00 | mriedem | and that field likely shouldn't be in the notification payload | |
| 15:07:04 | mriedem | now that you mention it | |
| 15:07:20 | mriedem | but dropping it would be a major version bump i think - gibi agree? | |
| 15:07:31 | edmondsw | mriedem gibi so should the solution be to remove the log statement or to remove numa_membw_values from the schema? | |
| 15:07:38 | gibi | mriedem: yepp, I was in the process of typing this comment | |
| 15:07:52 | edmondsw | or to keep it in the schema but start setting it to None explicitly | |
| 15:08:24 | gibi | mriedem, edmondsw: I think the notification change should be tight to the cleanup of this half done feature | |
| 15:08:27 | kosamara | jaypipes, dansmith: terrible or not, thanks a lot for the discussion. | |
| 15:08:34 | mriedem | gibi: edmondsw: looking at http://logs.openstack.org/97/579897/4/check/tempest-full/53d05dc/controller/logs/screen-n-cpu.txt.gz | |
| 15:08:41 | mriedem | "Defaulting the value of the field" shows up over 1K times | |
| 15:08:52 | mriedem | so i think the debug log should go away regardless | |
| 15:09:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Move mocking to setUp https://review.openstack.org/595802 | |
| 15:09:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Create functional libvirt test base class https://review.openstack.org/407055 | |
| 15:09:39 | mriedem | Flavor.projects is a huge one | |
| 15:09:44 | mriedem | since flavor is in all instance payloads | |
| 15:09:58 | gibi | mriedem: I agree that we need to drop the debug log | |
| 15:10:37 | gibi | mriedem: regardless of the notificaton change | |
| 15:10:44 | mriedem | +2 | |
| 15:10:48 | gibi | mriedem: or more like independently | |
| 15:11:27 | edmondsw | +1 from me | |
| 15:11:31 | ykarel | mriedem, jaypipes jroll sean-k-mooney Thanks, i commented https://bugs.launchpad.net/tripleo/+bug/1787910/comments/16, please correct if i added something wrong there | |
| 15:11:31 | openstack | Launchpad bug 1787910 in tripleo "OVB overcloud deploy fails on nova placement errors" [Critical,Triaged] - Assigned to Marios Andreou (marios-b) | |
| 15:11:33 | gibi | awesome :) | |
| 15:12:00 | jroll | ykarel: thanks! looks good to me | |
| 15:12:17 | openstackgerrit | Merged openstack/nova master: Fix nits in resource_provider.py https://review.openstack.org/588470 | |
| 15:12:30 | sean-k-mooney | mriedem: ok i finally got to a point where i could test https://review.openstack.org/#/c/594508/2. the error is still being thrown from qemu but the newroking on the vm is not broken anymore | |
| 15:13:11 | sean-k-mooney | mriedem: so that looks good to me. ill +1 it upstream | |
| 15:13:17 | mriedem | sean-k-mooney: awesome, can you note in the review so gibi can "put his love on it" or whatever he said earlier? | |
| 15:13:20 | mriedem | sean-k-mooney: thanks | |
| 15:13:36 | mriedem | i'm pretty sure gibi sexually harassed my patch | |
| 15:13:40 | edmondsw | efried https://docs.openstack.org/nova/latest/contributor/policies.html#metrics-gathering says there is "not yet a clear replacement"... is that still true, or does the placement service fill that role now? | |
| 15:13:51 | mriedem | placement doesn't gather metrics | |
| 15:14:21 | mriedem | but you could probably report metrics type things into placement to be used during nova scheduling | |
| 15:14:31 | gibi | mriedem: I think you started it ;) "* mriedem assumes gibi will love it immediately and want to +W so hard" | |
| 15:14:32 | mriedem | like the nw bw stuff gibi is working on | |
| 15:14:44 | mriedem | gibi: ha | |
| 15:15:33 | efried | "report metrics type things into placement"? mind blown | |
| 15:16:54 | gibi | I'm not sure how the available and used nw bw in placement relates to metrics but yeah | |
| 15:16:57 | sean-k-mooney | efried: metric type things? | |
| 15:17:10 | efried | sean-k-mooney: Don't look at me. It was mriedem's zany idea | |
| 15:17:46 | sean-k-mooney | i obvioulsy missed somthing while debuging my devstack setup | |
| 15:17:54 | edmondsw | efried you can probably blame me there | |
| 15:18:21 | edmondsw | I don't know that either of us were suggesting it should be done, just wondering | |
| 15:18:25 | sean-k-mooney | edmondsw: placement does not store metrics no | |
| 15:18:33 | sean-k-mooney | edmondsw: also it likely never will | |
| 15:18:47 | edmondsw | I don't really know why nova ever used metrics for scheduling | |
| 15:18:55 | mriedem | it was an ibm feature | |
| 15:18:58 | edmondsw | ha | |
| 15:19:02 | mriedem | you probably should remmeber this | |
| 15:19:06 | mriedem | i'm pretty sure it was powervc relatd | |
| 15:19:08 | mriedem | *related | |
| 15:19:13 | mriedem | sudipta biswas | |
| 15:19:14 | sean-k-mooney | edmondsw: but bandwidth based schduling is different then metric based suchduling that was keed off network usage | |
| 15:19:21 | mriedem | it was for metrics weighers | |
| 15:19:57 | jaypipes | hold up... somebody said metrics and placement in the same breath... /me perks up | |
| 15:20:09 | sean-k-mooney | edmondsw: for gibi's bandwith based schduling work we are tracking bandwidth as a consumable resouce which is exactly what placement was designed for | |
| 15:20:24 | edmondsw | sean-k-mooney yep, understood | |
| 15:20:39 | sean-k-mooney | jaypipes: yep the comment i made was that was not a thing | |
| 15:20:54 | gibi | ohh I see the relation between nw bw and metrics. If neutron would report physically used nw bw to placement that would be the metric | |
| 15:20:59 | efried | jaypipes: I'm going to tag providers with dynamic traits like CUSTOM_CPU_CYCLES_SINCE_LAST_RESET_<NNNN>, updated every periodic via update_provider_tree. | |
| 15:21:38 | sean-k-mooney | gibi: ya but we dont want to contiunally update allocation to model real usage. at would be an abuse of the datamodel in placement | |
| 15:21:48 | gibi | sean-k-mooney: totally agree | |
| 15:22:03 | gibi | sean-k-mooney: I never wanted to do that | |
| 15:23:08 | mriedem | do they sell those? | |
| 15:23:10 | sean-k-mooney | gibi: i have seen a really old poc for bandwidth based schduling using celomiter metrics in the past | |
| 15:23:21 | efried | I was expecting something along the lines of "over my cooling corpse" | |
| 15:23:44 | jaypipes | mriedem: https://www.amazon.com/Posey-Straight-Jacket-MEDIUM/dp/B001ANOR6E | |
| 15:23:44 | efried | mriedem: https://www.amazon.com/Freebily-Leather-Straitjacket-Straight-Costume/dp/B07B8KV2NQ/ref=sr_1_2?ie=UTF8&qid=1535037811&sr=8-2&keywords=straightjacket | |
| 15:23:50 | jaypipes | efried: :P | |
| 15:24:02 | sean-k-mooney | efried: what you do in the privacy of your out of tree virt driver is fine just so long as that never happens in the nova tree :) | |
| 15:24:17 | jaypipes | "Customers also bought..." section is awesome. | |
| 15:24:39 | mriedem | i suggested to my wife last night that while in berlin we should shop for something like that | |
| 15:24:48 | jaypipes | heh | |
| 15:24:49 | mriedem | b/c my german stereotype includes 80s synth music and leather | |
| 15:25:08 | efried | I like how it's other-legit-restraint other-legit-restraint kinky-s&m-thing other-legit-restraint... | |
| 15:31:08 | openstackgerrit | Chen proposed openstack/nova master: Fix create_resource_provider docstring https://review.openstack.org/595453 | |
| 15:43:46 | mriedem | so anyone that cares about this placement extract / governance thing should probably be in the tc channel as of about an hour ago | |
| 16:08:29 | openstackgerrit | Merged openstack/nova master: placement: use single-shot INSERT/DELETE agg https://review.openstack.org/592654 | |