| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-21 | |||
| 13:56:26 | tssurya | still working on filtering part | |
| 13:56:32 | dansmith | okay | |
| 13:56:36 | tssurya | but would be nice to get opinions | |
| 13:56:58 | tssurya | I have them as seperate patches for now, will squash them with the version BUMP | |
| 13:57:09 | tssurya | once we review the approach | |
| 13:57:59 | tssurya | and, mriedem: sorry about missing the instance.host None case earlier on and the backport headaches. | |
| 13:58:03 | openstackgerrit | Jiri Suchomel proposed openstack/nova stable/pike: Filter out instances without a host when populating AZ https://review.openstack.org/594184 | |
| 14:00:20 | openstackgerrit | Surya Seetharaman proposed openstack/nova stable/queens: Filter out instances without a host when populating AZ https://review.openstack.org/594185 | |
| 14:02:37 | stephenfin | mriedem: https://bugs.launchpad.net/oslo.policy/+bug/1788183 | |
| 14:02:37 | openstack | Launchpad bug 1788183 in oslo.policy "Rule description not rendered as rST" [Undecided,New] | |
| 14:04:14 | mriedem | tssurya: not your fault, we have reviewers for a reason | |
| 14:04:21 | mriedem | and i obviously missed it as well | |
| 14:04:33 | mriedem | sean-k-mooney: i think so yes | |
| 14:05:09 | mriedem | efried: why not in oslotest? because of the circular dep? | |
| 14:05:54 | efried | mriedem: And because it's... a UUID util. And because just because I can't think of a reason for it to be used outside of test, doesn't mean it can't be. See commit message. | |
| 14:06:33 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Filter out instances without a host when populating AZ https://review.openstack.org/594185 | |
| 14:07:03 | sean-k-mooney | mriedem: then in that case if you wanted to test the nova install guide, and use devstack to help, you would just have devstack install keystone,mysql, and rabbitmq. and perhapse memcached | |
| 14:07:39 | mriedem | but nova also needs neutron | |
| 14:07:46 | mriedem | and i don't want to go through the neutron install guide to test nova's install | |
| 14:07:49 | mriedem | same for glance | |
| 14:08:15 | mriedem | cue kevin fox to say it should all be one monolithic install | |
| 14:09:06 | sean-k-mooney | well i would not expect the install guide for nova to cover the glance or neutron parts | |
| 14:09:23 | sean-k-mooney | i also would not assmue you could boot a vm after finishing it | |
| 14:09:44 | sean-k-mooney | i would just assumne i had the nova compontes deployed and fuctioning | |
| 14:10:06 | sean-k-mooney | e.g. nova hypervior list should show all the resouces but openstack server create would fail | |
| 14:10:28 | mriedem | well, if i'm installing nova, i would like to be able to create a vm by the end of it | |
| 14:10:35 | mriedem | otherwise i don't know if i f'ed up the install somewhere | |
| 14:11:08 | sean-k-mooney | in that case it does have to be a multi service install guide | |
| 14:11:12 | mriedem | also, https://docs.openstack.org/nova/latest/install/controller-install-ubuntu.html#install-and-configure-components refers to the neutron install guide | |
| 14:13:19 | sean-k-mooney | i guess refering to the other guide also works. that said untill nova networks if fully dead neutron is technical not a nova depency | |
| 14:13:45 | sean-k-mooney | but i could see adding neutron to the devstack install. | |
| 14:14:24 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Filter out instances without a host when populating AZ https://review.openstack.org/594184 | |
| 14:14:46 | sean-k-mooney | glace i guess would also be required because there is no way to boot a vm otherwise. unless you used the fake drivers | |
| 14:27:42 | mriedem | jroll: pretty sure this has always been true yeah? https://bugs.launchpad.net/nova/+bug/1787509 | |
| 14:27:42 | openstack | Launchpad bug 1787509 in OpenStack Compute (nova) "Baremetal filters and default filters cannot be used simultaneously in the same nova" [Undecided,New] | |
| 14:27:47 | mriedem | until pike anyway | |
| 14:34:52 | dansmith | mriedem: so reviewing tssurya's series just now made me (re-)realize | |
| 14:35:07 | dansmith | we're still iterating all of the instances from a cell before returning them in order to do the fault stuff | |
| 14:35:29 | mriedem | dansmith: i think when you were adding instance lister, | |
| 14:35:40 | mriedem | you pre-joined faults in the db api and it didn't seem to make a difference in perf | |
| 14:35:48 | mriedem | and it might have caused some other issue | |
| 14:36:05 | dansmith | so I'm surprised we gained as much as we did by my batching, and so I wonder if we push the faults into the batches if it would help | |
| 14:36:10 | dansmith | mriedem: yeah, I remember that now | |
| 14:36:13 | mriedem | we also only show fault if the vm state is ERROR or DELETED | |
| 14:36:16 | dansmith | right | |
| 14:37:12 | mriedem | well this bug says nova list is too slow https://bugs.launchpad.net/nova/+bug/1788149 | |
| 14:37:12 | openstack | Launchpad bug 1788149 in OpenStack Compute (nova) "nova list too slow" [Undecided,New] | |
| 14:37:15 | mriedem | so there is that | |
| 14:37:57 | dansmith | heh | |
| 14:38:41 | tssurya | nice | |
| 14:41:28 | mriedem | alex_xu: did you say gmann was on vacation? https://review.openstack.org/#/c/584223/ | |
| 14:41:45 | mriedem | (8:09:57 AM) alex_xu: gmann: enjoy your vacation! | |
| 14:41:50 | tssurya | mriedem: yes untill 31st | |
| 14:42:17 | tssurya | until* | |
| 14:45:21 | sean-k-mooney | mriedem: regarding the migration issue i dont see "Binding ports to destination host" in either the source or dest compute logs | |
| 14:46:08 | sean-k-mooney | the dest does have "Plugging VIFs using destination host port bindings before live migration." and "Deleted binding for port 3218fd70-ea82-4ee1-9a5b-2d3c9d8b9fa0 and host devstack2." | |
| 14:46:47 | mriedem | the former is when we do pre_live_migration on the dest host, | |
| 14:46:54 | mriedem | at that point port bindings are still active for the source host | |
| 14:47:03 | mriedem | the latter is when we're rolling back after the failed migration | |
| 14:47:21 | mriedem | so i'm not sure that my patch would fix your issue if we never deactivated the source host bindings | |
| 14:47:42 | mriedem | that's why i was saying i'd be surprised if it fixed it b/c it would mean the failure happened after post-copy | |
| 14:47:47 | sean-k-mooney | ya. i expected to see boot. could deleteing the port bindings be the root of the issue | |
| 14:47:56 | mriedem | maybe? | |
| 14:48:09 | mriedem | maybe neutron f's up and screws up the active source host port binding? | |
| 14:48:11 | sean-k-mooney | ill apply the patch in anycase and see what happens | |
| 14:50:20 | s10 | mriedem: bug https://bugs.launchpad.net/nova/+bug/1788149 could be eventlet related and maybe caused by nova-neutron connection on every nova show/nova list (https://bugs.launchpad.net/nova/+bug/1567655) | |
| 14:50:20 | openstack | Launchpad bug 1788149 in OpenStack Compute (nova) "nova list too slow" [Undecided,Incomplete] | |
| 14:50:22 | openstack | Launchpad bug 1567655 in OpenStack Compute (nova) "500 error when trying to list instances and neutron-server is down" [Medium,Confirmed] | |
| 14:51:00 | mriedem | s10: hmm yeah good point re eventlet | |
| 14:51:13 | mriedem | also if they are running nova-api via wsgi in pike we aren't monkey patching eventlet | |
| 14:52:09 | mriedem | and yeah https://bugs.launchpad.net/nova/+bug/1567655 came up again with my product team overlords last week | |
| 14:52:09 | openstack | Launchpad bug 1567655 in OpenStack Compute (nova) "500 error when trying to list instances and neutron-server is down" [Medium,Confirmed] | |
| 14:52:15 | mriedem | regarding perf/scaling issues with nova api | |
| 14:52:51 | mriedem | tl;dr we should cache the port security group information in instance.info_cache like we do for other port information | |
| 14:53:41 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge config drive extension response into server controller https://review.openstack.org/584223 | |
| 14:53:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge extended server attributes extension response https://review.openstack.org/584590 | |
| 14:53:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge keypair extension response into server view builder https://review.openstack.org/584748 | |
| 14:53:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge server usage extension response into server view builder https://review.openstack.org/585262 | |
| 14:53:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge security groups extension response into server view builder https://review.openstack.org/585475 | |
| 14:53:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge extended_status extension response into server view builder https://review.openstack.org/592092 | |
| 14:56:29 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Record cell success/failure/timeout in CrossCellLister https://review.openstack.org/594265 | |
| 14:56:33 | dansmith | tssurya: ^ | |
| 14:56:51 | dansmith | tssurya: what if we do that, and then in get_instance_objects_sorted() (or above) we just get a handle on InstanceLister itself | |
| 14:57:14 | dansmith | tssurya: then we can construct the missing instances from the failed cells separately from the intricate multi-cell-listing logic? | |
| 14:57:48 | tssurya | dansmith: sounds good, guess its better to move it out of the generator | |
| 14:58:19 | sean-k-mooney | mriedem: this is really annoying. im not seeing the issue going from ovs-dpdk to kernel ovs. the migration failes but the binding are fine. i was hitting this going form ovs to ovs-dpdk when i reported the bug so ill test that next. | |
| 14:58:23 | dansmith | tssurya: yeah I actually would like it higher than get_instance_objects_sorted(), but definitely want it out of the low-level logic if possible | |
| 15:01:13 | tssurya | dansmith: when you say higher than get_instance_objects_sorted(), then you mean we return the list of non-responsive cells instead from ^^ patch and constrcut it in compute/api ? | |
| 15:01:33 | tssurya | construct* | |
| 15:01:43 | dansmith | tssurya: yes, I'd like that better personally, just to keep "api logic" closer to the api | |
| 15:02:10 | dansmith | tssurya: maybe just return a tuple from get_instance_objects_sorted() indicating (failed_cell_uuids, instances_i_actually_got) | |
| 15:03:38 | tssurya | dansmith: okay looks doable, I will try it out | |
| 15:04:00 | dansmith | cool | |
| 15:04:03 | tssurya | thanks for the review btw, was getting kind of lost in the details | |
| 15:04:11 | tssurya | :) | |
| 15:04:20 | dansmith | tssurya: no problem, this is complicated and I've been neglecting it too long | |
| 15:04:33 | tssurya | hehe :D | |
| 15:04:49 | openstackgerrit | Jose Castro Leon proposed openstack/nova master: Add extend in-use volumes support for RBD https://review.openstack.org/594273 | |
| 15:05:18 | jroll | mriedem: yeah, death to the baremetal filters | |
| 15:05:40 | mriedem | i left comments on the bug, | |