| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-14 | |||
| 16:49:30 | kosamara | sean-k-mooney: ok, etherpad :) | |
| 16:54:04 | melwitt | mdbooth: okay | |
| 16:57:41 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen: remove_provider_from_instance_allocation https://review.openstack.org/591784 | |
| 17:02:29 | efried | jroll, jaypipes: Can this test be deleted at this point? https://github.com/openstack/nova/blob/61f854ff6445dd7bc797fdde7361e47f3dc3b1bd/nova/tests/functional/compute/test_resource_tracker.py#L215 | |
| 17:02:49 | mdbooth | melwitt: I'm not keen on anything involving task state, though: it's a wild west. It's basically impossible to verify, and almost guaranteed to suffer bitrot. | |
| 17:03:01 | jaypipes | efried: should be able to, yes. | |
| 17:03:08 | jaypipes | efried: double check with mriedem and dansmith | |
| 17:03:17 | efried | jaypipes: ight, will do so via review I guess. | |
| 17:03:20 | jroll | I thought we had a patch out to drop those things | |
| 17:03:33 | mdbooth | I think it's robust to verify task state set vs not set, anything else is asking for trouble. | |
| 17:03:47 | melwitt | mdbooth: yeah. that would only be for the sake of the backport. I agree it's not ideal, but the copying of code from manager to driver is more prone to bitrot IMHO | |
| 17:03:57 | dansmith | efried: I'm sure we can because we don't technically support that mix of versions anyway | |
| 17:04:11 | mdbooth | melwitt: Yeah. I also don't love that. | |
| 17:04:16 | efried | dansmith: ack, proposing... | |
| 17:04:43 | mdbooth | melwitt: I think the behaviour being tested by the regression test, namely relying on instance_on_disk() is ok. | |
| 17:05:12 | mdbooth | The principal being: if we created it, we should clean it up. If we didn't, we shouldn't. | |
| 17:05:34 | openstackgerrit | Eric Fried proposed openstack/nova master: Remove obsolete func test_ironic_ocata_to_pike https://review.openstack.org/591785 | |
| 17:05:39 | mdbooth | I think that's moderately robust, although as noted in the comment I think we can also do better with a bit more work. | |
| 17:05:41 | efried | dansmith, jaypipes, jroll, mriedem: ^ | |
| 17:07:23 | jroll | efried: thanks. you reminded me I need to pick this one back up too https://review.openstack.org/#/c/565841/ | |
| 17:07:29 | jaypipes | efried: terrible code. -3. | |
| 17:07:33 | sean-k-mooney | mriedem: just an FYI livemigratin between an ovs host with ip tables firewall and openvswtich firewall and back appear to work correctly. | |
| 17:07:46 | efried | jroll: I was just looking at that a few minutes ago. | |
| 17:08:17 | sean-k-mooney | mriedem: im going to do a bit more testing but the xml is corerctly updated so i just going to check that the firewall actully works during the live migration | |
| 17:08:18 | jroll | heh | |
| 17:23:19 | mdbooth | dansmith melwitt: Rather than changing rebuild specifically, how about if I changed spawn() in the libvirt driver such that, unconditionally, it only deletes the instance directory if it created it, and it only deletes disks if it created them. | |
| 17:24:08 | mdbooth | spawn() is called by compute manager for: boot, unshelve, rebuild. | |
| 17:24:43 | mdbooth | For the first 2 nothing should exist already, but the current behaviour is to ignore that. | |
| 17:25:12 | mdbooth | So the only case where it might legitimately exist already is rebuild on shared storage. | |
| 17:37:04 | sean-k-mooney | mdbooth: for rebuild on shared stroage the disk might exists and the instance directory but we have to recreate teh disk from the new iamage anyway right | |
| 17:47:07 | openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: report 0 for vcpus/memory_mb/disk_gb resources https://review.openstack.org/565841 | |
| 17:47:18 | jroll | efried: I think that does it ^ | |
| 17:48:32 | melwitt | mdbooth: my initial thought is, I'm not sure that sounds good for a backport, but rather a possible refactor. I'm not sure what all would be involved there or any gotchas | |
| 17:48:45 | openstackgerrit | Dan Smith proposed openstack/nova stable/queens: DNM: Debug patch to test live migration waiting https://review.openstack.org/591775 | |
| 18:15:59 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen support for put allocations https://review.openstack.org/591647 | |
| 18:16:00 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consumer gen: remove_provider_from_instance_allocation https://review.openstack.org/591784 | |
| 18:16:01 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: support claim_resources https://review.openstack.org/583667 | |
| 18:16:02 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: move_allocations https://review.openstack.org/591810 | |
| 18:16:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: more tests for delete allocation cases https://review.openstack.org/591811 | |
| 18:19:13 | openstackgerrit | Merged openstack/nova stable/rocky: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/591275 | |
| 18:36:25 | efried | jroll: Soft -1 on the reno (as well as pep8) | |
| 18:41:22 | jroll | ughhhhhhh | |
| 18:43:25 | jroll | thanks efried | |
| 18:44:06 | openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: report 0 for vcpus/memory_mb/disk_gb resources https://review.openstack.org/565841 | |
| 18:51:21 | efried | much clearer, thanks jroll | |
| 18:51:28 | jroll | :) | |
| 20:19:31 | cfriesen | maybe odd question, but if I boot an instance from a flavor with trait:HW_CPU_X86_AVX2=required, the exact CPU model chosen seems to depend on the nova-compute config. Suppose I then try to live-migrate...I'm guaranteed that the dest node will support AVX2, but Is there somewhere that we verify that the dest node can support the same CPU model as is currently being used by the running VM? | |
| 20:31:23 | cfriesen | never mind, found the code. the scheduler filters don't check, but check_can_live_migrate_destination() should catch it. | |
| 20:42:23 | openstackgerrit | Jay Pipes proposed openstack/nova master: DNM: test possible deadlock cause https://review.openstack.org/591845 | |
| 21:15:52 | openstackgerrit | Chris Dent proposed openstack/nova master: Add explanatory prefix to post_test_perf output https://review.openstack.org/591850 | |
| 21:19:32 | openstackgerrit | Chris Dent proposed openstack/nova master: DNM: test possible deadlock cause https://review.openstack.org/591845 | |
| 21:21:10 | efried | cdent: Love it. | |
| 21:22:03 | cdent | I suppose once we've all memorized those words we can read right over them | |
| 21:25:11 | efried | cdent: One concern is tying that behavior to a specific version of placeload. | |
| 21:25:33 | efried | Perhaps a TODO to vet that periodically. | |
| 21:26:14 | cdent | but where will we put the todo to remind us to look for todos? | |
| 21:27:26 | openstackgerrit | Dmitry Sutyagin proposed openstack/nova master: Implement disabling KSM via flavor's extra specs https://review.openstack.org/591854 | |
| 21:30:31 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM: update_provider_tree() (compatible) https://review.openstack.org/468560 | |
| 21:30:39 | efried | edmondsw, jaypipes: ^ | |
| 21:32:15 | openstackgerrit | Jim Rollenhagen proposed openstack/nova master: Ironic: report 0 for vcpus/memory_mb/disk_gb resources https://review.openstack.org/565841 | |
| 21:32:54 | jroll | efried: jaypipes: ^ had a syntax error in release note :( | |
| 21:33:11 | efried | jroll: Wish somebody had been paying attention to your release note | |
| 21:33:17 | jroll | heh | |
| 21:33:24 | jroll | I did your suggestion too :) | |
| 21:33:53 | efried | d'oh, I should have caught that. | |
| 21:33:55 | efried | thanks. | |
| 21:34:16 | efried | jroll: +A | |
| 21:35:05 | jroll | thanks | |
| 22:35:28 | melwitt | mriedem: fyi added a question to the RC todos etherpad about translations | |
| 22:40:11 | openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Regex consts for placement schema https://review.openstack.org/591863 | |
| #openstack-nova - 2018-08-15 | |||
| 00:20:31 | openstackgerrit | xhzhf proposed openstack/nova master: [vmware] add missing os types in vSphere sdk 6.5 https://review.openstack.org/591771 | |
| 00:29:55 | mriedem | melwitt: ack, just got online | |
| 00:35:16 | mriedem | dansmith: lyarwood: fwiw, i backported the live migration revert from master to stable/rocky b/c i was sure that would be clean since we just cut stable/rocky, but assumed we'd have to revert per-branch for queens and pike | |
| 00:39:03 | mriedem | efried: re: https://github.com/openstack/nova/blob/61f854ff6445dd7bc797fdde7361e47f3dc3b1bd/nova/tests/functional/compute/test_resource_tracker.py#L215 have we removed the compat code in the RT for that yet? or are you saying we can now because master is stein? i would hold off on merging any big code removals this early until we've cut rc2 | |
| 00:43:39 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: placement: ignore policy scope check failures if not enforcing scope https://review.openstack.org/591872 | |
| 00:44:55 | mriedem | melwitt: on backporting https://review.openstack.org/#/c/591129/ to rc2, idk, would ask the release team (smcginnis or dhellmann) | |
| 00:45:27 | mriedem | or maybe ajaegar | |
| 00:59:02 | mriedem | melwitt: we don't need to backport the translations | |
| 02:01:13 | openstackgerrit | Merged openstack/nova master: Make Xen code py3-compatible https://review.openstack.org/591061 | |
| 02:01:20 | openstackgerrit | Merged openstack/nova master: Update really old comments about vmware hosts managing multiple nodes https://review.openstack.org/589666 | |
| 02:01:28 | openstackgerrit | Merged openstack/nova master: Ironic: report 0 for vcpus/memory_mb/disk_gb resources https://review.openstack.org/565841 | |
| 02:04:10 | mriedem | efried: ok i guess https://review.openstack.org/#/c/565841/ is merged... note there are other things to cleanup related to this from the ptg etherpad, ~L25 https://etherpad.openstack.org/p/nova-ptg-stein | |
| 02:46:58 | alex_xu | Kevin_Zheng: few comments on https://review.openstack.org/#/c/486850 | |
| 02:48:24 | alex_xu | Kevin_Zheng: I think using PATH_INFO is right. just need refine the code a little bit. And I found we will strip any work start with 'v', if we have a url called '/volume', then it will be stripped. although we don't have it, but it is trap for any url start with 'v' | |
| 02:48:47 | alex_xu | in the future | |
| 03:14:20 | melwitt | mriedem: thanks. I guess I don't know what all the hubbub about "rc2 translations" used to be about then | |
| 03:14:53 | Kevin_Zheng | alex_xu, thanks alot, I will look into that | |
| 03:22:49 | sapd1 | melwitt: Can I workaround to attach SR-IOV to exist instance? :D | |
| 03:26:04 | melwitt | sapd1: not that I know of. I haven't gotten around to asking artom about the bug https://bugs.launchpad.net/nova/+bug/1708433 | |
| 03:26:04 | openstack | Launchpad bug 1708433 in OpenStack Compute (nova) "Attaching sriov nic VM fail with keyError pci_slot" [Undecided,New] | |
| 03:31:13 | alex_xu | mriedem: enjoy...Xi'an food :) | |
| 03:32:06 | mriedem | alex_xu: biang biang noodle! | |
| 03:32:11 | mriedem | chinese hamburger | |
| 03:32:27 | alex_xu | mriedem: hahaha | |
| 03:33:32 | mriedem | sapd1: you can't attach sriov ports to existing instances | |
| 03:33:43 | mriedem | beyond just the KeyError | |
| 03:34:00 | mriedem | we should likely just 400 those types of requestse | |
| 03:34:49 | melwitt | yeah, sean-k-mooney was saying he thought it used to 400 but that artom might know about patch(es) that might have inadvertently changed it? | |
| 03:34:56 | sapd1 | mriedem: so we don't have any way to attach sriov ports, do you? | |
| 03:36:21 | mriedem | sapd1: it's not currently supported no | |