Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-08-09
15:43:36 lyarwood mriedem: yup looking
15:53:14 melwitt mriedem: I just happened upon the patch for adding the zvm driver to the support matrix https://review.openstack.org/532720
15:53:47 melwitt other doc updates are stacked on top
15:54:55 melwitt and I found that no reno was added for the zvm driver at the time of the changes, so I think someone needs to add that
15:55:54 mriedem if you want it, it's likely going to have to be you
15:55:58 mriedem jichen is probably gone for the day
15:56:11 melwitt yeah. I was thinking that, given the time factor
15:56:44 openstackgerrit Jay Pipes proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388
15:56:45 openstackgerrit Jay Pipes proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041
16:04:26 openstackgerrit Eric Fried proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150
16:10:00 mriedem -1 on the zvm feature support matrix patch
16:10:11 mriedem so if we do an rc2, the zvm docs and such might need to fall into that
16:10:43 melwitt ack
16:11:29 mriedem the only mention that it was added will be in your prelude reno
16:12:57 melwitt I know ... I'm writing up it's own reno based on the patches, and hopefully efried can help. I would like it to have its own reno with the details and not have the only mention be in the prelude
16:13:21 melwitt I didn't realize it was missing a reno of its own
16:13:59 mriedem ok, i personally don't think we should hold up https://review.openstack.org/#/c/589303/ on that,
16:14:00 mriedem but ok
16:14:14 efried I would only be guessing in writing up that reno. I guess it prolly needs to be done by EOB though, huh?
16:14:23 efried mriedem: No, I agree, I was holding on the other issue.
16:14:51 mriedem the grammar nit?
16:14:58 mriedem then let's just fix it inline and approve?
16:15:05 efried yeah, sounds good.
16:15:10 mriedem melwitt: ^?
16:15:13 melwitt mriedem: you think it's ok for that to be the only mention? if so, I'm fine with it. you know a lot more about this than I do
16:15:29 mriedem i'm fine with it
16:15:37 mriedem the bigger docs series is what really matters
16:15:40 mriedem but that's not ready for rc1
16:15:40 efried I can try to rip out a reno real quick
16:15:48 melwitt ok, inline fix it and approve is cool with me then
16:16:04 mriedem you can always do the docs in rc2
16:16:13 efried mriedem: I'll do the grammar fix and push it.
16:16:18 mriedem ack
16:16:34 openstackgerrit Eric Fried proposed openstack/nova master: Add a prelude release note for the 18.0.0 Rocky GA https://review.openstack.org/589303
16:16:40 melwitt ok, I wasn't sure if a docs-only thing was rc2 worthy. if it is, then we can do that
16:17:35 efried melwitt, mriedem: done. If we're not worried about getting the reno landed today, I'll happily wait for jichenjc to do it.
16:18:26 mriedem i'm not losing sleep over a detailed reno for the zvm driver which does a very small number of things - the docs are more important to me
16:18:30 mriedem the prelude mentions it
16:18:37 mriedem if someone wants to learn more, they can find the driver docs
16:19:29 mriedem the way i look at renos, if it's really detailed, it likely needs to be a doc, because release notes are a one time only thing
16:22:08 mriedem melwitt: should probably hold up stable releases on https://review.openstack.org/#/q/topic:bug/1784705+status:open
16:22:30 melwitt ok, that's helpful. fwiw, I was thinking basic detail in the reno like, what operations are supported (spawn, destroy, snapshot, get console output, power actions)
16:22:35 melwitt mriedem: ok, will do
16:22:39 mriedem anyone using ironic + ComputeCapabilitiesFilter will be hit by those
16:22:53 mriedem melwitt: supported ops for the zvm driver are in the feature support matrix
16:22:58 mriedem so i wouldn't put that in the reno
16:23:16 melwitt ok. efried, we don't need an additional reno ^
16:24:14 efried Okay, wfm. jichenjc, in case you're snooping later ^
16:24:31 efried The prelude could have linked to the admin config doc, if it was landed, but it ain't, so...
16:26:41 melwitt based on what mriedem said, we can have a rc2 because of the docs, and land them there
16:27:10 melwitt so I'll add those to https://etherpad.openstack.org/p/nova-rocky-release-candidate-todo
16:27:29 melwitt ok he already added them, thanks
16:28:01 mriedem lyarwood: should i start reviewing https://review.openstack.org/#/c/587013/ again or do you expect more from mdbooth/
16:28:02 mriedem ?
16:28:37 lyarwood mriedem: that should be good now
16:31:16 melwitt dansmith, lyarwood: could you pls review these changes for the ironic bug, we're holding the stable releases on those fixes https://review.openstack.org/#/q/topic:bug/1784705+status:open
16:32:31 lyarwood melwitt: ack'd the Pike changes
16:33:17 melwitt thanks
16:38:50 mriedem lyarwood: just a couple of small things in https://review.openstack.org/#/c/587013/
16:44:02 mriedem random musings in your functional test too; i.e. i wonder how many volumes we orphan when nova creates the root volume and we reschedule
16:44:19 mriedem nice fun way to go over volume quota
16:46:06 lyarwood mriedem: hmmm I forgot the compute did that, does it not see the existing bdm?
16:48:03 mriedem the existing bdm will have source_type=image on it or whatever
16:48:05 mriedem right?
16:48:07 mriedem we don't update that
16:48:19 mriedem so it will be transformed to a DriverImageBlockDevice or whatever
16:48:28 openstackgerrit Merged openstack/nova stable/pike: Fix bad links for admin-guide https://review.openstack.org/590072
16:48:40 mriedem DriverVolImageBlockDevice
16:48:59 mriedem anyway, haven't tested it, but i'm pretty sure that's been busted since forever
16:49:07 mriedem we cleanup after ourselves for ports but not volumes
16:51:00 lyarwood ah right understood, should be easy enough to show in another functional test
16:51:46 mriedem maybe.....i'm not sure the fixture is setup for that really
16:51:57 mriedem devstack is probably much easier/faster to start
16:52:02 mriedem if you have 2 nodes...
16:57:03 lyarwood mriedem: I don't to hand but I'll make a note to give this a go
17:21:48 openstackgerrit Lee Yarwood proposed openstack/nova master: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590439
17:34:57 openstackgerrit Matt Riedemann proposed openstack/nova master: placement: ignore policy scope check failures if not enforcing scope https://review.openstack.org/590445
17:38:49 openstackgerrit Matt Riedemann proposed openstack/nova master: placement: ignore policy scope check failures if not enforcing scope https://review.openstack.org/590445
17:44:48 openstackgerrit Merged openstack/nova master: Update the parameter explain when updating a volume attachment https://review.openstack.org/565181
19:11:26 openstackgerrit Matt Riedemann proposed openstack/nova master: placement: ignore policy scope check failures if not enforcing scope https://review.openstack.org/590445
19:15:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix image-defined numa claims during evacuate https://review.openstack.org/588657
19:18:06 openstackgerrit Matt Riedemann proposed openstack/nova master: Add encrypted volume support to feature matrix docs https://review.openstack.org/570255
19:28:38 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: fix GET /flavors?is_public description https://review.openstack.org/588092
19:37:11 prometheanfire is https://github.com/openstack/nova/commit/ff747792b8f5aefe1bebb01bdf49dacc01353348#diff-f4019782d93a196a0d026479e6aa61b1R6938 run multiple times or only checked once?
19:37:16 openstackgerrit Merged openstack/nova stable/queens: Fix host validity check for live-migration https://review.openstack.org/590262
19:37:23 openstackgerrit Merged openstack/nova master: [placement] api-ref: add description for 1.29 https://review.openstack.org/589407
19:37:36 prometheanfire live migrations seem to be limited to 1M a sec and never increase
19:44:23 melwitt hm
19:45:18 melwitt do you know anything about that mriedem ^
19:45:56 mriedem prometheanfire: linuxbridge?
19:46:23 mriedem https://github.com/openstack/nova/commit/ff747792b8f5aefe1bebb01bdf49dacc01353348#diff-f4019782d93a196a0d026479e6aa61b1R5380
19:46:27 mriedem are you using linuxbridge i mean
19:47:46 prometheanfire ya, lb
19:47:56 prometheanfire vlan interface on the VM
19:48:35 mriedem well, we should be waiting on network-vif-plugged events from neutron and if we get them, we set the bw back up and resume the live migration, else we should fail the live migration
19:48:56 mriedem i'm assuming you have vif_plugging_timeout left at the default config of 300?
19:49:03 prometheanfire the migration finishes, it's just slow
19:49:10 prometheanfire I don't think we changed it
19:49:30 mriedem does it finish in under 5 minutes?
19:49:38 prometheanfire takes ~10 min

Earlier   Later