| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-02 | |||
| 22:45:56 | openstackgerrit | Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | |
| 22:45:57 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Remove redundant _update()s https://review.openstack.org/588091 | |
| 22:46:15 | lbragstad | if not - then it sounds like something we can build into oslo.limit or consider supporting (since it's the thing raise exceptions to the service) | |
| 22:46:26 | melwitt | lbragstad: it is, sorry. I mean whether it's one call or two calls in oslo.limit to do limits vs enforce | |
| 22:46:49 | lbragstad | oh - the thing that protects against race conditions? | |
| 22:47:21 | melwitt | sorry, I think I'm confusing things and I haven't looked at the POC code in awhile | |
| 22:47:46 | lbragstad | the skeleton of oslo.limit has that implemented in the context manager https://github.com/openstack/oslo.limit/blob/master/oslo_limit/limit.py#L60-L62 | |
| 22:48:06 | melwitt | ah, yeah I remember now | |
| 22:48:13 | lbragstad | https://github.com/openstack/oslo.limit/blob/master/oslo_limit/tests/test_limit.py#L96 probably helps visualize things a bit, too | |
| 22:48:22 | lbragstad | from a usage perspective anyway | |
| 22:49:31 | melwitt | thanks | |
| 22:49:37 | lbragstad | this stuff will get implemented soon, since this is where the code the calculates the limits wrt the tree https://github.com/openstack/oslo.limit/blob/master/oslo_limit/limit.py#L81-L85 | |
| 22:49:57 | lbragstad | (implementation detail of the context manager though) | |
| 22:49:58 | melwitt | and that will also pull the limits from keystone? | |
| 22:50:07 | lbragstad | yep - exactly | |
| 22:50:32 | lbragstad | when you enter the context manager, it should query keystone for the limits and do calculations based on the claims your making | |
| 22:50:51 | melwitt | ah, I see. I think I jumped the gun then. for some reason I was thinking we could move to using keystone limits only, as a first step, and then start doing the oslo.enforcement in a second separate step | |
| 22:50:52 | lbragstad | then __exit__ will do error handling in the event there was a race condition and verify = True | |
| 22:51:00 | melwitt | from a project perspective | |
| 22:51:05 | lbragstad | aha - sure | |
| 22:51:16 | lbragstad | hopefully it's only one step for you | |
| 22:51:29 | lbragstad | (unless there is a good reason to break things up a bit?) | |
| 22:51:44 | melwitt | no, I don't think there is. just ignorance on my part | |
| 22:51:55 | lbragstad | it's a lot of moving pieces =/ | |
| 22:52:04 | melwitt | yeah, for sure | |
| 22:52:26 | lbragstad | we were waiting on an APi to return the project heirarchy with limit data associated to it (landed in rocky) | |
| 22:52:50 | lbragstad | now that's in, we can start working on finishing up the implementation of that context manager | |
| 22:52:59 | lbragstad | (i'm hoping to start that soon) | |
| 22:53:09 | melwitt | on our side we have to decide whether to go ahead with the custom resource classes quotas by using our own quota classes API or wait for oslo.limit | |
| 22:54:11 | lbragstad | i can bump the oslo.limit impl up on my priority list if it helps give you all a definitive direction | |
| 22:54:23 | lbragstad | (if support in oslo.limit is the question) | |
| 22:55:16 | melwitt | have to dig in more on what's the cost of that. might not be much actually because we can leverage our own old API for doing it. it's just then we'd have to migrate whatever quota classes people have created over to keystone limits. but we have to do that regardless so maybe it's not much extra cost | |
| 22:55:34 | lbragstad | sure | |
| 22:55:54 | lbragstad | i think i see what you mean | |
| 23:00:38 | melwitt | lbragstad: re: the comments on our PTG etherpad, there is already support for user_id right? as shown on this doc? https://docs.openstack.org/keystone/queens/admin/identity-unified-limits.html | |
| 23:02:38 | melwitt | we've had discussions with operators in the past and there was consensus that user_id isn't useful if hierarchy is possible, but I don't know if/how we could change the semantics of our existing quotas. so I'm thinking of what's possible if we *don't* change semantics | |
| #openstack-nova - 2018-08-03 | |||
| 00:58:02 | openstackgerrit | melanie witt proposed openstack/nova stable/ocata: [stable only] Handle quota usage during create/delete races https://review.openstack.org/582413 | |
| 00:58:04 | openstackgerrit | melanie witt proposed openstack/nova stable/ocata: Add functional regression test for bug 1783613 https://review.openstack.org/588416 | |
| 00:58:04 | openstack | bug 1783613 in OpenStack Compute (nova) ocata "[ocata only] quota usage not decremented during boot/delete race" [Undecided,In progress] https://launchpad.net/bugs/1783613 - Assigned to melanie witt (melwitt) | |
| 00:58:08 | openstackgerrit | Merged openstack/nova master: In Python3.7 async is a keyword [1] https://review.openstack.org/584365 | |
| 00:59:25 | openstackgerrit | melanie witt proposed openstack/nova stable/ocata: [stable only] Add functional regression test for bug 1783613 https://review.openstack.org/588416 | |
| 00:59:25 | openstack | bug 1783613 in OpenStack Compute (nova) ocata "[ocata only] quota usage not decremented during boot/delete race" [Undecided,In progress] https://launchpad.net/bugs/1783613 - Assigned to melanie witt (melwitt) | |
| 00:59:26 | openstackgerrit | melanie witt proposed openstack/nova stable/ocata: [stable only] Handle quota usage during create/delete races https://review.openstack.org/582413 | |
| 01:15:46 | melwitt | mriedem_afk: I added a functional regression test that might help demonstrate the bug ^ | |
| 01:18:19 | melwitt | customer hit an issue around this so I proposed it upstream too in case it can help | |
| 01:30:38 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove unused request API sample template https://review.openstack.org/588420 | |
| 01:31:45 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove unused request API sample template https://review.openstack.org/588420 | |
| 01:34:52 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove unused request API sample template https://review.openstack.org/588420 | |
| 01:44:07 | lbragstad | melwitt: oh - so don't try and support per user quotas? | |
| 01:51:53 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Update installation guide to be more clear about cellsv2 https://review.openstack.org/584244 | |
| 01:56:47 | openstackgerrit | zhufl proposed openstack/nova master: Fix none-ascii char in doc https://review.openstack.org/588422 | |
| 03:03:42 | openstackgerrit | Vishakha Agarwal proposed openstack/nova master: No change in field 'updated' in server https://review.openstack.org/586446 | |
| 04:38:48 | openstackgerrit | melanie witt proposed openstack/nova stable/ocata: [stable only] Handle quota usage during create/delete races https://review.openstack.org/582413 | |
| 05:57:32 | openstackgerrit | Vishakha Agarwal proposed openstack/nova master: 'Updated_at' is NULL when show aggregate info https://review.openstack.org/580271 | |
| 06:06:56 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove unused request API sample template https://review.openstack.org/588420 | |
| 06:48:14 | alex_xu | stephenfin: sorry, just send at wrong channel, the sample files are deleted by this commit https://review.openstack.org/#/c/149129/, and actually, the api sample test doesn't validate the request body, so there is no complain, those file actually just for document. | |
| 06:52:29 | gmann | alex_xu: stephenfin this will fix - https://review.openstack.org/#/c/588420/4 | |
| 06:53:27 | alex_xu | gmann: thanks | |
| 06:54:07 | alex_xu | gmann: but I'm thinking about why we cleanup those empty file at https://review.openstack.org/#/c/149129/ | |
| 06:55:36 | gmann | alex_xu: not sure why we removed may be because their are just empty | |
| 06:55:52 | gmann | they are just empty | |
| 06:56:25 | alex_xu | gmann: yea, anyway, your fix is better | |
| 07:00:16 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove unused request API sample template https://review.openstack.org/588420 | |
| 07:00:38 | gmann | alex_xu: done ^^ | |
| 07:02:54 | alex_xu | gmann: thanks | |
| 07:23:36 | openstackgerrit | Yongli He proposed openstack/nova master: Load expected attr pci_devices while migrate https://review.openstack.org/588455 | |
| 07:31:32 | openstackgerrit | Merged openstack/nova master: Add another up-call to the cells v2 caveats list https://review.openstack.org/581910 | |
| 08:22:13 | giblet | stephenfin: you found it you can make sure it is fixed ;) https://review.openstack.org/#/c/588420/ | |
| 08:28:24 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix nits in resource_provider.py https://review.openstack.org/588470 | |
| 09:12:03 | tobasco | is there any manual process that needs to be performed if you get a lot of this? | |
| 09:12:06 | tobasco | http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/resource_tracker.py#n1308 | |
| 09:12:26 | tobasco | why wouldn't it clear allocations if the instance doesn't exist? | |
| 09:12:37 | openstackgerrit | zhufl proposed openstack/nova master: xx_instance_type_id in list_migrations should be integer https://review.openstack.org/588481 | |
| 09:55:18 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Fix nits in resource_provider.py https://review.openstack.org/588470 | |
| 10:20:08 | cdent | giblet++ | |
| 10:29:07 | panda|rover | Hi, I'm trying to gather console logs for nova instances, but it seems logs resets at boot, is there a way to maintain the console log persistent across reboots ? | |
| 11:01:00 | openstackgerrit | Chen proposed openstack/nova master: Revert task_state to none for LM failure due to invalid dest https://review.openstack.org/588512 | |
| 11:13:31 | sean-k-mooney | tobasco: there are some bugs related to live migration that can cause allocation to leak | |
| 11:15:08 | amarao | Hello. I found that if I remove image instance booted from, migration no longer uses a proper aggregate based on that image meta. Is someone knew something about this? | |
| 11:15:38 | tobasco | so we've been pounding our cloud with rally, so if my logs contain excessive of such statements that would probably be after rally live migrations | |
| 11:15:52 | tobasco | should I be worried, I assume I would want to release those allocations manually somehow | |
| 11:29:40 | openstackgerrit | Merged openstack/nova master: Remove unused request API sample template https://review.openstack.org/588420 | |
| 12:06:03 | openstackgerrit | Liam Young proposed openstack/nova master: Target metadata requests at the correct cell. https://review.openstack.org/588520 | |
| 12:13:12 | openstackgerrit | Merged openstack/nova master: Docs: Add Placement to Nova system architecture https://review.openstack.org/584338 | |
| 12:20:48 | openstackgerrit | Liam Young proposed openstack/nova master: Remove Neutron MetaAPIProxy from cellsv2-layout https://review.openstack.org/588525 | |
| 12:30:53 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Cleanup comp_node, res_prov, services, aggregate_hosts during cell deletion https://review.openstack.org/546660 | |
| 12:40:26 | mriedem | cfriesen: what was the reason for needing a POST /os-services API to create nova-compute services on a given host? https://github.com/starlingx-staging/stx-nova/commit/71acfeae0d1c59fdc77704527d763bd85a276f9a#diff-f3afe2522f9c92f5705f0ff5cf343865R246 | |
| 12:40:36 | mriedem | which is also, btw, not multi-cell aware since it doesn't rely on the host mapping | |
| 12:44:49 | mriedem | sean-k-mooney: check this out https://github.com/starlingx-staging/stx-nova/commit/71acfeae0d1c59fdc77704527d763bd85a276f9a#diff-99e4b3f7232bf35155ff8b590b0ea589R44 | |
| 12:47:18 | sean-k-mooney | mriedem: clicking but not sure i want too | |
| 12:47:30 | sean-k-mooney | haha | |
| 12:48:23 | sean-k-mooney | mriedem: that in the api. that is not a bad idea to be honest | |
| 12:49:12 | sean-k-mooney | mriedem: we dont document in the api that when using the libvirt dirview we detach all pci/sriov device on suspend which is hostile to a guest application that was uing them | |
| 12:49:26 | sean-k-mooney | pause would not detach the devices. | |
| 12:51:06 | mriedem | sean-k-mooney: i know https://bugs.launchpad.net/nova/+bug/1785246 | |
| 12:51:06 | openstack | Launchpad bug 1785246 in OpenStack Compute (nova) "Compute API reference should describe pause and suspend operations" [Medium,Confirmed] | |
| 12:51:15 | sean-k-mooney | mriedem: we likely can do this where i wanted too in the snapshot case after talking to dansmith due to concern about data curroption by not flushing buffers but this seams ok | |
| 12:51:44 | sean-k-mooney | ya i was think about that yesterday after we were talking about it. | |
| 12:52:01 | mriedem | windriver could have just disabled the suspend/resume apis with policy | |
| 12:52:07 | mriedem | rather than change the behavior | |