Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-07-29
23:40:25 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019
23:40:36 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020
23:40:47 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027
23:41:08 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031
23:43:02 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299
23:43:16 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344
#openstack-nova - 2018-07-30
00:20:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673
01:15:09 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676
01:43:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689
01:44:27 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709
01:44:44 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712
04:58:54 openstackgerrit Takashi NATSUME proposed openstack/nova master: Transform compute_task notifications https://review.openstack.org/482629
04:59:14 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: Create specs directory for Stein https://review.openstack.org/573602
05:31:58 openstackgerrit Thomas Goirand proposed openstack/nova master: Remove "async" as variable name https://review.openstack.org/586782
06:54:03 openstackgerrit Jake Yip proposed openstack/nova master: Add --before to nova-manage db archive_deleted_rows https://review.openstack.org/556751
06:56:30 openstackgerrit Jake Yip proposed openstack/nova master: Add --before to nova-manage db archive_deleted_rows https://review.openstack.org/556751
07:21:18 vishakha takashin : Hi, Waiting for your response https://review.openstack.org/#/c/580271/
07:23:38 takashin vishakha: okay. I will review it today.
07:25:20 vishakha takashin, thanks Pl review this too https://review.openstack.org/#/c/586446/
07:48:19 openstackgerrit Merged openstack/nova master: Fix signature of _FakeImageService.download https://review.openstack.org/585747
07:48:26 openstackgerrit Merged openstack/nova master: api-ref: document user_data length restriction https://review.openstack.org/586388
07:57:14 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: libvirt: add method to configure migration speed https://review.openstack.org/586965
07:58:02 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: libvirt: add method to configure migration speed https://review.openstack.org/586965
08:11:06 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove unused stubbing function from test https://review.openstack.org/586968
09:05:48 kashyap sean-k-mooney: Thanks for the review here: https://review.openstack.org/#/c/567258/
09:06:27 sean-k-mooney did you get a chance to look into why the live migration was failing friday?
09:06:28 kashyap sean-k-mooney: Darn, I haven't yet dug into the Tempest failures. And I'll be off from Wednesday for 2 1/2 weeks
09:06:31 kashyap :-(
09:06:53 kashyap sean-k-mooney: I looked at it a couple of times, there were Cloud Provider issues
09:07:04 kashyap Let me look at it now
09:07:52 kashyap sean-k-mooney: I wonder if we can get this merged by tomm...
09:17:23 openstackgerrit huanhongda proposed openstack/nova master: Allow unicode keys for metadata https://review.openstack.org/536236
09:21:15 sean-k-mooney kashyap: well if you think its a cloud provider issue you chould just recheck. but this looked like it just did not migrate to the correct host so i would guesss there is a traceback in the n-cpu log
09:21:48 kashyap sean-k-mooney: Right, I did 'recheck' 2 times, and got over the Cloud Provider issues. But just looking through https://orangebox.com/products/Do
09:21:52 kashyap Err, http://logs.openstack.org/58/567258/10/check/nova-live-migration/17bbee9/job-output.txt.gz
09:21:58 kashyap To find the right failure
09:21:58 bauzas kashyap: yup, looks like infra has a cloud provider issue
09:28:43 kashyap bauzas: Hmm
09:28:45 kashyap Still?
09:30:01 bauzas no fresh news I know of, I'm afraid
09:30:30 sean-k-mooney kashyap: looks to me like this was a failure in the code you changed http://logs.openstack.org/58/567258/10/check/nova-live-migration/17bbee9/logs/screen-n-cpu.txt.gz?level=DEBUG#_Jul_27_10_28_57_610656
09:31:15 kashyap sean-k-mooney: Ah, let me look
09:32:02 kashyap sean-k-mooney: Which test failure is it?
09:32:11 kashyap sean-k-mooney: Is there a page with a precise list of test failures?
09:32:26 sean-k-mooney test_live_block_migration[id-1dce86b8-eb04-4c03-a9d8-9c1dc3ee0c7b]
09:32:32 sean-k-mooney http://logs.openstack.org/58/567258/10/check/nova-live-migration/17bbee9/logs/testr_results.html.gz
09:32:36 kashyap I see: http://logs.openstack.org/58/567258/10/check/nova-live-migration/17bbee9/job-output.txt.gz#_2018-07-27_10_29_43_862692
09:33:24 kashyap sean-k-mooney: Would be clearer if the HTML report will be in the top-level directory; thanks for the pointer!
09:33:55 sean-k-mooney kashyap: it is on some gate jobs. when its not its usually in the logs dir
09:34:02 kashyap I see, noted.
09:34:54 sean-k-mooney i just grabbed the instance uuid from the html report of the first failure then when to the n-cpu log and searched for a trasback with that uuid
09:35:44 kashyap Yep, thank you for the (non-null) pointer
09:42:11 kashyap sean-k-mooney: How can I reproduce this locally?
09:42:18 kashyap sean-k-mooney: By running one of the Tempest tests?
09:43:20 sean-k-mooney kashyap: tempest will work if you have a 2 node devstack running yes
09:43:35 sean-k-mooney https://review.openstack.org/#/c/567258/10/nova/virt/libvirt/guest.py
09:43:50 sean-k-mooney you removed a null check on domain_xml
09:43:54 kashyap sean-k-mooney: Afraid, need to set up afresh, and I'm doing last-minute stuff before I head out.
09:43:58 sean-k-mooney could that be the issue
09:44:40 kashyap sean-k-mooney: Aah, good pointer; let me look!
09:45:59 kashyap sean-k-mooney: But 'domain_xml' is no longer needed
09:46:10 sean-k-mooney its now destination_xml
09:46:25 sean-k-mooney which you default to None and never check
09:47:25 kashyap Hmm, true. I need to put such a check for 'destination_xml'
09:48:23 sean-k-mooney or you chould do 'params['destination_xml'] = destination_xml or ""' but really if you dont have a dest xml it should proably be the source xml?
09:48:34 sean-k-mooney or just not add it to the params dict
09:49:04 kashyap Hmm, that last option sounds cleaner: if 'destination_xml' is None, then don't add it to the 'params' dict
09:49:09 sean-k-mooney im not sure what the preconditions on migrateToURI3 are
09:50:11 sean-k-mooney in theory you should be able to test this with a functional test locally but i that is non trivail to write correctly
09:50:52 kashyap Yeah
09:52:24 kashyap sean-k-mooney: Meanwhile, here is the API definition: https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainMigrateToURI3
09:53:35 kashyap The Python bindings use the 'destination_xml', and the C equivalent: https://libvirt.org/html/libvirt-libvirt-domain.html#VIR_MIGRATE_PARAM_DEST_XML
09:57:14 sean-k-mooney kashyap: im not seeing anything that explcitly eays the destination_xml is required. so maybe just omitting it for the params is correct
09:57:32 kashyap sean-k-mooney: Yeah, so how about: http://paste.openstack.org/show/726818/
09:58:18 sean-k-mooney am you are always leaving it out in that case.
09:59:11 sean-k-mooney just do if destination_xml:
09:59:16 sean-k-mooney params['destination_xml'] = destination_xml
10:00:52 kashyap Ah, let me try
10:03:08 kashyap sean-k-mooney: Err, the 'else' thing had the wrong snippet
10:03:14 kashyap Let me re-pase what I have:
10:04:31 kashyap sean-k-mooney: http://paste.openstack.org/show/726820/
10:08:54 kashyap Thanks for the discussion here!
10:16:19 s10 https://bugs.launchpad.net/nova/+bug/1322921
10:16:19 openstack Launchpad bug 1322921 in OpenStack Compute (nova) "hypervisor-servers command always search by wildcard as '%hypervisor_hostname%'" [Wishlist,Opinion]
10:16:35 s10 Could this bug be changed to another status?
10:16:52 s10 Because this bug is awful. Execute: nova host-evaucate-live cmp2
10:17:17 s10 Result: all hosts cmp2* will be live evacuated.
10:22:50 kashyap sean-k-mooney: Okay, I'll go with this:
10:23:07 kashyap params = {}
10:23:07 kashyap params['bandwidth'] = bandwidth
10:23:07 kashyap params['migrate_disks'] = migrate_disks
10:23:07 kashyap params['migrate_uri'] = migrate_uri
10:23:07 kashyap if destination_xml:
10:23:09 kashyap params['destination_xml'] = destination_xml
10:53:58 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs https://review.openstack.org/567258
10:54:34 kashyap sean-k-mooney: When you have a minute, please have a gander ^. I've addressed the 'destination_xml' and both your consistency nits
11:04:18 sean-k-mooney kashyap: taking a look now. was on 1:1 call
11:09:21 kashyap sean-k-mooney: Thank you. I normally don't expect instant turn-around :-)
11:44:23 openstackgerrit Brin Zhang proposed openstack/nova stable/pike: Add unshelve instance error info to fault table https://review.openstack.org/583426
11:46:36 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.openstack.org/512552

Earlier   Later