| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-07-26 | |||
| 09:21:07 | mdbooth | In fairness it's a bug. | |
| 09:21:11 | bauzas | yeah | |
| 09:21:16 | bauzas | a libvirt bug | |
| 09:21:20 | mdbooth | But one which can't be fixed now. | |
| 09:21:30 | mdbooth | Indeed, a libvirt bug. | |
| 09:21:56 | bauzas | oh and FWIW, params.items() only works because that's checked for py2 | |
| 09:22:38 | mdbooth | IIRC params.items() is the recommended way to migration py2 -> py3 unless you really can't handle a list or a generator | |
| 09:24:01 | mdbooth | Yeah, params.items() would have the same behaviour there in py2 and py3. | |
| 09:25:25 | mdbooth | lyarwood: Chance of thunderstorms this afternoon, apparently \o/ | |
| 09:25:28 | mdbooth | But not for you | |
| 09:26:01 | bauzas | mdbooth: while py2 returns a dict, py3 returns a generator | |
| 09:26:19 | mdbooth | bauzas: Right, and they'll both do the same thing there. | |
| 09:32:42 | lyarwood | mdbooth: getting three days of rain from tomorrow so tis all good :) | |
| 10:11:43 | openstackgerrit | Merged openstack/nova master: ironic: Report resources as reserved when needed https://review.openstack.org/517921 | |
| 10:17:18 | kashyap | I thought you might be interested in getting banned! | |
| 10:18:45 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | |
| 10:20:50 | kashyap | mdbooth: I will leave the uncode / byte string change as-is. Not going to muck with it in this change. | |
| 10:21:43 | mdbooth | kashyap: Right. I was only ever suggesting a formatting change following a change of indentation :) | |
| 10:22:09 | mdbooth | kashyap: Changing the unicode thing in that change would be inappropriate. | |
| 10:22:19 | kashyap | mdbooth: I would have parsed the word "unindent" correctly. But you said: "undent", my brain went: "Can we remove this wrinkle / dent" :P | |
| 10:22:24 | kashyap | mdbooth: Absolutely | |
| 10:23:01 | kashyap | Okido, mooooooooooving on. | |
| 10:42:56 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs https://review.openstack.org/567258 | |
| 11:05:50 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Retry allocation writes server side https://review.openstack.org/586048 | |
| 11:07:40 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] api-ref: add traits parameter https://review.openstack.org/578048 | |
| 11:27:05 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Get resource provider by uuid or name https://review.openstack.org/527791 | |
| 12:00:19 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Provide a useful message in the case of 500-error https://review.openstack.org/586056 | |
| 12:01:23 | openstackgerrit | Andrey Volkov proposed openstack/osc-placement master: Provide a useful message in the case of 500-error https://review.openstack.org/586056 | |
| 12:23:00 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use placement 1.28 in scheduler report client https://review.openstack.org/583667 | |
| 12:35:46 | openstackgerrit | OpenStack Release Bot proposed openstack/os-traits stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/586101 | |
| 12:35:48 | openstackgerrit | OpenStack Release Bot proposed openstack/os-traits stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky https://review.openstack.org/586102 | |
| 12:35:50 | openstackgerrit | OpenStack Release Bot proposed openstack/os-traits master: Update reno for stable/rocky https://review.openstack.org/586103 | |
| 12:36:00 | openstackgerrit | OpenStack Release Bot proposed openstack/os-vif stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/586104 | |
| 12:36:02 | openstackgerrit | OpenStack Release Bot proposed openstack/os-vif stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky https://review.openstack.org/586105 | |
| 12:36:05 | openstackgerrit | OpenStack Release Bot proposed openstack/os-vif master: Update reno for stable/rocky https://review.openstack.org/586106 | |
| 12:36:42 | openstackgerrit | OpenStack Release Bot proposed openstack/osc-placement stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/586113 | |
| 12:36:45 | openstackgerrit | OpenStack Release Bot proposed openstack/osc-placement stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky https://review.openstack.org/586114 | |
| 12:39:08 | mriedem | gmann: i'm going to close out https://blueprints.launchpad.net/nova/+spec/api-extensions-merge-rocky for rocky which is a nice cut off point since what remains is the view builder stuff | |
| 12:39:12 | mriedem | i'll open a bp for stein | |
| 12:39:54 | gmann | mriedem: sure. Thanks | |
| 12:44:58 | mriedem | i need some core love on the last 2 changes of the port binding live migration series https://review.openstack.org/#/c/434870/ | |
| 12:45:10 | mriedem | the 2nd change has a +2 already | |
| 12:45:30 | mriedem | gibi: bauzas: dansmith: ^ | |
| 12:45:48 | gibi | mriedem: I'm in the process of reading it right now | |
| 12:46:03 | mriedem | cool, thanks | |
| 12:46:23 | mriedem | melwitt: need a final +2 on https://review.openstack.org/#/c/566813/ to get the queued_for_delete stuff plumbed into the API | |
| 13:01:59 | efried | Hey folks. We should talk about the reshaper series. Does it have a FFE? If not, it's going to need a lot of focus today, particularly since Jay is in pirate mode. | |
| 13:08:02 | mriedem | efried: i think we defer | |
| 13:08:22 | mriedem | we'll be lucky to merge stuff that's already been approved for 24 hours | |
| 13:08:43 | mriedem | this is why i asked the "what if we don't get this done in rocky" question in the ML | |
| 13:09:09 | mriedem | i think it just means the same thing, but in stein - you can't use the new fancy wizbang NRP stuff until you've migrated existing inventory/allocations, right? | |
| 13:09:34 | mriedem | so rather than the migration happening *before* getting to stein, it happens *once* you get to stein | |
| 13:10:39 | efried | mriedem: I think that sounds right. | |
| 13:10:55 | mriedem | melwitt: i think the only client releases today are osc-placement and python-novaclient right? | |
| 13:11:03 | mriedem | the various os-* lib releases were last week | |
| 13:11:10 | efried | mriedem: Obviously any of the bps wanting to do nrp with inventory moves won't happen in Rocky, but that was surely the case anyway at this point. | |
| 13:13:21 | efried | So given that, what can I put my eyeballs on today that will help most? | |
| 13:15:51 | mriedem | efried: i was just going through the bp etherpad https://etherpad.openstack.org/p/nova-rocky-blueprint-status | |
| 13:16:05 | mriedem | i've got 2 functional changes left in the port binding series https://review.openstack.org/#/c/434870/ | |
| 13:16:11 | mriedem | https://review.openstack.org/#/c/566813/ is easy | |
| 13:16:22 | mriedem | needs final +2 for the queued for delete cells v2 stuff | |
| 13:16:38 | mriedem | and then i think we're just rechecking stuff that's already approved | |
| 13:17:15 | efried | I haven't been following the down-cell stuff; am I going to be able to make sense of https://review.openstack.org/#/c/566813/ without context? | |
| 13:18:07 | mriedem | should be able to, commit message explains it - we are just setting a flag on the instance mapping when deleting (or restoring) an instance | |
| 13:18:25 | mriedem | so that if the cell goes down for that instance, we have something in the api db to key off to know if the instance was in the process of being deleted | |
| 13:18:40 | mriedem | the actual down cell handling code will be done in stein | |
| 13:18:49 | mriedem | this is all framework building at this point | |
| 13:19:40 | mriedem | oh and we also have https://review.openstack.org/#/c/566813/ for mgagne's metadata api changes for listing multiple ips/subnets per network attached to the vm | |
| 13:19:42 | efried | k, was gonna ask. Nothing is checking this yet | |
| 13:19:47 | mriedem | efried: right | |
| 13:19:48 | mriedem | so low risk | |
| 13:20:03 | efried | mriedem: wrong link for mgagne's thing? | |
| 13:20:20 | mriedem | yes... | |
| 13:20:27 | mriedem | https://review.openstack.org/#/c/580742/ | |
| 13:28:28 | gibi | mriedem_afk: besides the question in https://review.openstack.org/#/c/434870/37/nova/tests/unit/compute/test_compute_mgr.py@182 I'm +2 | |
| 13:29:23 | bauzas | mriedem_afk: ack, sorry was away | |
| 13:31:19 | mgagne | mriedem_afk, melwitt: if you feel the multi fixed-ips spec needs more work, I don't mind postponing to the next release. I want to make sure all concerns are addressed before implementing it. | |
| 13:45:33 | bauzas | mriedem_afk: dansmith: humpf, I'm torn by https://review.openstack.org/#/c/434870/37/nova/compute/manager.py@1054 | |
| 13:53:09 | melwitt | nova meeting in 7 minutes | |
| 13:53:22 | mriedem_afk | gibi: looking | |
| 13:53:39 | mriedem | mgagne: i approved the spec update | |
| 13:54:12 | mriedem | bauzas: the lazy load thing can be done in the follow up patch right? if we care about that. | |
| 13:55:25 | mriedem | gibi: you're right, good eye | |
| 13:55:26 | melwitt | mgagne: I think it's okay, just wanted to sanity check the 'networks' and 'services' part with dansmith | |
| 13:55:54 | dansmith | mriedem: I think the lazy-load thing is important to fix, personally | |
| 13:56:13 | dansmith | melwitt: link? | |
| 13:56:34 | dansmith | mriedem: I'm having a hard time with encoding this level of libvirtness into that manager-level event handler | |
| 13:56:36 | mriedem | dansmith: gibi: bauzas: ok i'll fix the lazy-load thing to make it conditional and fix that unit test | |
| 13:56:37 | melwitt | dansmith: https://review.openstack.org/#/c/580742/4/releasenotes/notes/multiple-fixed-ips-network-information-e2eabb992b7c1e33.yaml@9 | |
| 13:56:51 | mriedem | dansmith: that's the way this compute manager thing has kind of always been | |
| 13:56:54 | bauzas | mriedem: ack | |
| 13:56:57 | dansmith | mriedem: If you'll do it afterwards I'm okay with that, but I do think it needs to be fixed | |
| 13:57:00 | mriedem | the only other driver that uses the callback is the hyperv driver i think | |
| 13:57:14 | mriedem | i would prefer handling the lazy-load in the follow up if possible given the gate | |
| 13:57:17 | dansmith | mriedem: yes, hyperv does, and I know, but.. this is next level invasiveness | |
| 13:57:27 | mriedem | i don't know what alternative we'd have | |
| 13:57:45 | mriedem | but i do know this works in the post-copy trigger, it shows up in the n-cpu logs in the next patch in the series in the live migration job | |
| 13:57:52 | dansmith | I don't understand why we need this handler to know about both of these states | |
| 13:59:06 | gibi | mriedem: I have one thing to consider in the next patch in that series as well https://review.openstack.org/#/c/522537/35/nova/conductor/tasks/live_migrate.py@279 | |
| 14:00:49 | dansmith | o/ | |