Posted	Nick	Remark
#openstack-nova - 2018-07-25
21:14:35	mgagne	+1
21:16:38	openstackgerrit	Mathieu Gagné proposed openstack/nova master: Add support for multiple fixed-ips in metadata https://review.openstack.org/580742
21:16:43	artom	mriedem, yeah, am looking into it
21:16:46	artom	Really weird
21:18:24	mriedem	dansmith: so does that mean we're good with the move patch for my +2 since we have the functional WIP patch for the move ops?
21:18:27	artom	mriedem, no chance we can merge and later revert really excessive logging?
21:18:35	mriedem	like, are you ok approving the stack and cleaning up the functional patch test later or?
21:18:48	artom	Back in a bit, picking up daughter from daycare
21:18:52	mriedem	i also have to do ^
21:19:20	dansmith	mriedem_afk: oh I should have removed the WIP on that as I think it's okay
21:19:35	dansmith	mriedem_afk: but yeah, I think we need to merge that stack if you're good with it
21:19:42	dansmith	that's what I meant when I asked about your +2
21:21:18	mriedem_afk	want me to +W the bottom change too?
21:22:00	mriedem_afk	did it anyway
21:22:04	mriedem_afk	gotta run
21:47:08	openstackgerrit	Dan Smith proposed openstack/nova master: Add additional functional tests for NUMA networks https://review.openstack.org/585385
22:12:29	openstackgerrit	Mathieu Gagné proposed openstack/nova master: Add support for multiple fixed-ips in metadata https://review.openstack.org/580742
22:13:40	mgagne	mriedem_afk: sorry, I was a bit too hasty in updating the change. Let me know about the expected services field behavior. I will update accordingly.
22:18:10	melwitt	mgagne: well, tbh, I'm not sure what it should be, just pointing out that my prior understanding of the change was that it just adds the ip_addresses field and nothing else changes
22:19:24	melwitt	it might be fine to include more services in 'services' too. I'll add a comment and ask mriedem_afk and dansmith about it tomorrow to see what they think
22:25:42	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153
23:13:50	mgagne	melwitt: thanks for the review, much appreciated. sorry if I didn't make the full extend of the change clear in the initial spec :-/
23:16:19	melwitt	mgagne: that's okay, I'm guessing it's obvious to those more familiar than I. thanks for the prompt replies
23:16:50	mgagne	I shouldn't assume people are familiar with that part ;)
23:18:13	melwitt	I learned new things, that's a plus :)
23:18:55	openstackgerrit	Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927
23:18:56	openstackgerrit	Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033
23:18:57	openstackgerrit	Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598
23:18:58	openstackgerrit	Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599
23:18:59	openstackgerrit	Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648
23:19:00	openstackgerrit	Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034
23:19:01	openstackgerrit	Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049
23:19:02	openstackgerrit	Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236
#openstack-nova - 2018-07-26
00:19:46	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Making consistent used of GiB and MiB in API ref https://review.openstack.org/559985
00:20:33	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514
01:01:20	openstackgerrit	Chris Dent proposed openstack/nova master: [placement] Extract base functional test case from test_direct https://review.openstack.org/585777
01:01:21	openstackgerrit	Chris Dent proposed openstack/nova master: [placement] Use base test in placement functional tests https://review.openstack.org/585778
01:11:34	openstackgerrit	Merged openstack/nova master: Remove support for /os-floating-ips-bulk REST API https://review.openstack.org/582912
01:14:04	openstackgerrit	Merged openstack/nova master: Remove support for /os-floating-ip-dns REST API https://review.openstack.org/582943
01:14:11	openstackgerrit	Merged openstack/nova master: Remove "DEPRECATED" tag from Obsolete APIs https://review.openstack.org/583092
01:14:17	openstackgerrit	Merged openstack/nova stable/pike: cleanup mapping/reqspec after archive instance https://review.openstack.org/580775
01:14:23	openstackgerrit	Merged openstack/nova master: doc: remove rocky-specific nova-scheduler min placement version https://review.openstack.org/585520
02:06:16	naichuans	Txt files which store openstack IRC history reported as trojan and deleted by McAFee, anyone meet such kind of issues before?
02:16:14	openstackgerrit	Artom Lifshitz proposed openstack/nova master: DNM? Extra logs for volume detach device tags cleanup https://review.openstack.org/584032
02:18:27	openstackgerrit	Xiaohan Zhang proposed openstack/nova master: compute node local_gb_used include swap disks The ComputeNode.local_gb_used value is set in the ResourceTracker._update_usage() method: https://review.openstack.org/585928
06:22:34	openstackgerrit	huanhongda proposed openstack/nova master: hypervisor-stats shows wrong disk usages with shared storage https://review.openstack.org/149878
07:12:12	karimull	Hello , do the code freeze for the release applies to bugs related to documentation?
07:22:28	openstackgerrit	Xiaohan Zhang proposed openstack/nova master: compute node local_gb_used include swap disks https://review.openstack.org/585928
07:31:00	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Increase sleep time in ServerGroupTestV21 to avoid potential failure https://review.openstack.org/585978
07:52:52	openstackgerrit	Merged openstack/nova master: Online data migration for queued_for_delete flag https://review.openstack.org/584504
07:53:07	openstackgerrit	Merged openstack/nova master: Annotate flows and handle PortBindingDeletionFailed in ComputeManager https://review.openstack.org/551371
07:53:15	openstackgerrit	Merged openstack/nova master: Remove stevedore extensions server_create method https://review.openstack.org/583882
07:59:08	kashyap	ttx: Morning, do you have mod privileges on this channel? If so, can you kick the above spammers out, please?
08:02:46	lyarwood	kashyap: They are being kicked pretty quickly already
08:03:08	kashyap	lyarwood: Nod; some channels like Freenode's #kvm are still litterred with them :-(
08:03:31	kashyap	lyarwood: But you're right, the Freenode Team is working on it
08:04:01	kashyap	lyarwood: Morning, do you have a minute to look at something here?
08:04:09	kashyap	lyarwood: It's seemingly embarssing PEP8 failure
08:04:34	lyarwood	my forte
08:04:43	kashyap	lyarwood: Hehe, so here we go:
08:04:46	kashyap	On this line here: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/guest.py#L668
08:04:55	kashyap	If I remove that: "# noqa"
08:05:08	kashyap	I get this: ./nova/virt/libvirt/guest.py:665:60: F821 undefined name 'unicode'
08:05:17	kashyap	How is the comment "solving" it?
08:06:01	kashyap	lyarwood: It (that "# noqa") came in via this commit that was trying to fix the PEP8 on Py3 failures: a91af59f
08:06:30	lyarwood	http://pep8.readthedocs.io/en/release-1.7.x/intro.html#error-codes - it's not a comment
08:06:31	kashyap	lyarwood: Sorry for baiting you in the morning. If you're still making coffee or something, please go on. This can wait.
08:06:34	lyarwood	^ search for noqa
08:07:14	kashyap	lyarwood: Most excellent, thanks for the (non-null) pointer!
08:08:01	lyarwood	kashyap: so unicode isn't a keyword in py3 but is in py2
08:08:20	kashyap	lyarwood: Ha! So we indeed need to retain that "# noqa"
08:08:31	lyarwood	yup
08:09:05	kashyap	lyarwood: Thanks, I was going a bit mental right in the morning
08:09:47	kashyap	mdbooth: When you are about, per above discussion with lyarwood, we can't "undent" the "# noqa" here: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/guest.py#L668
08:11:38	lyarwood	kashyap: well you can, the #noqa is just to catch the unicode issue
08:12:21	lyarwood	anyway /me goes back to downstream paper work
08:12:27	kashyap	lyarwood: Alright, I'll look into it.
08:12:36	kashyap	mdbooth: Disregard the above for now; more to come soon in the review
08:29:30	bauzas	re: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/guest.py#L668
08:29:37	bauzas	kashyap: lyarwood: ^
08:30:22	bauzas	kashyap: lyarwood: there is a six method for it
08:30:34	kashyap	bauzas: I see
08:30:39	kashyap	bauzas: Got a link?
08:31:08	bauzas	kashyap: https://pythonhosted.org/six/#six.text_type
08:35:43	bauzas	kashyap: http://paste.openstack.org/show/726668/
08:36:24	bauzas	a 'kéké' in French is a 'lad'
08:38:00	bauzas	kashyap: of course a bytestring is not unicode
08:38:13	kashyap	Hehe
08:40:44	kashyap	bauzas: Thanks!
08:43:05	bauzas	kashyap: final explanation between bytestrings and unicode strings : http://paste.openstack.org/show/726669/
08:43:38	bauzas	using .decode() will translate it into unicode with the encoding you want
08:56:58	kashyap	Nod
09:02:25	mdbooth	kashyap: That's barely worthy of discussion :) Did I call it a nit? If not, I should have done.
09:06:39	kashyap	mdbooth: Hehe, I just make sure every point a reviewer raises is addressed, and not coldly ignore :P
09:07:00	kashyap	Address, if it makes sense, i.e.
09:07:24	mdbooth	kashyap: Yeah. I couldn't even tell, by eyeball, if the line was short enough.
09:07:30	mdbooth	But I thought it probably was.
09:08:42	kashyap	mdbooth: Ah, by "undent", I actually thought you wanted me to use a different way than the "# noqa" special comment
09:09:05	kashyap	Look for "# noqa" there: http://pep8.readthedocs.io/en/release-1.7.x/intro.html#error-codes
09:09:27	mdbooth	I assumed it was there for line length?

Earlier   Later