Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-07-13
16:01:26 dansmith I was just thinking it might be good to clear that road before I go, but yeah
16:01:34 mriedem i think the 3 options i pointed out yesterday were:
16:02:09 mriedem 1. make RequestSpec.network_metadata nullable so that create_resource_requests can return None and we just blindly set it (which is what he'd be doing as coded today),
16:02:45 mriedem 2. keep reqspec.network_metadata non-nullable and then: (a) he has to return an 'empty' NetworkMetadata if no networking or (b) leave RequestSpec.network_metadata unset
16:02:54 mriedem i don't really like 2-a
16:03:22 dansmith yeah I mean 2b is what I was thinking
16:03:23 mriedem since you can't tell if the network metadata is 'empty' because the user requested no networking, or because the network just doesn't have physnet/tunneled
16:03:27 dansmith right
16:03:34 mriedem i'm cool with 2-b
16:03:40 dansmith or not 2-b?
16:03:52 mriedem i'll pretend that didn't happen
16:04:01 dansmith haha
16:04:17 mriedem if 2-b, we can drain the bottom half now and he'll just have to handle the 'if network_metadata is not None: reqspec.network_metadata = network_metadata" in the API
16:04:21 mriedem but that's easy enough,
16:04:30 mriedem and his hardware.py change are already unset-aware
16:04:31 dansmith kinda need him to agree to that though right?
16:04:42 mriedem stephenfin: ^ agree?
16:05:01 mriedem dansmith: do we? this is the week where you and i just take over everyone's changes
16:05:07 dansmith heh
16:05:22 dansmith stephenfin: it's four minutes past beer o clock, what are you still doing here?
16:05:40 stephenfin dansmith: I had beer o'clock last night and started late :(
16:05:50 stephenfin But we won our tag (rugby) final
16:06:02 dansmith heh
16:06:29 stephenfin a'ight, what do you need from me, mriedem?
16:06:39 stephenfin the null'ness thing is still up in the air, right?
16:06:51 mriedem stephenfin: summarized above
16:06:56 mriedem with dansmith and my preferred option
16:07:04 mriedem which also allows us to start draining the bottom half of the series
16:07:18 mriedem (11:01:38 AM) mriedem: i think the 3 options i pointed out yesterday were:
16:07:19 mriedem (11:02:13 AM) mriedem: 1. make RequestSpec.network_metadata nullable so that create_resource_requests can return None and we just blindly set it (which is what he'd be doing as coded today),
16:07:19 mriedem (11:02:49 AM) mriedem: 2. keep reqspec.network_metadata non-nullable and then: (a) he has to return an 'empty' NetworkMetadata if no networking or (b) leave RequestSpec.network_metadata unset
16:07:23 mriedem we both want 2-b
16:08:06 stephenfin I'm fine with 1 or 2-b. 2-a does feel weird
16:08:21 mriedem ok 2-b it is and we can start approving patches
16:09:10 stephenfin cool. I'll throw an eye over the last few patches again and address all those comments of yours I missed yesterday
16:10:40 mriedem dansmith: there +W up to https://review.openstack.org/#/c/564442/
16:10:45 mriedem bbiab
16:11:19 dansmith woot
16:34:10 stephenfin dansmith: Thoughts on https://review.openstack.org/#/c/564444/14/nova/objects/fields.py@76 ?
16:34:50 stephenfin I'd read that comment as "these are the things we don't use directly in our models" but that's not what it means. Just remove that comment?
16:36:31 dansmith stephenfin: those are aliases, because much of that file was initially all in nova,
16:36:48 dansmith and so we did that so we could remove the top half, move it to ovo without changing all the references to things like "Set" below
16:36:55 dansmith well, not set, that clearly got added later
16:37:11 dansmith as the comment says, that whole list should go away, and should have years ago
16:37:14 dansmith you shouldn't add to it,
16:37:20 dansmith just use fields.String below where you use String now
16:37:32 stephenfin Oh, so I should have used 'fields.String' directly?
16:37:36 dansmith yes
16:37:46 stephenfin Cool. I'll fix that in this follow-up
16:43:08 dansmith commented for the credit^W^Wposterity
16:47:13 openstackgerrit Matt Riedemann proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505
16:47:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542
16:47:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file https://review.openstack.org/581562
17:41:22 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Add '[neutron] physnets' and related options https://review.openstack.org/564440
17:41:23 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_metadata field https://review.openstack.org/564441
17:41:24 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.network_metadata https://review.openstack.org/564452
17:41:25 openstackgerrit Stephen Finucane proposed openstack/nova master: Assorted cleanups from numa-aware-vswitches series https://review.openstack.org/582651
18:33:52 openstackgerrit Matt Riedemann proposed openstack/nova master: API: add support to abort queued live migration in microversion 2.64 https://review.openstack.org/573136
18:46:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542
18:46:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file https://review.openstack.org/581562
18:46:18 openstackgerrit Matt Riedemann proposed openstack/nova master: API: add support to abort queued live migration in microversion 2.64 https://review.openstack.org/573136
18:48:51 mriedem dansmith: i assume you're doneso
18:49:03 dansmith soon
18:49:05 dansmith wassup?
18:49:08 dansmith o
18:49:32 mriedem likely not a series you want to hit while you're in vacation brain
18:50:04 mriedem this is the compute service version check i added in there fwiw https://review.openstack.org/#/c/573136/8/nova/compute/api.py
18:51:52 mriedem didn't realize that was still in a runway slot, so i guess some other intrepid core will hit those
18:52:00 dansmith and we pass that flag from the api if the microversion was new enough?
18:52:03 mriedem if only one were around...
18:52:05 mriedem yeah
18:52:13 dansmith ack yeah
18:52:13 mriedem https://review.openstack.org/#/c/573136/8/nova/api/openstack/compute/server_migrations.py
18:53:13 dansmith yeah looks okay to me at skim-level
19:06:09 mriedem looks like we have a new functional test race bug https://bugs.launchpad.net/nova/+bug/1781648
19:06:10 openstack Launchpad bug 1781648 in OpenStack Compute (nova) "heal_allocations test randomly failing with "ValueError: Field `compute_node_uuid' cannot be None"" [Medium,Confirmed]
19:07:05 openstackgerrit Eric Fried proposed openstack/nova master: PoC: reshaper guts with inventory two-step https://review.openstack.org/582663
19:27:00 openstackgerrit Merged openstack/nova master: Heal allocations with incomplete consumer information https://review.openstack.org/574488
19:36:12 mriedem https://blueprints.launchpad.net/nova/+spec/ironic-rescue-mode is now in a runway slot
19:36:19 mriedem needs final +2s
19:36:22 mriedem pretty simple
19:43:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle HostMappingNotFound when deleting a compute service https://review.openstack.org/582674
20:00:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Stop using HostAPI.service_delete https://review.openstack.org/582680
21:19:02 fried_rice mriedem, needssleep: Sent ironic-rescue-mode patches to the gate
21:19:51 needssleep fried_rice: That is like... the best news possible for the end of a Friday! Thanks!
21:19:57 fried_rice :)
21:23:57 needssleep uhg, postfails in ironic's gate
21:24:27 needssleep and nova, and swift
21:24:29 needssleep woot
21:25:28 needssleep static and logs.o.o is apparently non-responsive
21:25:44 needssleep Some chat in the infra room
21:26:03 needssleep Anyway, I'm going to go not sit in front of a computer for a while, thanks everyone!
22:28:41 openstackgerrit Eric Fried proposed openstack/nova master: perform reshaper operations in single transaction https://review.openstack.org/582383
22:28:42 openstackgerrit Eric Fried proposed openstack/nova master: WIP: [placement] Add /reshaper handler for POST https://review.openstack.org/576927
22:28:43 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236
#openstack-nova - 2018-07-14
01:18:23 openstackgerrit Ken'ichi Ohmichi proposed openstack/nova master: DNM: Test a common "irrelevant-files" https://review.openstack.org/582700
02:30:10 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix ServerMigrationSampleJsonTests to use sample files from version dir https://review.openstack.org/582702
02:31:21 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix ServerMigrationSampleJsonTests to use sample files from version dir https://review.openstack.org/582702
08:04:12 openstackgerrit Chen proposed openstack/nova master: Clean up group members in db when delete https://review.openstack.org/581403
08:49:40 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix ServerMigrationSampleJsonTests to use sample files from version dir https://review.openstack.org/582702

Earlier   Later