| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-07-12 | |||
| 23:16:21 | melwitt | if we want to do that, we'd have to add some conditionals in the Service.save() method to skip things like the version check if self.deleted and do something to handle ServiceNotFound | |
| 23:16:36 | melwitt | *if we want to generate UUID for deleted service | |
| 23:16:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass request_spec from compute to cell conductor on reschedule https://review.openstack.org/582417 | |
| 23:16:49 | cfriesen | melwitt: seems plausible that it'd fix the problem. | |
| 23:17:44 | melwitt | I'm gonna add another functional regression test to the stack for the bug you linked to verify it | |
| 23:18:26 | melwitt | maybe we'll have to do a different approach to fix things but the functional tests should be useful either way | |
| 23:27:17 | mriedem | TheJulia: couple of small things in https://review.openstack.org/#/c/582416/ | |
| 23:29:01 | TheJulia | I can revise once the ironic jobs finish, otherwise zuul will flag everything as mergefail and then even more fun :( | |
| 23:29:22 | mriedem | yeah | |
| 23:31:15 | mriedem | +2 on the rescue driver change itself now at least | |
| 23:32:33 | TheJulia | mriedem: awesome! Thanks! | |
| #openstack-nova - 2018-07-13 | |||
| 00:30:19 | openstackgerrit | Merged openstack/nova master: Update process doc to be more generic about point of contact https://review.openstack.org/582312 | |
| 00:43:13 | openstackgerrit | Merged openstack/nova master: Handle rebuild of instances with image traits https://review.openstack.org/569498 | |
| 01:04:13 | openstackgerrit | Vu Cong Tuan proposed openstack/nova-specs master: Switch to stestr https://review.openstack.org/581284 | |
| 01:17:52 | mriedem | https://review.openstack.org/569498 merged so we can mark that bp complete and move it out of the runway slot | |
| 01:18:59 | melwitt | mriedem: ack, thanks | |
| 01:19:32 | openstackgerrit | Vu Cong Tuan proposed openstack/python-novaclient master: Switch to stestr https://review.openstack.org/582090 | |
| 01:21:19 | melwitt | mriedem: I put next in line into a runway and made the end date July 26 FF (instead of July 27) | |
| 01:21:36 | mriedem | melwitt: comment on https://review.openstack.org/#/c/582312/ if you wanted to make that more actionable | |
| 01:22:05 | melwitt | thanks | |
| 01:34:42 | openstackgerrit | melanie witt proposed openstack/nova master: Add functional regression test for bug 1778305 https://review.openstack.org/582407 | |
| 01:34:43 | openstack | bug 1778305 in OpenStack Compute (nova) "Nova may erronously look up service version of a deleted service, when hostname have been reused" [Undecided,In progress] https://launchpad.net/bugs/1778305 - Assigned to melanie witt (melwitt) | |
| 01:34:44 | openstackgerrit | melanie witt proposed openstack/nova master: Don't generate service UUID for deleted services https://review.openstack.org/582408 | |
| 01:34:44 | openstackgerrit | melanie witt proposed openstack/nova master: Add functional regression test for bug 1764556 https://review.openstack.org/582435 | |
| 01:34:46 | openstack | bug 1764556 in OpenStack Compute (nova) ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,In progress] https://launchpad.net/bugs/1764556 | |
| 01:36:38 | mriedem | Kevin_Zheng: i see you didn't change anything about the rpc api version handling in https://review.openstack.org/#/c/568542/ - i'll see if i can talk with dansmith about that tomorrow morning so we can sort that out (he's on vacation next week) | |
| 01:37:13 | mriedem | Kevin_Zheng: are you going to rebase https://review.openstack.org/#/c/573136/ back onto the top of that series? | |
| 01:38:02 | Kevin_Zheng | mriedem, yeah, I was planning to collect more ideas on version checks | |
| 01:39:29 | Kevin_Zheng | mriedem, I did all the updates to the API patch, but somehow the branch got messed up when I upload it, so I'm going to do it again today | |
| 01:39:30 | mriedem | i guess dansmith is saying the version checks would be redundant in the compute api and rpc api, | |
| 01:39:38 | mriedem | because if you can't send 5.1, that's all the check you need | |
| 01:39:50 | Kevin_Zheng | yeah, they are suggesting do it in API only | |
| 01:39:59 | Kevin_Zheng | I mean Alex and Gmann | |
| 01:40:03 | mriedem | dan is saying doing it all in rpcapi | |
| 01:40:10 | mriedem | b/c that's what has the can_send_version check | |
| 01:40:13 | mriedem | and knows the upgrade_levels pin | |
| 01:40:26 | mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#upgrade-levels | |
| 01:40:41 | mriedem | the API could tell us that the compute is running version 33 but the rpc api might be pinned to rocky, | |
| 01:40:49 | mriedem | at which point can_send_version would still fail the 5.1 check | |
| 01:41:08 | mriedem | also good lord that's a wall of text ^ | |
| 01:41:08 | Kevin_Zheng | hmmm this doc helps | |
| 01:41:40 | gmann | mriedem: what is case where node has compute 33 and RPC API not pinned ? | |
| 01:42:37 | gmann | mriedem: Kevin_Zheng the only reason of checking in api we thought is early revert back the request. check in rpc is needed as you and dansmith mentioned | |
| 01:43:11 | mriedem | you can fail fast and return an error to the user in either place | |
| 01:43:17 | mriedem | since the check happens before the cast to compute | |
| 01:43:41 | mriedem | i'm trying to sort out if we can *move* the !running check from api to rpcapi | |
| 01:43:45 | mriedem | otherwise it's redundant | |
| 01:44:00 | mriedem | this https://review.openstack.org/#/c/568542/17/nova/compute/api.py@4427 | |
| 01:44:11 | gmann | mriedem: you mean from rpc to api ? | |
| 01:44:38 | mriedem | api to rpc | |
| 01:44:38 | gmann | agree to have check of !running in single place, either one | |
| 01:44:50 | gmann | humm | |
| 01:44:51 | Kevin_Zheng | Hmm, that is for microversion | |
| 01:44:52 | mriedem | nova.compute.api.API can't do the rpc version check | |
| 01:44:58 | mriedem | it doesn't have the can_send_version logic | |
| 01:45:05 | mriedem | that's in nova.compute.rpcapi | |
| 01:45:11 | Kevin_Zheng | I mean, we should check for microversion first | |
| 01:45:22 | mriedem | right that's what is confusing me | |
| 01:45:29 | mriedem | because we need to build in the microversion logic as well | |
| 01:45:35 | Kevin_Zheng | yeah | |
| 01:46:12 | mriedem | but couldn't we just pass support_abort_in_queue to rpcapi? | |
| 01:46:14 | mriedem | and do the logic there? | |
| 01:46:35 | mriedem | then your acceptable status values are based on (1) the microversion and (2) the rpcapi version | |
| 01:46:57 | mriedem | allowed_statuses = ['running'] | |
| 01:46:59 | mriedem | if support_abort_in_queue: | |
| 01:47:16 | Kevin_Zheng | and can_send_version? | |
| 01:47:20 | mriedem | yeah, | |
| 01:47:29 | mriedem | if support_abort_in_queue and can_send_version(5.1): | |
| 01:47:41 | mriedem | allowed_statuses.extend(['queued', 'preparing']) | |
| 01:47:51 | gmann | microversion check is on APOI controller side not enough ? | |
| 01:47:52 | Kevin_Zheng | Then should I merge patch 2 and 4? | |
| 01:47:53 | mriedem | if migration.status not in allowed_statuses: | |
| 01:47:54 | gmann | API | |
| 01:47:58 | mriedem | raise exception.InvalidMigrationState( | |
| 01:48:12 | mriedem | gmann: no because if the compute is queens, | |
| 01:48:20 | mriedem | it doesn't know how to cancel a migration in queued or preparing status | |
| 01:49:11 | gmann | that what compute version or rpc version check will handle right | |
| 01:49:19 | mriedem | Kevin_Zheng: i don't think you merge them | |
| 01:49:56 | mriedem | Kevin_Zheng: i think patch 2 has the rpcapi version bump b/c of the signature change | |
| 01:50:12 | mriedem | and then in the same change that adds the microversion, you can move the status checking from api into rpcapi | |
| 01:50:26 | mriedem | based and pass in the support_abort_in_queue flag | |
| 01:50:35 | Kevin_Zheng | move it in patch 4? | |
| 01:50:36 | mriedem | *pass in the support_abort_in_queue | |
| 01:51:21 | gmann | this one will be passed all way till rpc right? - https://review.openstack.org/#/c/573136/6/nova/api/openstack/compute/server_migrations.py@149 | |
| 01:51:45 | openstackgerrit | Chen proposed openstack/nova master: fix cellv2 delete_host https://review.openstack.org/582171 | |
| 01:52:06 | mriedem | gmann: that's what i'm suggesting, | |
| 01:52:13 | mriedem | i'll leave a comment on patch 2 and then i need to call it a day | |
| 01:52:13 | gmann | ohk. i got confuse when you mentioned microversion checks on compute.apy.py | |
| 01:52:19 | mriedem | and i'll talk to dansmith about my idea in the morning | |
| 01:52:47 | Kevin_Zheng | Ok, good night | |
| 01:53:55 | openstackgerrit | Julia Kreger proposed openstack/nova master: ironic: provide facilities to gracefully navigate versions https://review.openstack.org/582416 | |
| 01:54:45 | TheJulia | mriedem: looks like I'll need to tune some job timeouts with that rescue test :\ Something for tomorrow since we seem to have a job that now wants to time out independently as well :\ | |
| 01:56:13 | openstackgerrit | Julia Kreger proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | |
| 01:56:23 | TheJulia | mriedem: parent update rebase ^ | |
| 01:57:24 | mriedem | Kevin_Zheng: gmann: dansmith: left my idea in https://review.openstack.org/#/c/568542/ | |
| 01:58:03 | Kevin_Zheng | Thanks I think it will work, lets collect more ideas. | |
| 01:58:59 | mriedem | TheJulia: thanks, lgtm | |
| 01:59:56 | TheJulia | mriedem: no, thank you! :) | |
| 02:02:31 | gmann | mriedem: thanks. ll check | |
| 02:19:32 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform instance.live_migration_force_complete notification https://review.openstack.org/480561 | |