| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-07-10 | |||
| 22:59:12 | openstackgerrit | Merged openstack/nova master: Update root providers in same tree https://review.openstack.org/580246 | |
| 22:59:22 | openstackgerrit | Merged openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | |
| 22:59:36 | openstackgerrit | Merged openstack/nova master: Refactor policies to policy in InstanceGroup DB model https://review.openstack.org/579113 | |
| 23:31:11 | openstackgerrit | Merged openstack/os-vif master: doc: Fix formatting issues https://review.openstack.org/580443 | |
| #openstack-nova - 2018-07-11 | |||
| 00:23:02 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform metrics.update notification https://review.openstack.org/580567 | |
| 00:24:04 | openstackgerrit | Merged openstack/os-vif master: Remove unnecessary pyNN testenv sections https://review.openstack.org/577686 | |
| 00:30:29 | openstackgerrit | Merged openstack/os-vif master: Remove [tox:jenkins] section from tox.ini https://review.openstack.org/580886 | |
| 00:48:14 | gmann | mriedem: alex_xu yeah, those are being ignored as per additionalProporties=True | |
| 00:49:15 | gmann | mriedem: alex_xu same legacy issue we had to keep about --all-tenant which i tired to fix but its more UX tradeoff and where we should fix in APi or on client side - https://review.openstack.org/#/c/198184/ | |
| 00:50:08 | gmann | mriedem: alex_xu how about doing additionalProperties=False with microversion in stein so that user can get clear 400 instead of confusing ignore things. | |
| 00:50:55 | gmann | and we can include more API fixes in that as mriedem said. i can start a etherpad for that and then we choose appropriate issues to fix in single version bump | |
| 00:51:22 | gmann | if you guys have not started that yet | |
| 00:53:41 | openstackgerrit | Merged openstack/nova master: update project/user for consumer in allocation https://review.openstack.org/581139 | |
| 01:02:29 | mriedem | gmann: no one has started an etherpad yet | |
| 01:03:04 | gmann | mriedem: ok. | |
| 01:05:57 | Kevin_Zheng | mriedem Hi, thanks for the review on my patch, I have one question and I left a comment on yikun's patch yesterday, | |
| 01:06:09 | mriedem | ok | |
| 01:06:31 | Kevin_Zheng | on what scenario should I bump compute version to 5.1 and what scenario to 5.0? | |
| 01:06:58 | Kevin_Zheng | like the last 3 bump was still 5.0 but added 3 versions | |
| 01:07:08 | mriedem | those were for behavioral changes | |
| 01:07:16 | mriedem | the rpc api version itself changes if the rpc api changes | |
| 01:07:23 | mriedem | like adding/changing parameters in an rpc api method | |
| 01:07:29 | mriedem | like you did in live_migration_abort | |
| 01:07:56 | mriedem | e.g. # Version 31: The compute manager checks if 'trusted_certs' are supported | |
| 01:07:56 | Kevin_Zheng | OK, I got it, that also what I thought | |
| 01:08:13 | mriedem | there is a version check for minimum nova-compute >= 31 if trying to create a server with trusted_certs | |
| 01:08:33 | Kevin_Zheng | ok, so it checks for 31 instead of 5.0 | |
| 01:08:54 | mriedem | yeah because 5.0 doesn't really tell us if trusted_certs is supported in the compute or not | |
| 01:09:04 | Kevin_Zheng | got it | |
| 01:09:34 | Kevin_Zheng | I think I will reply other comments in the patch :) | |
| 01:09:35 | mriedem | similar to yikun's late affinity check policy change | |
| 01:09:43 | mriedem | it's a behavior change in how we check late affinity on the compute | |
| 01:09:48 | mriedem | not an actual interface change in the rpc api | |
| 01:28:19 | Kevin_Zheng | mriedem replied on https://review.openstack.org/#/c/573136/ about why 2.24 sample files were added | |
| 01:29:07 | Kevin_Zheng | I will try to be more clear about this, tring to remember all the details, has been a long time :) | |
| 01:33:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Update some placement docs to reflect modern times https://review.openstack.org/581151 | |
| 01:34:18 | openstackgerrit | Merged openstack/nova master: unquiesce instance after quiesce failure https://review.openstack.org/550865 | |
| 01:34:47 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use hard coded values in schema than reference https://review.openstack.org/581288 | |
| 01:34:49 | mriedem | Kevin_Zheng: i saw the inheritance but i still don't really understand it | |
| 01:36:32 | Kevin_Zheng | mriedem, yeah, I'm trying to remember it but forgot some of the details. | |
| 01:37:08 | mriedem | i see that we don't have any api samples for ServerMigrationsSampleJsonTestV2_24 | |
| 01:37:58 | Kevin_Zheng | yeah, because it dont have microversion | |
| 01:38:03 | mriedem | i think it's the _read_template method | |
| 01:38:23 | mriedem | Kevin_Zheng: can you fix that separately? | |
| 01:38:38 | Kevin_Zheng | it has api.microversion and read_template uses self.microversion | |
| 01:38:49 | mriedem | fix the 2.24 api samples tests in a separate change before your new microversion | |
| 01:39:03 | mriedem | hell push that up outside of the series now and i'll approve it | |
| 01:39:06 | Kevin_Zheng | I don't know, because it was correct before my adding | |
| 01:39:14 | Kevin_Zheng | OK | |
| 01:39:40 | Kevin_Zheng | I still want to tell you the root cause though :) | |
| 01:39:49 | mriedem | i see the root issue, | |
| 01:39:52 | Kevin_Zheng | it is something in the setup | |
| 01:39:57 | mriedem | yeah i see that | |
| 01:40:01 | mriedem | ServerMigrationsSamplesJsonTestV2_23 is doing it correctly | |
| 01:40:37 | Kevin_Zheng | OK then I will make it a seperate patch | |
| 01:40:44 | Kevin_Zheng | I have to rebase anyway | |
| 01:41:05 | mriedem | the 2.24 api sample test is posting the live migration and deleting it with 2.24 but using the 2.1 sample | |
| 01:41:22 | mriedem | because the actual request didn't change between then it works | |
| 01:42:45 | Kevin_Zheng | Ah, I got it | |
| 01:42:59 | Kevin_Zheng | if we inherent 2.24 | |
| 01:43:09 | Kevin_Zheng | it was setup first | |
| 01:43:26 | Kevin_Zheng | and then again self.api.microversion was assigned to be 2.25 | |
| 01:43:28 | Kevin_Zheng | 2.24 | |
| 01:44:12 | Kevin_Zheng | because self.api.microversion=2.24 is after super.setup() | |
| 01:45:36 | Kevin_Zheng | and since it is wrpped in setUp, I can do nothing | |
| 01:46:25 | mriedem | yup | |
| 01:47:45 | Kevin_Zheng | yeah, I'm still young, I can remember things | |
| 01:48:18 | mriedem | what were we talking about again? | |
| 01:48:47 | Kevin_Zheng | I cant remember | |
| 02:07:22 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | |
| 02:13:27 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix TypeError in prep_resize allocation cleanup https://review.openstack.org/581548 | |
| 02:15:09 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table https://review.openstack.org/579747 | |
| 02:17:28 | jichen | alex_xu: API meeting 2pm today ? | |
| 02:18:53 | yikun | mriedem: hi, a question on policy notification, should we also do type convert in notification? | |
| 02:18:54 | openstackgerrit | Merged openstack/os-vif master: Fix docstrings to work with Sphinx 1.7.4 https://review.openstack.org/577028 | |
| 02:18:56 | yikun | ^ https://review.openstack.org/#/c/563401/28/nova/tests/unit/compute/test_compute_utils.py@1181 | |
| 02:19:39 | yikun | I mean should we change {"max_server_per_host": "3"} to {"max_server_per_host": 3} in notification | |
| 02:19:42 | mriedem | yikun: i don't think it's necessary to duplicate that type conversion for the notifications | |
| 02:22:46 | yikun | ok, got it, I just thought should keep same format in obj and notification-obj. | |
| 02:23:17 | yikun | and also if user create a group with {"max_server_per_host": 3}, but notification is {"max_server_per_host": "3"} | |
| 02:23:38 | yikun | just not sure it's okay for user or not. | |
| 02:23:55 | mriedem | it doesn't matter too much to me either way, i just don't really like the duplicate code | |
| 02:24:06 | mriedem | you could ask gibi for his opinion when he's up | |
| 02:25:24 | yikun | gibi: fortunately, gibi is online, could you give me some suggestion on it? | |
| 02:25:44 | openstackgerrit | Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317 | |
| 02:26:44 | mriedem | it's about 4:30am for gibi | |
| 02:26:47 | mriedem | so he's online but not relaly | |
| 02:26:49 | mriedem | *really | |
| 02:26:55 | mriedem | he's in budapest | |
| 02:28:46 | mriedem | i on the other hand need to go to bed | |
| 02:28:46 | mriedem | o/ | |
| 02:29:20 | yikun | ha, have a good night. | |
| 02:33:59 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table https://review.openstack.org/579747 | |
| 02:43:06 | gmann | jichen: yes, 2 PM for you. | |
| 02:43:36 | jichen | gmann: got it , thank you, I will arrange my time to join, in this channel, right? | |
| 02:43:37 | gmann | jichen: if you are in china :) its 6 UTC though | |
| 02:43:48 | gmann | jichen: yes, on nova channel only | |
| 02:44:04 | jichen | gmann: yes, I am in china :) | |
| 02:56:45 | openstackgerrit | Merged openstack/nova master: Remove unused variable in migration https://review.openstack.org/581464 | |
| 02:58:58 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505 | |