| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-06-28 | |||
| 17:27:00 | efried | and I'm just trying to get confirmation of that so I can respond with... confidence :) | |
| 17:29:03 | jangutter | efried: however. os-vif is still inside Nova at this point, so it's conceivable to think of something like like a query mechanism. It's fraught with peril though. | |
| 17:29:49 | efried | jangutter: I'm more concerned about the intent of the architecture than any gory details of the existing implementation. | |
| 17:30:36 | efried | jangutter: I think I've got what I need here. Dankie vir die hulp. | |
| 17:30:44 | jangutter | efried: Plesier! | |
| 17:31:34 | jangutter | efried: the os-acc object should be translateable to libvirt xml without any plugin intervention whatsoever. | |
| 17:34:03 | efried | jangutter: But the point is that nobody outside of the plugin itself should need to do that. | |
| 17:35:53 | jangutter | efried: with os-vif, the translation from the os-vif object to libvirt xml happens inside Nova (completely outside os-vif, and not inside the plugin). | |
| 17:36:43 | efried | jangutter: Hm, then I must be missing where that's being injected into the instance's XML. I'll look again... | |
| 17:38:36 | efried | mriedem: From here https://review.openstack.org/#/c/569498/6/nova/conductor/manager.py@1029 is there no better way to discover the compute node RP than ComputeNode.get_by_host_and_nodename() ? | |
| 17:39:06 | jangutter | efried: Here's one way it gets converted: https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_vif.py#L1795 | |
| 17:42:44 | efried | jangutter: Aha, I see it now. The plug method isn't returning anything, but the vif object is being used afterwards. Thanks for the pointer. | |
| 17:43:39 | jangutter | efried: yeah, a couple of os-vif plugins just pass, because libvirt does the heavy lifting. | |
| 17:43:54 | efried | In Power's case, it'll be vice versa. | |
| 17:48:34 | mriedem | efried: that's pretty common lookup for the 'source' compute in move operations at least, | |
| 17:49:02 | mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L205 | |
| 17:49:14 | mriedem | where self.source = instance.host | |
| 17:49:38 | mriedem | we can rebuild ironic nodes so we'd really need to call ComputeNode.get_by_host_and_nodename() using instance.host and instance.node | |
| 17:49:40 | efried | mriedem: Yeah, saw that. It just seemed pretty heavy-weight. Thought there might be a lighter way to get the compute node UUID. | |
| 17:49:47 | mriedem | from the instance? | |
| 17:50:07 | efried | yeah, or from something else we could potentially have at that point in the code path. | |
| 17:50:24 | efried | like maybe we already looked it up somewhere... | |
| 17:51:09 | mriedem | not for rebuild | |
| 17:52:10 | efried | okay, thanks. | |
| 17:52:42 | mriedem | i don't see ComputeNode.get_by_host_and_nodename() being used in that code, so i'm kind of missing the link - they are just looking up the provider tree a different way right? | |
| 17:53:04 | mriedem | so you're going to tell them to use ComputeNode.get_by_host_and_nodename() ? | |
| 17:55:32 | efried | mriedem: It was karimull's idea to do that; I was just wanting to verify that there wasn't a better way. | |
| 17:56:02 | efried | (karimull has a tendency to PM me rather than tagging me in here, which would be better, hint hint.) | |
| 18:07:43 | efried | Dude, this cyborg stuff is, like, a full-time job. | |
| 18:08:01 | cdent | s/cyborg/*/ | |
| 18:08:15 | cdent | too many things | |
| 18:14:32 | mriedem | you need to accelerate | |
| 18:14:37 | mriedem | amphetamines | |
| 18:14:54 | mriedem | Meth-as-a-service?! | |
| 18:41:58 | cdent | that acronym's taken | |
| 20:17:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use consumer generation in _heal_allocations_for_instance https://review.openstack.org/577905 | |
| 20:33:34 | mriedem | efried: yeah this is fun https://review.openstack.org/#/c/576099/ | |
| 20:34:03 | mriedem | i think that especially probably kills vcenter because it's 1 compute service per vcenter cluster, which can have like what 1000s of vms? | |
| 20:34:16 | mriedem | i wonder if powervc has hit something like that... | |
| 20:34:51 | mriedem | i sent it on to our internal perf team b/c they hit some similar types of issues where the big lock in the RT was being held too long when there are like 80 vms on the same host | |
| 20:55:03 | openstackgerrit | Corey Bryant proposed openstack/nova master: Refresh block device connection_info on hard reboot https://review.openstack.org/579004 | |
| 21:03:07 | openstackgerrit | Eric Fried proposed openstack/nova master: RT stats deepcopy 1x/node instead of 1x/instance https://review.openstack.org/576591 | |
| 21:31:27 | openstackgerrit | karim proposed openstack/nova master: Handle rebuild of instances with image traits https://review.openstack.org/569498 | |
| 21:40:48 | efried | mriedem: "kind of surprising given it was red hat people adding it" A guy who worked at IBM is surprised that one guy in a company with thousands of employees could have no clue what's happening in the next department over? | |
| 21:41:25 | efried | ffs, I can't tell you what most of the people in my *own* department are doing. | |
| 21:44:45 | mriedem | i hold red hatters to a higher standard... | |
| 21:44:56 | mriedem | i mean, they all wear the same red hat | |
| 21:45:03 | mriedem | therefore, should have a shared knowledge base | |
| 21:45:07 | mriedem | like the borg | |
| 21:45:35 | mriedem | efried: you don't have to endure daily standups? | |
| 21:45:54 | efried | I almost never stand | |
| 21:46:12 | efried | Is standup the new scrum? | |
| 21:46:30 | efried | I have a daily scrum on my calendar. But... that's pretty much where it stays. | |
| 21:46:57 | mriedem | synonyms i think | |
| 21:47:04 | mriedem | i think some people literally stand during their scrum though | |
| 21:47:05 | mriedem | for some reason | |
| 21:47:07 | mriedem | whiteboarding? | |
| 21:47:25 | efried | I also have a weekly thing on my calendar that's called "scrum" that bears no resemblance to an actual scrum. Scheduled for an hour, for starters. | |
| 21:47:29 | mriedem | my posture was almost always the worst of the day during a scrum | |
| 21:47:34 | efried | DEs <rolls eyes> what can you do? | |
| 21:47:43 | mriedem | scrum of scrums?! | |
| 21:48:01 | efried | It isn't even that. | |
| 21:48:04 | mriedem | scrumaggedon | |
| 21:48:20 | efried | It's ppt pushers getting together to decide what ppt they're going to push on what exec | |
| 21:49:02 | efried | I'm sure it's very important. Just not for me. | |
| 21:49:39 | openstackgerrit | Rick Bartra proposed openstack/nova master: Add granularity to os-services API https://review.openstack.org/578553 | |
| 21:49:44 | cfriesen | I used to do an *actual* scrum...playing rugby | |
| 21:50:37 | efried | yeah, me too. For like a week and a half when I was like 14. And I was like, wait, we do this in *winter*? And, like, *hit* each other? | |
| 21:51:39 | efried | Ironically, now that I'm 41, I grapple with people year round and have cauliflower ear as if I actually stuck with the rugby. | |
| 21:52:25 | cfriesen | I was going to say... | |
| 21:54:12 | openstackgerrit | Rick Bartra proposed openstack/nova master: Add granularity to os-services API https://review.openstack.org/578553 | |
| 22:23:47 | mriedem | efried: can you answer my question in https://review.openstack.org/#/c/519601/ before i approve? | |
| 22:24:19 | efried | ... | |
| 22:26:47 | efried | mriedem: Done, hope it's clear. | |
| 22:27:14 | mriedem | ah ok | |
| 22:28:00 | efried | looking at your other comment now, you async reviewer, you. | |
| 22:28:30 | efried | done | |
| 22:41:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: Fix the rescue race for vGPU instances https://review.openstack.org/577424 | |
| 23:35:19 | melwitt | efried: this bug looks up your alley, ksa UnknownConnectionError, maybe you could triage whether there's a problem there or if it's just a deployment issue? https://bugs.launchpad.net/nova/+bug/1778498 | |
| 23:35:19 | openstack | Launchpad bug 1778498 in OpenStack Compute (nova) "cannot launch instance" [Undecided,New] | |
| #openstack-nova - 2018-06-29 | |||
| 00:40:22 | gmann | melwitt: mriedem thanks, and sorry for starting that BP late :) | |
| 00:41:33 | gmann | efried: heh :)you will find that word in all 3 set of changes for that BP :) | |
| 00:45:34 | gmann | alex_xu: please check this carefully, it is merging the logic of device tag microversion of 2.32 only which we reintroduced in 2.42 - https://review.openstack.org/#/c/577185/ | |
| 00:46:06 | gmann | i am merging it via schema and hope i have not missed anything | |
| 00:47:16 | gmann | mriedem: ^^ need some eagle eyes on this - https://review.openstack.org/#/c/577185/ | |
| 01:38:47 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add InstanceGroupPolicy object https://review.openstack.org/573628 | |
| 01:40:30 | openstackgerrit | Merged openstack/nova stable/queens: Fix unit test modifying global state https://review.openstack.org/578722 | |
| 01:59:26 | openstackgerrit | yanpuqing proposed openstack/nova master: Rename auth_uri to www_authenticate_uri https://review.openstack.org/576820 | |
| 02:37:32 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647 | |
| 02:37:33 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12) https://review.openstack.org/542819 | |
| 02:37:34 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Transactionally update allocations (v1.13) https://review.openstack.org/546674 | |
| 02:37:35 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675 | |
| 02:37:36 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043 | |
| 02:37:37 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326 | |
| 02:39:17 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Remove doc/build during tox -e docs https://review.openstack.org/579041 | |
| 02:41:27 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Fix the 1.6 release note format https://review.openstack.org/579042 | |
| 02:44:43 | openstackgerrit | Merged openstack/nova master: Skip ServerShowV247Test.test_update_rebuild_list_server in nova-cells-v1 job https://review.openstack.org/578125 | |
| 05:06:25 | openstackgerrit | Andreas Jaeger proposed openstack/os-vif master: move legacy-tempest-dsvm-nova-os-vif to repo https://review.openstack.org/559401 | |
| 05:43:46 | openstackgerrit | Merged openstack/nova master: VMware: remove reading resourcePool data https://review.openstack.org/574553 | |
| 05:43:55 | openstackgerrit | Merged openstack/nova master: sync_guest_time: use the proper errno https://review.openstack.org/572346 | |