Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-06-28
14:58:39 efried stephenfin: Meh, it'll probably do me good to re-review from scratch anyway.
14:58:44 mnaser i'll be very happy to fix the docs if that's incorrect
14:58:46 efried was just giving you grief
14:59:13 mriedem mnaser: i think that's a typo
14:59:16 mriedem or out of context
14:59:22 melwitt mnaser: uh no, what I meant there was create a new db, mq, etc whatever you would have normally done to set up a new cell
14:59:56 mnaser okay, i'll be working on adding a new cells v2 over the next few days so there might be a bunch of doc patches that hopefully help
14:59:58 melwitt so it should be reworded if that's how it sounds to other people
14:59:59 melwitt (if it sounds like it's saying set up cells v1)
15:00:05 melwitt thanks mnaser
15:00:21 mnaser and hopefully adding cells v2 native support in openstack ansible (not just 1 cell)
15:01:04 mriedem yeah i'd just generalize https://docs.openstack.org/nova/latest/user/cells.html#adding-a-new-cell-to-an-existing-deployment into saying, create new db and mq, sync db, create cell with new db and mq, discover hosts, etc
15:01:26 mriedem don't need to run map_instances if it's a new deploy
15:01:36 melwitt right
15:02:37 mriedem if you're adding existing child cells to cells v2 mappings, then you skip the "create db and mq" part, and just create cell mapping with existing db and mq for child cell, discover hosts and map_instances
15:03:22 mriedem although step 4 in "Upgrade with Cells V1" already says that basically
15:03:34 mriedem "You will need to repeat this step for each cell in your deployment"
15:04:29 mriedem efried: doesn't the in-tree powervm driver support config drive now too? https://docs.openstack.org/nova/latest/user/config-drive.html#requirements-and-guidelines
15:04:35 mriedem "The following hypervisors support the configuration drive: libvirt, XenServer, Hyper-V, and VMware. Also, the Bare Metal service supports the configuration drive. "
15:05:20 efried mriedem: yes. Will propose an update to that, unless you're already in there for some reason.
15:05:26 mriedem go for it
15:05:39 mriedem note the release the support was added for powervm
15:06:12 mriedem looks like queens https://review.openstack.org/#/c/409404/
15:07:14 efried agree
15:07:15 mriedem https://bugs.launchpad.net/nova/+bug/1779159
15:07:15 openstack Launchpad bug 1779159 in OpenStack Compute (nova) "Store metadata on a configuration drive in nova - missing powervm" [Low,Triaged]
15:08:51 mriedem hmm, when was xenapi_disable_agent removed?
15:08:55 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375
15:10:06 openstackgerrit Eric Fried proposed openstack/nova master: Mention PowerVM support of config drive https://review.openstack.org/578840
15:10:13 efried mriedem, edmondsw: ^
15:10:22 efried edmondsw: not sure if there's more stuff we should mention in other places in there.
15:10:39 mriedem +2
15:10:40 mriedem thanks
15:11:03 yikun mriedem: I upload the recent patch and address comments from you and dans, but still WIP (lack testcase), if you have time can take a look, I will add test case tomorrow.
15:11:13 mriedem yikun: ok
15:11:33 mriedem yikun: were you going to split out the _policies backref modles change?
15:11:36 mriedem *models
15:11:41 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Correct documentation for '[pci] passthrough_whitelist' https://review.openstack.org/552874
15:11:42 openstackgerrit Stephen Finucane proposed openstack/nova master: Revert "docs: Disable smartquotes" https://review.openstack.org/578841
15:12:58 yikun yes, but I noticed that not a easy thing. - -
15:13:34 yikun because we use old _policies in some other method.
15:15:03 yikun and I'm going to complete it in tomorrow, : )
15:15:59 yikun now time for me to back home, hah, 11:15 PM, :(
15:16:49 yikun have a good day! :) and have a good night for me. :D
15:17:02 mriedem yikun: np, ttyl
15:22:45 openstackgerrit Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846
15:24:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Update xenapi_disable_agent config option usage in docs https://review.openstack.org/578848
15:25:29 efried stephenfin: have a look at https://review.openstack.org/#/c/534382/ if you please. If I'm full of malarkey, let me know and I'll flip to +2.
15:26:33 stephenfin efried: Looks good. Lemme try it
15:26:46 efried k
15:32:34 edmondsw efried looking
15:35:08 stephenfin efried: Yeah, Can't
15:35:15 efried stephenfin: Boo, how come?
15:35:20 stephenfin *Yeah, can't do that as that only works for explicitly defined things
15:35:29 stephenfin Not implicitly defined
15:35:52 stephenfin So I could manually set envdir for the environments I'm inheriting from but then what's the point
15:36:43 efried I see. I mean, it would still have the same dedup-ish effect. You'd only be defining it for what, three, four envs?
15:36:56 efried and then sharing it for the rest.
15:37:31 stephenfin So defining '[testenv] envdir' and overriding where I need it?
15:38:56 efried stephenfin: Oh, I thought like defining envdir in [testenv:{venv|doc|py27|py35}], not overriding it anywhere, and then using the suggested syntax wherever you want to share it.
15:39:23 efried (which is overriding, I suppose - not sure if we're talking the same terms here)
15:40:40 stephenfin Is there any difference, in that case? Those unclear attributes are still going to be there, there'll just be less of them
15:40:55 stephenfin Unclear attributes being e.g. 'envdir = {toxworkdir}/venv'
15:41:24 efried stephenfin: Well, except {toxworkdir}/venv will be defined in the [testenv:venv] env, which seems pretty clear.
15:41:55 efried anyway, you're right, this certainly reduces the usefulness of the suggestion. So I'm fine if you want to do it or skip it.
15:42:25 efried stephenfin: were you wanting to respin to add those two missed ones anyway?
15:42:30 stephenfin I might skip it, if that's OK. It's not any shorter and, IMO, is probably less clear
15:42:37 efried okay
15:42:37 stephenfin Yup, working at that atm
15:42:40 efried k
15:42:50 edmondsw efried I added a couple comments on https://review.openstack.org/#/c/578840 that you might want to squeeze into that, but could also be a follow-on
15:43:00 edmondsw burgerk would be a good source for information / reviewer
15:44:50 openstackgerrit Eric Fried proposed openstack/nova master: Mention PowerVM support of config drive https://review.openstack.org/578840
15:45:20 efried added him.
15:48:07 mdbooth mriedem: This is a WIP, but you had a (now abandoned) patch up for this bug a couple of years ago: https://review.openstack.org/#/c/578846/
15:48:12 mdbooth cfriesen: You killed it :)
15:53:40 mriedem mdbooth: you kind of left me hanging here https://review.openstack.org/#/c/572790/
15:53:43 mriedem so you're in my doghouse
15:54:21 mriedem and yeah looks like my failed attempt was https://review.openstack.org/#/c/288109/
15:57:54 mdbooth mriedem: Sorry, thought we were good on the other patch. I'll pick it up again.
16:03:02 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646
16:03:03 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647
16:03:04 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12) https://review.openstack.org/542819
16:03:05 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Transactionally update allocations (v1.13) https://review.openstack.org/546674
16:03:06 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675
16:03:07 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043
16:03:08 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326
16:03:27 mriedem gibi: i think the bottom of that series is good now ^
16:03:34 mriedem i just cleaned up some leftovers from the command split
16:08:56 efried gibi: IIRC, the func test failure here https://review.openstack.org/#/c/560317/17/nova/tests/functional/libvirt/test_report_cpu_traits.py looks similar to a race you debugged... somewhere else. Do you remember offhand what the fix was?
16:15:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Use ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa in tree https://review.openstack.org/578878
16:15:57 mriedem would be nice to get this in so we don't burn nodes on docs-only changes ^
16:18:34 stephenfin mriedem: Any idea is zuul supports YAML roles/anchors, like we use for the API samples (I think)?
16:18:40 stephenfin https://anil.io/blog/symfony/yaml/using-variables-in-yaml-files/
16:20:03 mriedem no idea
16:20:10 mriedem to define irrelevant-files?
16:20:15 stephenfin aye
16:20:22 mriedem ask in -infra
16:20:26 stephenfin Will do
16:32:13 openstackgerrit Stephen Finucane proposed openstack/nova master: tox: Reuse envdirs https://review.openstack.org/534382

Earlier   Later