Posted	Nick	Remark
#openstack-nova - 2018-06-27
14:03:42	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Merge server create schema for config drive extension https://review.openstack.org/578329
14:05:44	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Merge server create schema for config drive extension https://review.openstack.org/578329
14:06:11	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Merge server create schema for keypair extension https://review.openstack.org/578332
14:07:21	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Merge server create schema for multiple create extension https://review.openstack.org/578338
14:07:55	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Merge server create schema for multiple create extension https://review.openstack.org/578338
14:08:27	mriedem	melwitt: fyi, i had removed the bp for ^ from rocky since there weren't any changes posted as of june 13th, but now there are several https://review.openstack.org/#/q/topic:bp/api-extensions-merge-rocky+(status:open+OR+status:merged) so i guess throw it back into the rocky mix if you want
14:08:43	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Merge server create schema for scheduler hint extension https://review.openstack.org/578343
14:09:12	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Merge server create schema for scheduler hint extension https://review.openstack.org/578343
14:09:59	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Merge server create schema for security group extension https://review.openstack.org/578345
14:13:59	openstackgerrit	Andrey Volkov proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646
14:14:00	openstackgerrit	Andrey Volkov proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647
14:14:01	openstackgerrit	Andrey Volkov proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12) https://review.openstack.org/542819
14:14:02	openstackgerrit	Andrey Volkov proposed openstack/osc-placement master: Transactionally update allocations (v1.13) https://review.openstack.org/546674
14:14:03	openstackgerrit	Andrey Volkov proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675
14:14:04	openstackgerrit	Andrey Volkov proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043
14:14:05	openstackgerrit	Andrey Volkov proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326
14:24:03	openstackgerrit	Merged openstack/nova master: Drop API compat handling for old compute error cases https://review.openstack.org/546256
14:38:09	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Merge server create schema for security group extension https://review.openstack.org/578345
14:47:14	mriedem	dansmith: you should take a look at this https://review.openstack.org/#/c/563375/ - it's attempting to deprecate InstanceGroup.policies (which is a list of policy names - even though a group can only ever have 1 policy associated with it), and add InstanceGroup.policy which is a new InstanceGroupPolicy object - but it straddles both fields during the deprecation. i'm not sure if we can just drop the InstanceGroup.policies fie
14:47:14	mriedem	like metadetails in there) and just handle the backport compat if necessary?
14:47:24	mriedem	but the code handling both is overly complicated imo
14:47:33	mriedem	yikun: ^
14:48:00	dansmith	mriedem: okay in a sec
14:50:34	mriedem	and gerrit is dead
14:52:21	mriedem	nvm
14:55:54	openstackgerrit	Matt Riedemann proposed openstack/nova master: Remove compatibility code for instance groups https://review.openstack.org/578192
14:55:55	openstackgerrit	Matt Riedemann proposed openstack/nova master: Remove unused DB API instance_group_delete method https://review.openstack.org/578223
15:03:37	melwitt	mriedem_afk: copy that
15:08:01	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Merge server create schema for user data extension https://review.openstack.org/578349
15:15:42	dansmith	mriedem_afk: commented on that policy thing, let me know if that all makes sense
15:19:25	openstackgerrit	qingszhao proposed openstack/os-traits master: Add release note link in README https://review.openstack.org/578444
15:20:08	fungi	mriedem_afk: when you have a sec, i'm curious whether https://review.openstack.org/572195 (or more specifically its stable backport) is considered sufficient to mitigate https://launchpad.net/bugs/1742102 on upgrade without needing any configuration adjustments
15:20:08	openstack	Launchpad bug 1742102 in OpenStack Compute (nova) "Simple user can disable compute" [High,In progress]
15:20:42	fungi	just trying to decide how to move forward on the report now that those related backports have all merged
15:20:47	dansmith	fungi: that's the point
15:21:48	fungi	cool, i wonder why they weren't flagged as fixing that bug. can we consider those bugtasks fix-committed now?
15:21:53	dansmith	fungi: second paragraph of the commit message
15:22:40	dansmith	fungi: because that bug is also about the fact that we consider overquota for volumes as a retryable event
15:23:23	fungi	ahh. and someone retrying overquota volume requests can still be used as a denial of service attack against compute nodes?
15:23:52	dansmith	no, meaning compute auto-retrying something we know will fail is just a waste of resources
15:24:09	dansmith	the user can retry of course, but we shouldn't automatically retry something we know is going to fail again
15:24:22	dansmith	we have a list of things that we know are terminal and just cause the build to go to error,
15:24:58	dansmith	and this bug is also indicating we should do that for this situation, aside from the fact that it shouldn't have counted against the build failures for the disabler thing
15:25:14	fungi	okay, so the bug report remains open, but the security vulnerability described in the bug is no longer relevant on upgrade to the related patches
15:25:27	dansmith	aye
15:25:55	fungi	perfect, thanks! i'll move forward on drafting the advisory and get some input on the wording once i have it fleshed out
15:26:08	dansmith	okay
15:26:53	openstackgerrit	qingszhao proposed openstack/os-vif master: Add release note link in README https://review.openstack.org/578446
15:52:30	openstackgerrit	Matt Riedemann proposed openstack/os-vif master: Add release note link in README https://review.openstack.org/578446
15:52:47	mriedem	dansmith: ok
15:52:57	mriedem	dansmith: also this was ok https://review.openstack.org/#/c/578192/
15:53:01	mriedem	the failing functional test was a known thing
15:57:43	dansmith	mriedem: I saw
15:57:52	dansmith	you can imagine why I assumed... :)
16:03:44	mriedem	replies on some of https://review.openstack.org/#/c/563375/17/nova/objects/instance_group.py
16:03:48	mriedem	i think we're mostly on the same page though
16:19:41	dansmith	mriedem: replied
16:19:55	dansmith	I plied, then I plied again
16:26:31	melwitt	okay, just got off the phone with the rdo cloud peeps (kforde) and the state of the instance was that it had no instance mapping (no row) and it only existed as a build request. there was no other reference to the instance, and it was stuck in vm_state 'building' and task_state 'scheduling'
16:27:08	melwitt	it couldn't be deleted because it failed to find an instance mapping (no instance with uuid found)
16:27:48	mriedem	dansmith: ok i'm not sure i'm following all of the lazy-load stuff you're talking about
16:27:57	mriedem	not sure if you mean the joinedload on the db object?
16:28:07	mriedem	when you say lazy-load, i think obj_load_attr()
16:28:26	mriedem	melwitt: ok was that instance created in like mitaka?
16:29:23	melwitt	mriedem: I don't think so, no. the deployment is ocata and he said there's been no upgrade or change around the time the instance was created (it was created a month ago)
16:30:18	melwitt	do we currently have code that will handle this case, no instance mapping but build request only, for a delete? (mostly rhetorical, will check the code)
16:30:34	mriedem	we create the instance mapping at the same time that we create the build request, in the api
16:30:52	mriedem	so it doesn't really make sense, unless we have something that accidentally deleted the instance mapping, but we don't do that anywhere in ocata as far as i know
16:30:54	melwitt	hrm.
16:31:15	mriedem	and is it reproducable?
16:31:37	mriedem	https://github.com/openstack/nova/blob/stable/ocata/nova/compute/api.py#L1010
16:31:53	melwitt	no, not yet. this is the second time they've found instances in that state but we don't yet know how it's happening
16:32:45	openstackgerrit	Stephen Finucane proposed openstack/nova master: network: Always retrieve network information if available https://review.openstack.org/564444
16:32:46	openstackgerrit	Stephen Finucane proposed openstack/nova master: network: Retrieve tunneled status in '_get_physnet_info' https://review.openstack.org/564445
16:32:47	openstackgerrit	Stephen Finucane proposed openstack/nova master: objects: Add NUMACell.network_metadata https://review.openstack.org/564439
16:32:49	openstackgerrit	Stephen Finucane proposed openstack/nova master: objects: Add NUMATopologyLimits.networks https://review.openstack.org/575486
16:32:49	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Start accounting for networks in NUMA placement https://review.openstack.org/564448
16:32:50	openstackgerrit	Stephen Finucane proposed openstack/nova master: objects: Add RequestSpec.network_metadata https://review.openstack.org/564442
16:32:51	openstackgerrit	Stephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.network_metadata https://review.openstack.org/564452
16:32:53	openstackgerrit	Stephen Finucane proposed openstack/nova master: conf: Add '[neutron] physnets' and related options https://review.openstack.org/564440
16:32:54	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_metadata field https://review.openstack.org/564441
16:33:05	mriedem	melwitt: and they don't have any errors in the logs?
16:33:53	mriedem	dansmith: stephenfin: did you guys ever talk about the physnet/tunneled modeling stuff?
16:34:23	stephenfin	mriedem: Nope. I didn't get a chance today. Can we do that tomorrow afternoon?
16:34:35	mriedem	i can
16:35:04	stephenfin	Cool. The above was simply reworking based on the comments I did have. I can respin based on whatever comes out of that tomorrow
16:35:19	stephenfin	Though I did (hopefully) explain what I'm doing with additional comments where I set those fields
16:36:39	dansmith	I'm out the rest of the week
16:36:56	dansmith	but I think you guys can handle it
16:37:06	stephenfin	(y)
16:37:40	stephenfin	Cool. I'll give you a shout tomorrow morning (for you) so, mriedem
16:56:58	openstackgerrit	Merged openstack/os-traits master: Add release note link in README https://review.openstack.org/578444
17:06:26	mriedem	i'm not sure i can handle it
17:07:49	openstackgerrit	Matt Riedemann proposed openstack/nova master: Remove unused DB API instance_group_member* methods https://review.openstack.org/578488
17:19:49	tssurya	dansmith: do we have a cells meeting today?
17:19:57	dansmith	tssurya: I dunno, do we?
17:20:19	tssurya	I don't have much (working on the spec implementation and POCs)
17:21:28	melwitt	I don't have anything meeting worthy
17:21:31	tssurya	ah and this funny but legit bug, : https://bugs.launchpad.net/nova/+bug/1778515 I guess it should be a doc fix
17:21:31	openstack	Launchpad bug 1778515 in OpenStack Compute (nova) "nova-manage list_cells doesn't work if some special characters are in the passwords" [Undecided,New] - Assigned to Surya Seetharaman (tssurya)

Earlier   Later