| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-06-25 | |||
| 15:11:10 | bauzas | oops, yeah | |
| 15:11:15 | bauzas | confirm_resize I meant | |
| 15:11:26 | bauzas | okay, thanks, I was a bit confused | |
| 15:11:26 | mriedem | this does the allocation swap https://github.com/openstack/nova/blob/master/nova/conductor/tasks/migrate.py#L27 | |
| 15:11:42 | bauzas | okay, thanks for the link, I think I understand now | |
| 15:11:58 | mriedem | cdent: efried: now that i'm looking at this, fyi on the fixme here re shared providers https://github.com/openstack/nova/blob/master/nova/conductor/tasks/migrate.py#L56 | |
| 15:12:16 | mriedem | so while we might support shared providers*, we've got a pretty big asterisk most likely | |
| 15:13:34 | cdent | in our copious free time (whooo dawg) we should try to fix that | |
| 15:13:42 | mriedem | dansmith: so i'm seeing this weird issue where i've got a versioned object with a DictOfStringsField, and the dict has some strings and boolean value | |
| 15:13:46 | mriedem | *'ed fields in it, | |
| 15:14:05 | mriedem | at some point along the way, the values in the dict are converted to strings, but i'm having a hard time figuring out where that is, but it looks like it must be coming from the coerce() somewhere | |
| 15:14:20 | mriedem | DictOfStringsField means the *values* in the dict are strings right? | |
| 15:14:31 | dansmith | mriedem: if you have a dict of strings, it will str() everything you try to set in there | |
| 15:14:43 | dansmith | right at the point of setting it on the object, but definitely during/after serialization | |
| 15:14:59 | mriedem | i was playing with that locally and wasn't seeing it at the point of setting the field | |
| 15:15:18 | mriedem | >>> obj = MyObj(foo=vif_details) | |
| 15:15:18 | mriedem | >>> obj.foo | |
| 15:15:18 | mriedem | {'port_filter': True, 'datapath_type': 'system', 'ovs_hybrid_plug': True} | |
| 15:15:23 | dansmith | well, | |
| 15:15:33 | mriedem | with | |
| 15:15:33 | mriedem | >>> class MyObj(base.NovaObject): | |
| 15:15:33 | mriedem | ... VERSION = '1.0' | |
| 15:15:33 | mriedem | ... fields = { | |
| 15:15:33 | mriedem | ... 'foo': fields.DictOfStringsField(), | |
| 15:15:33 | mriedem | ... } | |
| 15:15:33 | mriedem | ... | |
| 15:15:34 | dansmith | if you set the dict on the field and the manipulate the dict, then it won't do it immediately | |
| 15:16:02 | dansmith | okay, well, hmm, | |
| 15:16:18 | dansmith | maybe even when you set the dict it won't because it's complex, but I thought it would | |
| 15:16:24 | dansmith | definitely during serialization though I think | |
| 15:18:09 | mriedem | hmm | |
| 15:18:09 | mriedem | >>> obj.obj_attr_is_set('foo') | |
| 15:18:09 | mriedem | False | |
| 15:18:16 | mriedem | something weird in my test | |
| 15:25:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304 | |
| 15:30:14 | dansmith | mriedem: did you @register_if(False) it? | |
| 15:30:20 | dansmith | otherwise you don't get the magic fieldage | |
| 15:30:24 | mriedem | nope | |
| 15:32:43 | mriedem | http://paste.openstack.org/show/724236/ | |
| 15:32:49 | mriedem | maybe this just doesn't work without some stubs | |
| 15:32:52 | mriedem | or fixture setup | |
| 15:33:05 | mriedem | anyway, i realize i can't use DictOfStringsField | |
| 15:33:20 | mriedem | because vif_details can have a shitload of random key/value pairs of several types | |
| 15:33:54 | dansmith | that's odd | |
| 15:34:02 | dansmith | if you serialize it does it show up in the result? | |
| 15:34:37 | mriedem | no because it says the field isn't set | |
| 15:34:46 | dansmith | you tried? | |
| 15:35:02 | mriedem | >>> obj.obj_to_primitive() | |
| 15:35:02 | mriedem | {'nova_object.name': 'MyObj', 'nova_object.version': '1.0', 'nova_object.data': {}, 'nova_object.namespace': 'nova'} | |
| 15:35:26 | dansmith | man, that's odd | |
| 15:36:43 | dansmith | is it any different if you don't pass it to __init__ ? | |
| 15:36:56 | dansmith | like o=MyObj(); o.vif_details = | |
| 15:37:02 | mriedem | nope | |
| 15:37:17 | dansmith | I just don't even | |
| 15:41:45 | mriedem | hmm, we don't have any generic DictField where the values aren't coerced? | |
| 15:42:07 | mriedem | crap i guess you can't | |
| 15:42:17 | mriedem | Dict is a CompoundFieldType which takes some kind of element | |
| 15:45:15 | mriedem | and this is why BlockDeviceMapping.connection_info is a StringField... | |
| 15:49:37 | openstackgerrit | Chris Dent proposed openstack/nova stable/ocata: Ensure resource class cache when listing usages https://review.openstack.org/574279 | |
| 15:50:38 | dansmith | because it's full of random we don't control at the rpc layer yeah | |
| 15:51:41 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Make nova list and migration-list ignore down cells https://review.openstack.org/575734 | |
| 15:52:08 | mriedem | right...this is why i'm stressing over this https://review.openstack.org/#/c/515423/28/nova/objects/migrate_data.py@41 | |
| 15:52:45 | dansmith | yeah | |
| 15:58:47 | cdent | melwitt, mriedem : can I assume that except for truly exceptional circumstances we are done with specs until nearly the end of the cycle (when we start looking at stein stuff) and thus I can leave them off my weekly placement updates henceforth? | |
| 15:58:59 | mriedem | yeah | |
| 15:59:11 | cdent | cool. less noise. thanks. | |
| 16:11:06 | gibi | mriedem: Is it OK for you if we skip this week's notification subteam meeting? | |
| 16:11:12 | mriedem | gibi: yeah | |
| 16:11:27 | gibi | mriedem: cool. I will send the status mail tomorrow | |
| 16:15:14 | cfriesen | is it nova or cinder that reports storage capacity to placement? | |
| 16:15:25 | mriedem | nova for now | |
| 16:15:41 | mriedem | cinder doesn't control ephemeral compute host storage | |
| 16:17:15 | cfriesen | thanks | |
| 16:19:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604 | |
| 16:19:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | |
| 16:19:17 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | |
| 16:19:18 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | |
| 16:19:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | |
| 16:19:20 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | |
| 16:19:21 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData.get_dest_vif https://review.openstack.org/566931 | |
| 16:19:22 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: factor out pre_live_migration plug_vifs call https://review.openstack.org/566932 | |
| 16:19:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: use dest host port bindings during pre_live_migration https://review.openstack.org/566933 | |
| 16:19:24 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | |
| 16:19:25 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Annotate flows and handle PortBindingDeletionFailed in ComputeManager https://review.openstack.org/551371 | |
| 16:19:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 16:19:27 | openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | |
| 16:36:30 | openstackgerrit | YAMAMOTO Takashi proposed openstack/os-vif master: Fix docstrings to work with Sphinx 1.7.4 https://review.openstack.org/577028 | |
| 16:40:49 | openstackgerrit | Merged openstack/nova stable/pike: Metadata-API fails to retrieve avz for instances created before Pike https://review.openstack.org/571320 | |
| 16:40:54 | openstackgerrit | Merged openstack/nova master: Switch to oslo_messaging.ConfFixture.transport_url https://review.openstack.org/573046 | |
| 16:50:13 | mnaser | for those who were interested in the whole discussion around multi-cell + glance.. cloudnull brought up this tool which could probably be refactored to use glance_store to sync glance servers.. https://github.com/rcbops/glance-image-sync | |
| 16:51:30 | mnaser | mriedem: if you are around, i proposed https://review.openstack.org/#/c/576944/ to help with OSA upgrades (and probably other tools).. i'd appreciate your feedback (i didnt fix lint stuff cause i figured it'll need revisions anyways) | |
| 16:54:40 | mriedem | very interesting | |
| 17:19:07 | openstackgerrit | Merged openstack/nova master: objects: Remove legacy '_to_dict' functions https://review.openstack.org/537413 | |
| 17:19:13 | openstackgerrit | Merged openstack/nova master: network: Unchain '_get_phynet_info' from '_get_port_vnic_info' https://review.openstack.org/564443 | |
| 17:23:26 | dansmith | stephenfin: did you see my comments here? https://review.openstack.org/#/c/564444/7..9/nova/network/neutronv2/api.py | |
| 17:25:03 | stephenfin | dansmith: I did and I think I've addressed them all, though I didn't leave replies. Will do so now. Let me know if there's something I did miss and I'll address it asap | |
| 17:27:51 | dansmith | stephenfin: okay I guess it doesn't seem like anything is really different from the original | |
| 17:28:17 | dansmith | oh, wait, I see you don't actually split it in this one | |
| 17:28:31 | dansmith | I was thinking you'd split first, so I was looking for this to be the split patch | |
| 17:33:00 | stephenfin | dansmith: Caught rotten. I meant to actually do it but got my ordering mixed up and didn't want to go through the misery of another rebase :D I can if it would be preferable though | |