| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-06-19 | |||
| 13:58:27 | dansmith | kashyap: okay, I'm confused from all your edits to the bug.. going off of the libvirt patch it says it should be amd-ssbd and amd-no-ssb | |
| 13:59:47 | dansmith | I just processed the email notifications from your bug edits and it seems like you dropped the 'b' off the end of the first | |
| 13:59:49 | dansmith | er, the 'd' | |
| 14:01:54 | openstackgerrit | Dan Smith proposed openstack/nova stable/queens: [Stable Only] Add amd-ssbd and amd-no-ssb CPU flags https://review.openstack.org/576270 | |
| 14:01:56 | dansmith | whatever, changing it to match the libvirt patch | |
| 14:02:04 | dansmith | changing it *back* I should say | |
| 14:03:01 | kashyap | dansmith: Damn, I was bleary-eyed without coffee in the morning, and mistook Matt's comment | |
| 14:03:06 | kashyap | My bad; let me go update it right away | |
| 14:03:07 | dansmith | the bug also still calls it "amdb-no-ssb" by the way | |
| 14:03:15 | kashyap | Sorry about that. | |
| 14:03:19 | kashyap | Adjusting it | |
| 14:04:18 | kashyap | Originally I typoed only one place, in the summary. But somehow thought I did it all over the description. | |
| 14:04:45 | dansmith | and I copied those two names into the conf file, but then used the libvirt patch as reference for all the text I typed | |
| 14:07:06 | bauzas | efried: good morning | |
| 14:07:14 | efried | bauzas: Howdy! | |
| 14:07:37 | bauzas | efried: about efried: about https://review.openstack.org/#/c/564214/5/nova/tests/unit/virt/libvirt/test_driver.py@19853 the problem is that I need to provide a nova.conf fake file for this | |
| 14:07:45 | mriedem | alex_xu: so should we put https://review.openstack.org/#/c/560317/ in a runway or hold off for now? | |
| 14:08:14 | bauzas | efried: I can't just set the options directly ;) | |
| 14:08:31 | efried | bauzas: whyzat? Because the groups are dynamic? | |
| 14:09:07 | efried | oh, sorry, I was thinking of the wrong patch. | |
| 14:09:47 | efried | bauzas: wait, no I'm not. Can't you set the one opt, then call the dynamic conf thingy, then set the subsequent opt? | |
| 14:10:22 | kashyap | dansmith: Updated the bug. Struggling with too many acronyms. :-) | |
| 14:12:41 | bauzas | efried: well, if I'm providing 2 types but only set one opt, the second opt would get an exception | |
| 14:12:59 | mriedem | cdent: i think i'm going to put the optional placement db series into the available runway slot, are you around to deal with reviews on it for the next 2 weeks (shouldn't really take that long, the big pieces have merged it looks like) | |
| 14:13:15 | openstackgerrit | Merged openstack/os-traits master: Adds HW_CPU_HYPERTHREADING standard trait https://review.openstack.org/576030 | |
| 14:13:33 | cdent | a) cool, b) yes, c) there was a big bug in the next in line, but I fixed it, so we good | |
| 14:13:45 | mriedem | ack | |
| 14:13:47 | cdent | I except there will be some documentation concerns, which is good and right | |
| 14:13:51 | efried | bauzas: Sorry, I'm not understanding. Why wouldn't you provide 2 types and set both opts? | |
| 14:14:16 | bauzas | efried: sec | |
| 14:14:58 | sq4ind | Hey guys, have a problem with long running tasks (migrations). I've enabled send_service_user_token and allow_expired but still sometimes it fails. Here are logs: https://pastebin.com/cY82PP34 . Any idea? | |
| 14:15:01 | sq4ind | Thanks | |
| 14:15:53 | bauzas | efried: something like this ? http://paste.openstack.org/show/723830/ | |
| 14:16:14 | bauzas | efried: if so, looks a bit weird | |
| 14:16:30 | efried | bauzas: sec... | |
| 14:17:11 | bauzas | efried: oops, of course I meant http://paste.openstack.org/show/723831/ | |
| 14:18:27 | efried | bauzas: Does self.flags not let you set an opt that's not registered? | |
| 14:18:40 | bauzas | efried: unfortunately, no | |
| 14:18:44 | efried | boo. | |
| 14:18:49 | dansmith | or, fortunately. | |
| 14:18:55 | bauzas | heh | |
| 14:19:35 | bauzas | efried: self.flags is like conf.override | |
| 14:19:42 | bauzas | you need to have an existing group | |
| 14:19:57 | bauzas | actually, sec | |
| 14:20:46 | bauzas | efried: I think I can test it | |
| 14:22:04 | efried | bauzas: okay; the other option is to split apart _configure_gpu_mapping, one bit to register the groups and one to grab the values and do the validation. Then you can call the former from your test before you set self.flags; then call the latter. | |
| 14:22:39 | bauzas | efried: I think I can mock register_opts | |
| 14:24:18 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1764883 https://review.openstack.org/562072 | |
| 14:24:19 | openstack | bug 1764883 in OpenStack Compute (nova) "Evacuation fails if the source host returns while the migration is still in progress" [Undecided,In progress] https://launchpad.net/bugs/1764883 - Assigned to Lee Yarwood (lyarwood) | |
| 14:24:19 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Ensure pre-migrating instances are destroyed during init_host https://review.openstack.org/562284 | |
| 14:30:58 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Ensure pre-migrating instances are destroyed during init_host https://review.openstack.org/562284 | |
| 14:40:16 | mriedem | this should be an easy +W for someone to fix busted compat tests https://review.openstack.org/#/c/576256/ | |
| 14:42:51 | mriedem | zcorneli: i'm going to rebase your change on top of ^ ok? | |
| 14:50:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement file backed memory for instances in libvirt https://review.openstack.org/567876 | |
| 14:50:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: Libvirt file backed memory https://review.openstack.org/575766 | |
| 14:51:49 | do3meli | can someone please tell me whats the recommended way to evacuate all instances from a failed compute node (and let the scheduler decide where to place them)? we have opened https://bugs.launchpad.net/nova/+bug/1763039 and are currently bit confused on what to use. | |
| 14:51:50 | openstack | Launchpad bug 1763039 in OpenStack Compute (nova) "evacuate instance documentation not mentioning host-evacuate" [Undecided,Opinion] | |
| 14:51:57 | zcorneli | mriedem: Yep, go ahead (was hopefully going to get to that this morning) | |
| 14:52:23 | mriedem | done, reviewing the spec and then the code in a bit | |
| 14:52:23 | zcorneli | mriedem: dansmith: For Dan's patch to fix up ts, should we be fixing up the similar tests on other objects? | |
| 14:52:39 | mriedem | zcorneli: yeah | |
| 14:52:57 | mriedem | or at least reporting bugs that they are busted so low-hanging-fruit contributors can clean them up | |
| 14:53:14 | mriedem | like, the bug smash in china is this week, that would be a good opportunity | |
| 14:58:19 | openstackgerrit | zhangyangyang proposed openstack/nova master: Remove Chancefilter https://review.openstack.org/576384 | |
| 14:58:39 | dansmith | zcorneli: yeah I was just trying to get up a quick fix to let you depend on so you could roll forward | |
| 14:59:26 | zcorneli | mriedem: dansmith: I'll look at knocking out bug(s) for the remainder this afternoon then | |
| 15:02:28 | dansmith | mriedem: are you going to take another pass over that patch today? | |
| 15:04:30 | mriedem | dansmith: the file-backed one? i'm doing it now | |
| 15:04:39 | dansmith | ah cool | |
| 15:04:43 | mriedem | i will have a craigslist interruption here in a minute though | |
| 15:04:44 | openstackgerrit | zhangyangyang proposed openstack/nova master: Remove Chancefilter https://review.openstack.org/576384 | |
| 15:07:29 | mriedem | hmm, are we ready to remove the ChanceScheduler? ^ | |
| 15:07:36 | mriedem | i didn't even realize it was deprecated | |
| 15:08:18 | dansmith | mriedem: I thought they removed the personal services section? | |
| 15:08:51 | mriedem | dansmith: while laura is away... | |
| 15:08:55 | mriedem | comstud got me the backdoor deal | |
| 15:09:01 | dansmith | understandable | |
| 15:18:56 | kashyap | :D The sheer rawness... | |
| 15:19:15 | openstackgerrit | Brianna Poulos proposed openstack/python-novaclient master: Fix trusted-image-certificate-id help text https://review.openstack.org/576555 | |
| 15:29:48 | dansmith | kashyap: I meant personal coding services.. obviously mriedem is doing some side coding work for hire | |
| 15:29:59 | kashyap | Haha | |
| 15:30:20 | kashyap | Nice try to deflect the "original intention"... | |
| 15:31:05 | mriedem | doesn't matter, because in true craigslist form, the person confirms they are coming at 10am today, and it's now 10:30am and no-show | |
| 15:31:09 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | |
| 15:33:25 | mriedem | jacqueslist | |
| 15:35:40 | openstackgerrit | huanhongda proposed openstack/nova stable/ocata: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/570653 | |
| 15:35:41 | kashyap | Heh; that looks dodgy. /me stops going more off-topic, and heads offline. Tomorrow evening is my most difficult Dutch written exam; need to study. | |
| 15:49:50 | mriedem | zcorneli: dansmith: ok comments inline on the file-backed memory change https://review.openstack.org/#/c/567876/ | |
| 15:49:53 | mriedem | mostly good, | |
| 15:50:07 | mriedem | but i did wonder about the AggregateRamFilter for host aggregates that set ram_allocation_ratio!=1.0 | |
| 15:50:23 | mriedem | the spec didn't mention that nor the docs in the change | |
| 15:50:44 | mriedem | maybe it just means, don't put file-backed memory hosts in aggregates that have ram_allocation_ratio!=1.0 | |
| 15:51:56 | zcorneli | mriedem: Looking through commentary now | |
| 15:52:42 | mriedem | i think in general we will just have some gaps that we could shore up with proper scheduling filtering, including not landing a flavor that requests huge pages on a file-backed host | |
| 15:52:48 | mriedem | but we could also do follow ups on those | |
| 16:07:41 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: Configure multiple vGPU types https://review.openstack.org/564214 | |
| 16:07:42 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: mdevs returning parent and vendor PCI info https://review.openstack.org/562304 | |
| 16:07:43 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: Get inventories per vGPU type https://review.openstack.org/564215 | |
| 16:13:00 | zcorneli | mriedem: Most of the notes look good, will fix up what I can. Not sure how to handle the aggregates ram_allocation_ratio thing, except just documenting not to do that. | |
| 16:13:18 | mriedem | zcorneli: interested in dansmith's thoughts on that as well | |